Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Dan Carpenter
On Wed, Oct 29, 2014 at 09:13:24AM -0700, Joe Perches wrote: > On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote: > > On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote: > > > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: > > > > The right shift operation has higher preceden

Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Joe Perches
On Wed, 2014-10-29 at 19:10 +0300, Dan Carpenter wrote: > On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote: > > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: > > > The right shift operation has higher precedence than the mask so we > > > left shift by "(i * 3)" and then immedia

Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Dan Carpenter
On Wed, Oct 29, 2014 at 09:08:39AM -0700, Joe Perches wrote: > On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: > > The right shift operation has higher precedence than the mask so we > > left shift by "(i * 3)" and then immediately right shift by "(i * 3)" > > then we mask. It should be le

Re: [patch] ath9k: fix some debugfs output

2014-10-29 Thread Joe Perches
On Wed, 2014-10-29 at 18:48 +0300, Dan Carpenter wrote: > The right shift operation has higher precedence than the mask so we > left shift by "(i * 3)" and then immediately right shift by "(i * 3)" > then we mask. It should be left shift, mask, and then right shift. > Hey Dan. My grep pattern do

[patch] ath9k: fix some debugfs output

2014-10-29 Thread Dan Carpenter
The right shift operation has higher precedence than the mask so we left shift by "(i * 3)" and then immediately right shift by "(i * 3)" then we mask. It should be left shift, mask, and then right shift. Signed-off-by: Dan Carpenter diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/driver