Re: [patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()

2014-10-29 Thread Emmanuel Grumbach
On Wed, Oct 29, 2014 at 6:08 PM, Dan Carpenter wrote: > The shift operation is higher precedence so the code is wrong and it > sets of a static checker warning. But it doesn't affect real life > because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. > > I have re-written it in nor

[patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()

2014-10-29 Thread Dan Carpenter
The shift operation is higher precedence so the code is wrong and it sets of a static checker warning. But it doesn't affect real life because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. I have re-written it in normal style and with parenthesis as a cleanup and to silence the s