[patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2015-12-19 Thread Dan Carpenter
There is a type bug so it always returns success. Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') Signed-off-by: Dan Carpenter diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c index f8c5065..a7afdee 100644 --- a/drivers/ne

Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2015-12-19 Thread Martin Blumenstingl
On Sat, Dec 19, 2015 at 11:59 AM, Dan Carpenter wrote: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter Acked-by: Martin Blumenstingl Thank you for finding and fixing this one! -- T

Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2015-12-20 Thread Joe Perches
On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > There is a type bug so it always returns success. How many false positives do you have to sift through to find this sort of error? > +++ b/drivers/net/wireless/ath/ath9k/eeprom.c > @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(stru

Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2015-12-20 Thread Julia Lawall
On Sun, 20 Dec 2015, Joe Perches wrote: > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > There is a type bug so it always returns success. > > How many false positives do you have to sift > through to find this sort of error? The return type is thoughtfully bool, so it should be eas

Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2015-12-20 Thread Joe Perches
On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > On Sun, 20 Dec 2015, Joe Perches wrote: > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > There is a type bug so it always returns success. > >  > > How many false positives do you have to sift > > through to find this sort

Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2015-12-20 Thread Dan Carpenter
On Sun, Dec 20, 2015 at 11:05:55AM -0800, Joe Perches wrote: > On Sun, 2015-12-20 at 20:00 +0100, Julia Lawall wrote: > > On Sun, 20 Dec 2015, Joe Perches wrote: > > > > > On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote: > > > > There is a type bug so it always returns success. > > >  > > >

Re: [patch -next] ath9k: fix ath9k_hw_nvram_check_version()

2016-01-07 Thread Kalle Valo
Dan Carpenter writes: > There is a type bug so it always returns success. > > Fixes: 6fa658fd5ab2 ('ath9k: Simplify and fix eeprom endianness swapping') > Signed-off-by: Dan Carpenter Applied to ath.git, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-