Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Felix Fietkau
On 2015-09-30 20:34, Ben Greear wrote: > On 09/30/2015 11:30 AM, Johannes Berg wrote: >> On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: >>> >>> Yes, it is a transmitter side problem, and A-MSDU on IBSS >>> is disabled by default in all ath10k firmware versions that I am aware of. >> >> Right.

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/30/2015 11:30 AM, Johannes Berg wrote: On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: Yes, it is a transmitter side problem, and A-MSDU on IBSS is disabled by default in all ath10k firmware versions that I am aware of. Right. I was hoping there might be a way to allow A-MSDU + I

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: > > Yes, it is a transmitter side problem, and A-MSDU on IBSS > is disabled by default in all ath10k firmware versions that I am aware of. Right. > I was hoping there might be a way to allow A-MSDU + IBSS + ath10k > to work in future kernels w

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/30/2015 10:14 AM, Johannes Berg wrote: On Wed, 2015-09-30 at 08:44 -0700, Ben Greear wrote: Any idea how this could be done in the stack instead of the driver? I don't see why it should be? The problem is that this is a receiver-side issue, so even if I manage to hack the ath10k firmw

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 08:44 -0700, Ben Greear wrote: > > Any idea how this could be done in the stack instead of the driver? I don't see why it should be? > The problem is that this is a receiver-side issue, so even if I manage > to hack the ath10k firmware or driver rx logic, it would not fix a

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/30/2015 08:17 AM, Johannes Berg wrote: On Wed, 2015-09-30 at 08:07 -0700, Ben Greear wrote: On 09/29/2015 11:46 PM, Johannes Berg wrote: On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: It seems that ath10k ar988X hardware has a bug where the BSSID for IBSS AMSDU frames is all zeros

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 08:07 -0700, Ben Greear wrote: > > On 09/29/2015 11:46 PM, Johannes Berg wrote: > > On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: > > > It seems that ath10k ar988X hardware has a bug where the BSSID > > > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmw

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/29/2015 11:46 PM, Johannes Berg wrote: On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: It seems that ath10k ar988X hardware has a bug where the BSSID for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware does not seem to use AMSDUs for IBSS, and when I enable it in my

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Nicolas Cavallari
On 26/09/2015 01:00, Ben Greear wrote: > It seems that ath10k ar988X hardware has a bug where the BSSID > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware > does not seem to use AMSDUs for IBSS, and when I enable it in my CT > firmware, then I see the breakage. So, I suspect it

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-29 Thread Johannes Berg
On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: > It seems that ath10k ar988X hardware has a bug where the BSSID > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware > does not seem to use AMSDUs for IBSS, and when I enable it in my CT > firmware, then I see the breakage. So,

Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-25 Thread Ben Greear
It seems that ath10k ar988X hardware has a bug where the BSSID for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware does not seem to use AMSDUs for IBSS, and when I enable it in my CT firmware, then I see the breakage. So, I suspect it is not just a simple software/firmware bug. I