Re: Mac80211 : Wpa rekeying issue

2016-01-06 Thread Matthias May
On 05/01/16 16:50, Johannes Berg wrote: On Tue, 2016-01-05 at 11:54 +0100, Matthias May wrote: Not safe as in "access to stuff which has to be locked", or not safe as in "a CCMP replay attack is possible"? When changing this we argumented that since we are not really connected yet, a CCMP repla

Re: Mac80211 : Wpa rekeying issue

2016-01-05 Thread Johannes Berg
On Tue, 2016-01-05 at 11:54 +0100, Matthias May wrote: >  > Not safe as in "access to stuff which has to be locked", or not safe > as > in "a CCMP replay attack is possible"? > When changing this we argumented that since we are not really > connected > yet, a CCMP replay attack doesn't really mak

Re: Mac80211 : Wpa rekeying issue

2016-01-05 Thread Matthias May
On 05/01/16 10:58, Johannes Berg wrote: On Tue, 2016-01-05 at 10:47 +0100, Matthias May wrote: We've encountered exactly this problem in a mix of devices where one applies key material faster than the other. (ath9k and aquilla) As a workaround we check on the STA if we are authorized when upda

Re: Mac80211 : Wpa rekeying issue

2016-01-05 Thread Johannes Berg
On Tue, 2016-01-05 at 10:47 +0100, Matthias May wrote: > > We've encountered exactly this problem in a mix of devices where one > applies key material faster than the other. (ath9k and aquilla) > As a workaround we check on the STA if we are authorized when > updating/checking CCMP. (see attach

Re: Mac80211 : Wpa rekeying issue

2016-01-05 Thread Matthias May
x27;Emmanuel Grumbach' Cc : 'linux-wireless'; 'Johannes Berg' Objet : RE: Mac80211 : Wpa rekeying issue > -Message d'origine- De : Emmanuel Grumbach [mailto:egrumb...@gmail.com] Envoyé : mardi 29 décembre 2015 15:20 À : Cedric VONCKEN Cc : linu

Re: Mac80211 : Wpa rekeying issue

2016-01-05 Thread Johannes Berg
On Thu, 2015-12-31 at 10:41 +0200, Emmanuel Grumbach wrote: > It simply disables the replay attack detection :) > You could receive the same (encrypted) packet twice and not throw > away the second one. Correct. > PTK rekeying is a problem from the spec point of view. Which was/is being addres

Re: Mac80211 : Wpa rekeying issue

2015-12-31 Thread Ben Greear
On 12/31/2015 02:15 AM, voncken wrote: Thanks for your answer. Do you know if we can have the same issue with ATH10K chipset? Someone else reported re-keying problems with ath10k recently, and it appears to be a bug in in upstream firmware, probably related to the same issue that keeps 802.1

RE: Mac80211 : Wpa rekeying issue

2015-12-31 Thread voncken
> > > > Hi, > > > > I'm not a WPA expert and security expert, > > > > Could you explain why the patch sent by Alexander Wetzel break the > security properties of this code? > > > > The Alexander's patch is in attachment. > > > > Thanks for your help. > > It simply disables the replay attac

Re: Mac80211 : Wpa rekeying issue

2015-12-31 Thread Emmanuel Grumbach
That's what I remember, but I may be wrong. > > > -Message d'origine- > > De : linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > > ow...@vger.kernel.org] De la part de voncken > > Envoyé : mardi 29 décembre 2015 16:24 > &

RE: Mac80211 : Wpa rekeying issue

2015-12-31 Thread voncken
ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] De la part de voncken > Envoyé : mardi 29 décembre 2015 16:24 > À : 'Emmanuel Grumbach' > Cc : 'linux-wireless'; 'Johannes Berg' > Objet : RE: Mac80211 : Wpa rekeying issue &

RE: Mac80211 : Wpa rekeying issue

2015-12-29 Thread voncken
> -Message d'origine- > De : Emmanuel Grumbach [mailto:egrumb...@gmail.com] > Envoyé : mardi 29 décembre 2015 15:20 > À : Cedric VONCKEN > Cc : linux-wireless > Objet : Re: Mac80211 : Wpa rekeying issue > > On Tue, Dec 29, 2015 at 3:01 PM, Ce

Re: Mac80211 : Wpa rekeying issue

2015-12-29 Thread Emmanuel Grumbach
On Tue, Dec 29, 2015 at 3:01 PM, Cedric VONCKEN wrote: > Hi, > > My test plateform is: > 2 equipements > Both equipment used compat version 2015-07-21 from openwrt. > Both equipment used security WPA2 > > The equipment #1 is an AP. > The Group rekey interval is set to 3601s > The P

Mac80211 : Wpa rekeying issue

2015-12-29 Thread Cedric VONCKEN
Hi, My test plateform is: 2 equipements Both equipment used compat version 2015-07-21 from openwrt. Both equipment used security WPA2 The equipment #1 is an AP. The Group rekey interval is set to 3601s The Pair rekey interval set to 50s (I reduced this value to show the issue of