Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-13 Thread Rickard Strandqvist
2014-10-13 10:55 GMT+02:00 David Laight : > From: Rickard Strandqvist >> Replacing strncpy with strlcpy to avoid strings that lacks null terminate. >> And changed from using strncpy to strlcpy to simplify code. > > I think you should return an error if the strings get truncated. > Silent truncation

RE: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-13 Thread David Laight
From: Rickard Strandqvist > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > And changed from using strncpy to strlcpy to simplify code. I think you should return an error if the strings get truncated. Silent truncation is going to lead to issues at some point in the fu

Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Rickard Strandqvist
2014-10-12 10:06 GMT+02:00 Arend van Spriel : > On 12-10-14 01:52, Rickard Strandqvist wrote: >> Replacing strncpy with strlcpy to avoid strings that lacks null terminate. >> And changed from using strncpy to strlcpy to simplify code. > > Looks good to me. Just two small process related remarks: >

Re: [PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-12 Thread Arend van Spriel
On 12-10-14 01:52, Rickard Strandqvist wrote: > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > And changed from using strncpy to strlcpy to simplify code. Looks good to me. Just two small process related remarks: - It is sufficient to prefix the patch with brcmfmac (