RE: [PATCH v2 3/3] mwifiex: Enable WoWLAN for both sdio and pcie

2016-11-14 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Saturday, November 12, 2016 2:13 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > raja...@google.com; dmitry.torok...@gmail.com > Subject: Re: [PATCH v2 3/

Re: [PATCH v2 3/3] mwifiex: Enable WoWLAN for both sdio and pcie

2016-11-11 Thread Brian Norris
Hi, One correction to my review: On Fri, Nov 11, 2016 at 12:42:36PM -0800, Brian Norris wrote: > On Fri, Nov 11, 2016 at 04:45:11PM +0530, Amitkumar Karwar wrote: > > --- a/drivers/net/wireless/marvell/mwifiex/main.c > > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > > @@ -1552,14 +1552,55 @

Re: [PATCH v2 3/3] mwifiex: Enable WoWLAN for both sdio and pcie

2016-11-11 Thread Brian Norris
On Fri, Nov 11, 2016 at 04:45:11PM +0530, Amitkumar Karwar wrote: > From: Rajat Jain > > Commit ce4f6f0c353b ("mwifiex: add platform specific wakeup interrupt > support") added WoWLAN feature only for sdio. This patch moves that > code to the common module so that all the interface drivers can us