Re: [Make-wifi-fast] [PATCH v2] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-26 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Mon, 2016-08-22 at 16:47 +0200, Toke Høiland-Jørgensen wrote: >>  >> I suppose that could be a way to do it (i.e. have >> ieee80211_tx_dequeue call all the TX hooks etc), but am not sure >> whether there would be problems doing all this work in the loop >> that's buildi

Re: [Make-wifi-fast] [PATCH v2] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-26 Thread Johannes Berg
On Mon, 2016-08-22 at 16:47 +0200, Toke Høiland-Jørgensen wrote: >  > I suppose that could be a way to do it (i.e. have > ieee80211_tx_dequeue call all the TX hooks etc), but am not sure > whether there would be problems doing all this work in the loop > that's building aggregates (which is what wo

Re: [Make-wifi-fast] [PATCH v2] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-22 Thread Toke Høiland-Jørgensen
Johannes Berg writes: >> well, we're getting there. the results of both patch attempts were >> really nice, and brought encrypted performance with fq back into line >> with unencrypted. Still running crypted tests as I write... >> >> So fixing TKIP would be next, forcing the AP to use that? What

Re: [Make-wifi-fast] [PATCH v2] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Johannes Berg
> well, we're getting there. the results of both patch attempts were > really nice, and brought encrypted performance with fq back into line > with unencrypted. Still running crypted tests as I write... > > So fixing TKIP would be next, forcing the AP to use that? What other > scenarios do we hav

Re: [Make-wifi-fast] [PATCH v2] mac80211: Move crypto IV generation to after TXQ dequeue.

2016-08-17 Thread Dave Taht
On Wed, Aug 17, 2016 at 9:49 PM, Johannes Berg wrote: > Hi, > > You need to work on coding style, a lot of your indentation is > completely messed up. > >> + switch (sdata->vif.type) { >> + case NL80211_IFTYPE_STATION: >> + if (sdata->u.mgd.use_4addr) { >> +