RE: Re: Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-15 Thread Xinming Hu
Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part > from > combo firmware during function level reset > > External Email > > -- > Hi, > > On Fri, Apr 14, 2017 at 03:28:28AM +, Xinming Hu wrote:

Re: Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-14 Thread Brian Norris
Hi, On Fri, Apr 14, 2017 at 03:28:28AM +, Xinming Hu wrote: > According to the firmware download protocol, every CMD should not exceed > MWIFIEX_UPLD_SIZE. > we can add a sanity check , like, > if (data_len > MWIFIEX_UPLD_SIZE - sizeof(fwdata->header)) > *error* I was primarily

RE: Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-13 Thread Xinming Hu
Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from > combo firmware during function level reset > > External Email > > -- > Hi, > > On Thu, Apr 13, 2017 at 06:47:59AM +, Xinming Hu wrote: >

Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-13 Thread Brian Norris
m; > > Amitkumar Karwar; Cathy Luo; Xinming Hu; Ganapathi Bhat > > Subject: [EXT] Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from > > combo > > firmware during function level reset > > > > External Email > > > >

RE: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-13 Thread Xinming Hu
[EXT] Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo > firmware during function level reset > > External Email > > -- > Hi, > > On Mon, Apr 10, 2017 at 09:09:34AM +, Xinming Hu

Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-12 Thread Brian Norris
Hi, One more thing, since you need to update this patchset anyway: On Mon, Apr 10, 2017 at 09:09:34AM +, Xinming Hu wrote: > From: Xinming Hu > > A seperate wifi-only firmware was download during pcie function level reset. You might consider running checkpatch.pl on your

Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-10 Thread Brian Norris
Hi, On Mon, Apr 10, 2017 at 09:09:34AM +, Xinming Hu wrote: > From: Xinming Hu > > A seperate wifi-only firmware was download during pcie function level reset. > It is in fact the tail part of wifi/bt combo firmware. Per Brian's and > Dmitry's suggestion, this patch