Re: rtl8821ae dbi read question

2017-11-06 Thread Larry Finger
On 11/05/2017 10:09 PM, Nik Nyby wrote: On 11/05/2017 09:09 PM, Larry Finger wrote: Disabling all of _rtl8821ae_enable_aspm_back_door() may not be wise. We tried that patch as part of debugging. That routine consists of two mdio r/w sequences, and 3 dbi r/w sequences. The third one of the

Re: rtl8821ae dbi read question

2017-11-05 Thread Nik Nyby
On 11/05/2017 09:09 PM, Larry Finger wrote: Disabling all of _rtl8821ae_enable_aspm_back_door() may not be wise. We tried that patch as part of debugging. That routine consists of two mdio r/w sequences, and 3 dbi r/w sequences. The third one of the latter is only used for RTL8812AE, thus it

Re: rtl8821ae dbi read question

2017-11-05 Thread Larry Finger
On 11/05/2017 03:15 PM, Nik Nyby wrote: I also want to note that adding rtl8821ae.aspm=0 to my grub kernel boot command doesn't fix my problem. (I'm building this driver into the kernel, not as a module). My connection dropping problem is fixed only if I comment out the aspm init code in the

Re: rtl8821ae dbi read question

2017-11-05 Thread Larry Finger
On 11/05/2017 02:53 PM, Nik Nyby wrote: On 11/05/2017 11:50 AM, Larry Finger wrote: If you read the commit message for commit b8b8b16352cd, you will find that we do not understand why using a byte read causes failure, but reverting the change so that it is a word read made it function again.

Re: rtl8821ae dbi read question

2017-11-05 Thread James Cameron
On Sun, Nov 05, 2017 at 04:15:36PM -0500, Nik Nyby wrote: > I also want to note that adding rtl8821ae.aspm=0 to my grub kernel > boot command doesn't fix my problem. (I'm building this driver into > the kernel, not as a module). My connection dropping problem is > fixed only if I comment out the

Re: rtl8821ae dbi read question

2017-11-05 Thread Nik Nyby
I also want to note that adding rtl8821ae.aspm=0 to my grub kernel boot command doesn't fix my problem. (I'm building this driver into the kernel, not as a module). My connection dropping problem is fixed only if I comment out the aspm init code in the driver, per this patch:

Re: rtl8821ae dbi read question

2017-11-05 Thread Nik Nyby
On 11/05/2017 11:50 AM, Larry Finger wrote: If you read the commit message for commit b8b8b16352cd, you will find that we do not understand why using a byte read causes failure, but reverting the change so that it is a word read made it function again. The "fix" was found by a user doing

Re: rtl8821ae dbi read question

2017-11-05 Thread Larry Finger
On 11/04/2017 06:27 PM, Nik Nyby wrote: In drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c, we have this function:  static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr)  { u16 read_addr = addr & 0xfffc; u8 tmp = 0, count = 0, ret = 0;

rtl8821ae dbi read question

2017-11-04 Thread Nik Nyby
In drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c, we have this function: static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr) { u16 read_addr = addr & 0xfffc; u8 tmp = 0, count = 0, ret = 0; rtl_write_word(rtlpriv, REG_DBI_ADDR, read_addr);