Re: [PATCHv2] mac80211: Copy tx'ed beacons to monitor mode

2015-09-18 Thread Johannes Berg
On Wed, 2015-09-09 at 09:46 +0200, Helmut Schaa wrote: > When debugging wireless powersave issues on the AP side it's quite > helpful > to see our own beacons that are transmitted by the hardware/driver. > However, > this is not that easy since beacons don't pass through the regular TX > queues.

Re: [PATCH] ibss: add VHT80 support for IBSS

2015-09-18 Thread Johannes Berg
On Thu, 2015-09-10 at 12:04 +0200, Janusz Dziedzic wrote: > Add VHT80 support for IBSS. > > eg. iw wlan0 ibss join 5180 80MHZ > iw wlan0 ibbs join 5220 80MHZ > Applied, with the obvious code style issue fixed. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wirele

Re: [PATCH] nl80211: Print reasons for errors in setting bitrates.

2015-09-21 Thread Johannes Berg
On Fri, 2015-09-18 at 14:02 -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Makes it easier to figure out why user-space calls are > failing. I'm aware of this problem, but I'm not going to gratuitously start printing to dmesg for this. There's a scheme being discussed for extended

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Johannes Berg
On Sat, 2015-09-19 at 12:39 +0200, Hauke Mehrtens wrote: > modinfo iwlwifi showed the following required firmware: > firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode This is obviously wrong. > > MODULE_FIRMWARE(IWL7260_MODULE_FIRMWARE(IWL7260_UCODE_API_OK)); > -MODULE_FIRMWARE(IWL3160_MODULE_F

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Johannes Berg
On Tue, 2015-09-22 at 10:44 +0200, Johannes Berg wrote: > On Sat, 2015-09-19 at 12:39 +0200, Hauke Mehrtens wrote: > > modinfo iwlwifi showed the following required firmware: > > firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode > > This is obviously wrong. > &

Re: [PATCH] mac80211: reset CQM history upon reconfiguration

2015-09-22 Thread Johannes Berg
On Mon, 2015-09-21 at 15:47 +0300, Luca Coelho wrote: > From: Sara Sharon > > Current behavior of notifying CQM events is inconsistent. > Upon first configuration there is a cqm event of channel status > according to threshold configured, regardless of signal stability. > When there is reconfigur

Re: [PATCH 0/6] mac80211: Deinline large functions in driver-ops.h

2015-09-22 Thread Johannes Berg
On Fri, 2015-09-18 at 15:19 +0200, Denys Vlasenko wrote: > After measuring size of inlines, these functions were found to be > largest. > These patches reduce code size by about 21 kbytes. > Only patches 1, 2 and 5 applied to mac80211-next. johannes -- To unsubscribe from this list: send the li

Re: [PATCH 0/6] mac80211: Deinline large functions in driver-ops.h

2015-09-22 Thread Johannes Berg
On Tue, 2015-09-22 at 15:28 +0200, Johannes Berg wrote: > On Fri, 2015-09-18 at 15:19 +0200, Denys Vlasenko wrote: > > After measuring size of inlines, these functions were found to be > > largest. > > These patches reduce code size by about 21 kbytes. > > > > O

Re: [PATCH v2] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-09-22 Thread Johannes Berg
On Sat, 2015-09-19 at 10:40 +0800, Fu, Zhonghui wrote: > Now, PM core supports asynchronous suspend/resume mode for devices > during system suspend/resume, and the power state transition of one > device may be completed in separate kernel thread. PM core ensures > all power state transition timing

Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160

2015-09-22 Thread Johannes Berg
> > Should I change something? No, I already created a different patch to make it simply use the 7260 number instead of the 3165 one. I also made one, in fact, to get rid of the 3165 since that has the same values anyway. > iwl3165 uses iwl3160 firmware, but support for that was added in rev >

ANN: wireless workshop at netdev 1.1 in Seville / February 10th

2015-09-22 Thread Johannes Berg
Hi all, As we did last year, we're planning to hold a wireless workshop for wireless (mostly 802.11) related topics at the netdev conference. This workshop will be at netdev 1.1, which takes places in Seville, Spain, February 10-12. The workshop will be held on the first day of the conference, i.

[PATCH] mac80211: minstrel[_ht]: remove non-ascii debugfs characters

2015-09-23 Thread Johannes Berg
From: Johannes Berg Replace the average symbol by "avg" to avoid being warned about the non-ASCII symbol all the time, line up the columns properly. (I changed my mind - the warnings are getting annoying) Signed-off-by: Johannes Berg --- net/mac80211/rc80211_minstrel_debugfs

[PATCH] mac80211: allow writing TX PN in debugfs

2015-09-23 Thread Johannes Berg
From: Johannes Berg For certain tests, for example replay detection, it can be useful to be able to influence/set the PN used in outgoing packets. Make it possible to change the TX PN in debugfs. For now, this doesn't support TKIP since I haven't needed it, but there's no reason

[PATCH] mac80211: advertise support for full station state in AP mode

2015-09-23 Thread Johannes Berg
associated, prior to that low rates will be used. Signed-off-by: Ayala Beker Signed-off-by: Johannes Berg --- net/mac80211/cfg.c | 33 ++--- net/mac80211/main.c | 3 ++- 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/net/mac80211/cfg.c b/net

pull-request: mac80211 2015-09-23

2015-09-23 Thread Johannes Berg
rom Sara Sharon ---- Johannes Berg (1): mac80211: fix VHT MCS mask array overrun Sara Sharon (1): mac80211: reset CQM history upon reconfiguration net/mac80211/cfg.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) -- To unsubscribe from this

Re: [PATCH] mac80211: minstrel[_ht]: remove non-ascii debugfs characters

2015-09-23 Thread Johannes Berg
On Wed, 2015-09-23 at 10:49 +0200, Bastian Bittorf wrote: > * Johannes Berg [23.09.2015 10:44]: > > Replace the average symbol by "avg" to avoid being warned about the > > non-ASCII symbol all the time, line up the columns properly. > > who warns you? the compile

Re: [PATCH] cfg80211: Add multiple scan plans for scheduled scan

2015-09-23 Thread Johannes Berg
Need to fix up the other drivers ... johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mac80211: Do not restart scheduled scan if multiple scan plans are set

2015-09-23 Thread Johannes Berg
On Mon, 2015-09-21 at 15:48 +0300, Luca Coelho wrote: > From: Avraham Stern > > If multiple scan plans were set for scheduled scan, do not restart > scheduled scan on reconfig because it is possible that some scan > plans were already completed and there is no need to run them all > over again. I

Re: [PATCH] mac80211: don't tear down aggregation on suspend in case of wowlan->any

2015-09-23 Thread Johannes Berg
On Mon, 2015-09-21 at 15:50 +0300, Luca Coelho wrote: > From: Eliad Peller > > in case of "any" wowlan trigger, there is no reason to tear down > aggregations, as we want the device to continue working normally. > > Similarly, there's no reason to tear down aggregations on resume, > as they shou

Re: Low latency communication over wifi

2015-09-23 Thread Johannes Berg
On Wed, 2015-09-23 at 13:03 +0200, Pavel Machek wrote: > Hi! > > I'm trying to transfer some audio data over wifi. Latency constrains > are such that if it would took more than 20msec to wait for > transmission, the packet should be dropped instead, and new one > should be transmitted. This is t

[PATCH] mac80211: improve __rate_control_send_low warning

2015-09-23 Thread Johannes Berg
From: Johannes Berg If there are no supported rates in the rate mask with the required flags, we warn, but it's not clear which part causes the warning. Add the relevant data to the warning to understand why it happens. Signed-off-by: Johannes Berg --- net/mac80211/rate.c | 5 - 1

Re: [PATCH 1/3] mac80211: Deinline drv_switch_vif_chanctx()

2015-09-23 Thread Johannes Berg
On Wed, 2015-09-23 at 14:18 +0200, Denys Vlasenko wrote: > With this .config: http://busybox.net/~vda/kernel_config_ALLYES_Os, > after deinlining the function size is 821 bytes and there are > 2 callsites, reducing code size by about 800 bytes. > Thanks, all applied. johannes -- To unsubscribe fr

Re: [PATCH 18/19] mac80211: make ieee80211_new_mesh_header return unsigned

2015-09-24 Thread Johannes Berg
On Thu, 2015-09-24 at 16:00 +0200, Andrzej Hajda wrote: > The function returns always non-negative values. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > You should at least compile your patches. johannes -- To un

[PATCH 1/2] mac80211: reduce indentation by inlining a check

2015-09-24 Thread Johannes Berg
From: Johannes Berg Instead of nesting two if statements, inline the second check into the first if statement and to indentation. Signed-off-by: Johannes Berg --- net/mac80211/mlme.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff

[PATCH 2/2] mac80211: use bool argument to ieee80211_send_nullfunc

2015-09-24 Thread Johannes Berg
From: Johannes Berg Instead of int with 0/1, use bool with false/true for the powersave argument to ieee80211_send_nullfunc(). Signed-off-by: Johannes Berg --- net/mac80211/ieee80211_i.h | 2 +- net/mac80211/mlme.c| 10 +- net/mac80211/offchannel.c | 6 +++--- net/mac80211

[RFC] mac80211: remove software PS-Poll implementation

2015-09-24 Thread Johannes Berg
From: Johannes Berg There's not all that much value in having a software PS-Poll implementation, particularly since it's very old and can't deal with multiple virtual interfaces. The code still supports a very basic software implementation of powersave using null-data packets.

Re: [PATCH 4.3 2/2] mac80211: fix handling of PS filtering with fast-xmit

2015-09-24 Thread Johannes Berg
On Thu, 2015-09-24 at 14:59 +0200, Felix Fietkau wrote: > Fixes dropped packets in the tx path in case a non-PS station > triggers > the tx filter. > Applied, but without the stable tag since no driver in 4.2 that uses IEEE80211_TX_CTL_CLEAR_PS_FILT also had FAST_XMIT. johannes -- To unsubscribe

Re: [PATCH 4.3 1/2] mac80211: fix tx sequence number assignment with software queue + fast-xmit

2015-09-24 Thread Johannes Berg
On Thu, 2015-09-24 at 14:59 +0200, Felix Fietkau wrote: > When using software queueing, tx sequence number assignment happens > at > ieee80211_tx_dequeue time, so the fast-xmit codepath must not do > that. > Applied, but to mac80211-next since there's no driver in 4.3 yet that actually uses ieee

[PATCH] mac80211: allow driver to prevent two stations w/ same address

2015-09-25 Thread Johannes Berg
From: Johannes Berg Some devices or drivers cannot deal with having the same station address for different virtual interfaces, say as a client to two virtual AP interfaces. Rather than requiring each driver with a limitation like that to enforce it, add a hardware flag for it. Signed-off-by

[PATCH v2 2/2] mac80211: allow driver to prevent two stations w/ same address

2015-09-25 Thread Johannes Berg
From: Johannes Berg Some devices or drivers cannot deal with having the same station address for different virtual interfaces, say as a client to two virtual AP interfaces. Rather than requiring each driver with a limitation like that to enforce it, add a hardware flag for it. Signed-off-by

[PATCH v2 1/2] mac80211: make sta_info_alloc() return value an ERR_PTR

2015-09-25 Thread Johannes Berg
From: Johannes Berg In order to return more accurate error numbers instead of assuming that all errors are actually -ENOMEM, return an ERR_PTR() from the function instead of NULL for errors. Signed-off-by: Johannes Berg --- net/mac80211/cfg.c| 4 ++-- net/mac80211/ibss.c | 4

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Johannes Berg
On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote: > Signed-off-by: Viresh Kumar > --- > V3->V4: > - Create a local variable instead of changing type of global_lock > (Rafael) Err, surely that wasn't what Rafael meant, since it's clearly impossible to use a pointer to the stack, assign to

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Johannes Berg
> Rafael wrote: > > Actually, what about adding a local u32 variable, say val, here and > > doing > > > > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 > > > *)&first_ec->gpe)) > > > goto error; > > > if (!debugfs_create_bool("use_global_lock", 0444, > > > dev_dir, > > > -

Re: Low latency communication over wifi

2015-09-28 Thread Johannes Berg
On Sat, 2015-09-26 at 12:24 +0200, Pavel Machek wrote: > > That would be equivalent to ping -Q, right? It does not seem to have > any effect :-(. I'd expect at least local machine to use shorter waits > for medium, and thus drop packets instead of waiting. Correct. But it won't *drop* packets, it

Re: [wireless-regdb] wireless-regdb: Update regulatory rules for South Africa (ZA) on 5GHz

2015-09-28 Thread Johannes Berg
> The bands don’t quite match up and DFS/TPC is (apparently) not > required for 5470 - 5725. More importantly, the max transmitted power > seems to be 1W/30dBm e.i.r.p and not 27dBm. Without checking now, just a note: we sometimes have lower limits here due to spectral power density, indoor/outd

Re: Low latency communication over wifi

2015-09-28 Thread Johannes Berg
On Mon, 2015-09-28 at 14:15 +0200, Bastian Bittorf wrote: > * Johannes Berg [28.09.2015 14:00]: > > > > # you have to add some magic for matching your data > > > > e.g. $IPT -t mangle -I OUTPUT -j DSCP --set-dscp-class CS7 > > > > > > Again, t

Re: [wireless-regdb] wireless-regdb: Update regulatory rules for South Africa (ZA) on 5GHz

2015-09-28 Thread Johannes Berg
On Mon, 2015-09-28 at 11:07 -0500, Seth Forshee wrote: > On Mon, Sep 28, 2015 at 09:44:20AM +0200, Johannes Berg wrote: > > > > > The bands don’t quite match up and DFS/TPC is (apparently) not > > > required for 5470 - 5725. More importantly, the max transmitted >

Re: [PATCH] mac80211: fix oops in ieee80211_beacon_get_tim

2015-09-29 Thread Johannes Berg
On Mon, 2015-09-28 at 20:58 +0200, Christian Lamparter wrote: > This patch fixes a crash which is triggered > by __ieee80211_beacon_get returning NULL. > This causes sky_copy to crash later unless > the hardware supports BEACON_TX_STATUS > feature. > > Signed-off-by: Christian Lamparter > --- > "

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-29 Thread Johannes Berg
On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: > It seems that ath10k ar988X hardware has a bug where the BSSID > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware > does not seem to use AMSDUs for IBSS, and when I enable it in my CT > firmware, then I see the breakage. So,

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 08:07 -0700, Ben Greear wrote: > > On 09/29/2015 11:46 PM, Johannes Berg wrote: > > On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: > > > It seems that ath10k ar988X hardware has a bug where the BSSID > > > for IBSS AMSDU frames is all

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 08:44 -0700, Ben Greear wrote: > > Any idea how this could be done in the stack instead of the driver? I don't see why it should be? > The problem is that this is a receiver-side issue, so even if I manage > to hack the ath10k firmware or driver rx logic, it would not fix a

Re: Low latency communication over wifi

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 19:24 +0200, Pavel Machek wrote: > On Mon 2015-09-28 09:41:43, Johannes Berg wrote: > > On Sat, 2015-09-26 at 12:24 +0200, Pavel Machek wrote: > > > > > > That would be equivalent to ping -Q, right? It does not seem to have > > > any e

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: > > Yes, it is a transmitter side problem, and A-MSDU on IBSS > is disabled by default in all ath10k firmware versions that I am aware of. Right. > I was hoping there might be a way to allow A-MSDU + IBSS + ath10k > to work in future kernels w

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 13:02 -0400, Josh Boyer wrote: > Hi Johannes, > > We've seen a handful of reports that seem to have verbose output from > the ieee80211_config_bw function in net/mac80211/mlme.c. It looks > similar to this: > > [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Johannes Berg
> > I'm not sure ratelimiting it would even work - it's not *that* high > frequency? Not really sure though. > > I think we can do either, it's not such a terribly important message as > far as I can tell. > Seems like Emmanuel would like to see the message stay in some form - perhaps we shoul

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-10-01 Thread Johannes Berg
> For what purpose? Or rather, when a user sees this in their dmesg, > what are they supposed to do about it? I think the idea isn't that the user would do something, but more that in case of performance issues, or perhaps driver/device bugs handling the changes, or similar you'd have an indicat

Re: [PATCH] cfg80211: drop unlikely behind WARN_ON()

2015-10-04 Thread Johannes Berg
The subject is entirely wrong - this is not a cfg80211 patch. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: iwlegacy and bridging iwl3945...? (sort of)

2015-10-04 Thread Johannes Berg
On Sun, 2015-10-04 at 20:38 +0100, Morgan Read wrote: > > So, can I expect to be able to bridge my 802.11 connection to work > with my KVM guests? > No, never over wireless, regardless of the driver. (Unless you also control the software on the AP and can run openwrt or such and use the Linux-

[PATCH] nl80211: allow BSS data to include CLOCK_BOOTTIME timestamp

2015-10-05 Thread Johannes Berg
n when the frame might have been buffered in the device (e.g. firmware.) Signed-off-by: Dmitry Shmidt [modified to use struct, inlines] Signed-off-by: Johannes Berg --- include/net/cfg80211.h | 91 +++- include/uapi/linux/nl80211.h | 4 ++ net/wirel

pull-request: mac80211-next 2015-10-05

2015-10-05 Thread Johannes Berg
Fu, Zhonghui (1): net/wireless: enable wiphy device to suspend/resume asynchronously Helmut Schaa (2): mac80211: Split sending tx'ed frames to monitor interfaces into its own function mac80211: Copy tx'ed beacons to monitor mode Johannes Berg (13): wireless: mak

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-10-05 Thread Johannes Berg
On Mon, 2015-10-05 at 14:49 -0400, Jes Sorensen wrote: > > Finally went back to look at this - I believe this is exactly what I am > doing in the driver right now. Pulling the short_preamble info from > BSS_CHANGED_ERP_PREAMBLE and storing it sta->drv_priv for use in the > tx function. > You can

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-10-05 Thread Johannes Berg
On Mon, 2015-10-05 at 15:04 -0400, Jes Sorensen wrote: > > I have this in the code - that said, I may not be getting a pointer > back ever? > > if (changed & BSS_CHANGED_ERP_PREAMBLE) { > ... > sta = ieee80211_find_sta(vif, bss_conf->bssid); > if (sta) { >

Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

2015-10-05 Thread Johannes Berg
On Mon, 2015-10-05 at 15:19 -0400, Jes Sorensen wrote: > Johannes Berg writes: > > On Mon, 2015-10-05 at 15:04 -0400, Jes Sorensen wrote: > > > > > > I have this in the code - that said, I may not be getting a > > > pointer > > > back ever? > >

Re: Deadlock in mac80211 running 3.18.11 + compat-wireless 2015-03-09

2015-10-06 Thread Johannes Berg
commit 2c158887f1185e04b3763ae346da9f71fcbc4429 Author: Johannes Berg Date: Thu Mar 12 19:28:31 2015 +0100 mac80211: agg-tx: avoid sending DelBA with sta->lock held The rate control locking caused a potential deadlock here due to the locks being acquired in different ord

Re: iwlegacy and bridging iwl3945...? (sort of)

2015-10-07 Thread Johannes Berg
> However, before I go down that route are any of the options for bonding, > which again seem as if they would work, actually a reality? > I don't really know anything about bonding, sorry. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a m

[PATCH v2] nl80211: allow BSS data to include CLOCK_BOOTTIME timestamp

2015-10-07 Thread Johannes Berg
n when the frame might have been buffered in the device (e.g. firmware.) Signed-off-by: Dmitry Shmidt [modified to use struct, inlines] Signed-off-by: Johannes Berg --- Documentation/DocBook/80211.tmpl | 5 ++- include/net/cfg80211.h | 95 include/

[PATCH 1/2] wireless: update robust action frame list

2015-10-07 Thread Johannes Berg
From: Johannes Berg Unprotected DMG and VHT action frames are not protected, reflect that in the list. Signed-off-by: Johannes Berg --- include/linux/ieee80211.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h index f79a02a69d26

[PATCH 2/2] wireless: add WNM action frame categories

2015-10-07 Thread Johannes Berg
From: Johannes Berg Add the WNM and unprotected WNM categories and mark the latter as not robust. Signed-off-by: Johannes Berg --- include/linux/ieee80211.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h index d55e605212e3

Re: [PATCH] Revert "mac80211: remove exposing 'mfp' to drivers"

2015-10-08 Thread Johannes Berg
On Wed, 2015-10-07 at 09:52 -0700, Peter Oh wrote: > On 10/06/2015 10:10 PM, c_tr...@qti.qualcomm.com wrote: > > From: Tamizh chelvam > > > > This reverts commit 5c48f1201744233d4f235c7dd916d5196ed20716. > > > > Some device drivers (ath10k) offload part of aggregation including > > AddBA/DelBA >

Re: [PATCH] iw: Fix return values when parameters are wrong

2015-10-08 Thread Johannes Berg
On Wed, 2015-10-07 at 18:45 +0200, Ola Olsson wrote: > According to header file, wrong parameters > yield 1 as return value. > Also tried to fix the comments since one part > of it was unreadable. > That seems reasonable, but your patch (this one at least) is completely whitespace damaged. Did you

Re: [PATCH] mac80211: add missing struct ieee80211_txq tid field initialization

2015-10-08 Thread Johannes Berg
Applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mac80211: Take bitrates into account when building IEs.

2015-10-08 Thread Johannes Berg
On Fri, 2015-09-18 at 14:02 -0700, gree...@candelatech.com wrote: > From: Ben Greear > > If a user restricts the rateset for some reason, then the > probe requests should not advertise rates that are not > selected by the user. > > To implement this, we save the requested bitrates at > the mac80

Re: [PATCH] iw: Display-interface-generation-if-available

2015-10-08 Thread Johannes Berg
On Tue, 2015-09-29 at 12:30 +0200, Olsson, Ola wrote: [attached patch] That email didn't make it to the list, perhaps due to the attachment. > + if (tb_msg[NL80211_ATTR_GENERATION]) > +>> > printf("%s\tgeneration %d\n", indent, > nla_get_u32(tb_msg[NL80211_ATTR_GENERATION])); That

Re: [PATCH] iw: Memory leak in error condition

2015-10-08 Thread Johannes Berg
On Thu, 2015-10-01 at 01:27 +0200, Ola Olsson wrote: > Oh yes! :) > Suddenly valgrind was happy as well. > > From 2724dd259f2bf61a2b7c85a70a70fd640a583453 Mon Sep 17 00:00:00 > 2001 > From: Ola Olsson > Date: Thu, 1 Oct 2015 00:43:06 +0200 > Subject: [PATCH] iw: Memory leak in error condition Si

Re: [PATCH] Remove superfluous header files

2015-10-08 Thread Johannes Berg
On Sun, 2015-10-04 at 23:08 +0200, Ola Olsson wrote: > if.h only contains if_nametoindex and the reverse. > Lets remove the inclusion in the source files where > these functions are not called. > Applied, with updated subject. Thanks! johannes -- To unsubscribe from this list: send the line "uns

Re: [PATCH] iw: Fix memory leak in error path

2015-10-12 Thread Johannes Berg
On Fri, 2015-10-09 at 16:52 +0200, Ola Olsson wrote: > The leak is present if malloc fails after requesting > a scan with ies or meshid as input. > Applied, thanks! johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.ker

Re: [PATCH] Revert "mac80211: remove exposing 'mfp' to drivers"

2015-10-13 Thread Johannes Berg
On Wed, 2015-10-07 at 10:40 +0530, c_tr...@qti.qualcomm.com wrote: > From: Tamizh chelvam > > This reverts commit 5c48f1201744233d4f235c7dd916d5196ed20716. > > Some device drivers (ath10k) offload part of aggregation including > AddBA/DelBA > negotiations to firmware. In such scenario, the PMF

Re: [PATCH] mac80211: Fix hwflags debugfs file format

2015-10-13 Thread Johannes Berg
On Thu, 2015-10-08 at 19:20 +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Commit 30686bf7f5b3 ("mac80211: convert HW flags to unsigned long > bitmap") accidentally removed the newline delimiter from the hwflags > debugfs file. Fix this by adding back the newline betw

Re: [PATCH v2] nl80211: allow BSS data to include CLOCK_BOOTTIME timestamp

2015-10-13 Thread Johannes Berg
On Wed, 2015-10-07 at 11:32 +0200, Johannes Berg wrote: > From: Dmitry Shmidt > > For location and connectivity services, userspace would often like > to know the time when the BSS was last seen. The current "last seen" > value is calculated in a way that makes it les

Re: [PATCH v2 1/2] cfg80211: Add multiple scan plans for scheduled scan

2015-10-13 Thread Johannes Berg
On Mon, 2015-10-12 at 09:51 +0300, Luca Coelho wrote: > From: Avraham Stern > > Add the option to configure multiple 'scan plans' for scheduled scan. > Each 'scan plan' defines the number of scan cycles and the interval > between scans. The scan plans are executed in the order they were > configu

pull-request: mac80211 2015-10-13

2015-10-13 Thread Johannes Berg
Hi, There are just two small fixes, but I didn't really want to wait since I have nothing else pending. Let me know if there's any problem. johannes The following changes since commit babc305e21ea3811d98b67437299360904ac1b6a: mac80211: reset CQM history upon reconfiguration (2015-09-22 15:22

Re: [PATCH] ocb: use correct "MHz" instead of "MHZ"

2015-10-13 Thread Johannes Berg
Hi Ola, Thanks for all the patches - I just applied this and three others. Note that I've reworded the subject for some - I prefer the subject to state in active voice what the change is doing - i.e. be something you read before the actual change, rather than afterwards. I'd appreciate if you cou

[PATCH] mac80211: use new cfg80211_inform_bss_frame_data() API

2015-10-13 Thread Johannes Berg
From: Johannes Berg The new API is more easily extensible with a metadata struct passed to it, use it in mac80211. Signed-off-by: Johannes Berg --- net/mac80211/ibss.c | 11 ++- net/mac80211/scan.c | 19 +-- 2 files changed, 15 insertions(+), 15 deletions(-) diff

Re: [PATCH] ocb: use correct "MHz" instead of "MHZ"

2015-10-13 Thread Johannes Berg
Hi, > May I ask if you are interested in patches that removes the compiler > warnings on Android? I have cloned the iw git under the external > folder in the android tree and everything compiles fine with "mm" but > there are a lot of warnings. Most warnings are unused-parameter and > sign-compare

Re: [PATCH] ocb: use correct "MHz" instead of "MHZ"

2015-10-14 Thread Johannes Berg
On Wed, 2015-10-14 at 09:36 +0200, Ola Olsson wrote: > Correct. I have done a macro to utilize the gcc "__attribute__ > ((unused))" and I fully understand that it is not an elegant > solution. > I don't want to convince you about merging it since I wouldn't do it > myself. :) Yeah, ouch, I don't

[PATCH] mac80211: remove PM-QoS listener

2015-10-14 Thread Johannes Berg
From: Johannes Berg As this API has never really seen any use and most drivers don't ever use the value derived from it, remove it. Change the only driver using it (rt2x00) to simply use the DTIM period instead of the "max sleep" time. Signed-off-by: Johannes Berg --- drive

[PATCH] mac80211: clean up ieee80211_rx_h_check_dup code

2015-10-14 Thread Johannes Berg
From: Johannes Berg Reduce indentation a bit to make the condition more readable. Signed-off-by: Johannes Berg --- net/mac80211/rx.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 5bc0b88d9eb1

[PATCH] mac80211: remove cfg.h

2015-10-14 Thread Johannes Berg
From: Johannes Berg The file contains just a single declaration that can easily move to another file - remove it. Signed-off-by: Johannes Berg --- net/mac80211/cfg.c | 1 - net/mac80211/cfg.h | 9 - net/mac80211/ieee80211_i.h | 2 ++ net/mac80211/main.c| 1 - 4

[PATCH] mac80211: remove event.c

2015-10-14 Thread Johannes Berg
From: Johannes Berg That file contains just a single function, which itself is just a single statement to call a different function. Remove it. Signed-off-by: Johannes Berg --- net/mac80211/Makefile | 1 - net/mac80211/event.c | 27 --- net/mac80211

[PATCH] mac80211: move sta_set_rate_info_rx() and make it static

2015-10-14 Thread Johannes Berg
From: Johannes Berg There's only a single caller of this function, so it can be moved to the same file and made static. Signed-off-by: Johannes Berg --- net/mac80211/cfg.c | 39 --- net/mac80211/sta_info.c

new regdb file format

2015-10-14 Thread Johannes Berg
Hi, I spent a bit of time thinking about a file format that would be more extensible, yet still be loadable into the kernel without having to parse it into new data structures in the kernel, i.e. be easy enough to read when needed. My considerations * must be extensible in some way * should be

Re: new regdb file format

2015-10-14 Thread Johannes Berg
Err. Let's try that again. I spent a bit of time thinking about a file format that would be more extensible, yet still be loadable into the kernel without having to parse it into new data structures in the kernel, i.e. be easy enough to read when needed. My considerations * must be extensible in

Re: new regdb file format

2015-10-14 Thread Johannes Berg
On Wed, 2015-10-14 at 23:01 +0200, Johannes Berg wrote: > > More documentation is here: > https://wireless.wiki.kernel.org/en/developers/todo-list/regdb-file > -format > FWIW, the file currently ends up being 3676 bytes with a new field for the CAC timeout already added

[PATCH 6/6] cfg80211: reg: rename reg_regdb_query() to reg_query_builtin()

2015-10-15 Thread Johannes Berg
From: Johannes Berg The new name better reflects the functionality. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 2d1343a7b60e..156a7d6eaf95 100644 --- a/net/wireless

[PATCH 2/6] cfg80211: reg: rename reg_call_crda to reg_query_database

2015-10-15 Thread Johannes Berg
From: Johannes Berg The new name is more appropriate since in the case of a built-in database it may not really rely on CRDA. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless

[PATCH 4/6] cfg80211: reg: remove useless reg_timeout scheduling

2015-10-15 Thread Johannes Berg
From: Johannes Berg When the functions reg_set_rd_driver() and reg_set_rd_country_ie() return with an error, the calling function already restores data by calling restore_regulatory_settings(), so there's no need to also schedule a timeout (which would lead to other side effects su

[PATCH 3/6] cfg80211: reg: search built-in database directly

2015-10-15 Thread Johannes Berg
From: Johannes Berg Instead of searching the built-in database only in the worker, search it directly and return an error if the entry cannot be found (or memory cannot be allocated.) This means that builtin database queries no longer rely on the timeout. Signed-off-by: Johannes Berg --- net

[PATCH 5/6] cfg80211: reg: make CRDA support optional

2015-10-15 Thread Johannes Berg
From: Johannes Berg If there's a built-in regulatory database, there may be little point in also calling out to CRDA and failing if the system is configured that way. Allow removing CRDA support to save ~1K kernel size. Signed-off-by: Johannes Berg --- net/wireless/Kconfig | 10 +

[RFC] cfg80211: support loading regulatory database as firmware file

2015-10-15 Thread Johannes Berg
From: Johannes Berg Signed-off-by: Johannes Berg --- net/wireless/reg.c | 259 - 1 file changed, 238 insertions(+), 21 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 156a7d6eaf95..f752be2b9f6f 100644 --- a/net

[PATCH 1/6] cfg80211: reg: remove useless non-NULL check

2015-10-15 Thread Johannes Berg
From: Johannes Berg There's no way that the alpha2 pointer can be NULL, so no point in checking that it isn't. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 7258246b7458..3a

Re: [RFC] cfg80211: support loading regulatory database as firmware file

2015-10-15 Thread Johannes Berg
> +>> return request_firmware_nowait(THIS_MODULE, true, "regulatory.db", > +>> > > >®_pdev->dev, GFP_KERNEL, > +>> > > >(void *)alpha2, regdb_fw_cb); > That should have some kind of signature validation though. Luis, is that going a

[PATCH 01/12] cfg80211: reg: remove useless non-NULL check

2015-10-15 Thread Johannes Berg
From: Johannes Berg There's no way that the alpha2 pointer can be NULL, so no point in checking that it isn't. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 7258246b7458..3a

[PATCH 09/12] cfg80211: reg: centralize freeing ignored requests

2015-10-15 Thread Johannes Berg
From: Johannes Berg Instead of having a lot of places that free ignored requests and then return REG_REQ_OK, make reg_process_hint() process REG_REQ_IGNORE by freeing the request, and let functions it calls return that instead of freeing. This also fixes a leak when a second (different) country

[PATCH 03/12] cfg80211: reg: rename reg_call_crda to reg_query_database

2015-10-15 Thread Johannes Berg
From: Johannes Berg The new name is more appropriate since in the case of a built-in database it may not really rely on CRDA. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless

[PATCH 02/12] cfg80211: reg: fix reg_call_crda() return value bug

2015-10-15 Thread Johannes Berg
From: Johannes Berg The function reg_call_crda() can't actually validly return REG_REQ_IGNORE as it does now when calling CRDA fails since that return value isn't handled properly. Fix that. Signed-off-by: Johannes Berg --- net/wireless/

[PATCH 08/12] cfg80211: reg: clarify 'treatment' handling in reg_process_hint()

2015-10-15 Thread Johannes Berg
From: Johannes Berg This function can only deal with treatment values OK and ALREADY_SET so make the callees not return anything else and warn if they do. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a

[PATCH 10/12] cfg80211: reg: fix antenna gain in chan_reg_rule_print_dbg()

2015-10-15 Thread Johannes Berg
From: Johannes Berg Printing "N/A mBi" is strange - print just "N/A" instead. Also add a missing opening parenthesis. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/wireless/reg.c b/net/

[PATCH 07/12] cfg80211: reg: rename reg_regdb_query() to reg_query_builtin()

2015-10-15 Thread Johannes Berg
From: Johannes Berg The new name better reflects the functionality. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 408cae3574bb..5532ecc080e5 100644 --- a/net/wireless

[PATCH 04/12] cfg80211: reg: search built-in database directly

2015-10-15 Thread Johannes Berg
From: Johannes Berg Instead of searching the built-in database only in the worker, search it directly and return an error if the entry cannot be found (or memory cannot be allocated.) This means that builtin database queries no longer rely on the timeout. Signed-off-by: Johannes Berg --- net

[PATCH 11/12] cfg80211: reg: reduce chan_reg_rule_print_dbg() ifdef

2015-10-15 Thread Johannes Berg
From: Johannes Berg The function is void and static, so just ifdef its contents instead of duplicating the declaration. Signed-off-by: Johannes Berg --- net/wireless/reg.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c

<    13   14   15   16   17   18   19   20   21   22   >