On Thu, 2015-11-12 at 08:59 +0100, Johannes Berg wrote:
> On Wed, 2015-11-11 at 23:15 +0100, Johannes Berg wrote:
> >
> > +static unsigned long long count_or_symbols(struct expr *e)
> > +{
> > + switch (e->type) {
> > + case E_SYMBOL:
> > +
From: Johannes Berg
There are a few hardware flags that *are* valid to change, at least
under certain circumstances. Since drivers are doing that, add an
inline to make it easier to do correctly. They still need to take
care of locking themselves.
While at it, remove the pointless return in
From: Johannes Berg
There are many drivers with different behaviour, but in a lot of
systems only a single driver will ever be built. In that case we
could practically get rid of the code for the paths that this
driver/device doesn't need. Doing that, however, would be rather
dangerous.
From: Johannes Berg
"count" works similar to "select"; take, for example, this snippet:
config MY_COUNTER
int
config MY_DRIVER_1
bool "my driver 1"
count MY_COUNTER
config MY_DRIVER_2
bool "my dri
From: Johannes Berg
This will later allow introducing different behaviour between
driver and hw checks. Make mac80211 use the new check function
almost everywhere - one place cannot (rate control) and two of
them shouldn't get the behaviour I want to introduce (in hw
registration.)
Signe
From: Johannes Berg
Drivers that would like to have feature flag optimisations are
currently required to select _ON and _OFF symbols for each one,
indicating whether they'd like to be optimised for being on or
off respectively. This handles badly, if a new feature flag is
added then all
Changes since v3:
* fix Kconfig count to count only enabled (!= n) symbols
* fix code when CONFIG_JUMP_LABEL is not enabled
Changes since v2:
* introduce Kconfig count and use it instead of _ON/_OFF in
the first few patches and described below
(I'll squash that later if I don't abandon th
From: Johannes Berg
Make hwsim select a few on/off symbols and check that the
result is as expected:
* before 'registering' a device the branches are according
to the Kconfig default only
* 'registering' a device fixes that up to actually check
the hardware flags
* &
From: Johannes Berg
Instead of having to list all the hw flags in many places, just
list the macro to generate everything in a new include file and
include it in the proper places.
Unfortunately this breaks docbook processing since that doesn't
pre-process the file. It also doesn't ge
From: Johannes Berg
Unfortunately, I again used a different version of the tools,
so the changes are rather large.
Signed-off-by: Johannes Berg
---
scripts/kconfig/zconf.hash.c_shipped | 10 +-
scripts/kconfig/zconf.lex.c_shipped | 62 +-
scripts/kconfig/zconf.tab.c_shipped | 1600
On Thu, 2015-11-12 at 09:36 -0800, Peter Oh wrote:
> Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers
> to indicate support for VHT in Mesh mode.
>
I'm confused. Why would it be needed? You haven't added any API or
anything where userspace would do something differently based on
whether or n
On Thu, 2015-11-12 at 09:59 -0800, Peter Oh wrote:
> Add NL80211_EXT_FEATURE_VHT_MESH flag to allow drivers
> to indicate support for VHT in Mesh mode.
> This flag will be used by wireless drivers to indicate
> the capability of VHT Mesh support and wpa_supplicant to inspect
> wireless drivers' cap
On Thu, 2015-11-12 at 13:33 -0800, Peter Oh wrote:
>
> At this moment Mesh Point is not able to be brought up by userspace
> such
> as wap_supplicant at VHT data rates because there is no
> events/NL80211
> defined that userspace can check out if drivers can support Mesh
> Point
> (802.11s) at
In v5, I've radically simplified the whole concept and dropped the
support for static keys. Instead, I'm now simply entirely removing
the if statements - replacing them by "if (true)" or "if (false)"
if that's at all possible.
For many (distro) kernels, this will - as before - mean no change,
bu
In v5, I've radically simplified the whole concept and dropped the
support for static keys. Instead, I'm now simply entirely removing
the if statements - replacing them by "if (true)" or "if (false)"
if that's at all possible.
For many (distro) kernels, this will - as before - mean no change,
bu
From: Johannes Berg
Unfortunately, I again used a different version of the tools,
so the changes are rather large.
Signed-off-by: Johannes Berg
---
scripts/kconfig/zconf.hash.c_shipped | 10 +-
scripts/kconfig/zconf.lex.c_shipped | 62 +-
scripts/kconfig/zconf.tab.c_shipped | 1600
From: Johannes Berg
Copy the hardware flags settings into Kconfig for iwlwifi/mvm.
Signed-off-by: Johannes Berg
---
drivers/net/wireless/iwlwifi/Kconfig | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlwifi/Kconfig
b/drivers/net
From: Johannes Berg
Instead of having to list all the hw flags in many places, just
list the macro to generate everything in a new include file and
include it in the proper places.
Unfortunately this breaks docbook processing since that doesn't
pre-process the file. It also doesn't ge
From: Johannes Berg
There are many drivers with different behaviour, but in a lot of
systems only a single driver will ever be built. In that case we
can get rid of code paths that this driver doesn't need and also
optimize the ones that it always takes to not have a check.
To make
From: Johannes Berg
"count" works similar to "select"; take, for example, this snippet:
config MY_COUNTER
int
config MY_DRIVER_1
bool "my driver 1"
count MY_COUNTER
config MY_DRIVER_2
bool "my dri
On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote:
>
> Exactly the same communication mechanism and purpose are used with
> NL80211_EXT_FEATURE_VHT_IBSS which is already a part of NL80211
> feature
> flag.
> The new feature flag, NL80211_EXT_FEATURE_VHT_MESH, follows the same
> purpose and usag
On Thu, 2015-11-12 at 15:05 -0800, Peter Oh wrote:
> On 11/12/2015 02:32 PM, Johannes Berg wrote:
> > On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote:
> > >
> > > Exactly the same communication mechanism and purpose are used
> > > with
> > > NL
On Fri, 2015-11-13 at 20:48 +1100, Julian Calaby wrote:
>
> Am I missing something or are you not actually doing anything with
> MAC80211_DRIVER_NO_HWFLAGS?
>
Crap. I meant to pass it to the macro like this (I think):
#define __DEFINE_HWFLAG(_flg, _dyn, _on, _off) \
On Fri, 2015-11-13 at 10:52 +0100, Johannes Berg wrote:
>
> (CONFIG_MAC80211_DRIVER_NO_HWFLAGS > 0),
Of course not, it's a bool. Anyway, thanks!
johannes
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless"
On Fri, 2015-11-13 at 11:22 -0500, Steven Rostedt wrote:
> This sure could use a comment.
>
> on = 0, off = 0, -1 + (0^0) * (1 + 0) = -1
> on = 0, off = 1, -1 + (0^1) * (1 + 0) = 0
> on = 1, off = 0, -1 + (1^0) * (1 + 1) = 1
> on = 1, off = 1, -1 + (1^1) * (1 + 1) = -1
>
> The I would al
On Fri, 2015-11-13 at 11:25 -0500, Steven Rostedt wrote:
> > + __DEFINE_HWFLAG(_flg,
> > \
> > + IS_ENABLED(CONFIG_MAC80211_HW_##_flg##_ON)
> > , \
> > + IS_ENABLED(CONFIG_MAC80211_HW_##_flg##_OFF
> > ))
> > +#include
On Fri, 2015-11-13 at 11:26 -0500, Steven Rostedt wrote:
>
> > config MY_DRIVER_2
> > bool "my driver 2"
> > count MY_COUNTER
> >
> > This will get MY_COUNTER to have a value of 0, 1 or 2, depending
> > on whether or not MY_DRIVER_1/MY_DRIVER_2 are not at all, one or
>
On Fri, 2015-11-13 at 11:29 -0500, Steven Rostedt wrote:
> > - select MAC80211_HW_HAS_RATE_CONTROL_OFF
> > - select MAC80211_HW_RX_INCLUDES_FCS_OFF
>
> What happened to these two?
I removed the _OFF ones entirely, and instead with this patch am now
relying on modified logic:
_on = flags_c
On Fri, 2015-11-13 at 15:50 -0800, Peter Oh wrote:
>
> I'm saying, cannot use VHT Mesh by wpa_supplicant because a lack of
> communication method between driver and wpa_supplicant, hence
> extending NL80211 feature flag.
> >
And I'm arguing that you don't need such a communication method since,
> So maybe add some wrapper that does a pr_info then
> a pr_debug for the second and subsequent uses like:
>
That seems like a bad idea - one might be tricked into think that one
saw the current data, but the actually current data is later hidden.
johannes
--
To unsubscribe from this list: send
On Mon, 2014-09-01 at 13:26 +0200, Henning Rogge wrote:
> The following patch adds NL80211_CMD_GET_MPP as a new nl80211 command that
> allows to query the content of the 'mesh proxy path' table of mac80211s via
> 'get' or 'dump' operation.
For review and merging, and to make it more obvious to yo
On Fri, 2014-08-29 at 19:27 +0200, Steinar H. Gunderson wrote:
> ieee80211_find_80211h_pwr_constr
Please format the code like this:
static bool
ieee80211_find_80211h_pwr_constr(struct ieee80211_sub_if_data *sdata,
struct ieee80211_channel *channel,
On Fri, 2014-08-29 at 19:38 +0200, Steinar H. Gunderson wrote:
> Linux already supports 802.11h, where the access point can tell the
> client to reduce its transmission power. However, 802.11h is only
> defined for 5 GHz, where the need for this is much smaller than on
> 2.4 GHz.
>
> Cisco has the
On Wed, 2014-09-03 at 14:12 +0200, Henning Rogge wrote:
> On Wed, Sep 3, 2014 at 1:52 PM, Johannes Berg
> wrote:
> > On Mon, 2014-09-01 at 13:26 +0200, Henning Rogge wrote:
> >> The following patch adds NL80211_CMD_GET_MPP as a new nl80211 command that
> >> allo
On Wed, 2014-09-03 at 14:32 +0200, Henning Rogge wrote:
> > No need, I just wasn't sure it really needed the same data so figured
> > I'd ask.
>
> At the moment I don't use much of the mpath_info field... but I think
> the mpp operations will always use a subset of the mpath fields, so we
> can r
On Wed, 2014-09-03 at 15:33 +0200, Matteo Croce wrote:
> Sorry, gmail wrapped the line with the C function.
> Here is a fixed patch
Nope, didn't work either :)
I think I'll just commit the fix myself ...
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
th
On Wed, 2014-09-03 at 15:33 +0200, Steinar H. Gunderson wrote:
> On Wed, Sep 03, 2014 at 02:00:36PM +0200, Johannes Berg wrote:
> > I think for some vendors shipping our stack this might become
> > problematic. I think it would make sense to have a Kconfig option for
> > this,
On Wed, 2014-09-03 at 16:15 +0300, Jouni Malinen wrote:
> Source:
> http://www.ntrc.org.lc/operational_structures.htm
Out of curiosity, I clicked the URL, but it seems empty/dead? :)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to
On Thu, 2014-09-04 at 13:17 +0300, Jouni Malinen wrote:
> On Thu, Sep 04, 2014 at 10:03:51AM +0200, Johannes Berg wrote:
> > On Wed, 2014-09-03 at 16:15 +0300, Jouni Malinen wrote:
> > > Source:
> > > http://www.ntrc.org.lc/operational_structures.htm
> >
> &
On Thu, 2014-09-04 at 10:51 -0700, Ben Greear wrote:
> I'm having issues with udev renaming newly created stations when I have
> udev rules for wlanX, when wlanX is not already existing.
>
> I think specifying MAC on station creation time would solve my problems,
> but haven't looked closely yet.
From: Johannes Berg
Many devices run firmware and/or complex hardware, and most of that
can have bugs. When it misbehaves, however, it is often much harder
to debug than software running on the host.
Introduce a "device coredump" mechanism to allow dumping internal
device/firmware sta
On Thu, 2014-09-04 at 21:18 +0300, Emmanuel Grumbach wrote:
> Not sure how the declaration of ieee80211_tdls_peer_del_work
> landed after the double inclusion protection end.
Applied, thanks.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a m
On Fri, 2014-09-05 at 11:40 +0200, Jonas Gorski wrote:
> On Fri, Sep 5, 2014 at 10:50 AM, Johannes Berg
> wrote:
> > From: Johannes Berg
>
> Can't you just send from the correct address? ;p
Not easily :)
> How about the following to avoid negative options
On Thu, 2014-09-04 at 23:57 +0200, Lorenzo Bianconi wrote:
> Enable ACK timeout estimation algorithm (dynack) using mac80211
> set_coverage_class API. Dynack is activated passing -1 as coverage class
> to lower drivers and it is automatically disabled setting valid value for
> coverage class. Curre
On Thu, 2014-09-04 at 22:37 +0300, Emmanuel Grumbach wrote:
> From: Eyal Shapira
>
> commit "mac80211: disable 40MHz support in case of 20MHz AP"
> broke working VHT in 20Mhz with APs like Netgear R6300v2 which
> do not publish support for 40Mhz but allow use of VHT in 20Mhz.
> The break is becau
On Wed, 2014-09-03 at 15:25 +0300, Emmanuel Grumbach wrote:
> sta_set_sinfo is obviously takes data for specific station.
> This specific station is attached to a specific virtual
> interface. Hence we should use the dtim_period from this
> virtual interface rather than the system wide dtim_period.
On Wed, 2014-09-03 at 15:24 +0300, Emmanuel Grumbach wrote:
> Hi Johannes,
>
> here are a few patches from our internal tree. You have already seen
> most of them.
Applied all.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majo
On Fri, 2014-09-05 at 13:31 +0200, Johannes Berg wrote:
> On Thu, 2014-09-04 at 23:57 +0200, Lorenzo Bianconi wrote:
> > Enable ACK timeout estimation algorithm (dynack) using mac80211
> > set_coverage_class API. Dynack is activated passing -1 as coverage class
> > to lo
On Fri, 2014-09-05 at 13:39 +0200, Henning Rogge wrote:
> From: "Henning Rogge" fkie.fraunhofer.de>
>
> The following patch series adds and implements two new cfg80211_ops that
> allow to query the content of the mac80211s mesh proxy path table via
> netlink.
>
> v2 changes:
> * split the origin
On Fri, 2014-09-05 at 15:13 -0700, Greg Kroah-Hartman wrote:
> > +MODULE_AUTHOR("Johannes Berg ");
> > +MODULE_DESCRIPTION("Device Coredump support");
> > +MODULE_LICENSE("GPL");
>
> As you only allow Y or N as build options, it's no
On Fri, 2014-09-05 at 15:13 -0700, Greg Kroah-Hartman wrote:
> > + /*
> > +* this seems racy, but I don't see a notifier or such on
> > +* a struct device to know when it goes away?
> > +*/
> > + if (devcd->failing_dev->kobj.sd)
> > + sysfs_delete_link(&devcd->failing_dev
On Wed, 2014-09-03 at 06:48 -0700, Steinar H. Gunderson wrote:
> Linux already supports 802.11h, where the access point can tell the
> client to reduce its transmission power. However, 802.11h is only
> defined for 5 GHz, where the need for this is much smaller than on
> 2.4 GHz.
>
> Cisco has the
From: Johannes Berg
This message occasionally triggers for some people as in
https://bugzilla.redhat.com/show_bug.cgi?id=740 but
it's not clear which (headroom or tailroom) is at fault.
Annotate the message a bit to get more information.
Signed-off-by: Johannes Berg
---
net/mac80211/
On Mon, 2014-09-08 at 08:24 -0400, Bob Copeland wrote:
> On Mon, Sep 08, 2014 at 02:01:22PM +0800, Chun-Yeow Yeoh via Devel wrote:
> > The hidden mesh ID is use to enhance the security of
> > open mesh and possible secured mesh later on by not
> > advertising the mesh ID during beacon generation,
>
-
Emmanuel Grumbach (1):
mac80211: use bss_conf->dtim_period instead of conf.ps_dtim_period
Johannes Berg (1):
nl80211: clear skb cb before passing to netlink
net/mac80211/sta_info.c | 2 +-
net/wireless/nl80211.c | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-
On Tue, 2014-09-09 at 20:08 +0200, Toralf Förster wrote:
> trivial, but this is user visible b/c it is in the help text
Since I saw it I just picked it up into our tree - it'll make it's way
through the system. Thanks.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-w
On Mon, 2014-09-08 at 18:30 +0200, Rostislav Lisovy wrote:
> The possible (first implementation) solution might be either to
> implement some "dummy" rate control algorithm that will set a fixed
> datarate only once (during "ocb join" command) or to use the Minstrel
> while limiting the allowed da
On Wed, 2014-09-10 at 16:06 -0400, Alexander Duyck wrote:
> The code for cloning the skb for an acknowledgement was checking to see if
> the cloned skb was shared and if it was it was then freeing the original
> skb. Since a clone should never really be shared I suspect that the
> intention was to
On Thu, 2014-09-11 at 04:02 +, Sharma, Sanjeev wrote:
> -Original Message-
> From: Johannes Berg [mailto:johan...@sipsolutions.net]
> Sent: Friday, August 22, 2014 5:01 PM
> To: Sharma, Sanjeev
> Cc: d...@gentoo.org; k...@deine-taler.de; linvi...@tuxdriver.com;
&
On Wed, 2014-09-10 at 18:05 -0400, Alexander Duyck wrote:
> There is a possible issue with the use, or lack thereof of sk_refcnt and
> sk_wmem_alloc in the wifi ack status functionality.
>
> Specifically if a socket were to request acknowledgements, and the socket
> were to have sk_refcnt drop to
On Wed, 2014-09-10 at 13:39 +0300, Emmanuel Grumbach wrote:
> From: Johannes Berg
>
> When freeing the connect keys, clear the memory to avoid
> having the key material stick around in memory "forever".
Applied, except for patch 4 which is actually pointless.
johannes
On Wed, 2014-09-10 at 15:00 +0300, Emmanuel Grumbach wrote:
> From: Johannes Berg
>
> Clear any nl80211 messages that might contain keys after
> processing them to avoid leaving their data in memory
> "forever" after they've been freed.
Applied.
johannes
--
To un
On Wed, 2014-09-10 at 22:28 +0300, Emmanuel Grumbach wrote:
> From: Johannes Berg
>
> There's no need to put the values on the stack, just pass a
> pointer to the data in the nl80211 message. This reduces stack
> usage and avoids potential issues with putting sensitive
On Tue, 2014-09-09 at 23:22 +0200, Thomas Huehn wrote:
> Minstrel and Mintrel_HT used there own structs to keep track of rate
> statistics. Unify those variables in struct minstrel_rate_states and
> move it to rc80211_minstrel.h for common usage. This is a clean-up
> patch to prepare Minstrel and M
On Tue, 2014-09-09 at 23:22 +0200, Thomas Huehn wrote:
> This patch improves the way minstrel_ht sorts rates according to throughput
> and success probability. 3 FOR-loops across the entire rate and mcs group set
> in function minstrel_ht_update_stats() which where used to determine the
> fastest,
On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote:
> on some architecture spin_is_locked() always return false in
> uniprocessor configuration and therefore it would be advise
> to replace with lockdep_assert_held().
>
> Signed-off-by: Sanjeev Sharma
> ---
> Changes in v2:
> - corrected t
On Fri, 2014-09-05 at 15:06 +0200, Henning Rogge wrote:
> Add two new cfg80211 operations for querying the content of the the mac80211s
> proxy path table
Please use shorter line lengths, and formulate it in a generic way -
this shouldn't be mac80211 specific.
johannes
--
To unsubscribe from th
On Fri, 2014-09-05 at 15:06 +0200, Henning Rogge wrote:
> Implement get_mpp and dump_mpp cfg80211_ops to export the content of the
> 802.11s mesh proxy path table to userspace.
line is also too long.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the bo
On Thu, 2014-09-04 at 08:28 +0300, Emmanuel Grumbach wrote:
> From: Liad Kaufman
>
> Adding a timeout for tearing down a TDLS connection that
> hasn't had ACKed traffic sent through it for a certain
> amount of time.
>
> Since we have no other monitoring facility to indicate the
> existance (or
On Mon, 2014-09-01 at 13:34 +0200, Henning Rogge wrote:
> Add "mpp get" and "mpp dump" command to query to mac80211s
> mesh proxy path table.
>
> Signed-off-by: Henning Rogge
> ---
> Makefile | 2 +-
> mpp.c | 84
> +++
This patc
On Tue, 2014-09-09 at 22:55 +0300, Emmanuel Grumbach wrote:
> From: Johannes Berg
>
> Add nl80211 and driver API to validate, add and delete traffic
> streams with appropriate settings.
>
> The API calls for userspace doing the action frame handshake
> with the peer, and th
On Tue, 2014-09-09 at 17:09 +0300, Emmanuel Grumbach wrote:
> From: Eliad Peller
>
> Userspace might need to know what queues are configured
> for uapsd (e.g. for setting proper default values in tspecs).
>
> Add this bitmap to the association event (inside wmm
> nested attribute)
>
> Add addit
On Tue, 2014-09-09 at 17:11 +0300, Emmanuel Grumbach wrote:
> From: Arik Nemtsov
>
> Correctly mark the network header location in mac80211-generated TDLS
> frames. These may be used by lower-level drivers.
Applied.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wi
On Thu, 2014-09-11 at 10:36 +, Sharma, Sanjeev wrote:
> > - ZD_ASSERT(!spin_is_locked(&mac->lock));
> > + lockdep_assert_held(&mac->lock);
> >Look closely at this again.
>
> I didn't understand where I put wrong logic ?
Ok, that's fine. But please send a new patch only when you've und
On Thu, 2014-09-11 at 12:43 +0200, Henning Rogge wrote:
> On Thu, Sep 11, 2014 at 12:18 PM, Johannes Berg
> wrote:
> > On Fri, 2014-09-05 at 15:06 +0200, Henning Rogge wrote:
> >> Add two new cfg80211 operations for querying the content of the the
> >> mac80211s p
On Wed, 2014-09-10 at 14:07 +0300, Emmanuel Grumbach wrote:
> From: Eliad Peller
>
> Add feature bits to indicate device support for
> static-smps and dynamic-smps modes.
>
> Add a new NL80211_ATTR_SMPS_MODE attribue to allow
> configuring the smps mode to be used by the ap
> (e.g. configuring t
didn't clone twice - no big deal, it
never happens anyway (that IDR thing should never actually run out of
space)
Anyway, thanks. I expect due to the patch 1 davem will apply both
patches (and I'm going to be on vacation anyway), so
Acked-by: Johannes Berg
for both patches.
Thanks!
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Johannes Berg
Many devices run firmware and/or complex hardware, and most of that
can have bugs. When it misbehaves, however, it is often much harder
to debug than software running on the host.
Introduce a "device coredump" mechanism to allow dumping internal
device/firmware sta
: combine roc with the "next roc" if possible
cfg80211/mac80211: add wmm info to assoc event
cfg80211: allow requesting SMPS mode on ap start
mac80211: set smps_mode according to ap params
mac80211: replace SMPS hw flags with wiphy feature bits
Eyal Shapira (1):
mac802
On Thu, 2014-09-11 at 23:35 +0300, Vadim Kochan wrote:
> Added new netdev_ops callback for setting namespace in specific
> for this device way
> +++ b/include/linux/netdevice.h
> @@ -997,6 +997,8 @@ typedef u16 (*select_queue_fallback_t)(struct net_device
> *dev,
> * Callback to use for xmit
On Tue, 2014-09-23 at 09:14 +0800, Chun-Yeow Yeoh wrote:
> Allow user to configure frequency and channel type during
> mesh join command.
I think I saw another v4 of this, was this meant to be v5?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body o
On Tue, 2014-09-30 at 11:48 -0700, gree...@candelatech.com wrote:
> From: Ben Greear
>
> This saves an extra call to change it later, and will
> also keep udev from potentially messing with a vdev
> it should not be messing with.
>
> Signed-off-by: Ben Greear
> ---
> info.c | 2 ++
> int
On Mon, 2014-09-29 at 15:46 -0700, Ben Greear wrote:
> As far as I can tell, the .h file is not installed anywhere
> in a normal OS.
>
> What is the proper method to get this file sanitized and put
> into a more common location?
You mean from the kernel build? Then you'd have to move it into the
On Fri, 2014-09-26 at 16:24 -0700, gree...@candelatech.com wrote:
> +/*
> + * Attempt to rename a device. Acquire RTNL before calling.
> + */
please add kernel-doc
> +int cfg80211_dev_rename_wiphy(struct wiphy *wiphy, char *newname);
Should also be const char *
And should probably be called c
You also really need to work on the subject prefixes...
They should be
1) cfg80211
2) mac80211-hwsim:
3) mac80211:
4) mac80211-hwsim:
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
On Thu, 2014-09-25 at 15:58 -0700, gree...@candelatech.com wrote:
> From: Ben Greear
>
> It is not always convenient to have to know the device-id,
> so allow deleting by name as well.
>
> Signed-off-by: Ben Greear
> ---
>
> v2: Protect against bad input.
>
> drivers/net/wireless/mac80211_h
On Wed, 2014-09-17 at 01:47 +0200, Steinar H. Gunderson wrote:
> On Mon, Sep 08, 2014 at 10:53:20AM +0200, Johannes Berg wrote:
> >> Linux already supports 802.11h, where the access point can tell the
> >> client to reduce its transmission power. However, 802.11h is only
&
On Wed, 2014-10-01 at 11:27 +0200, Stanislaw Gruszka wrote:
> Dynamic power save timeout value is suppose to be configurable via
> wext, but due to iwconfig bug is not possible to set using that tool.
That's interesting, what's that bug?
> Allow to configure PS timeout via nl80211 - add NL80211_A
On Mon, 2014-10-06 at 23:48 +0800, Yeoh Chun-Yeow wrote:
> Hi, Johannes
>
> There are actually two different patches. The latest one, both of them
> are named as v4.
Right, sorry. I'm clearly going through email too quickly.
johannes
--
To unsubscribe from this list: send the line "unsubscribe
On Thu, 2014-09-25 at 14:22 -0700, gree...@candelatech.com wrote:
> +static const char mac80211_hwsim_gstrings_stats[][ETH_GSTRING_LEN] = {
> + "tx_pkts_nic",
> + "tx_bytes_nic",
> + "rx_pkts_nic",
> + "rx_bytes_nic",
> + "d_tx_dropped",
> + "d_tx_failed",
> + "d_ps_mod
On Thu, 2014-09-25 at 14:22 -0700, gree...@candelatech.com wrote:
> From: Ben Greear
>
> It seems previous code did not properly clean up memory
> if the packet could not be delivered to user-space.
Applied, also patch #3.
johannes
--
To unsubscribe from this list: send the line "unsubscribe l
On Thu, 2014-10-02 at 08:45 +0200, Michal Kazior wrote:
> It is okay to enable DFS for channel contexts
> based drivers as long as no combination advertises
> radar detection and multi-channel operation at the
> same time.
Don't we already check the latter in cfg80211?
johannes
--
To unsubscribe
On Tue, 2014-10-07 at 13:03 +0200, Stanislaw Gruszka wrote:
> On Mon, Oct 06, 2014 at 05:00:40PM +0200, Johannes Berg wrote:
> > On Wed, 2014-10-01 at 11:27 +0200, Stanislaw Gruszka wrote:
> > > Dynamic power save timeout value is suppose to be configurable via
> > > we
On Tue, 2014-10-07 at 18:02 +0530, Krishna Chaitanya wrote:
> iw/iwconfig tools are not only used by regular users but also used by
> developers/
> engineers. We use it heavily for all our wifi testing, and when
> debugging performance
> related issue having a configurable ps timeout is of value.
On Tue, 2014-10-07 at 15:43 +0200, Michal Kazior wrote:
> Correct. However ieee80211_radar_detected() takes only ieee80211_hw as
> an argument now. Skipping this check in mac80211 might bite later if
> someone extends cfg80211 later for multi-channel radar detection with
> non-mac80211 driver in m
On Wed, 2014-10-08 at 10:34 +0200, Loic Poulain wrote:
> + { "BCM2E1A", (kernel_ulong_t)&acpi_default_bluetooth },
Shouldn't that be uintptr_t?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More ma
On Fri, 2014-09-12 at 08:58 +0200, Henning Rogge wrote:
[...]
In general, this looks fine. However,
> @@ -691,6 +719,9 @@ int mpp_path_add(struct ieee80211_sub_if_data *sdata,
>
> spin_unlock(&tbl->hashwlock[hash_idx]);
> read_unlock_bh(&pathtbl_resize_lock);
> +
> + mpp_paths_g
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote:
[...]
Nice work. Let me (finally) look in more detail ...
> +++ b/include/uapi/linux/nl80211.h
> @@ -2031,6 +2031,8 @@ enum nl80211_attrs {
> * and therefore can't be created in the normal ways, use the
> * %NL80211_CMD_START_P2
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy
A bit more commit log would be good :)
> +++ b/include/net/cfg80211.h
> @@ -375,6 +375,8 @@ static inline enum nl80211_channel_type
> cfg80211_get_chandef_type(const struct cfg80211_chan_def *chandef)
>
On Thu, 2014-09-11 at 16:30 +0200, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy
same comment about commit log here - also this patch should either go
first in the series, or just be squashed with the cfg80211 patch,
there's no real need to distinguish between the two. I guess it can'
1901 - 2000 of 4576 matches
Mail list logo
