Re: [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant

2024-03-06 Thread Stefan Schmidt
Hello. On 05.03.24 20:55, Ricardo B. Marliere wrote: Since commit 43a7206b0963 ("driver core: class: make class_register() take a const *"), the driver core allows for struct class to be in read-only memory, so move the wpan_phy_class structure to be declared at build time placing it into read-o

Re: [PATCH net-next v1 1/1] ieee802154: mcr20a: Remove unused of_gpio.h

2024-03-06 Thread Stefan Schmidt
Hello. On 04.03.24 18:53, Andy Shevchenko wrote: of_gpio.h is deprecated and subject to remove. The driver doesn't use it, simply remove the unused header. Signed-off-by: Andy Shevchenko --- drivers/net/ieee802154/mcr20a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ieee8

Re: [PATCH net-next v1 1/1] ieee802154: at86rf230: Replace of_gpio.h by proper one

2024-03-06 Thread Stefan Schmidt
Hello. On 04.03.24 18:42, Andy Shevchenko wrote: of_gpio.h is deprecated and subject to remove. The driver doesn't use it directly, replace it with what is really being used. Signed-off-by: Andy Shevchenko --- drivers/net/ieee802154/at86rf230.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

Re: [PATCH wpan] mac802154: fix llsec key resources release in mac802154_llsec_key_del

2024-03-06 Thread Stefan Schmidt
Hello. On 28.02.24 17:38, Fedor Pchelkin wrote: mac802154_llsec_key_del() can free resources of a key directly without following the RCU rules for waiting before the end of a grace period. This may lead to use-after-free in case llsec_lookup_key() is traversing the list of keys in parallel with

Re: Re: [PATCH wpan] mac802154: fix llsec key resources release in mac802154_llsec_key_del

2024-03-06 Thread Alexander Aring
Hi, On Mon, Mar 4, 2024 at 2:25 AM Fedor Pchelkin wrote: > > Hello Alexander, > > Thanks for review! > > On 24/03/03 06:19PM, Alexander Aring wrote: > > Hi, > > > > On Wed, Feb 28, 2024 at 11:44 AM Fedor Pchelkin wrote: > > > > > > mac802154_llsec_key_del() can free resources of a key directly w

Re: [PATCH wpan-next] wifi: cfg802154: make wpan_phy_class constant

2024-03-06 Thread Miquel Raynal
Hi Ricardo, rica...@marliere.net wrote on Tue, 05 Mar 2024 16:55:24 -0300: > Since commit 43a7206b0963 ("driver core: class: make class_register() take > a const *"), the driver core allows for struct class to be in read-only > memory, so move the wpan_phy_class structure to be declared at build