Re: [Linux-zigbee-devel] [PATCH net-next 0/4] 6lowpan: set of bug fixes

2012-06-11 Thread Tony Cheneau
Hello, As Jan pointed out, it seems that the third patch of my patchset is not formatted properly. Moreover, I got my own email address wrong. Please disregard the whole patchset as I need to investigate the issue. I'll repost the complete patchset when it will be resolved. I'm sorry if it cau

Re: [Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread Sasha Levin
On Sun, 2012-06-10 at 20:04 -0700, David Miller wrote: > From: Sasha Levin > Date: Sun, 10 Jun 2012 13:10:19 +0200 > > > Currently when sending data over datagram, the send function will attempt to > > allocate any size passed on from the userspace. > > > > We should make sure that this size is

Re: [Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread David Miller
From: Sasha Levin Date: Sun, 10 Jun 2012 13:10:19 +0200 > Currently when sending data over datagram, the send function will attempt to > allocate any size passed on from the userspace. > > We should make sure that this size is checked and limited. The maximum size > of an IP packet seemed like t

[Linux-zigbee-devel] [PATCH net-next 0/4] 6lowpan: set of bug fixes

2012-06-11 Thread Tony Cheneau
Hello, (This is my first time submitting patches. If I fail to apply to some rules in here, please let me know) After reading the 6lowpan code, I found a few issues. This patchset fixes them. This patchset should apply cleanly against the current net-next. It contains only bug fixes, I'll send la

Re: [Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread Sasha Levin
Hi Alan, On Sun, 2012-06-10 at 12:24 +0100, Alan Cox wrote: > On Sun, 10 Jun 2012 13:10:19 +0200 > Sasha Levin wrote: > > + if (hlen + tlen + size > IEEE802154_MTU) { > > + err = -EMSGSIZE; > > + goto out; > > What stops an overflow at this point. We'll then pass a small va

[Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread Sasha Levin
Currently when sending data over datagram, the send function will attempt to allocate any size passed on from the userspace. We should make sure that this size is checked and limited. The maximum size of an IP packet seemed like the safest limit here. Signed-off-by: Sasha Levin --- Change in v2