Re: [Linux-zigbee-devel] [PATCH v2] mac802154: Keep track of the channel when changed

2013-04-08 Thread David Miller
From: Alan Ott Date: Fri, 5 Apr 2013 19:03:10 -0400 > Two sections checked whether the current channel != the new channel > without ever setting the current channel variables. > > 1. net/mac802154/tx.c: Prevent set_channel() from getting called every > time a packet is sent. > > 2. net/mac8021

Re: [Linux-zigbee-devel] [PATCH] mrf24j40: Enable link-layer acknowledgement and retry

2013-04-08 Thread David Miller
From: Alan Ott Date: Fri, 5 Apr 2013 16:34:51 -0400 > On the MRF24J40, link-layer acknowledgment request and retry must be > turned on explicitly for each packet. Turn this on in the hardware based > on the FC_ACK_REQ bit being set in the packet. > > Also, now that failure to receive an ACK wi

Re: [Linux-zigbee-devel] [PATCH net-next 0/2] ieee802154_mlme_ops oops removal and cleanup

2013-04-08 Thread David Miller
From: Werner Almesberger Date: Thu, 4 Apr 2013 13:31:46 -0300 > This fixes a kernel oops we get when some linux-zigbee user > space tools try to invoke unimplemented operations. > > The second of the two patches checks whether the respective > functions are present and returne EOPNOTSUPP if they

Re: [Linux-zigbee-devel] [PATCH 1/2] at86rf230: remove unnecessary / dead code

2013-04-08 Thread David Miller
From: Sascha Herrmann Date: Thu, 4 Apr 2013 23:02:00 +0200 > In at86rf230_probe() lp was first set to dev->priv and a few lines later > dev->priv was set to lp again, without changing lp in between. The call > to ieee802154_unregister_device() before err_irq: was unreachable. > > Signed-off-by:

Re: [Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq

2013-04-08 Thread Werner Almesberger
Sascha Herrmann wrote: > Maybe one way to eliminate the extra latency of the second register read > would be to split the interrupt handling function into a generic part > and two different functions to handle the different types of interrupts: Yes, if you want to optimize the number of register a