Re: [Linux-zigbee-devel] [PATCH] 6lowpan: Allow 6LoWPAN to be modular

2014-08-07 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 7 Aug 2014 17:06:43 +0200 > Change config symbol 6LOWPAN from type bool to type tristate, so > 6LoWPAN can be built modular, just like IPV6 > > Signed-off-by: Geert Uytterhoeven Applied, thanks. -

Re: [Linux-zigbee-devel] [PATCH net-next v9 3/9] net: nl802154 - make add_iface take name assign type

2014-07-17 Thread David Miller
From: Tom Gundersen Date: Thu, 17 Jul 2014 10:06:04 +0200 > @@ -192,8 +193,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct > genl_info *info) > if (devname[nla_len(info->attrs[IEEE802154_ATTR_DEV_NAME]) - 1] > != '\0') >

Re: [Linux-zigbee-devel] [PATCH net-next 1/2] 6lowpan: introduce new net/6lowpan directory

2014-07-11 Thread David Miller
From: Marcel Holtmann Date: Fri, 11 Jul 2014 14:33:03 +0200 > If you want I can also take the net/6lowpan stuff through bluetooth-next tree. Please take this stuff via the bluetooth/wireless trees to avoid the conflicts, thanks. --

Re: [Linux-zigbee-devel] [PATCH net-next 1/2] ieee802154: removed unwanted header files

2014-07-08 Thread David Miller
From: Varka Bhadram Date: Wed, 9 Jul 2014 09:14:04 +0530 > diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c > index 511ddee..d85caa2 100644 > --- a/net/ieee802154/6lowpan_iphc.c > +++ b/net/ieee802154/6lowpan_iphc.c > @@ -49,12 +49,8 @@ > * SUCH DAMAGE. > */ > > -

Re: [Linux-zigbee-devel] [PATCH v3 net-next 00/13] at86rf230: rework driver implementation

2014-07-07 Thread David Miller
From: Alexander Aring Date: Thu, 3 Jul 2014 00:20:42 +0200 > this patch series includes a rework of the at86rf230 driver. Series applied, thanks. -- Open source business process management suite built on Java and Eclip

Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154: fix coding style issues

2014-07-07 Thread David Miller
From: Varka Bhadram Date: Wed, 2 Jul 2014 09:01:09 +0530 > This patch fixed the coding style issues reported by checkpatch.pl > > following issues fixed: > CHECK: Alignment should match open parenthesis > WARNING: line over 80 characters > CHECK: Blank lines aren't necessary b

Re: [Linux-zigbee-devel] [PATCH net] ieee802154: reassembly: fix possible buffer overflow

2014-07-02 Thread David Miller
From: Alexander Aring Date: Sun, 29 Jun 2014 13:10:18 +0200 > The max_dsize attribute in ctl_table for lowpan_frags_ns_ctl_table is > configured with integer accessing methods. This patch change the > max_dsize attribute to int to avoid a possible buffer overflow. > > Signed-off-by: Alexander Ar

Re: [Linux-zigbee-devel] [PATCH net-next 01/13] mac802154: at86rf230: add hw flags and merge ops

2014-07-01 Thread David Miller
From: Alexander Aring Date: Sat, 28 Jun 2014 20:33:39 +0200 > This patch adds new mac802154 hw flags for transmit power, csma and > listen before transmit (lbt). These flags indicates that the transceiver > supports these features. In ieee802154_register_device the callbacks are > setted by hw fl

Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154: fix coding style issues

2014-07-01 Thread David Miller
From: Joe Perches Date: Tue, 01 Jul 2014 21:58:10 -0700 > The code is currently: > > __raw_writel(upper_32_bits(addr) & DESC_ADDR_HI_MASK, > d + DESC_ADDR_HI_STATUS_LEN); > > 1st line has 1 leading tab, > 2nd line has 3 leading tabs > > For networking code style, th

Re: [Linux-zigbee-devel] [PATCH net-next 0/2] cleanup for 6lowpan and mac802514

2014-07-01 Thread David Miller
From: David Miller Date: Tue, 01 Jul 2014 17:04:09 -0700 (PDT) > From: Varka Bhadram > Date: Thu, 26 Jun 2014 19:06:53 +0530 > >> These patches fixed the coding style issues reported by checkpatch.pl. > > Applied to net-next, thanks. Actually looking at your later posti

Re: [Linux-zigbee-devel] [PATCH net-next 0/2] cleanup for 6lowpan and mac802514

2014-07-01 Thread David Miller
From: Varka Bhadram Date: Thu, 26 Jun 2014 19:06:53 +0530 > These patches fixed the coding style issues reported by checkpatch.pl. Applied to net-next, thanks. -- Open source business process management suite built on J

Re: [Linux-zigbee-devel] [PATCH net-next v7 0/3] Driver for TI CC2520 Radio

2014-06-22 Thread David Miller
Series applied, thanks. -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Lev

Re: [Linux-zigbee-devel] [PATCH net] at86rf230: fix irq setup

2014-06-22 Thread David Miller
From: Phoebe Buckheister Date: Wed, 18 Jun 2014 16:28:49 +0200 > Commit 8eba0eefae24953962067 ("at86rf230: remove irq_type in > request_irq") removed the trigger configuration when requesting an irq, > and instead relied on the interrupt trigger to be properly configured > already. This does not

Re: [Linux-zigbee-devel] [PATCH net-next] mrf24j40: separate h/w init and add checkings

2014-06-17 Thread David Miller
From: Varka Bhadram Date: Mon, 16 Jun 2014 09:12:31 +0530 > separate the mrf24j40 hardware initialisation from probe() > and adds the sanity checkings. > > These checkings are required if somebody hasn't a right spi configuration > the probe function should fail. So we have to return from there.

Re: [Linux-zigbee-devel] [PATCH net-next] mrf24j40: separate h/w init and add checkings

2014-06-12 Thread David Miller
From: David Miller Date: Thu, 12 Jun 2014 11:03:24 -0700 (PDT) > From: Varka Bhadram > Date: Thu, 12 Jun 2014 14:40:48 +0530 > >> separate the mrf24j40 hardware initialisation from probe() >> and adds the sanity checkings. >> >> These checkings are requir

Re: [Linux-zigbee-devel] [PATCH net-next] mrf24j40: separate h/w init and add checkings

2014-06-12 Thread David Miller
From: Varka Bhadram Date: Thu, 12 Jun 2014 14:40:48 +0530 > separate the mrf24j40 hardware initialisation from probe() > and adds the sanity checkings. > > These checkings are required if somebody hasn't a right spi configuration > the probe function should fail. So we have to return from there

Re: [Linux-zigbee-devel] [net-next PATCH] mrf24j40: add device managed APIs

2014-06-11 Thread David Miller
From: Varka Bhadram Date: Wed, 11 Jun 2014 10:04:44 +0530 > adds the device managed APIs so that no need worry about > freeing the resources. > > Signed-off-by: Varka Bhadram Applied. -- HPCC Systems Open Source Big D

Re: [Linux-zigbee-devel] some mac802154 fixes

2014-06-11 Thread David Miller
From: Phoebe Buckheister Date: Wed, 11 Jun 2014 12:03:05 +0200 > Recent llsec code introduced a memory leak on decryption failures during rx. > This fixes said leak, and optimizes the receive loops for monitor and wpan > devices to only deliver skbs to devices that are actually up. Also changes a

Re: [Linux-zigbee-devel] [PATCH net-next] mac802154: llsec: add forgotten list_del_rcu in key removal

2014-06-06 Thread David Miller
From: Phoebe Buckheister Date: Fri, 6 Jun 2014 14:27:52 +0200 > During key removal, the key object is freed, but not taken out of the > llsec key list properly. Fix that. > > Signed-off-by: Phoebe Buckheister Applied, thank you. ---

Re: [Linux-zigbee-devel] [PATCH net-next v2 0/2] 6lowpan: fragmentation fixes

2014-06-02 Thread David Miller
From: Alexander Aring Date: Mon, 2 Jun 2014 13:21:56 +0200 > This patch series fix the 6LoWPAN fragmentation which are in two cases broken. > > The first case is if we have exactly two 6LoWPAN fragments only. This is fixed > by patch "6lowpan_rtnl: fix fragmentation with two fragments". > The s

Re: [Linux-zigbee-devel] [patch] ieee802154: missing put_dev() on error

2014-05-22 Thread David Miller
From: Dan Carpenter Date: Thu, 22 May 2014 10:53:06 +0300 > We should call put_dev() on the error path here. > > Fixes: 3e9c156e2c21 ('ieee802154: add netlink interfaces for llsec') > Signed-off-by: Dan Carpenter Applied, thanks Dan. ---

Re: [Linux-zigbee-devel] [PATCH net-next] mac802154: llsec: correctly lookup implicit-indexed keys

2014-05-22 Thread David Miller
From: Phoebe Buckheister Date: Tue, 20 May 2014 17:51:31 +0200 > Key id comparison for type 1 keys (implicit source, with index) should > return true if mode and id are equal, not false. > > Signed-off-by: Phoebe Buckheister Applied, thanks. ---

Re: [Linux-zigbee-devel] [PATCH net-next 0/2] mac802154: llsec oversights

2014-05-22 Thread David Miller
From: Phoebe Buckheister Date: Tue, 20 May 2014 13:14:21 +0200 > Fixes an unlock operation not matching a previous lock operation in > an unlikely error path and removes a redundant check. Series applied, thanks. -- "Ac

Re: [Linux-zigbee-devel] [PATCH v2] ieee802154: Introduce the use of the managed version of kzalloc

2014-05-21 Thread David Miller
From: Himangi Saraogi Date: Mon, 19 May 2014 22:25:11 +0530 > This patch moves data allocated using kzalloc to managed data allocated > using devm_kzalloc and cleans now unnecessary kfrees in probe and remove > functions. An explicit linux/device.h include is added to make sure > the devm_*() rou

Re: [Linux-zigbee-devel] [PATCH] ieee802154: Introduce the use of the managed version of kzalloc

2014-05-18 Thread David Miller
From: Himangi Saraogi Date: Fri, 16 May 2014 23:39:35 +0530 > This patch moves data allocated using kzalloc to managed data allocated > using devm_kzalloc and cleans now unnecessary kfrees in probe and remove > functions. Likewise please add an explicit linux/device.h include to make sure the de

Re: [Linux-zigbee-devel] [PATCH net-next 00/11] 802154: implement link-layer security

2014-05-16 Thread David Miller
From: Phoebe Buckheister Date: Fri, 16 May 2014 17:46:34 +0200 > This patch series implements 802.15.4-2011 link layer security. Series applied, thank you. -- "Accelerate Dev Cycles with Automated Cross-Browser Testing

Re: [Linux-zigbee-devel] [PATCH net-next v2 0/6] 802154: some cleanups and fixes

2014-05-15 Thread David Miller
From: Phoebe Buckheister Date: Wed, 14 May 2014 17:43:05 +0200 > This series adds some definitions for 802.15.4 header fields that were > missing, > changes 6lowpan fragmentation to be aware of security headers and fixes > 802.15.4 datagram socket sendmsg(), which was entirely incompliant to dat

Re: [Linux-zigbee-devel] [PATCH net-next 00/14] at86rf230 cleanup

2014-04-26 Thread David Miller
From: Alexander Aring Date: Thu, 24 Apr 2014 19:09:04 +0200 > this is the first patch series to cleanup the at86rf230 driver. Later I want > to implement regmap and a asynchron spi handling for transmit and receiving > frames. Series applied, thanks.

Re: [Linux-zigbee-devel] [PATCH] 6lowpan: nuke net_ieee802154_lowpan() accessor when 6lowpan is disabled

2014-04-24 Thread David Miller
From: "Luis R. Rodriguez" Date: Tue, 22 Apr 2014 12:03:58 -0700 > From: "Luis R. Rodriguez" > > Johannes noted this is not needed, all of the fragment > accessors don't need CONFIG_NET_NS. This goes test compiled with > CONFIG_BT_6LOWPAN=y and a disabled CONFIG_NET_NS. > > CC: Alexander Smirno

Re: [Linux-zigbee-devel] [PATCH 0/3] 6lowpan: few changes to help with backports

2014-04-20 Thread David Miller
From: "Luis R. Rodriguez" Date: Thu, 17 Apr 2014 18:22:53 -0700 > Here's a few changes that can help automate the backport of 6lowpan. > I've been carrying them around for a while, I think its best to just > merge these upstream as its nothing controversial. Series applied.

Re: [Linux-zigbee-devel] [PATCH net v2 0/2] at86rf230: various fixes

2014-04-14 Thread David Miller
From: Alexander Aring Date: Mon, 14 Apr 2014 18:48:00 +0200 > I currently working on a big cleanup for the at86rf230 and I detect some bugs > in the current implementation. I will send patch stacks if net-next is open > again. > > It's funny to find the forgotten shift and mask in the __at86rf23

Re: [Linux-zigbee-devel] [PATCH net] at86rf230: fix MAX_CSMA_RETRIES parameter

2014-04-07 Thread David Miller
From: Alexander Aring Date: Sat, 5 Apr 2014 13:49:26 +0200 > This patch fix a copy&paste failure for setting the MAX_CSMA_RETRIES > value of the at86rf212 chip which was introduced by commit > f2fdd67c6bc89de0100410efb37de69b1c98ac03 ("ieee802154: enable > smart transmitter features of RF212") >

Re: [Linux-zigbee-devel] [PATCH net-next v2] mac802154: fix multiple WPAN handling

2014-04-01 Thread David Miller
From: Phoebe Buckheister Date: Mon, 31 Mar 2014 21:37:44 +0200 > The current mac802154 stack allows an arbitrary number of WPAN netdevs for any > given PHY, which is not sensible and not supported by all hardware with > in-tree > drivers. Also, previous commits have introduced configuration opti

Re: [Linux-zigbee-devel] [PATCH net] at86rf230: mask irq's before deregister device

2014-03-31 Thread David Miller
From: Alexander Aring Date: Mon, 31 Mar 2014 03:26:51 +0200 > While transmit over a at86rf231 device and unloading the module I got: > > [ 29.643073] WARNING: CPU: 0 PID: 3 at kernel/workqueue.c:1335 > __queue_work+0xb4/0x224() > [ 29.651457] Modules linked in: at86rf230(-) autofs4 > [ 29

Re: [Linux-zigbee-devel] [PATCH v2 net] mac802154: stop tx queue before destroy workqueue

2014-03-28 Thread David Miller
From: Alexander Aring Date: Fri, 28 Mar 2014 14:20:29 +0100 > please drop this patch... I having still some issues to unloading the > at86rf230 driver while transmitting... I don't giving up to fix that issue... > > Sorry, I need some time to understand what's going on there. Ok. -

Re: [Linux-zigbee-devel] [PATCH net-next 1/2] af_ieee802154: fix check on broadcast address

2014-03-20 Thread David Miller
From: Alexander Aring Date: Thu, 20 Mar 2014 14:57:02 +0100 > This patch fixes an issue which was introduced by commit > (b70ab2e87f17176d18f67ef331064441a032b5f3). The canonical way to refer to commits is: $SHA1_ID ("Commit message header line.") I've fixed this up for you this time. > The c

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: properly unshare skbs in ieee802154 *_rcv functions

2014-03-18 Thread David Miller
From: Phoebe Buckheister Date: Mon, 17 Mar 2014 16:41:28 +0100 > ieee802154 sockets do not properly unshare received skbs, which leads to > panics (at least) when they are used in conjunction with 6lowpan, so > run skb_share_check on received skbs. > 6lowpan also contains a use-after-free, which

Re: [Linux-zigbee-devel] [PATCH net-next 0/5] at86rf230: various fixes and devicetree support

2014-03-17 Thread David Miller
From: Alexander Aring Date: Sat, 15 Mar 2014 09:29:02 +0100 > this patch series fix some bugs with the at86rf231 chip and cleaup some code. > Also add devicetree support for the at86rf230 driver. Series applied, thank you.

Re: [Linux-zigbee-devel] [PATCH net-next v2 0/8] ieee802154: fix endianness and header handling

2014-03-14 Thread David Miller
From: Phoebe Buckheister Date: Fri, 14 Mar 2014 21:23:56 +0100 > This patch set enforces network byte order on all internal operations and > fields of the 802.15.4 stack and adds a general representation of 802.15.4 > headers with operations to create and parse those headers. This reduces code >

Re: [Linux-zigbee-devel] [PATCH net] at86rf230: fix lockdep splats

2014-03-13 Thread David Miller
From: Alexander Aring Date: Wed, 12 Mar 2014 08:21:24 +0100 > This patch fix a lockdep in the at86rf230 driver, otherwise we get: ... > Signed-off-by: Alexander Aring Applied, thank you. -- Learn Graph Databases - Dow

Re: [Linux-zigbee-devel] [PATCH net-next 4/6] ieee802154: Convert uses of __constant_ to

2014-03-12 Thread David Miller
From: Joe Perches Date: Wed, 12 Mar 2014 10:04:18 -0700 > The use of __constant_ has been unnecessary for quite awhile now. > > Make these uses consistent with the rest of the kernel. > > Signed-off-by: Joe Perches Applied.

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: at86rf230: add support for rf233 chip

2014-03-11 Thread David Miller
From: Thomas Stilwell Date: Mon, 10 Mar 2014 19:29:25 -0500 > The rf233 and rf231 are sufficiently similar that we can treat > rf233 like rf231. > > rf233 is missing some features that rf231 has, but we don't currently > make use of them so there's nothing to handle differently yet. > > Should

Re: [Linux-zigbee-devel] [PATCH net-next] 6lowpan: reassembly: fix access of ctl table entry

2014-03-10 Thread David Miller
From: Alexander Aring Date: Sun, 9 Mar 2014 09:51:40 +0100 > Correct offset is 3 of the 6lowpanfrag_max_datagram_size value in proc > entry ctl table and not 2. > > Signed-off-by: Alexander Aring Applied, thanks. --

Re: [Linux-zigbee-devel] [PATCH net-next v4 1/4] ieee802154: add generic header handling routines

2014-03-09 Thread David Miller
From: Ben Hutchings Date: Sun, 09 Mar 2014 17:59:03 + > On Tue, 2014-03-04 at 17:20 -0500, David Miller wrote: >> From: "Phoebe Buckheister" >> Date: Tue, 4 Mar 2014 23:16:31 +0100 >> >> > I see some value in being able to memcpy() to/from those fi

Re: [Linux-zigbee-devel] [PATCH net-next v2] 6lowpan: reassembly: fix return of init function

2014-03-07 Thread David Miller
From: Alexander Aring Date: Fri, 7 Mar 2014 11:06:54 +0100 > This patch adds a missing return after fragmentation init. Otherwise we > register a sysctl interface and deregister it afterwards which makes no > sense. > > Signed-off-by: Alexander Aring > --- > Changes since v2: > - remove goto

Re: [Linux-zigbee-devel] [PATCH net-next v4 1/4] ieee802154: add generic header handling routines

2014-03-06 Thread David Miller
From: Phoebe Buckheister Date: Thu, 6 Mar 2014 11:11:39 +0100 > On Wed, 05 Mar 2014 19:39:13 -0500 (EST) > David Miller wrote: > >> This is how we handle some fields of struct iphdr, and it's fine with >> me. > > Wonderful, this will unclutter everything

Re: [Linux-zigbee-devel] [PATCH net-next v2 0/2] ieee802154: Kconfig fixes

2014-03-04 Thread David Miller
From: Alexander Aring Date: Tue, 4 Mar 2014 19:01:16 +0100 > this patch series fix some issues with Kconfig in the ieee802154 subsystem. Series applied, thank you. -- Subversion Kills Productivity. Get off Subversion &

Re: [Linux-zigbee-devel] [PATCH net-next v4 1/4] ieee802154: add generic header handling routines

2014-03-04 Thread David Miller
From: "Phoebe Buckheister" Date: Wed, 5 Mar 2014 02:01:52 +0100 > That's the thing - there are so many different byte orders floating around > at the moment. Network byte order is little endian. Hardware addresses are > big endian in the network layer and 6lowpan though, and our sockaddrs are > h

Re: [Linux-zigbee-devel] [PATCH net-next v4 1/4] ieee802154: add generic header handling routines

2014-03-04 Thread David Miller
From: "Phoebe Buckheister" Date: Tue, 4 Mar 2014 23:49:33 +0100 > I didn't mean the runtime cost of any conversion that might happen, I was > thinking about how much these conversions would affect the code that uses > these header structs. While for the u16/u32 fields this might be not much, > it

Re: [Linux-zigbee-devel] [PATCH net-next v4 1/4] ieee802154: add generic header handling routines

2014-03-04 Thread David Miller
From: "Phoebe Buckheister" Date: Tue, 4 Mar 2014 23:16:31 +0100 > I see some value in being able to memcpy() to/from those fields directly > when building/reading headers, but I also think that not having to do > endianness conversion everywhere for a struct that cannot ever be a valid > header a

Re: [Linux-zigbee-devel] [PATCH net-next v4 1/4] ieee802154: add generic header handling routines

2014-03-04 Thread David Miller
From: Phoebe Buckheister Date: Tue, 4 Mar 2014 15:34:45 +0100 > +struct ieee802154_sechdr { > + u8 sc; > + u32 frame_ctr; > + union { > + struct { > + u16 pan_id; > + u16 short_addr; > + } pan; > + u8 hw[IEEE

Re: [Linux-zigbee-devel] [PATCH net-next v2 1/4] ieee802154: add generic header handling routines

2014-03-03 Thread David Miller
From: Phoebe Buckheister Date: Mon, 3 Mar 2014 16:30:03 +0100 > +/* pushes hdr onto the skb. fields of hdr->fc that can be calculated from > + * the contents of hdr will be, and the actual value of those bits in > +* hdr->fc will be ignored. this includes the INTRA_PAN bit and the frame Please

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: fix at86rf212_set_txpower() exit path

2014-03-03 Thread David Miller
From: Jean Sacren Date: Sat, 1 Mar 2014 15:54:36 -0700 > The commit 9b2777d6089bc ("ieee802154: add TX power control to > wpan_phy") introduced the new function at86rf212_set_txpower() with > the questionable check of the return of __at86rf230_write() in the > exit path: > > 1) Both at86rf212_s

Re: [Linux-zigbee-devel] [PATCH net-next 0/3] 6lowpan: fix issues with byte ordering types

2014-03-02 Thread David Miller
From: Alexander Aring Date: Sun, 2 Mar 2014 08:09:32 +0100 > I got some mail from a "kbuild test robot" and it detected some byte > ordering issues with the tag and datagram size value of 6LoWPAN IEEE > 802.15.4 fragmentation header. > > This patch series should fix the issues with the byte ord

Re: [Linux-zigbee-devel] [PATCH net-next v6 0/8] 6lowpan: reimplementation of fragmentation handling

2014-02-28 Thread David Miller
From: Alexander Aring Date: Fri, 28 Feb 2014 07:32:42 +0100 > this patch series reimplementation the fragmentation handling of 6lowpan > accroding to rfc4944 [1]. Looks great, series applied, thanks Alexander. -- Flow-b

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: fix new function declaration

2014-02-26 Thread David Miller
From: Jean Sacren Date: Tue, 25 Feb 2014 22:38:29 -0700 > The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to > at86rf230 driver") introduced the new function is_rf212() with some > minor issues in declaration: > > 1) Fix the function type by changing it to bool as the function

Re: [Linux-zigbee-devel] [PATCH net-next v4 6/8] 6lowpan: fix some checkpatch issues

2014-02-26 Thread David Miller
From: Joe Perches Date: Wed, 26 Feb 2014 09:24:56 -0800 > On Wed, 2014-02-26 at 17:05 +0100, Alexander Aring wrote: >> Detected with: >> >> ./scripts/checkpatch.pl --strict -f net/ieee802154/6lowpan_rtnl.c > > Hello Alexander. > > Can I suggest to you (and to David) that the > multiline commen

Re: [Linux-zigbee-devel] [PATCH net-next v4 2/8] 6lowpan: add uncompress header size function

2014-02-26 Thread David Miller
From: David Laight Date: Wed, 26 Feb 2014 16:10:05 + > From: Alexander Aring >> Signed-off-by: Alexander Aring >> --- >> net/ieee802154/6lowpan.h | 116 >> +++ >> 1 file changed, 116 insertions(+) >> >> diff --git a/net/ieee802154/6lowpan.h b/ne

Re: [Linux-zigbee-devel] [PATCH net-next v2 2/6] 6lowpan: fix fragmentation on sending side

2014-02-24 Thread David Miller
From: Alexander Aring Date: Tue, 25 Feb 2014 02:21:57 +0100 > In this case I can be sure we talking with ARPHRD_IEEE802154 devices only. This doesn't mean anything. The qdisc layer can be involved no matter what. Once you call dev_queue_xmit(), all bets are off wrt. the SKB control block. It i

Re: [Linux-zigbee-devel] [PATCH net-next v2 2/6] 6lowpan: fix fragmentation on sending side

2014-02-24 Thread David Miller
From: Alexander Aring Date: Fri, 21 Feb 2014 19:58:58 +0100 > + err = lowpan_fragment_xmit(skb, head, header_length, > +frag_plen + lowpan_size, 0, > +LOWPAN_DISPATCH_FRAG1); > if (err) { > pr_debug("%s unable

Re: [Linux-zigbee-devel] [PATCH RFC net-next 0/6] 6lowpan: reimplementation of fragmentation handling

2014-02-20 Thread David Miller
RFC means "request for comments", if you want me to apply it, resend the series without the RFC tag in the subject line. Also, target your patches at net-next. Thanks. -- Managing the Performance of Cloud-Based Applicat

Re: [Linux-zigbee-devel] [PATCH net-next] ieee802154: fix faulty check in set_phy_params api

2014-02-18 Thread David Miller
From: Phoebe Buckheister Date: Tue, 18 Feb 2014 14:39:27 +0100 > phy_set_csma_params has a redundant (and impossible) check for > "retries", found by smatch. The check was supposed to be for > frame_retries, but wasn't moved during development when > phy_set_frame_retries was introduced. Also, ma

Re: [Linux-zigbee-devel] [PATCH net-next v3 0/10] ieee802154: support rf212 and extended mac features

2014-02-17 Thread David Miller
From: Phoebe Buckheister Date: Mon, 17 Feb 2014 11:34:05 +0100 > this patch set adds support for the RF212 radio chip to the existing > at86rf230 driver and adds support for numerous features of the RF212 > chips to the ieee802154 stack. These features include CSMA parameter > configuration, tran

Re: [Linux-zigbee-devel] [PATCH net-next v2 01/10] ieee802154: add basic support for RF212 to at86rf230 driver

2014-02-16 Thread David Miller
From: Phoebe Buckheister Date: Fri, 14 Feb 2014 23:49:23 +0100 > - if (page != 0 || channel < 11 || channel > 26) { > + if (page < 0 > + || page > 31 > + || !(lp->dev->phy->channels_supported[page] & BIT(channel))) { This is not indented properly. The first chara

Re: [Linux-zigbee-devel] [PATCH net] 6lowpan: add missing fragment list spinlock

2014-02-04 Thread David Miller
From: Alexander Aring Date: Tue, 4 Feb 2014 11:57:53 +0100 > @@ -197,7 +197,9 @@ static void lowpan_fragment_timer_expired(unsigned long > entry_addr) > > pr_debug("timer expired for frame with tag %d\n", entry->tag); > > + spin_lock_bh(&flist_lock); > list_del(&entry->list)

Re: [Linux-zigbee-devel] [PATCH] Bluetooth: remove direct compilation of 6lowpan_iphc.c

2014-01-22 Thread David Miller
From: Stephen Warren Date: Fri, 17 Jan 2014 12:29:24 -0700 > From: Stephen Warren > > It's now built as a separate utility module, and enabling BT selects > that module in Kconfig. This fixes: ... > (this change probably simply wasn't "git add"d to a53d34c3465b) > > Fixes: a53d34c3465b ("net:

Re: [Linux-zigbee-devel] linux-next: Tree for Jan 14 (lowpan, 802.15.4)

2014-01-17 Thread David Miller
From: Dmitry Eremin-Solenikov Date: Wed, 15 Jan 2014 02:54:56 +0400 > David, Marcel, could you please consider the attached patch. Applied, thanks Dmitry. -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. L

Re: [Linux-zigbee-devel] [PATCH] ieee802154: Fix memory leak in ieee802154_add_iface()

2014-01-14 Thread David Miller
From: Christian Engelmayer Date: Sat, 11 Jan 2014 22:19:30 +0100 > Fix a memory leak in the ieee802154_add_iface() error handling path. > Detected by Coverity: CID 710490. > > Signed-off-by: Christian Engelmayer Applied and queued up for -stable, thanks. --

Re: [Linux-zigbee-devel] [PATCH net-next v2] 6lowpan: Moving generic compression code into 6lowpan_iphc.c

2013-12-10 Thread David Miller
From: Marcel Holtmann Date: Tue, 10 Dec 2013 13:12:10 +0100 > Hi Alexander, > >> thanks for working on this! Now my acked-by is correct, sry. Didn't >> catch the debug output at first time. >> >>> Because the IEEE 802154 and Bluetooth share the IP header compression >>> and uncompression code,

Re: [Linux-zigbee-devel] [PATCH net-next 0/6] 6lowpan: udp compression/uncompression fix

2013-11-14 Thread David Miller
From: Eric Dumazet Date: Thu, 14 Nov 2013 08:19:43 -0800 > On Thu, 2013-11-14 at 16:48 +0100, Alexander Aring wrote: >> The current 6LoWPAN udp compression/uncompression is completely broken. >> This patch series fix a lot of udp compression/uncompression issues and >> add support parsing with lo

Re: [Linux-zigbee-devel] [patch] 6lowpan: release device on error path

2013-11-07 Thread David Miller
From: Dan Carpenter Date: Thu, 7 Nov 2013 10:44:45 +0300 > We recently added a new error path and it needs a dev_put(). > > Fixes: 7adac1ec8198 ('6lowpan: Only make 6lowpan links to IEEE802154 devices') > Signed-off-by: Dan Carpenter Applied. --

Re: [Linux-zigbee-devel] [PATCH net-next 0/4] 6lowpan: cleanup header creation

2013-10-30 Thread David Miller
From: Alexander Aring Date: Wed, 30 Oct 2013 09:18:20 +0100 > This patch series cleanup the 6LoWPAN header creation and extend the use > of skb_*_header functions. > > Patch 2/4 fix issues of parsing the mac header. The ieee802.15.4 header > has a dynamic size which depends on frame control bits

Re: [Linux-zigbee-devel] [PATCH] mac802154: Use pr_err(...) rather than printk(KERN_ERR ...)

2013-10-30 Thread David Miller
From: Chen Weilong Date: Wed, 30 Oct 2013 15:28:07 +0800 > This change is inspired by checkpatch. > > Signed-off-by: Weilong Chen Applied to net-next, thanks. -- Android is increasing in popularity, but the open devel

Re: [Linux-zigbee-devel] [PATCH net-next v3 0/5] 6lowpan: trivial changes

2013-10-28 Thread David Miller
From: Alexander Aring Date: Mon, 28 Oct 2013 10:24:15 +0100 > This patch series includes some trivial changes to prepare the 6lowpan stack > for upcomming patch-series which mainly fix fragmentation according to rfc4944 > and udp handling(which is currently broken). > > Changes since v3: > - r

Re: [Linux-zigbee-devel] [PATCH net-next 3/5] 6lowpan: use netdev_alloc_skb instead dev_alloc_skb

2013-10-26 Thread David Miller
From: Joe Perches Date: Fri, 25 Oct 2013 23:01:44 -0700 > On Sat, 2013-10-26 at 01:42 -0400, David Miller wrote: >> From: Alexander Aring >> Date: Thu, 24 Oct 2013 22:51:42 +0200 >> >> > @@ -1127,12 +1127,12 @@ lowpan_fragment_xmit

Re: [Linux-zigbee-devel] [PATCH net-next 3/5] 6lowpan: use netdev_alloc_skb instead dev_alloc_skb

2013-10-25 Thread David Miller
From: Alexander Aring Date: Thu, 24 Oct 2013 22:51:42 +0200 > @@ -1127,12 +1127,12 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head, > > lowpan_raw_dump_inline(__func__, "6lowpan fragment header", head, hlen); > > - frag = dev_alloc_skb(hlen + mlen + plen + IEEE802154_MFR_SIZE)

Re: [Linux-zigbee-devel] [PATCH net-next 5/5] 6lowpan: remove unecessary break

2013-10-24 Thread David Miller
From: Joe Perches Date: Thu, 24 Oct 2013 20:40:51 -0700 > On Fri, 2013-10-25 at 07:28 +0400, Alexander Smirnov wrote: >> > 25 окт. 2013 г., в 0:51, Alexander Aring написал(а): > [] >> > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > [] >> > @@ -440,7 +440,6 @@ lowpan_uncompre

Re: [Linux-zigbee-devel] [PATCH] net: af802154: Fix wrong structure declaration

2013-10-08 Thread David Miller
From: Guenter Roeck Date: Sun, 6 Oct 2013 14:44:01 -0700 > net_devce doesn't exist. > > Signed-off-by: Guenter Roeck This is simply rediculous. The reason I say this is that every user of this header includes net/sock.h which in turn includes linux/skbuff.h and linux/netdevice.h which theref

Re: [Linux-zigbee-devel] [PATCH v1 0/3] Fix race conditions in mrf24j40 interrupts

2013-10-08 Thread David Miller
From: Alan Ott Date: Sat, 5 Oct 2013 23:52:21 -0400 > After testing with the betas of this patchset, it's been rebased and is > ready for inclusion. > > David Hauweele noticed that the mrf24j40 would hang arbitrarily after some > period of heavy traffic. Two race conditions were discovered, an

Re: [Linux-zigbee-devel] [PATCH v2 0/2] 6lowpan default hardware address

2013-10-08 Thread David Miller
From: Alan Ott Date: Sat, 5 Oct 2013 23:15:17 -0400 > Alexander Aring suggested that devices desired to be linked to 6lowpan > be checked for actually being of type IEEE802154, since IEEE802154 devices > are all that are supported by 6lowpan at present. > > Alan Ott (2): > 6lowpan: Only make

Re: [Linux-zigbee-devel] [PATCHv3 net-next 0/6] 6lowpan: address uncompression fixes

2013-08-20 Thread David Miller
From: Alexander Aring Date: Fri, 16 Aug 2013 21:59:53 +0200 > The current implementation to uncompress addresses in a 6lowpan header > is completely broken. > > This patch series fixes the parsing of addresses in a 6lowpan header. > It contains a major rewrite of the uncompress address function

Re: [Linux-zigbee-devel] [PATCHv2 net-next] 6lowpan: handle only real link-local addresses

2013-08-15 Thread David Miller
From: Alexander Aring Date: Thu, 15 Aug 2013 06:57:21 +0200 > Hi David, > > On Wed, Aug 14, 2013 at 05:18:25PM -0700, David Miller wrote: >> From: Alexander Aring >> Date: Wed, 14 Aug 2013 23:17:01 +0200 >> >> > Ok, please let me know what should I do to

Re: [Linux-zigbee-devel] [PATCHv2 net-next] 6lowpan: handle only real link-local addresses

2013-08-14 Thread David Miller
From: Alexander Aring Date: Wed, 14 Aug 2013 23:17:01 +0200 > Ok, please let me know what should I do to submit it properly. What you don't understand is that just because patches aren't related doesn't mean that their order of application doesn't matter. So you put all the patches into a full

Re: [Linux-zigbee-devel] [PATCHv2 net-next] 6lowpan: handle only real link-local addresses

2013-08-14 Thread David Miller
From: Alexander Aring Date: Wed, 14 Aug 2013 13:01:07 +0200 > A link-local address isn't fe80::/10 it's fe80::/64 > see http://tools.ietf.org/html/rfc4291#section-2.5.6 > for more details. > > Also fix a comment issue "local link" -> "link-local" > > Signed-off-by: Alexander Aring > Reviewed-b

Re: [Linux-zigbee-devel] [PATCH] 6lowpan: handle only real link-local addresses

2013-08-13 Thread David Miller
You're submitting 7 patches, one set is numbered 1-6 and this one has no number. What in the world do you want me to do with these patches? What tree are they targetted at? Are there dependencies? What order should I apply them in? You've given me none of this information, therefore I am toss

Re: [Linux-zigbee-devel] [PATCH 09/12] drivers/net/ieee802154: don't use devm_pinctrl_get_select_default() in probe

2013-07-11 Thread David Miller
From: Wolfram Sang Date: Wed, 10 Jul 2013 16:57:44 +0100 > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij (personally at LCE13) > Signed-off-by: Wolfram Sa

Re: [Linux-zigbee-devel] [PATCH v5] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W

2013-04-29 Thread David Miller
From: Chen Gang Date: Thu, 25 Apr 2013 18:49:55 +0800 > > Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in > mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not > succeed. > > This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0) > [...] else [...

Re: [Linux-zigbee-devel] [PATCH v3] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W

2013-04-25 Thread David Miller
From: Chen Gang Date: Thu, 25 Apr 2013 16:43:14 +0800 > (the change is for net/mac802154/mac802154.h, and exist in v3.9-rc8) It exist, but your patch doesn't apply cleanly there, it only applies cleanly to the -next tree, because other changes have happend to that file in -next. ---

Re: [Linux-zigbee-devel] [PATCH v3] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W

2013-04-25 Thread David Miller
From: Chen Gang Date: Tue, 23 Apr 2013 19:24:36 +0800 > > Need change ~(u8)0 to 0xff, or in mac802154_wpan_xmit(), "u8 chan" > will never == MAC802154_CHAN_NONE. > > The related warning: > net/mac802154/wpan.c:325:2: warning: comparison is always false > due to limited range of data type [-

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-16 Thread David Miller
From: Sascha Herrmann Date: Mon, 15 Apr 2013 10:33:27 +0200 > Changes to last version: Reordered local variable declarations. > > The first patch add the option to configure the irq type of the > plattform and the device. The second patch changes the irq handling > when edge type interrupts are

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread David Miller
From: Werner Almesberger Date: Tue, 16 Apr 2013 00:16:58 -0300 > David Miller wrote: >> "Acked-by: Werner ..." is most useful to me. > > Hmm, since I don't have any official role (maintainer or such) > with respect to that driver or the WPAN stack, I think this

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread David Miller
From: Werner Almesberger Date: Mon, 15 Apr 2013 22:44:19 -0300 > David Miller wrote: >> I'd like to see some reviews of this patch series, thanks. > > Sascha and I discussed the functional aspects of his changes a > while ago and I'm satisfied with the way he h

Re: [Linux-zigbee-devel] [PATCH 0/2 v3] changed irq handling for at86rf230

2013-04-15 Thread David Miller
From: Sascha Herrmann Date: Mon, 15 Apr 2013 10:33:27 +0200 > Changes to last version: Reordered local variable declarations. > > The first patch add the option to configure the irq type of the > plattform and the device. The second patch changes the irq handling > when edge type interrupts are

Re: [Linux-zigbee-devel] [PATCH 1/2 v2] at86rf230: add irq type configuration option

2013-04-12 Thread David Miller
From: Sascha Herrmann Date: Fri, 12 Apr 2013 00:16:13 +0200 > static int at86rf230_hw_init(struct at86rf230_local *lp) > { > u8 status; > - int rc; > + int rc, irq_pol; > + struct at86rf230_platform_data *pdata = lp->spi->dev.platform_data; Please order local variable declara

Re: [Linux-zigbee-devel] [PATCH -next] mrf24j40: use module_spi_driver to simplify the code

2013-04-09 Thread David Miller
From: Wei Yongjun Date: Tue, 9 Apr 2013 14:34:44 +0800 > From: Wei Yongjun > > module_spi_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Wei Yongjun Applied. -- Precog is a nex

Re: [Linux-zigbee-devel] [PATCH v2] mac802154: Keep track of the channel when changed

2013-04-08 Thread David Miller
From: Alan Ott Date: Fri, 5 Apr 2013 19:03:10 -0400 > Two sections checked whether the current channel != the new channel > without ever setting the current channel variables. > > 1. net/mac802154/tx.c: Prevent set_channel() from getting called every > time a packet is sent. > > 2. net/mac8021

Re: [Linux-zigbee-devel] [PATCH] mrf24j40: Enable link-layer acknowledgement and retry

2013-04-08 Thread David Miller
From: Alan Ott Date: Fri, 5 Apr 2013 16:34:51 -0400 > On the MRF24J40, link-layer acknowledgment request and retry must be > turned on explicitly for each packet. Turn this on in the hardware based > on the FC_ACK_REQ bit being set in the packet. > > Also, now that failure to receive an ACK wi

Re: [Linux-zigbee-devel] [PATCH net-next 0/2] ieee802154_mlme_ops oops removal and cleanup

2013-04-08 Thread David Miller
From: Werner Almesberger Date: Thu, 4 Apr 2013 13:31:46 -0300 > This fixes a kernel oops we get when some linux-zigbee user > space tools try to invoke unimplemented operations. > > The second of the two patches checks whether the respective > functions are present and returne EOPNOTSUPP if they

Re: [Linux-zigbee-devel] [PATCH 1/2] at86rf230: remove unnecessary / dead code

2013-04-08 Thread David Miller
From: Sascha Herrmann Date: Thu, 4 Apr 2013 23:02:00 +0200 > In at86rf230_probe() lp was first set to dev->priv and a few lines later > dev->priv was set to lp again, without changing lp in between. The call > to ieee802154_unregister_device() before err_irq: was unreachable. > > Signed-off-by:

Re: [Linux-zigbee-devel] [PATCH v2 0/4] 802.15.4 and 6LoWPAN Buffering Fixes

2013-04-07 Thread David Miller
From: Alan Ott Date: Wed, 3 Apr 2013 10:00:54 -0400 > Version 2 of this patch series: > > Differences from v1: > > 1. Patches previously numbered 5 and 6 were squashed (to become current > patch #4) at the request of Alexander Smirnov. > > 2. Current patch #2 had extraneous braces removed. >

  1   2   >