[Linux-zigbee-devel] [PATCH v3] ieee802154: verify packet size before trying to allocate it

2012-07-02 Thread Sasha Levin
Currently when sending data over datagram, the send function will attempt to allocate any size passed on from the userspace. We should make sure that this size is checked and limited. We'll limit it to the MTU of the device, which is checked later anyway. Signed-off-by: Sasha Levin ---

Re: [Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread Sasha Levin
On Sun, 2012-06-10 at 20:04 -0700, David Miller wrote: > From: Sasha Levin > Date: Sun, 10 Jun 2012 13:10:19 +0200 > > > Currently when sending data over datagram, the send function will attempt to > > allocate any size passed on from the userspace. > > > > We s

Re: [Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread Sasha Levin
Hi Alan, On Sun, 2012-06-10 at 12:24 +0100, Alan Cox wrote: > On Sun, 10 Jun 2012 13:10:19 +0200 > Sasha Levin wrote: > > + if (hlen + tlen + size > IEEE802154_MTU) { > > + err = -EMSGSIZE; > > + goto out; > > What stops an overflow at th

[Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-11 Thread Sasha Levin
Currently when sending data over datagram, the send function will attempt to allocate any size passed on from the userspace. We should make sure that this size is checked and limited. The maximum size of an IP packet seemed like the safest limit here. Signed-off-by: Sasha Levin --- Change in

[Linux-zigbee-devel] [PATCH] ieee802154: verify packet size before trying to allocate it

2012-06-06 Thread Sasha Levin
Currently when sending data over datagram, the send function will attempt to allocate any size passed on from the userspace. We should make sure that this size is checked and limited. The maximum size of an IP packet seemed like the safest limit here. Signed-off-by: Sasha Levin --- net

Re: [Linux-zigbee-devel] ieee802154: WARNING: at mm/page_alloc.c:2095

2011-12-24 Thread Sasha Levin
On Thu, 2011-12-15 at 15:21 +0300, Alexander Smirnov wrote: > first of all could you please specify: > 1. What's the kernel do you use? linux-next. > 2. What's the config options are enabled in your kernel? It's a testing kernel which is pretty close to being 'make allyesconfig'. So if you're th

[Linux-zigbee-devel] ieee802154: WARNING: at mm/page_alloc.c:2095

2011-12-15 Thread Sasha Levin
Hi all, I got the following warning when trying out ieee802154: [ 157.736372] WARNING: at mm/page_alloc.c:2095 __alloc_pages_nodemask+0x177/0x722() [ 157.737707] Pid: 9100, comm: trinity Not tainted 3.2.0-rc2-sasha-00280-g45a222d #22 [ 157.739114] Call Trace: [ 157.739559] [] ? __alloc_pag