Re: [LinuxBIOS] [PATCH] BCOM WinNET100 improvements

2007-10-21 Thread Juergen Beisert
Uwe, On Sunday 14 October 2007 19:10, Uwe Hermann wrote: See patch. Btw, do we need to (or want to) enable the SMI PCI device? I guess not as we don't use the VSA(?) Do we need it for the VSA-less audio driver? Btw, Juergen, can you please attach a license to your photos in the wiki? GPL

Re: [LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

2007-10-21 Thread Stefan Reinauer
Uwe Hermann wrote:: On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote: Please put generic 440 code in northbridge/, and not in mainboard/440-base/ Having two northbridge directories for the same northbridge sounds complex. Full ack. Northbridge-specific code belongs

Re: [LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

2007-10-21 Thread Stefan Reinauer
[EMAIL PROTECTED] wrote:: Quoting Uwe Hermann [EMAIL PROTECTED]: On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote: Please put generic 440 code in northbridge/, and not in mainboard/440-base/ Having two northbridge directories for the same northbridge sounds complex.

[LinuxBIOS] [flashrom] request for review: VT8233A support

2007-10-21 Thread Peter Lemenkov
Hello All! Looking at the lspci output I created simple patch for adding VT8233A support. Unfortunately I can't find out what flash-chip is on my mainboard (it's far away from me so I can perform only software look) but maybe someone else tests whether this patch works or not? Unfortunately guys

[LinuxBIOS] Flashrom and superiotool on non-x86 platforms?

2007-10-21 Thread Peter Lemenkov
Hello All! Does anybody tried to use linuxbios and LB-tools on non-x86 platforms? There are some issues we need to fir even for compilation (not for successful usage). One thing I found so far is excessive usage of non-portable inb/outb macros. For instance - inb may be emulated as folliwing:

Re: [LinuxBIOS] [PATCH] flashrom: SPI serial flash: The sector/block erase pitfalls

2007-10-21 Thread Stefan Reinauer
* Carl-Daniel Hailfinger [EMAIL PROTECTED] [071019 23:39]: This patch introduces block and sector erase routines, but does not use them yet. Signed-off-by: Carl-Daniel Hailfinger [EMAIL PROTECTED] Acked-by: Stefan Reinauer [EMAIL PROTECTED] --- Index: util/flashrom/flash.h

Re: [LinuxBIOS] [PATCH] Add K8T890CE support

2007-10-21 Thread Rudolf Marek
=== --- Config.lb (revision 0) +++ Config.lb (revision 0) Missing license header. Fixed +static void host_enable(struct device *dev) Would const struct device *dev work? It looks like dev is not being modified(?)

Re: [LinuxBIOS] question on lx raminit.c

2007-10-21 Thread Marc Jones
Carl-Daniel Hailfinger wrote: On 20.10.2007 02:44, ron minnich wrote: I offer the following diff and a question: can the use of in these if expressions be wrong? Currently it is: if ((MIN_MOD_BANKS spd_byte) (spd_byte MAX_MOD_BANKS)) You want || because either condition