Re: [LinuxBIOS] [PATCH] v3: add a check for a termination member

2008-01-06 Thread Stefan Reinauer
* ron minnich [EMAIL PROTECTED] [080105 23:23]: OK, I'm back. Stefan, we don't really need this for correctness. But on the alix1c I am observing huge delays at startup while find_file iterates through 512KB of empty FLASH looking for entries that are not there. So the goal here is to have a

Re: [LinuxBIOS] Suspend to RAM with LinuxBIOSv2

2008-01-06 Thread Stefan Reinauer
* Rudolf Marek [EMAIL PROTECTED] [080105 02:11]: I'm pleased to announce that I got S3 working with LinuxBIOSv2 on ASUS A8V-E SE (K8 + VT8237 + K8T890)! Rudolf, this is wonderful! Thank you very much for your work! 1) consolidate the memory usage of LinuxBIOSv2 What needs to be done here?

[LinuxBIOS] [PATCH] beautify m57sli mptable.c (Was: Fix FireWire...)

2008-01-06 Thread Torsten Duwe
I still owe you a beautification patch. On Thursday 20 December 2007, ron minnich wrote: Hi Torsten, why not add the comments and readable indentation right now? once it is committed, it won't happen :-) It's not indentation. I found the extra long lines and useless comments extremely ugly

Re: [LinuxBIOS] [PATCH] v3: add a check for a termination member

2008-01-06 Thread Carl-Daniel Hailfinger
On 06.01.2008 05:52, ron minnich wrote: On Jan 5, 2008 5:11 PM, Peter Stuge [EMAIL PROTECTED] wrote: On Sat, Jan 05, 2008 at 02:44:55PM -0800, ron minnich wrote: NOT finding a file should be efficient. Yes. Where do the delay come from? Can anyone measure the LPC? I

Re: [LinuxBIOS] [PATCH] beautify m57sli mptable.c (Was: Fix FireWire...)

2008-01-06 Thread Carl-Daniel Hailfinger
On 06.01.2008 15:01, Torsten Duwe wrote: I still owe you a beautification patch. On Thursday 20 December 2007, ron minnich wrote: Hi Torsten, why not add the comments and readable indentation right now? once it is committed, it won't happen :-) It's not indentation. I found the

[LinuxBIOS] [RFC] Macros vs. functions for better readability

2008-01-06 Thread Carl-Daniel Hailfinger
Hi, it seems we sometimes have lots of repetitive code sequences which could be simplified by use of macros or functions. For a really shining example see Torsten Duwe's recent patch titled beautify m57sli mptable.c. Cut-and-paste errors can happen and eliminating repetitive code reduces the risk

Re: [LinuxBIOS] Suspend to RAM with LinuxBIOSv2

2008-01-06 Thread Rudolf Marek
Hi, this is wonderful! Thank you very much for your work! Yeah I'm happy that it works too. It costs me lot of time and I would rather win then lose ;) I'm taking this as broading up my know-how. It goes well because I got nearly all datasheets for all chips on the board except the marvel

Re: [LinuxBIOS] [PATCH] document the GPIO setup of A8V-E and fix power sequencing for suspend

2008-01-06 Thread Rudolf Marek
You might want one other acked by but, that said, I think this is a really excellent patch. Well nope the other one is just experimental, showing how it is done. It might be useful for v3 development. Hum this patch has one minor glitch in the comment /* set memory voltage to 2.75V chipset

Re: [LinuxBIOS] [PATCH] v3: add a check for a termination member

2008-01-06 Thread ron minnich
On Jan 6, 2008 3:29 AM, Stefan Reinauer [EMAIL PROTECTED] wrote: And we can't cache the ROM because of CAR? yes. I am not convinced that failing to find files has to be a performance critical path - While I generally agree it must not take several seconds, something's wrong with our logic

Re: [LinuxBIOS] [RFC] Macros vs. functions for better readability

2008-01-06 Thread ron minnich
On Jan 6, 2008 9:32 AM, Carl-Daniel Hailfinger [EMAIL PROTECTED] wrote: How do we factor out such code? I prefer macros for simple function wrappers and functions for multiline sequences. I spend a lot of time with Plan 9 code nowadays. These are the Bell Labs guys who invented it all. I am

Re: [LinuxBIOS] [RFC] Macros vs. functions for better readability

2008-01-06 Thread Juergen Beisert
On Sunday 06 January 2008 18:32, Carl-Daniel Hailfinger wrote: How do we factor out such code? I prefer macros for simple function wrappers and functions for multiline sequences. As we are working with hardware we should avoid any macros for function replacement. There are ugly side effects.

Re: [LinuxBIOS] [RFC] Macros vs. functions for better readability

2008-01-06 Thread ron minnich
On Jan 6, 2008 1:43 PM, Juergen Beisert [EMAIL PROTECTED] wrote: getCx86 and setCx86 defined as inline functions are working in all cases. So: Do not use macros as functions. That's a good point. It's easy to get fooled by macros. Thanks ron -- linuxbios mailing list

Re: [LinuxBIOS] [RFC] Macros vs. functions for better readability

2008-01-06 Thread Carl-Daniel Hailfinger
On 06.01.2008 23:41, ron minnich wrote: On Jan 6, 2008 1:43 PM, Juergen Beisert [EMAIL PROTECTED] wrote: getCx86 and setCx86 defined as inline functions are working in all cases. So: Do not use macros as functions. That's a good point. It's easy to get fooled by macros. Macros

Re: [LinuxBIOS] [RFC] Macros vs. functions for better readability

2008-01-06 Thread Russell Whitaker
On Sun, 6 Jan 2008, ron minnich wrote: On Jan 6, 2008 1:43 PM, Juergen Beisert [EMAIL PROTECTED] wrote: getCx86 and setCx86 defined as inline functions are working in all cases. So: Do not use macros as functions. That's a good point. It's easy to get fooled by macros. How about

[LinuxBIOS] The device number of PCIe

2008-01-06 Thread Feng, Libo
Hi, all, In PCI, the IDSEL pin defines the device number. But in PCIe, there is no such pin, how is the device number defined? Best Regards 丰立波 Feng Libo @ AMD Ext: 20906 Mobile Phone: 13683249071 Office Phone: 0086-010-62801406 -- linuxbios mailing list linuxbios@linuxbios.org

Re: [LinuxBIOS] #69: Fix mptable util so the output will compile

2008-01-06 Thread LinuxBIOS
#69: Fix mptable util so the output will compile --+- Reporter: Jon Dufresne [EMAIL PROTECTED] | Owner: somebody Type: defect |Status: new