Re: [LinuxBIOS] [PATCH] flashrom: SPI serial flash: The sector/block erase pitfalls

2007-10-22 Thread Carl-Daniel Hailfinger
On 21.10.2007 15:49, Stefan Reinauer wrote: * Carl-Daniel Hailfinger [EMAIL PROTECTED] [071019 23:39]: This patch introduces block and sector erase routines, but does not use them yet. Signed-off-by: Carl-Daniel Hailfinger [EMAIL PROTECTED] Acked-by: Stefan Reinauer [EMAIL

Re: [LinuxBIOS] [PATCH] flashrom: SPI serial flash: The sector/block erase pitfalls

2007-10-21 Thread Stefan Reinauer
* Carl-Daniel Hailfinger [EMAIL PROTECTED] [071019 23:39]: This patch introduces block and sector erase routines, but does not use them yet. Signed-off-by: Carl-Daniel Hailfinger [EMAIL PROTECTED] Acked-by: Stefan Reinauer [EMAIL PROTECTED] --- Index: util/flashrom/flash.h

Re: [LinuxBIOS] [PATCH] flashrom: SPI serial flash: The sector/block erase pitfalls

2007-10-19 Thread Uwe Hermann
On Thu, Oct 18, 2007 at 10:32:01PM +0200, Carl-Daniel Hailfinger wrote: Index: util/flashrom/spi.c === --- util/flashrom/spi.c (Revision 2876) +++ util/flashrom/spi.c (Arbeitskopie) @@ -45,17 +45,31 @@ #define

Re: [LinuxBIOS] [PATCH] flashrom: SPI serial flash: The sector/block erase pitfalls

2007-10-19 Thread Carl-Daniel Hailfinger
On 19.10.2007 23:01, Uwe Hermann wrote: On Thu, Oct 18, 2007 at 10:32:01PM +0200, Carl-Daniel Hailfinger wrote: [...] Looks good IMO. With the above fixes: Acked-by: Uwe Hermann [EMAIL PROTECTED] Thanks for the review! I fixed most of the points you raised, but especially

[LinuxBIOS] [PATCH] flashrom: SPI serial flash: The sector/block erase pitfalls

2007-10-18 Thread Carl-Daniel Hailfinger
This is more a rant than a tutorial how to solve the remaining problems. Almost all SPI flash falls into at least one of three categories: * Does not respect the JEDEC standards * Totally different chips with exactly the same ID and no means to tell them apart unless you physically look at their