[PATCH] PPC: CELLEB - fix possible NULL pointer dereference

2007-11-28 Thread Ishizaki Kou
From: Cyrill Gorcunov <[EMAIL PROTECTED]> This patch adds checking for NULL returned value to prevent possible NULL pointer dereference. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- Paul, This is a resend of a patch from Cyrill. I changed it to inline style. Cyrill, This works good o

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-11-28 Thread Kamalesh Babulal
Andrew Morton wrote: > On Wed, 28 Nov 2007 12:47:19 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >>> On Wed, 28 Nov 2007 11:59:00 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> >>> wrote: >>> Hi, >>> (cc linux-scsi, for sym53c8xx) >>> Soft lockup is detected w

Re: [PATCH] Increase the upper bound on NR_CPUS.

2007-11-28 Thread Stephen Rothwell
Hi Tony, :-) On Thu, 29 Nov 2007 15:16:03 +1100 [EMAIL PROTECTED] (Tony Breeds) wrote: > > Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> NAK ... you need to change the static initialisation of the paca structures to match ... -- Cheers, Stephen Rothwell[EMAIL PROTECTED] htt

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Cyrill Gorcunov
On 11/29/07, Ishizaki Kou <[EMAIL PROTECTED]> wrote: [...snip...] > > There is no problem to use Michael's part, and I also prefer simple > one like this. > > Cyrill, would you please update your patch? > > Best regards, > Kou Ishizaki > Please see updated patch enveloped. (Can't do it inline beca

Re: [PATCH] Increase the upper bound on NR_CPUS.

2007-11-28 Thread Michael Ellerman
On Thu, 2007-11-29 at 15:23 +1100, Tony Breeds wrote: > On Thu, Nov 29, 2007 at 03:17:16PM +1100, Michael Ellerman wrote: > > On Thu, 2007-11-29 at 15:16 +1100, Tony Breeds wrote: > > > Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> > > > > > > --- > > > why not? > > > > How big is say a pseries

Re: [PATCH] Increase the upper bound on NR_CPUS.

2007-11-28 Thread Tony Breeds
On Thu, Nov 29, 2007 at 03:17:16PM +1100, Michael Ellerman wrote: > On Thu, 2007-11-29 at 15:16 +1100, Tony Breeds wrote: > > Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> > > > > --- > > why not? > > How big is say a pseries_defconfig with NR_CPUS = 1024 ? This is a ppc64_defconfig, with a cou

Re: [PATCH] Increase the upper bound on NR_CPUS.

2007-11-28 Thread Michael Ellerman
On Thu, 2007-11-29 at 15:16 +1100, Tony Breeds wrote: > Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> > > --- > why not? How big is say a pseries_defconfig with NR_CPUS = 1024 ? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2

[PATCH] Increase the upper bound on NR_CPUS.

2007-11-28 Thread Tony Breeds
Signed-off-by: Tony Breeds <[EMAIL PROTECTED]> --- why not? arch/powerpc/platforms/Kconfig.cputype |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 99684ea..5d70862 100644 --- a/arch

Re: Timers on mpc8248 etc...

2007-11-28 Thread Alan Bennett
It comes from uboot. Can you point me in the right direction to make sure its right? PowerPC,[EMAIL PROTECTED] { device_type = "cpu"; reg = <0>; d-cache-line-size = ; i-cache-line-size = ;

Re: [PATCH] IB/ehca: Fix static rate if path faster than link

2007-11-28 Thread Roland Dreier
thanks, applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Ishizaki Kou
Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > On 11/28/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > > On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > > > > This patch adds checking for NULL value returned to prevent possi

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Nish Aravamudan
On 11/28/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > Nish Aravamudan wrote: > > On 11/28/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > >> On Tue, 27 Nov 2007 23:03:10 -0600 Jon Tollefson wrote: > >> > >>> This patch adds the hugepagesz boot-time parameter for ppc64 that lets > >>> you pick the si

Re: [PATCH] [0/12] pasemi_mac updates for 2.6.25 + DMA channel management library

2007-11-28 Thread Olof Johansson
On Wed, Nov 28, 2007 at 08:54:10PM -0600, Olof Johansson wrote: > The patches are: [...] I got the order wrong above, the actual one is: 1/12 pasemi_mac: RX/TX ring management cleanup 2/12 pasemi_mac: Move register definitions to include/asm-powerpc 3/12 pasemi: DMA engine management library 4/1

[PATCH] [12/12] pasemi_mac: Don't enable RX/TX without a link (if possible)

2007-11-28 Thread Olof Johansson
pasemi_mac: Don't enable RX/TX without a link (if possible) Don't enable RX/TX of packets until we have a link, since there's a chance we'll just get RX frame errors, etc. The case where we don't have a PHY we can't do much about: Just enable it and deal with errors as they come in. Signed-off-

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Randy Dunlap
Nish Aravamudan wrote: > On 11/28/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: >> On Tue, 27 Nov 2007 23:03:10 -0600 Jon Tollefson wrote: >> >>> This patch adds the hugepagesz boot-time parameter for ppc64 that lets >>> you pick the size for your huge pages. The choices available are 64K >>> and 16

[PATCH] [11/12] pasemi_mac: Print warning when not attaching to a PHY

2007-11-28 Thread Olof Johansson
pasemi_mac: Print warning when not attaching to a PHY Print a warning on the console when not connecting to a phy for an interface. It turns out to be a pretty common problem when someone gets the MDIO info wrong in their device tree, resulting in the macs running at a fixed 1Gbit FD. Signed-off-

[PATCH] [10/12] pasemi_mac: Remove SKB copy/recycle logic

2007-11-28 Thread Olof Johansson
pasemi_mac: Remove SKB copy/recycle logic It doesn't really buy us much, since copying is about as expensive as the allocation in the first place. Just remove it for now. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 25 +++-- 1 file ch

[PATCH] [9/12] pasemi_mac: SKB unmap optimization

2007-11-28 Thread Olof Johansson
pasemi_mac: SKB unmap optimization Avoid touching skb_shinfo() in the unmap path, since it turns out to normally cause cache misses and delays. instead, save number of fragments in the TX_RING_INFO structures since that's all that's needed anyway. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]

[PATCH] [8/12] pasemi_mac: Software-based LRO support

2007-11-28 Thread Olof Johansson
pasemi_mac: Software-based LRO support Implement LRO for pasemi_mac. Pretty straightforward. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 drivers/net/pasemi_mac.c | 53 +++ drivers/net/pasemi_mac.h |5

[PATCH] [7/12] pasemi_mac: Improve RX interrupt mitigation

2007-11-28 Thread Olof Johansson
pasemi_mac: Improve RX interrupt mitigation Currently the receive side interrupts will go off on the reception of a packet, NAPI will poll the ring and keep polling as long as there's a decent amount of packets to receive. This is less than optimal, especially for LRO where it's better if we have

[PATCH] [6/12] pasemi_mac: Fix TX cleaning

2007-11-28 Thread Olof Johansson
pasemi_mac: Fix TX cleaning This is a bit awkward. We don't have a timer-delayed interrupt on TX complete, but we have a count threshold. So set that reasonably high (32 packets), and schedule the NAPI poll when it goes off. Also bump a regular timer that will take care of rotting packets for the

[PATCH] [5/12] pasemi_mac: performance tweaks

2007-11-28 Thread Olof Johansson
pasemi_mac: performance tweaks * Seems like we do better with a smaller RX ring, probably because chances of still having the SKB cached are better * Const-ify variables to get better code generation and fewer reloads * Move prefetching around a little, and try to prefetch the whole SKB * Set NE

[PATCH] [4/12] pasemi_mac: Convert to new dma library

2007-11-28 Thread Olof Johansson
pasemi_mac: Convert to new dma library Convert the pasemi_mac driver to the new platform global DMA manaagement library. This also does a couple of other minor cleanups w.r.t. channel management. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 480 +

[PATCH] [3/12] pasemi: DMA engine management library

2007-11-28 Thread Olof Johansson
pasemi: DMA engine management library Introduce a DMA management library to manage the various DMA resources on the PA Semi SoCs. Since several drivers need to allocate these shared resources, provide some abstractions as well as allocation/free functions for channels, etc. Signed-off-by: Olof J

[PATCH] [2/12] pasemi_mac: Move register definitions to include/asm-powerpc

2007-11-28 Thread Olof Johansson
pasemi_mac: Move register definitions to include/asm-powerpc Move the common register formats and descriptor layouts from drivers/net/pasemi_mac.h to include/asm-poewrpc/pasemi_dma.h Previously only the ethernet driver was using them, but other drivers are coming up that will also use them, so it

[PATCH] [1/12] pasemi_mac: RX/TX ring management cleanup

2007-11-28 Thread Olof Johansson
pasemi_mac: RX/TX ring management cleanup Prepare a bit for supporting multiple TX queues by cleaning up some of the ring management and shuffle things around a bit. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- drivers/net/pasemi_mac.c | 277 --

[PATCH] [0/12] pasemi_mac updates for 2.6.25 + DMA channel management library

2007-11-28 Thread Olof Johansson
Hi, The following series contains driver updates for 2.6.25, together with a couple of patches that introduces a library for abstracting DMA channel allocation and access. While the DMA stuff (patches 5 and 6) isn't really netdev material, the driver updates depend on them, and it'd just be easie

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-28 Thread Anton Vorontsov
On Wed, Nov 28, 2007 at 07:11:19PM +0300, Sergei Shtylyov wrote: > Anton Vorontsov wrote: > > This driver nicely wraps around pata_platform library functions, > and provides OF platform bus bindings to the PATA devices. > > +static struct of_device_id pata_of_platform_match[] = { > >>

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Nish Aravamudan
On 11/28/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Tue, 27 Nov 2007 23:03:10 -0600 Jon Tollefson wrote: > > > This patch adds the hugepagesz boot-time parameter for ppc64 that lets > > you pick the size for your huge pages. The choices available are 64K > > and 16M. It defaults to 16M (pre

Re: 2.6.24-rc3-mm2 - Build Failure on powerpc timerfd() undeclared

2007-11-28 Thread Arnd Bergmann
On Wednesday 28 November 2007 19:43:45 Andrew Morton wrote: > > I guess all architectures except x86 are currently broken because they > > reference the old sys_timerfd function. > > None of them were broken in my testing and I'm unsure why powerpc broke > here. PowerPC is unique in that it actual

[PATCH v2] MTD: pasemi_nand driver

2007-11-28 Thread Olof Johansson
Plumbing for NAND connected via localbus on PA Semi PWRficient-based boards. From: Egor Martovetsky <[EMAIL PROTECTED]> Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Changes from original post: * asm/of_platform.h -> linux/of_platform.h * MODULE_DEVICE_TABLE() drivers/mtd/nand/Kconfig

Re: [PATCH] MTD: pasemi_nand driver

2007-11-28 Thread Olof Johansson
On Wed, Nov 28, 2007 at 10:40:32PM +, David Woodhouse wrote: > > On Wed, 2007-11-28 at 16:14 -0600, Olof Johansson wrote: > > Plumbing for NAND connected via localbus on PA Semi PWRficient-based > > boards. > > Any reason it lacks MODULE_DEVICE_TABLE() ? > > I note electra-ide lacks it too.

Re: PPC upstream kernel ignored DABR bug

2007-11-28 Thread Arnd Bergmann
On Wednesday 28 November 2007 23:59:36 Geoff Levand wrote: > > This sounds like a bug recently reported by Uli Weigand. BenH > > said he'd take a look, but it probably fell under the table. > > The problem found by Uli is that on certain processors (Cell/B.E. > > in his case), the DABRX register ne

Re: MPC5200 I2C and 2.6 kernel

2007-11-28 Thread Jon Smirl
On 11/28/07, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > In message <[EMAIL PROTECTED]> you wrote: > > > > Regardless what I'm doing in the 2.6 kernel configuration I can't get > > this RTC running (I activated RTC support and the driver for the M41T00 > > in the configuration). > > hwclock --debug

Re: Timers on mpc8248 etc...

2007-11-28 Thread Scott Wood
Alan Bennett wrote: > I've got a routine that needs to delay for X microseconds, this is a > must. The command after schedule_timeout must has to wait for the HW > to complete a task that takes X microseconds. > > I would think that one way to do this is with a simple > schedule_timeout. But in

Timers on mpc8248 etc...

2007-11-28 Thread Alan Bennett
I've got a routine that needs to delay for X microseconds, this is a must. The command after schedule_timeout must has to wait for the HW to complete a task that takes X microseconds. I would think that one way to do this is with a simple schedule_timeout. But in the example below, the time that

Re: Problems booting a 64k page kernel

2007-11-28 Thread Michael Ellerman
On Wed, 2007-11-28 at 16:50 -0600, aglitke wrote: > Hello all. I am new to building 64k page kernels and can't seem to get > one to boot correctly. Everything looks okay until init gets a signal > 11 while booting. Attached is my boot log and the kernel config I used. > To generate this config I

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Randy Dunlap
On Tue, 27 Nov 2007 23:03:10 -0600 Jon Tollefson wrote: > This patch adds the hugepagesz boot-time parameter for ppc64 that lets > you pick the size for your huge pages. The choices available are 64K > and 16M. It defaults to 16M (previously the only choice) if nothing or > an invalid choice

Re: [patch 7/7] ps3: denoise arch/powerpc/platforms/ps3/repository.c

2007-11-28 Thread Geoff Levand
Geert Uytterhoeven wrote: > arch/powerpc/platforms/ps3/repository.c: sparse and checkpatch denoising > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Acked-by: Geoff Levand <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlab

Re: PPC upstream kernel ignored DABR bug

2007-11-28 Thread Geoff Levand
Arnd Bergmann wrote: > On Monday 26 November 2007, Jan Kratochvil wrote: >> Hi, >> >> this testcase: >> http://people.redhat.com/jkratoch/dabr-lost.c >> >> reproduces a PPC DABR kernel bug. The variable `variable' should not get >> modified as the thread modifying it should be caught by

Re: [patch 6/7] ps3: Refactor ps3_repository_find_device()

2007-11-28 Thread Geoff Levand
Geert Uytterhoeven wrote: > ps3: Refactor ps3_repository_find_device() to use the existing > ps3_repository_read_bus_id() > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/ps3/repository.c | 60 > +++- > 1 files changed, 22 in

Problems booting a 64k page kernel

2007-11-28 Thread aglitke
Hello all. I am new to building 64k page kernels and can't seem to get one to boot correctly. Everything looks okay until init gets a signal 11 while booting. Attached is my boot log and the kernel config I used. To generate this config I merely enabled the 64k page option in make menuconfig to

Re: [patch 5/7] ps3: Kill unused ps3_repository_bump_device()

2007-11-28 Thread Geoff Levand
Geert Uytterhoeven wrote: > ps3: Kill unused ps3_repository_bump_device() > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/ps3/platform.h |6 -- > 1 files changed, 6 deletions(-) Acked-by: Geoff Levand <[EMAIL PROTECTED]>

Re: [PATCH] MTD: pasemi_nand driver

2007-11-28 Thread David Woodhouse
On Wed, 2007-11-28 at 16:14 -0600, Olof Johansson wrote: > Plumbing for NAND connected via localbus on PA Semi PWRficient-based > boards. Any reason it lacks MODULE_DEVICE_TABLE() ? I note electra-ide lacks it too. So no autoload of either. -- dwmw2 ___

Re: [patch 4/7] ps3: Add repository polling loop to work around hypervisor bug

2007-11-28 Thread Geoff Levand
Geert Uytterhoeven wrote: > ps3: Add repository polling loop to work around hypervisor bug > > On some firmware versions (e.g. 1.90), the storage device may not show up > in the repository immediately after receiving the notification message. > Add a small polling loop to make sure we don't miss

Re: [patch 3/7] ps3: Use the HVs storage device notification mechanism properly

2007-11-28 Thread Geoff Levand
Geert Uytterhoeven wrote: > ps3: Use the HV's storage device notification mechanism properly > > The hypervisor has a storage device notification mechanism to wait until a > storage device is ready. Unfortunately the storage device probing code used > this mechanism in an incorrect way, needing a

Re: [patch 2/7] ps3: Add ps3_repository_find_device_by_id()

2007-11-28 Thread Geoff Levand
> ps3: Add ps3_repository_find_device_by_id() > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/ps3/platform.h |2 > arch/powerpc/platforms/ps3/repository.c | 77 > > 2 files changed, 79 insertions(+) Looks good.

Re: [patch 1/7] ps3: Make bus_id and dev_id u64

2007-11-28 Thread Geoff Levand
Geert Uytterhoeven wrote: > ps3: Make bus_id and dev_id u64. > > These IDs are 64-bit in the repository, and the special storage notification > device has a device ID of ULONG_MAX. > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/ps3/device-init.c |4 +

[PATCH] MTD: pasemi_nand driver

2007-11-28 Thread Olof Johansson
Plumbing for NAND connected via localbus on PA Semi PWRficient-based boards. From: Egor Martovetsky <[EMAIL PROTECTED]> Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: 2.6.24/drivers/mtd/nand/Kconfig === --- 2.6.24.orig/driv

Re: [RFC/PATCH 5/14] powerpc: Fix 440/440A machine check handling

2007-11-28 Thread Benjamin Herrenschmidt
On Wed, 2007-11-28 at 15:34 -0600, Olof Johansson wrote: > On Thu, Nov 22, 2007 at 07:05:25AM +1100, Benjamin Herrenschmidt > wrote: > > > > On Wed, 2007-11-21 at 13:51 -0600, Josh Boyer wrote: > > > > Hrm... it's per processor, not per board. I didn't feel like > digging > > > > which board uses

Re: Why are CONFIG_LOCKDEP_SUPPORT, CONFIG_TRACE_IRQFLAGS_SUPPORT, and CONFIG_STACKTRACE_SUPPORT not defined for PowerPC?

2007-11-28 Thread Johannes Berg
> These work for me, but I don't think they're finalised yet so your > mileage may vary: > > http://patchwork.ozlabs.org/linuxppc/patch?id=14171 > http://patchwork.ozlabs.org/linuxppc/patch?id=14172 FWIW, the second one doesn't work on my quad G5 but I have a version that works... Haven't figure

Re: Why are CONFIG_LOCKDEP_SUPPORT, CONFIG_TRACE_IRQFLAGS_SUPPORT, and CONFIG_STACKTRACE_SUPPORT not defined for PowerPC?

2007-11-28 Thread Tim Pepper
On Nov 28, 2007 11:56 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > These three Kconfig options: > > CONFIG_LOCKDEP_SUPPORT > CONFIG_TRACE_IRQFLAGS_SUPPORT > CONFIG_STACKTRACE_SUPPORT > > Are not defined for ppc or powerpc, but they are defined for several other > architecture

Re: [RFC/PATCH 5/14] powerpc: Fix 440/440A machine check handling

2007-11-28 Thread Olof Johansson
On Thu, Nov 22, 2007 at 07:05:25AM +1100, Benjamin Herrenschmidt wrote: > > On Wed, 2007-11-21 at 13:51 -0600, Josh Boyer wrote: > > > Hrm... it's per processor, not per board. I didn't feel like digging > > > which board uses which processor and go fixup all the ppc_md's > > > > Sounds like some

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Geoff Levand
Arnd Bergmann wrote: > On Wednesday 28 November 2007, Mel Gorman wrote: >> On (28/11/07 08:26), Arnd Bergmann didst pronounce: >> > On Wednesday 28 November 2007, Jon Tollefson wrote: >> > > This patch adds the hugepagesz boot-time parameter for ppc64 that lets >> > > you pick the size for your hu

Re: MPC5200 I2C and 2.6 kernel

2007-11-28 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > Regardless what I'm doing in the 2.6 kernel configuration I can't get > this RTC running (I activated RTC support and the driver for the M41T00 > in the configuration). > hwclock --debug tells me: > hwclock: Open of /dev/rtc failed, errno=19: No suc

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Tue, Nov 27, 2007 at 06:15:59PM -0600, Will Schmidt wrote: > (resending with the proper "from" addr this time). > > > I'm seeing some funky behavior on power5/power6 partitions with this > patch.A "/sbin/reboot" is now behaving much more like a > "/sbin/halt". > > Anybody else seeing thi

Re: [PATCH 2/2] [PPC 44x] enable L2-cache for ALPR, Katmai, Ocotea, and Taishan

2007-11-28 Thread Benjamin Herrenschmidt
On Wed, 2007-11-28 at 11:47 -0800, Eugene Surovegin wrote: > On Tue, Nov 27, 2007 at 10:41:46AM +1100, Benjamin Herrenschmidt wrote: > > BTW... Do you know why we can't just enable HW snoop ? The 440SPe > > documentation seems to indicate that this is supported by the L2 cache > > via snooping on

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: > On Tue, Nov 27, Will Schmidt wrote: > > > > -void rtas_os_term(char *str) > > > +void rtas_panic_msg(char *str) > > > > - if (panic_timeout) > > > - return; > > This change is wrong. Booting with panic=123 really means the sy

Re: 2.6.24-rc3-mm2 - Build Failure on powerpc timerfd() undeclared

2007-11-28 Thread Davide Libenzi
On Wed, 28 Nov 2007, Andrew Morton wrote: > On Wed, 28 Nov 2007 14:32:07 +0100 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > > > On Wednesday 28 November 2007, Kamalesh Babulal wrote: > > > Kernel build fails, with build error > > > > > >   CC      arch/powerpc/platforms/cell/spu_callbacks.o > > >

RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-28 Thread Brandeburg, Jesse
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

Re: [PATCH 0/2] [PPC 4xx] L2-cache synchronization for ppc44x

2007-11-28 Thread Eugene Surovegin
On Wed, Nov 07, 2007 at 01:40:10AM +0300, Yuri Tikhonov wrote: > > Hello all, > > Here is a patch-set for support L2-cache synchronization routines for > the ppc44x processors family. I know that the "ppc" branch is for bug-fixing > only, thus > the patch-set is just FYI [though enabled but no

[PATCH] Stop phy code from returning success to unknown ioctls.

2007-11-28 Thread David Woodhouse
This kind of sucks, and prevents the Fedora installer from using the device for network installs... [EMAIL PROTECTED] phy]# iwconfig eth0 Warning: Driver for device eth0 has been compil

Why are CONFIG_LOCKDEP_SUPPORT, CONFIG_TRACE_IRQFLAGS_SUPPORT, and CONFIG_STACKTRACE_SUPPORT not defined for PowerPC?

2007-11-28 Thread Timur Tabi
These three Kconfig options: CONFIG_LOCKDEP_SUPPORT CONFIG_TRACE_IRQFLAGS_SUPPORT CONFIG_STACKTRACE_SUPPORT Are not defined for ppc or powerpc, but they are defined for several other architectures. I'm trying to debug some semaphore locks in ALSA, and these defines are

Re: [PATCH 2/2] [PPC 44x] enable L2-cache for ALPR, Katmai, Ocotea, and Taishan

2007-11-28 Thread Eugene Surovegin
On Tue, Nov 27, 2007 at 10:41:46AM +1100, Benjamin Herrenschmidt wrote: > BTW... Do you know why we can't just enable HW snoop ? The 440SPe > documentation seems to indicate that this is supported by the L2 cache > via snooping on the PLB. Unless something has been changed significantly in the 44x

Re: dtc: RFC: Fix some lexical problems with references

2007-11-28 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > The recent change to the lexer to only recognize property and node > names in the appropriate context removed a number of lexical warts in > our language that would have gotten ugly as we add expression support > and so forth. > > But there's one nas

RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-28 Thread Benjamin Herrenschmidt
On Wed, 2007-11-28 at 10:47 -0800, Brandeburg, Jesse wrote: > > > The side effect is that I removed the assignments to the netdev > > fields mem_start, mem_end and base_addr, which are totally useless > > for PCI devices. > > also, concerning this, ifconfig shows the output of these variables, I

Re: 2.6.24-rc3-mm2 - Build Failure on powerpc timerfd() undeclared

2007-11-28 Thread Andrew Morton
On Wed, 28 Nov 2007 14:32:07 +0100 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Wednesday 28 November 2007, Kamalesh Babulal wrote: > > Kernel build fails, with build error > > > >   CC      arch/powerpc/platforms/cell/spu_callbacks.o > > In file included from arch/powerpc/platforms/cell/spu_cal

[PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c

2007-11-28 Thread David Woodhouse
This helps to allow the Fedora installer to use the built-in Ethernet on the Efika for a network install. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- a/drivers/net/fec_mpc52xx.c +++ b/drivers/net/fec_mpc52xx.c @@ -971,6 +971,8 @@ mpc52xx_fec_probe(struct of_device *op, const struct of

Re: [PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-11-28 Thread David Woodhouse
On Sun, 2007-11-18 at 20:49 -0500, Jon Smirl wrote: > On 11/9/07, Grant Likely <[EMAIL PROTECTED]> wrote: > > On 11/9/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > > On 09/11/07 00:31 -0500, Jon Smirl wrote: > > > > This is the reason I couldn't get user space started or connect to my > > > > nf

Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h

2007-11-28 Thread Jon Loeliger
So, like, the other day Scott Wood mumbled: > On Wed, Nov 28, 2007 at 09:39:08AM -0600, Kumar Gala wrote: > > Take from u-boot whitespace fixup of the file > > > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> [snip] > I don't think this is an improvement... tabs are great for indentation, but

Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h

2007-11-28 Thread Scott Wood
On Wed, Nov 28, 2007 at 09:39:08AM -0600, Kumar Gala wrote: > Take from u-boot whitespace fixup of the file > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > libfdt/fdt.h | 32 > 1 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/libfdt

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Arnd Bergmann
On Wednesday 28 November 2007, Mel Gorman wrote: > On (28/11/07 08:26), Arnd Bergmann didst pronounce: > > On Wednesday 28 November 2007, Jon Tollefson wrote: > > > This patch adds the hugepagesz boot-time parameter for ppc64 that lets > > > you pick the size for your huge pages.  The choices avai

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-28 Thread Sergei Shtylyov
Hello. Arnd Bergmann wrote: >>>This driver nicely wraps around pata_platform library functions, >>>and provides OF platform bus bindings to the PATA devices. >>>+static struct of_device_id pata_of_platform_match[] = { >>>+ { .compatible = "pata-platform", }, >>>+}; >>"pata-platform" really

[PATCH][DTC] Add an option to pad the blob that is generated

2007-11-28 Thread Kumar Gala
There are times when we need extra space in the blob and just want to have it added on w/o know the exact size to make it. The padding and min size options are mutually exclusive. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- dtc.c | 14 +- dtc.h |1 + flattree.c

Re: [PATCH 1/2] powerpc: add hugepagesz boot-time parameter

2007-11-28 Thread Mel Gorman
On (28/11/07 08:26), Arnd Bergmann didst pronounce: > On Wednesday 28 November 2007, Jon Tollefson wrote: > > This patch adds the hugepagesz boot-time parameter for ppc64 that lets > > you pick the size for your huge pages.  The choices available are 64K > > and 16M.  It defaults to 16M (previous

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-28 Thread Sergei Shtylyov
Anton Vorontsov wrote: This driver nicely wraps around pata_platform library functions, and provides OF platform bus bindings to the PATA devices. +static struct of_device_id pata_of_platform_match[] = { + { .compatible = "pata-platform", }, +}; >>>"pata-platform" really

Re: [PATCH][DTC] Fix whitespace in libfdt/fdt.h

2007-11-28 Thread Jon Loeliger
So, like, the other day Kumar Gala mumbled: > Take from u-boot whitespace fixup of the file > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-28 Thread Anton Vorontsov
On Tue, Nov 27, 2007 at 10:32:58PM +0100, Arnd Bergmann wrote: > On Tuesday 27 November 2007, Olof Johansson wrote: > > On Tue, Nov 27, 2007 at 06:39:08PM +0300, Anton Vorontsov wrote: > > > This driver nicely wraps around pata_platform library functions, > > > and provides OF platform bus bindings

[PATCH][DTC] Fix whitespace in libfdt/fdt.h

2007-11-28 Thread Kumar Gala
Take from u-boot whitespace fixup of the file Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- libfdt/fdt.h | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libfdt/fdt.h b/libfdt/fdt.h index e00559a..48ccfd9 100644 --- a/libfdt/fdt.h +++ b

[patch 7/7] ps3: denoise arch/powerpc/platforms/ps3/repository.c

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> arch/powerpc/platforms/ps3/repository.c: sparse and checkpatch denoising Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/repository.c | 64 1 files changed, 32 insertions(+), 32 d

[patch 5/7] ps3: Kill unused ps3_repository_bump_device()

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> ps3: Kill unused ps3_repository_bump_device() Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/platform.h |6 -- 1 files changed, 6 deletions(-) --- a/arch/powerpc/platforms/ps3/platform.h +++ b/arch/powerp

[patch 6/7] ps3: Refactor ps3_repository_find_device()

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> ps3: Refactor ps3_repository_find_device() to use the existing ps3_repository_read_bus_id() Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/repository.c | 60 +++- 1 files changed, 22

[patch 3/7] ps3: Use the HVs storage device notification mechanism properly

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> ps3: Use the HV's storage device notification mechanism properly The hypervisor has a storage device notification mechanism to wait until a storage device is ready. Unfortunately the storage device probing code used this mechanism in an incorrect way,

[patch 4/7] ps3: Add repository polling loop to work around hypervisor bug

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> ps3: Add repository polling loop to work around hypervisor bug On some firmware versions (e.g. 1.90), the storage device may not show up in the repository immediately after receiving the notification message. Add a small polling loop to make sure we do

[patch 2/7] ps3: Add ps3_repository_find_device_by_id()

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> ps3: Add ps3_repository_find_device_by_id() Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/platform.h |2 arch/powerpc/platforms/ps3/repository.c | 77 2 files changed, 79

[patch 0/7] PS3 notification device patches for 2.6.25

2007-11-28 Thread Geert Uytterhoeven
Hi all, Here are my PS3 notification device patches for 2.6.25: [1] ps3: Make bus_id and dev_id u64 [2] ps3: Add ps3_repository_find_device_by_id() [3] ps3: Use the HV's storage device notification mechanism properly [4] ps3: Add repository polling loop to work around hypervisor bu

[patch 1/7] ps3: Make bus_id and dev_id u64

2007-11-28 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> ps3: Make bus_id and dev_id u64. These IDs are 64-bit in the repository, and the special storage notification device has a device ID of ULONG_MAX. Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/device-init.c |

[BUG] 2.6.24-rc3-mm2 soft lockup while running tbench

2007-11-28 Thread Kamalesh Babulal
Hi Andrew, while running tbench on the powerpc with 2.6.24-rc3-mm2 softlock up occurs BUG: soft lockup - CPU#0 stuck for 11s! [tbench:12183] NIP: c00ac978 LR: c00acff0 CTR: c005c648 REGS: C0076F0F3200 TRAP: 0901 Not tainted (2.6.24-rc3-mm2-autotest) MSR: 800

[PATCH] IB/ehca: Fix static rate if path faster than link

2007-11-28 Thread Joachim Fenkes
The formula would yield -1 for this, which is wrong in a bad way (max throttling). Clamp to 0, which is the correct value. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- This fixes another regression introduced in rc3. Please review and apply for 2.6.24-rc4. Thanks! drivers/infiniband/hw

Re: 2.6.24-rc3-mm2 - Build Failure on powerpc timerfd() undeclared

2007-11-28 Thread Arnd Bergmann
On Wednesday 28 November 2007, Kamalesh Babulal wrote: > Kernel build fails, with build error > >   CC      arch/powerpc/platforms/cell/spu_callbacks.o > In file included from arch/powerpc/platforms/cell/spu_callbacks.c:49: > include/asm/systbl.h:312: error: ‘sys_timerfd’ undeclared here (not in a

Re: NULL dereference in clockevents_program_event

2007-11-28 Thread Johannes Berg
> During a hibernate cycle on my G5, while machine was powering down after > saving the image, I just had a NULL dereference in > clockevents_program_event when accessing dev->mode, dev was NULL. > > Unfortunately the machine rebooted before I was able to write down more > than the fact that it

Re: [PATCH 0/3] OF-platform PATA driver

2007-11-28 Thread Anton Vorontsov
On Wed, Nov 28, 2007 at 06:51:51PM +0900, Paul Mundt wrote: > On Tue, Nov 27, 2007 at 06:37:08PM +0300, Anton Vorontsov wrote: > > Here is the second spin of the OF-platform PATA driver and > > related patches. > > > So either the patches are missing, or I wasn't CC'ed on them. I'm going > to go o

Re: PPC upstream kernel ignored DABR bug

2007-11-28 Thread Jan Kratochvil
On Wed, 28 Nov 2007 13:28:48 +0100, Arnd Bergmann wrote: > On Wednesday 28 November 2007, Jan Kratochvil wrote: > > Please be aware DABR works fine if the same code runs just 1 (always) or > > 2 (sometimes) threads.  It starts failing with too many threads running: > > > > $ ./dabr-lost > > TID 32

Re: 2.6.24-rc3-mm2 - Build Failure on powerpc timerfd() undeclared

2007-11-28 Thread Kamalesh Babulal
Hi Andrew, Kernel build fails, with build error CC arch/powerpc/platforms/cell/spu_callbacks.o In file included from arch/powerpc/platforms/cell/spu_callbacks.c:49: include/asm/systbl.h:312: error: ‘sys_timerfd’ undeclared here (not in a function) make[2]: *** [arch/powerpc/platforms/cell

Re: PPC upstream kernel ignored DABR bug

2007-11-28 Thread Arnd Bergmann
On Wednesday 28 November 2007, Jan Kratochvil wrote: > Please be aware DABR works fine if the same code runs just 1 (always) or > 2 (sometimes) threads.  It starts failing with too many threads running: > > $ ./dabr-lost > TID 32725: DABR 0x1001279f NIP 0xfecf41c > TID 32726: DABR 0x1001279f NIP 0

Re: of_compat_cmp on various platforms

2007-11-28 Thread Stephen Rothwell
On Tue, 27 Nov 2007 22:46:16 -0500 "Jon Smirl" <[EMAIL PROTECTED]> wrote: > > Is this right or should it be the same everywhere? > > asm-powerpc/prom.h:#define of_compat_cmp(s1, s2, l) strcasecmp((s1), (s2)) > asm-sparc/prom.h:#define of_compat_cmp(s1, s2, l) strncmp((s1), (s2), > (l))

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Olaf Hering
On Tue, Nov 27, Will Schmidt wrote: > > -void rtas_os_term(char *str) > > +void rtas_panic_msg(char *str) > > - if (panic_timeout) > > - return; This change is wrong. Booting with panic=123 really means the system has to reboot in 123 seconds after a panic. But, maybe this panic_time

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Cyrill Gorcunov
On 11/28/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > > > This patch adds checking for NULL value returned to prevent possible > > > NULL pointer dereference. > > > Also two

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Cyrill Gorcunov
On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > > This patch adds checking for NULL value returned to prevent possible > > NULL pointer dereference. > > Also two unneeded 'return' are removed. > > > > Signed-off-by: Cyrill Gorcu

Re: pseries (power3) boot hang (pageblock_nr_pages==0)

2007-11-28 Thread Mel Gorman
On (26/11/07 13:35), Will Schmidt didst pronounce: > > On Wed, 2007-11-21 at 22:03 +, Mel Gorman wrote: > > On (21/11/07 15:55), Will Schmidt didst pronounce: > > > Hi Folks, > > > > > > I imagine this would be properly fixed with something similar to the > > > change for iSeries. > > > >

  1   2   >