Re: CPM2 USB host driver

2007-12-01 Thread Mike Rapoport
> >> I tried to forward-port FHCI from Freescale 2.6.11 kernels. Twice. >> But these efforts always stumbled over more important tasks. > > Do you think I start from the FHCI driver provided by Freescale for 2.6.11, > from the cpm2usb driver or from scratch ? The cmp2usb is old and crappy, and

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-01 Thread Grant Likely
On 12/1/07, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This patch makes the platform code use the new machine-specific initcall > hooks. This has the advantage of not needing to explicitly test > machine_is() at the top of every initcall function. Warning

[PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> This patch makes the platform code use the new machine-specific initcall hooks. This has the advantage of not needing to explicitly test machine_is() at the top of every initcall function. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/p

[PATCH v2 1/2] [POWERPC] Add machine initcall macros

2007-12-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> The machine initcall macros allow initcalls to be registered which test machine_is() before executing the initcall. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- include/asm-powerpc/machdep.h | 23 +++ 1 files changed, 23 insert

[PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-12-01 Thread Grant Likely
From: Jon Smirl <[EMAIL PROTECTED]> This is the reason I couldn't get user space started or connect to my nfs server. Patch is against current linus git. mpc5200 fec driver is corrupting memory. This patch fixes two bugs where the wrong skb buffer was being referenced. Signed-off-by: Jon Smirl <

[PATCH] gianfar driver: eliminate compiler warnings and unnecessary macros

2007-12-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> This patch eliminates the warning of unused return values when the driver registers it sysfs files. Now the driver will print an error if it is unable to register the sysfs files. It also eliminates the macros used to wrap the DEVICE_ATTR macro and the devi

[PATCH] gianfar: fix compile warning

2007-12-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Eliminate an uninitialized variable warning. The code is correct, but a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent. Since addr has never been initialized, and the compiler doesn't know what dma_alloc_coherent will do with it, it

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-01 Thread Olof Johansson
On Tue, Nov 27, 2007 at 06:39:08PM +0300, Anton Vorontsov wrote: > +static struct of_device_id pata_of_platform_match[] = { > + { .compatible = "pata-platform", }, > +}; On top of previous comment about the compatible string being inappropriate: You should add a MODULE_DEVICE_TABLE() entry f

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Olof Johansson
On Sun, Dec 02, 2007 at 02:58:10AM +0300, Anton Vorontsov wrote: > On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: > while (1) { > send_patches(); > > if (ack_collected(PaulM) && ack_collected(PowerPC_people)) > break; > > sleep(wait_for_comments_timeo

Re: serial console autodetection not working on powermac

2007-12-01 Thread Benjamin Herrenschmidt
On Sat, 2007-12-01 at 15:40 +0100, Olaf Hering wrote: > How is the serial console autodetection supposed to work with current > kernels? arch/powerpc/kernel/legacy_serial.c is not compiled unless > CONFIG_PPC_UDBG_16550 is selected. > Even if I force this config option, legacy_serial_console remai

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Anton Vorontsov
On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: > Anton Vorontsov wrote: > > Hi all, > > > > Here is the second spin of the OF-platform PATA driver and > > related patches. > > > > Changes since RFC: > > - nuked drivers/ata/pata_platform.h; > > - powerpc bits: proper localbus node ad

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Stephen Rothwell
Just a little reminder ... On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > static int __init of_add_fixed_phys(void) > { > struct device_node *np; > const u32 *prop; > struct fixed_phy_status status = {}; > > while ((np = of_find_node_by_na

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Jeff Garzik
Anton Vorontsov wrote: > Hi all, > > Here is the second spin of the OF-platform PATA driver and > related patches. > > Changes since RFC: > - nuked drivers/ata/pata_platform.h; > - powerpc bits: proper localbus node added. > > > Thanks for the previous review! This time I'm collecting acks, > d

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov wrote: > > If i understand your code correctly, you seem to rely on the fact > > that fixed_phy_add() is called before the fixed MDIO bus is scanned > > for devices. > > Yes, indeed. The other name of "fixed phys" are "platform phys" > or "plat

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sat, 01 Dec 2007 16:59:52 -0500 Jeff Garzik wrote: > Vitaly Bordug wrote: > > With that patch fixed.c now fully emulates MDIO bus, thus no need > > to duplicate PHY layer functionality. That, in turn, drastically > > simplifies the code, and drops down line count. > > > > As an additional bonu

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Jeff Garzik
Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all em

Re: [PATCH] [1/12] pasemi_mac: RX/TX ring management cleanup

2007-12-01 Thread Jeff Garzik
Olof Johansson wrote: > pasemi_mac: RX/TX ring management cleanup > > Prepare a bit for supporting multiple TX queues by cleaning up some > of the ring management and shuffle things around a bit. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> applied 1-12 ___

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Anton Vorontsov
On Sat, Dec 01, 2007 at 02:48:54PM +0100, Jochen Friedrich wrote: > Hi Vitaly, > > > With that patch fixed.c now fully emulates MDIO bus, thus no need > > to duplicate PHY layer functionality. That, in turn, drastically > > simplifies the code, and drops down line count. > > > > As an additional b

Re: [PATCH] Stop phy code from returning success to unknown ioctls.

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: > This kind of sucks, and prevents the Fedora installer from using the > device for network installs... > > [EMAIL PROTECTED] phy]# iwconfig eth0 > > Warning: Dri

Re: [PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c

2007-12-01 Thread Jeff Garzik
David Woodhouse wrote: > This helps to allow the Fedora installer to use the built-in Ethernet on > the Efika for a network install. > > Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> > > --- a/drivers/net/fec_mpc52xx.c > +++ b/drivers/net/fec_mpc52xx.c > @@ -971,6 +971,8 @@ mpc52xx_fec_probe

Re: [PATCH 1/3][RESEND] phylib: add PHY interface modes for internal delay for tx and rx only

2007-12-01 Thread Jeff Garzik
Kim Phillips wrote: > Allow phylib specification of cases where hardware needs to configure > PHYs for Internal Delay only on either RX or TX (not both). > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> > Acked-by: Li Yang <[EMAIL PROTECTED]> > -

Re: [RFC] [PATCH] pasemi: NMI support with MPIC

2007-12-01 Thread Olof Johansson
On Sun, Dec 02, 2007 at 07:38:45AM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2007-12-01 at 12:28 -0600, Olof Johansson wrote: > > Some PWRficient-based boards have a NMI button that's wired up to a GPIO > > as interrupt source. By configuring the openpic accordingly, these get > > delivered

Re: [RFC] [PATCH] pasemi: NMI support with MPIC

2007-12-01 Thread Benjamin Herrenschmidt
On Sat, 2007-12-01 at 12:28 -0600, Olof Johansson wrote: > Some PWRficient-based boards have a NMI button that's wired up to a GPIO > as interrupt source. By configuring the openpic accordingly, these get > delivered as a machine check with high priority, instead of as an external > interrupt. >

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Vitaly Bordug
On Sat, 01 Dec 2007 14:48:54 +0100 Jochen Friedrich wrote: > Hi Vitaly, > > > With that patch fixed.c now fully emulates MDIO bus, thus no need > > to duplicate PHY layer functionality. That, in turn, drastically > > simplifies the code, and drops down line count. > > > > As an additional bonus,

[RFC] [PATCH] pasemi: NMI support with MPIC

2007-12-01 Thread Olof Johansson
Some PWRficient-based boards have a NMI button that's wired up to a GPIO as interrupt source. By configuring the openpic accordingly, these get delivered as a machine check with high priority, instead of as an external interrupt. The device tree contains a property "nmi-source" in the openpic node

serial console autodetection not working on powermac

2007-12-01 Thread Olaf Hering
How is the serial console autodetection supposed to work with current kernels? arch/powerpc/kernel/legacy_serial.c is not compiled unless CONFIG_PPC_UDBG_16550 is selected. Even if I force this config option, legacy_serial_console remains -1 and the ch-a/ch-b check in check_legacy_serial_console()

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Jochen Friedrich
Hi Vitaly, > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all emulated PHY

[PATCH 2/3] 4xx: Change Kilauea dts to support new EMAC device tree properties

2007-12-01 Thread Stefan Roese
The recent changes from Benjamin Herrenschmidt to the ibm_newemac now make it possible to support other 4xx variants by just defining the correct properties in the device tree. In this case of the 405EX we need to define "has-mdio" in the RGMII node and "has-inverted-stacr-oc" and "has-new-stacr-st

[PATCH 3/3] 4xx: Add EMAC support to Kilauea defconfig

2007-12-01 Thread Stefan Roese
Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- arch/powerpc/configs/kilauea_defconfig | 717 1 files changed, 533 insertions(+), 184 deletions(-) diff --git a/arch/powerpc/configs/kilauea_defconfig b/arch/powerpc/configs/kilauea_defconfig index fd1c530..134

[PATCH 1/3] 4xx: Add 405EX CPU type needed for EMAC support on Kilauea

2007-12-01 Thread Stefan Roese
For EMAC support, 405EX needs to be defined to enable the corresponding EMAC features (IBM_NEW_EMAC_EMAC4, etc.). Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- arch/powerpc/platforms/40x/Kconfig |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platf