[PATCH 1/3] cell: fix undefined reference to mmio_nvram_init

2007-12-04 Thread Ishizaki Kou
This patch fixes the following link error with CONFIG_PPC_CELL_NATIVE=y and CONFIG_PPC_CELL_BLADE=n: arch/powerpc/platforms/built-in.o: In function `.cell_setup_arch': setup.c:(.init.text+0xe80): undefined reference to `.mmio_nvram_init' Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- Index:

[PATCH 3/3] update celleb_defconfig to support for native CBE

2007-12-04 Thread Ishizaki Kou
This patch updates celleb_defconfig to support for native CBE. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- Index: linux-powerpc-git/arch/powerpc/configs/celleb_defconfig === --- linux-powerpc-git.orig/arch/powerpc/configs/cel

[PATCH 2/3] celleb: add supporting for native CBE

2007-12-04 Thread Ishizaki Kou
This patch adds supporting for native CBE on Celleb. Many codes in platforms/cell/ are used when native CBE environment. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> --- Index: linux-powerpc-git/arch/powerpc/platforms/cell/iommu.c ==

Re: [PATCH] Add IPIC MSI interrupt support

2007-12-04 Thread Li Li
Yes. According to the PCI spec, a PCI device can request multi MSI interrupts and require that interrupts are consecutive. But it is ok if only allocate one to it. Anyway, the hwirq should be allocated from bitmap instead of increment by hand. I will correct this and resend the patch. - Tony On

[PATCH 1/2] powerpc: Add MPC837xE MDS PCIE RC mode support

2007-12-04 Thread Li Li
Modified based on discussion in list. 1.Change the device node to pcie 2.Add PPC_83XX_PCI_PRIMARY flag 3.Rearrange the codes The PCIE controller is initiated in u-boot. Signed-off-by: Tony Li <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8377_mds.dts | 54 -- arch/powerpc/boot/

RE: [PATCH] Add IPIC MSI interrupt support

2007-12-04 Thread Li Tony
> -Original Message- > From: Michael Ellerman [mailto:[EMAIL PROTECTED] > Sent: 2007年12月4日 13:38 > To: Li Tony > Cc: Li Tony; Gala Kumar; linuxppc-dev > Subject: Re: [PATCH] Add IPIC MSI interrupt support > > On Mon, 2007-12-03 at 17:07 +0800, Li Li wrote: > > Hi Michael, > > > > I em

[PATCH] ipic: ack only for edge interrupts

2007-12-04 Thread Li Yang
Only external interrupts in edge detect mode support ack operation. Therefore, in most cases ack is not needed. The patch makes ipic ack only when it's needed. This could boost over all system performance. Signed-off-by: Li Yang <[EMAIL PROTECTED]> Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>

[PATCH 2/2] powerpc: Add IPIC MSI support

2007-12-04 Thread Li Li
Modified based on discussion on list. 1. Adopt virq_to_hw routine 2. Correct a legacy bug Implements the IPIC MSI as two level interrupt controller. Signed-off-by: Tony Li <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8377_mds.dts | 14 ++ arch/powerpc/boot/dts/mpc8378_mds.dts |

RE: [PATCH 2/2] powerpc: Add IPIC MSI support

2007-12-04 Thread Li Yang
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > On Behalf Of Li Tony > Sent: Tuesday, December 04, 2007 6:39 PM > To: Gala Kumar; Phillips Kim; [EMAIL PROTECTED]; linuxppc-dev > Subject: [PATCH 2/2] powerpc: Add IPIC MSI support > > Modified based on discussi

RE: [PATCH] Add IPIC MSI interrupt support

2007-12-04 Thread Michael Ellerman
On Tue, 2007-12-04 at 18:34 +0800, Li Tony wrote: > > From: Michael Ellerman [mailto:[EMAIL PROTECTED] > > Sent: 2007年12月4日 13:38 > > To: Li Tony > > Cc: Li Tony; Gala Kumar; linuxppc-dev > > Subject: Re: [PATCH] Add IPIC MSI interrupt support > > > > On Mon, 2007-12-03 at 17:07 +0800, Li Li wrot

RE: [PATCH 2/2] powerpc: Add IPIC MSI support

2007-12-04 Thread Michael Ellerman
On Tue, 2007-12-04 at 18:57 +0800, Li Yang wrote: > > -Original Message- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] > > On Behalf Of Li Tony > > Sent: Tuesday, December 04, 2007 6:39 PM > > To: Gala Kumar; Phillips Kim; [EMAIL PROTECTED]; linuxppc-dev > > Subject: [PATCH 2/

Re: [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources

2007-12-04 Thread Geert Uytterhoeven
On Tue, 4 Dec 2007, Benjamin Herrenschmidt wrote: > The current pci_assign_unassigned_resources() code doesn't work properly > on 32 bits platforms with 64 bits resources. The main reason is the use > of unsigned long in various places instead of resource_size_t. > > This fixes it, along with some

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-12-04 Thread Ingo Molnar
* Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > So 2.6.24-rc3 was OK and 2.6.24-rc3-git2 is not? > > Yes, the 2.6.24-rc3 was Ok and this is seen from 2.6.24-rc3-git2/3/4. just to make sure: this is a real lockup and failed bootup (or device init), not just a message, right? Ingo ___

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Geert Uytterhoeven
On Sat, 1 Dec 2007, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This patch makes the platform code use the new machine-specific initcall > hooks. This has the advantage of not needing to explicitly test > machine_is() at the top of every initcall function. You seem to have m

Re: [PATCH 1/3] cell: fix undefined reference to mmio_nvram_init

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Ishizaki Kou wrote: > > +#ifdef CONFIG_MMIO_NVRAM > mmio_nvram_init(); > +#endif >  } The patch is technically correct, but the preferred way of doing this is to define a conditional inline function in the header, like: #ifdef CONFIG_MMIO_NVRAM extern int mmi

Re: [PATCH 1/5] PowerPC 74xx: Katana Qp device tree

2007-12-04 Thread Jon Loeliger
David Gibson wrote: > On Mon, Dec 03, 2007 at 01:26:34PM -0600, Jon Loeliger wrote: >> On Sun, 2007-12-02 at 19:50, David Gibson wrote: >> + clock-frequency = <7f28155>;/* 133.33 MHz */ >>> You can use to avoid the ugly hex. >> Better still, blaze a new trail, convert

Re: [PATCH 2/3] celleb: add supporting for native CBE

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Ishizaki Kou wrote: > This patch adds supporting for native CBE on Celleb.  Many codes in > platforms/cell/ are used when native CBE environment. > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Ah, excellent to hear that this is now working! I'd suggest doing the

Re: Merge dtc

2007-12-04 Thread Jon Loeliger
So, like, the other day David Woodhouse mumbled: > > I think this is a bad idea -- it's hardly a difficult for those people > who _do_ need dts to obtain it separately. > > We shouldn't be merging _more_ stuff in. Thanks for chiming in here, David W. As far as I can tell so far, the only two pe

Re: dtc: Fix uninitialized use of structure_ok

2007-12-04 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > My rework of the tree checking code introduced a potentially nasty bug > - it uses the structure_ok variable uninitialized. This patch fixes > the problem. It's a fairly ugly bandaid approach, but the ugly will > disappear once future patches have f

Re: [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info

2007-12-04 Thread David Woodhouse
On Thu, 2007-11-29 at 21:29 -0600, Olof Johansson wrote: > + continue; > + > + info.addr = *addr; > + > + i2c_register_board_info(PCI_FUNC(pdev->devfn), > &info, > + 1); > +

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Grant Likely
On 12/4/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > On Sat, 1 Dec 2007, Grant Likely wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > This patch makes the platform code use the new machine-specific initcall > > hooks. This has the advantage of not needing to explicitly test > > ma

Re: [PATCH] Add IPIC MSI interrupt support

2007-12-04 Thread Scott Wood
On Tue, Dec 04, 2007 at 11:04:18PM +1100, Michael Ellerman wrote: > On Tue, 2007-12-04 at 18:34 +0800, Li Tony wrote: > > I am not very sure about spin_lock influence. > > But maybe somebody will change the virq_to_hw implementation. > > I will take virq_to_hw instead. > > I mean the time to take

Re: [PATCH][DTC] Add an option to pad the blob that is generated

2007-12-04 Thread Jon Loeliger
So, like, the other day Kumar Gala mumbled: > There are times when we need extra space in the blob and just want > to have it added on w/o know the exact size to make it. > > The padding and min size options are mutually exclusive. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> Applied. Than

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Geert Uytterhoeven
On Tue, 4 Dec 2007, Grant Likely wrote: > On 12/4/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > On Sat, 1 Dec 2007, Grant Likely wrote: > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > This patch makes the platform code use the new machine-specific initcall > > > hooks. This has th

Re: dtc: Add may const qualifications

2007-12-04 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > This adds 'const' qualifiers to many variables and functions. In > particular it's now used for passing names to the tree accesor > functions. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Typo fixed, rebased and applied. Thanks, jdl _

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Grant Likely
On 12/4/07, Grant Likely <[EMAIL PROTECTED]> wrote: > On 12/4/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > On Sat, 1 Dec 2007, Grant Likely wrote: > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > This patch makes the platform code use the new machine-specific initcall > > > hooks.

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-12-04 Thread Kamalesh Babulal
Ingo Molnar wrote: > * Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > >>> So 2.6.24-rc3 was OK and 2.6.24-rc3-git2 is not? >> Yes, the 2.6.24-rc3 was Ok and this is seen from 2.6.24-rc3-git2/3/4. > > just to make sure: this is a real lockup and failed bootup (or device > init), not just a message

Re: Merge dtc

2007-12-04 Thread Josh Boyer
On Tue, 04 Dec 2007 07:25:57 -0600 Jon Loeliger <[EMAIL PROTECTED]> wrote: > So, like, the other day David Woodhouse mumbled: > > > > I think this is a bad idea -- it's hardly a difficult for those people > > who _do_ need dts to obtain it separately. > > > > We shouldn't be merging _more_ stuff

[PATCH] lparcfg: remove useless buffer allocation

2007-12-04 Thread Nathan Lynch
The 'data' member of proc_ppc64_lparcfg is unused, but the lparcfg module's init routine allocates 4K for it. Remove the code which allocates and frees this buffer. Signed-off-by: Nathan Lynch <[EMAIL PROTECTED]> --- arch/powerpc/kernel/lparcfg.c | 12 +--- 1 files changed, 1 insertion

Re: Merge dtc

2007-12-04 Thread Kumar Gala
On Dec 4, 2007, at 9:26 AM, Josh Boyer wrote: > On Tue, 04 Dec 2007 07:25:57 -0600 > Jon Loeliger <[EMAIL PROTECTED]> wrote: > >> So, like, the other day David Woodhouse mumbled: >>> >>> I think this is a bad idea -- it's hardly a difficult for those >>> people >>> who _do_ need dts to obtain i

[FDT][PATCH] Fix padding options

2007-12-04 Thread Kumar Gala
commit 22e787ca2b1e49a9a0f3c43262564ab1038c5c3c broke the padding support. We were updating the fdt header after writing it. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- flattree.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/flattree.c b/flattree.c in

[FDT][PATCH] Print out the total size as part of ftdump

2007-12-04 Thread Kumar Gala
Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- ftdump.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ftdump.c b/ftdump.c index 577c2cf..53343d7 100644 --- a/ftdump.c +++ b/ftdump.c @@ -87,6 +87,7 @@ static void dump_blob(void *blob) char *p_struct = blob + b

Re: [PATCH v2] Fix hardware IRQ time accounting problem.

2007-12-04 Thread Johannes Berg
On Tue, 2007-12-04 at 16:51 +1100, Tony Breeds wrote: > The commit fa13a5a1f25f671d084d8884be96fc48d9b68275 (sched: restore > deterministic CPU accounting on powerpc), unconditionally calls > update_process_tick() in system context. In the deterministic accounting case > this is the correct thing

[PATCH v2 0/4] OF-platform PATA driver

2007-12-04 Thread Anton Vorontsov
Hi all, Here is the second version of the OF-platform PATA driver and related patches. Arnd, the first patch has been changed, so technically it lost your Acked-by. - - - Changes since v1: - __pata_platform_probe now accepts pio_mask argument; - pata-platform compatible property renamed to ata-

[PATCH v2 1/4] [libata] pata_platform: make probe and remove functions device type neutral

2007-12-04 Thread Anton Vorontsov
Split pata_platform_{probe,remove} into two pieces: 1. pata_platform_{probe,remove} -- platform_device-dependant bits; 2. __ptata_platform_{probe,remove} -- device type neutral bits. This is done to not duplicate code for the OF-platform driver. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>

[PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Anton Vorontsov
This driver nicely wraps around pata_platform library functions, and provides OF platform bus bindings to the PATA devices. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/ata/Kconfig| 10 drivers/ata/Makefile |1 + drivers/ata/pata_of_platform.c |

[PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Anton Vorontsov
This patch adds localbus and pata nodes to use CF IDE interface on MPC8349E-mITX boards. Patch also adds code to probe localbus. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8349emitx.dts| 18 +- arch/powerpc/platforms/83xx/mpc834x_itx.c |

[PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g

2007-12-04 Thread Anton Vorontsov
This patch renames ioport_shift member of pata_platform_info structure to reg_shift. Users of pata_platform are followed appropriately. Rationale of that change is: shifting applies to the whole memory mapped region, not only to the command block of the ATA registers, despite the fact that shiftin

Re: [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g

2007-12-04 Thread Sergei Shtylyov
Hello. Anton Vorontsov wrote: > This patch renames ioport_shift member of pata_platform_info > structure to reg_shift. Users of pata_platform are followed > appropriately. > Rationale of that change is: shifting applies to the whole memory > mapped region, not only to the command block of the AT

Re: Merge dtc

2007-12-04 Thread David Woodhouse
On Tue, 2007-12-04 at 14:10 +1100, David Gibson wrote: > We've been back and forth on this several times, Paul and I finally > concluded this was the better option. As long as I can just ignore it and use the separately-shipped dtc, I suppose it doesn't have to bother me too much. > It means we c

Re: Merge dtc

2007-12-04 Thread Scott Wood
On Tue, Dec 04, 2007 at 07:25:57AM -0600, Jon Loeliger wrote: > So, like, the other day David Woodhouse mumbled: > > > > I think this is a bad idea -- it's hardly a difficult for those people > > who _do_ need dts to obtain it separately. > > > > We shouldn't be merging _more_ stuff in. > > Than

Re: [PATCH 1/5] PowerPC 74xx: Katana Qp device tree

2007-12-04 Thread Andrei Dolnikov
Mark A. Greer wrote: > On Tue, Dec 04, 2007 at 07:52:50AM +1100, Benjamin Herrenschmidt wrote: > >>> #address-cells = <1>; >>> + #size-cells = <1>; >>> + model = "Katana-Qp"; /* Default */ >>> + compatible = "emerson,Katana-Qp"; >>> + coherency-off; >>> + >>> >> What do that m

Re: [PATCH 1/5] PowerPC 74xx: Katana Qp device tree

2007-12-04 Thread Mark A. Greer
On Tue, Dec 04, 2007 at 08:28:57PM +0300, Andrei Dolnikov wrote: > Mark A. Greer wrote: > >On Tue, Dec 04, 2007 at 07:52:50AM +1100, Benjamin Herrenschmidt wrote: > > > >>> #address-cells = <1>; > >>>+ #size-cells = <1>; > >>>+ model = "Katana-Qp"; /* Default */ > >>>+ compatible = "emerson,

ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Timur Tabi
Add support for UART serial ports using a Freescale QUICC Engine (found on some MPC83xx and MPC85xx SOCs). Because of a silicon bug in some QE-enabled SOCs (e.g. 8323 and 8360), a new microcode is required. This microcode implements UART via a work-around, hence it's called "Soft-UART". This driv

Re: [PATCH 5/7] powerpc: Replace ppc_md.power_off with pm_power_off

2007-12-04 Thread Mark A. Greer
On Tue, Dec 04, 2007 at 06:23:09PM +1100, Benjamin Herrenschmidt wrote: > > On Mon, 2007-12-03 at 22:48 -0700, Mark A. Greer wrote: > > From: Mark A. Greer <[EMAIL PROTECTED]> > > > > The ppc_md.power_off hook performs the same function that the > > pm_power_off hook is supposed to. However, it

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread David Woodhouse
Oops: Exception in kernel mode, sig: 5 [#1] nfs: server pmac not responding, still trying SMP NR_CPUS=128 NUMA PA Semi PWRficient Modules linked in: appletouch cbc blkcipher dm_crypt dm_

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread David Woodhouse
On Tue, 2007-12-04 at 18:04 +, David Woodhouse wrote: > Oops: Exception in kernel mode, sig: 5 [#1] > > nfs: server pmac not responding, still trying Oops, sorry. That was meant to be just to Olof. And it helps if I'm actually running the kernel i

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
Hi, On Tue, Dec 04, 2007 at 08:07:19PM +0300, Anton Vorontsov wrote: > This driver nicely wraps around pata_platform library functions, > and provides OF platform bus bindings to the PATA devices. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > drivers/ata/Kconfig| 1

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Olof Johansson
Hi, On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote: > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts > b/arch/powerpc/boot/dts/mpc8349emitx.dts > index 5072f6d..c459b0a 100644 > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts > @@

2.6.25-candidates branch updated in 4xx tree

2007-12-04 Thread Josh Boyer
For those following my tree, I've added a 2.6.25-candidates branch and based it off of Paul's latest master. (If you've already pulled you'll have to reset, sorry.) I call it candidates because several patches (most notably Ben's) will probably get reworked a little before I ask Paul to pull them

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Scott Wood
Olof Johansson wrote: > Hi, > > On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote: >> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts >> b/arch/powerpc/boot/dts/mpc8349emitx.dts >> index 5072f6d..c459b0a 100644 >> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts >> +++ b/arch/powerp

Re: [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 01:28:46PM +, David Woodhouse wrote: > > On Thu, 2007-11-29 at 21:29 -0600, Olof Johansson wrote: > > + continue; > > + > > + info.addr = *addr; > > + > > + i2c_register_board_info(PCI_FUNC(pdev->

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Grant Likely wrote: > On 12/4/07, Grant Likely <[EMAIL PROTECTED]> wrote: > > On 12/4/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > You seem to have missed the PS3 *_initcall()s. > > > Probably because they test for firmware_has_feature(FW_FEATURE_PS3_LV1) >

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Anton Vorontsov
On Tue, Dec 04, 2007 at 01:16:57PM -0600, Olof Johansson wrote: > Hi, > > On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote: > > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts > > b/arch/powerpc/boot/dts/mpc8349emitx.dts > > index 5072f6d..c459b0a 100644 [...] > > +static struc

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Anton Vorontsov
On Tue, Dec 04, 2007 at 12:48:26PM -0600, Olof Johansson wrote: > Hi, > > On Tue, Dec 04, 2007 at 08:07:19PM +0300, Anton Vorontsov wrote: > > This driver nicely wraps around pata_platform library functions, [..] > There's a typo in the dependencies for PATA_PLATFORM that you should change: > > d

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: > Turns out we're freeing the skb when we detect CRC error, but we're > not clearing out info->skb. We could either clear it and have the stack > reallocate it, or just leave it and the rx ring refill code will reuse > the one that was allocated. > > Reusing a freed skb obvio

Re: [PATCH 5/7] powerpc: Replace ppc_md.power_off with pm_power_off

2007-12-04 Thread Benjamin Herrenschmidt
On Tue, 2007-12-04 at 11:01 -0700, Mark A. Greer wrote: > On Tue, Dec 04, 2007 at 06:23:09PM +1100, Benjamin Herrenschmidt wrote: > > > > On Mon, 2007-12-03 at 22:48 -0700, Mark A. Greer wrote: > > > From: Mark A. Greer <[EMAIL PROTECTED]> > > > > > > The ppc_md.power_off hook performs the same

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > tristate "Generic platform device PATA support" > - depends on EMBEDDED || ARCH_RPC > + depends on EMBEDDED || ARCH_PPC It needs to be || PPC, not || ARCH_PPC. -Olof ___

Re: [PATCH] pci: Fix bus resource assignment on 32 bits with 64b resources

2007-12-04 Thread Benjamin Herrenschmidt
On Tue, 2007-12-04 at 13:39 +0100, Geert Uytterhoeven wrote: > > Can we please have them in ? They look very useful to > me > elsewhere (other bus drivers, device drivers), too. > > What about naming the printf format specifier macros more like in C99, > e.g. > PRI*? That's a can of worms I jus

Re: [PATCH] Stop phy code from returning success to unknown ioctls.

2007-12-04 Thread Andy Fleming
On Nov 28, 2007, at 13:56, David Woodhouse wrote: > This kind of sucks, and prevents the Fedora installer from using the > device for network installs... > > [EMAIL PROTECTED] phy]# iwconfig eth0 > Warning: Driver for device eth0 has been compiled with an ancient > version > of Wireless Extensi

Re: [PATCH 5/7] powerpc: Replace ppc_md.power_off with pm_power_off

2007-12-04 Thread Grant Likely
On 12/4/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-12-04 at 11:01 -0700, Mark A. Greer wrote: > > On Tue, Dec 04, 2007 at 06:23:09PM +1100, Benjamin Herrenschmidt wrote: > > > > > > On Mon, 2007-12-03 at 22:48 -0700, Mark A. Greer wrote: > > > > From: Mark A. Greer <[EMA

Re: [PATCH] gianfar: fix compile warning

2007-12-04 Thread Jeff Garzik
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Eliminate an uninitialized variable warning. The code is correct, but > a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent. > Since addr has never been initialized, and the compiler doesn't know > what dma_al

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-04 Thread Jeff Garzik
Vitaly Bordug wrote: > With that patch fixed.c now fully emulates MDIO bus, thus no need > to duplicate PHY layer functionality. That, in turn, drastically > simplifies the code, and drops down line count. > > As an additional bonus, now there is no need to register MDIO bus > for each PHY, all em

Re: [PATCH 5/7] powerpc: Replace ppc_md.power_off with pm_power_off

2007-12-04 Thread Benjamin Herrenschmidt
On Tue, 2007-12-04 at 13:05 -0700, Grant Likely wrote: > We could simply have the setup code copy the ppc_md.power_off pointer > into pm_power_off; that we retain the nice assignment in > define_machine(), but eliminate the duplicated calls. Good idea. Ben.

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Benjamin Herrenschmidt
On Tue, 2007-12-04 at 20:35 +0100, Arnd Bergmann wrote: > > 1. If another platform gets added that uses the same firmware feature, > it > will automatically do the right thing. Yes but is it something that we want to happen ? That is, do we want code somewhere in a platform/foo dir to run when u

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Anton Vorontsov
On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > tristate "Generic platform device PATA support" > > - depends on EMBEDDED || ARCH_RPC > > + depends on EMBEDDED || ARCH_PPC > > It needs to be || PPC, not

Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 11:37:51PM +0300, Anton Vorontsov wrote: > On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote: > > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote: > > > tristate "Generic platform device PATA support" > > > - depends on EMBEDDED || ARCH_RPC > >

Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 10:45:31PM +0300, Anton Vorontsov wrote: > This patch adds localbus and pata nodes to use CF IDE interface > on MPC8349E-mITX boards. > > Patch also adds code to probe localbus. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Olof Johansson <[EMAIL PROTEC

Re: [PATCH] gianfar driver: eliminate compiler warnings and unnecessary macros

2007-12-04 Thread Jeff Garzik
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This patch eliminates the warning of unused return values when the driver > registers it sysfs files. Now the driver will print an error if it is > unable to register the sysfs files. > > It also eliminates the macros used to wrap

Re: [PATCH v2 1/4] [libata] pata_platform: make probe and remove functions device type neutral

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 08:06:25PM +0300, Anton Vorontsov wrote: > Split pata_platform_{probe,remove} into two pieces: > 1. pata_platform_{probe,remove} -- platform_device-dependant bits; > 2. __ptata_platform_{probe,remove} -- device type neutral bits. > > This is done to not duplicate code for t

[PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Olof Johansson
[POWERPC] Move electra-ide support over to new pata_of_platform framework Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- I'll remove the electra-ide stuff from arch/powerpc/platfo

[PATCH] [POWERPC] Xilinx: clear data caches.

2007-12-04 Thread Stephen Neuendorffer
This code is needed to boot without a boot loader. Grant: I'm not sure where the right place to put this is. I'm assuming we'll actually need some boot code that is not generic? Also, note that there is a V4FX errata workaround in arch/ppc/boot/head.S, which probably also needs to get pulled

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Jeff Garzik
Olof Johansson wrote: > [POWERPC] Move electra-ide support over to new pata_of_platform framework > > Move electra-ide glue over to the new pata_of_platform framework, and > add the quirks needed to that driver. > > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > --- > > I'll remove th

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-12-04 Thread Ingo Molnar
* Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Ingo, > > This softlockup is seen in the 2.6.24-rc4 either and looks like a > message because this is seen while running tbench and machine > continues running other test's after the softlockup messages and some > times seen with the bootup,

Re: [PATCH] [POWERPC] Xilinx: clear data caches.

2007-12-04 Thread Grant Likely
On 12/4/07, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > This code is needed to boot without a boot loader. > > Grant: I'm not sure where the right place to put this is. I'm assuming > we'll actually need some boot code that is not generic? Also, note that > there is a V4FX errata workaro

Re: [PATCH] pata_of_platform: Move electra-ide support over to new framework

2007-12-04 Thread Olof Johansson
On Tue, Dec 04, 2007 at 03:50:03PM -0500, Jeff Garzik wrote: > Olof Johansson wrote: >> [POWERPC] Move electra-ide support over to new pata_of_platform framework >> Move electra-ide glue over to the new pata_of_platform framework, and >> add the quirks needed to that driver. >> Signed-off-by: Olof

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Geoff Levand
Geert Uytterhoeven wrote: > On Tue, 4 Dec 2007, Grant Likely wrote: >> On 12/4/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> > On Sat, 1 Dec 2007, Grant Likely wrote: >> > > From: Grant Likely <[EMAIL PROTECTED]> >> > > >> > > This patch makes the platform code use the new machine-specific i

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Benjamin Herrenschmidt wrote: > On Tue, 2007-12-04 at 20:35 +0100, Arnd Bergmann wrote: > > > > 1. If another platform gets added that uses the same firmware feature, > > it > > will automatically do the right thing. > > Yes but is it something that we want to happen

Re: [FDT][PATCH] Fix padding options

2007-12-04 Thread David Gibson
On Tue, Dec 04, 2007 at 10:27:52AM -0600, Kumar Gala wrote: > commit 22e787ca2b1e49a9a0f3c43262564ab1038c5c3c broke the padding > support. We were updating the fdt header after writing it. Uh.. I can't find a commit with that SHA1. Which one are you referring to? -- David Gibson

Re: [PATCH v2 2/2] [POWERPC] Use new machine_xxx_initcall hooks in platform code

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Benjamin Herrenschmidt wrote: > > 2. The call to firmware_has_feature() turns into a compile-time check > > in > > many cases, so if the kernel does not contain support for any firmware > > with the given feature, all the code referenced it can get optimized > > away by

Re: ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Timur Tabi wrote: > Add support for UART serial ports using a Freescale QUICC Engine > (found on some MPC83xx and MPC85xx SOCs). > > Because of a silicon bug in some QE-enabled SOCs (e.g. 8323 and 8360), a new > microcode is required. This microcode implements UART via

Re: Merge dtc

2007-12-04 Thread David Gibson
On Tue, Dec 04, 2007 at 10:04:53AM -0600, Kumar Gala wrote: > > On Dec 4, 2007, at 9:26 AM, Josh Boyer wrote: > > > On Tue, 04 Dec 2007 07:25:57 -0600 > > Jon Loeliger <[EMAIL PROTECTED]> wrote: > > > >> So, like, the other day David Woodhouse mumbled: > >>> > >>> I think this is a bad idea -- it

Re: [FDT][PATCH] Fix padding options

2007-12-04 Thread Kumar Gala
I guess it was really git commit 2b7dc8dce549ad72ad437b254bf756d7ba4c2a5a Add an option to pad the blob that is generated - k On Dec 4, 2007, at 4:04 PM, David Gibson wrote: > On Tue, Dec 04, 2007 at 10:27:52AM -0600, Kumar Gala wrote: >> commit 22e787ca2b1e49a9a0f3c43262564ab1038c5c3c broke

Re: [FDT][PATCH] Print out the total size as part of ftdump

2007-12-04 Thread David Gibson
On Tue, Dec 04, 2007 at 10:33:20AM -0600, Kumar Gala wrote: > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> You know, the whole batch of fprintf()s of header information in dt_from_blob() are really just a debugging hack that uglifies dtc's output. The whole lot could be moved over to ftdump inst

Re: Merge dtc

2007-12-04 Thread Paul Mackerras
David Woodhouse writes: > I think this is a bad idea -- it's hardly a difficult for those people > who _do_ need dts to obtain it separately. The trouble is that it's not just people who are making a kernel for a specific embedded board that need dtc. These days anyone who wants to try cross-com

Re: ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Timur Tabi
Arnd Bergmann wrote: > Can you use the driver on CPUs without this particular bug when it's built > in Soft-UART mode? No, you have to build with Soft-UART mode turned off. Soft-UART mode actually uses the HMC mode of the QE and hacks it up to act like a UART. The only way to know at runtime w

Re: Merge dtc

2007-12-04 Thread David Woodhouse
On Wed, 2007-12-05 at 09:21 +1100, Paul Mackerras wrote: > David Woodhouse writes: > > > I think this is a bad idea -- it's hardly a difficult for those people > > who _do_ need dts to obtain it separately. > > The trouble is that it's not just people who are making a kernel for a > specific embe

Re: Merge dtc

2007-12-04 Thread Josh Boyer
On Wed, 5 Dec 2007 09:21:21 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > David Woodhouse writes: > > > I think this is a bad idea -- it's hardly a difficult for those people > > who _do_ need dts to obtain it separately. > > The trouble is that it's not just people who are making a kernel f

Re: ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Timur Tabi
Arnd Bergmann wrote: > I'm guessing that you don't really mean dma_addr_t here, but rather > phys_addr_t, which is something different. Now that I think about it, I don't know which is correct. The value is plugged into the pointer register of a buffer descriptor, and the QE performs a DMA-lik

dtc: Fix FAIL() macro varargs

2007-12-04 Thread David Gibson
The way the checking subsystem FAIL() macro is currently implemented it must take at least one paramater after the format string. This patch corrects the problem. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: dtc/checks.c =

dtc: Convert "name" property checking to new infrastructure

2007-12-04 Thread David Gibson
This patch removes the old-style checking code for the "name" property - i.e. verifying that the "name" property, if present, matches the node name. It replaces it with a pair of more-or-less equivalent checks in the new checking framework. This also promotes this check to a "structural" check, o

dtc: Trivial lexer cleanups

2007-12-04 Thread David Gibson
This patch applies a couple of tiny cleanups to the lexer. The not-very-useful 'WS' named pattern is removed, and the debugging printf() for single character tokens is moved to the top of the action, which results in less confusing output when LEXDEBUG is switched on (because it goes before the pr

Re: [PATCH v2] Fix hardware IRQ time accounting problem.

2007-12-04 Thread Jörg Sommer
Hallo Tony, Tony Breeds <[EMAIL PROTECTED]> wrote: > The commit fa13a5a1f25f671d084d8884be96fc48d9b68275 (sched: restore > deterministic CPU accounting on powerpc), unconditionally calls > update_process_tick() in system context. In the deterministic accounting case > this is the correct thing to

Re: ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Arnd Bergmann
On Tuesday 04 December 2007, Timur Tabi wrote: > When I program the DMA controller, I give it a dma_addr_t.  And yet, the DMA > controller and the QE are both devices on the SoC.  So if the DMA controller > takes a dma_addr_t, then shouldn't the QE also take one? > >From a code clarity perspect

dtc: Generate useful error message for properties after subnodes

2007-12-04 Thread David Gibson
On several occasions, I've accidentally put properties after subnodes in a dts file. I've then spent ages thinking that the resulting syntax error was because of something else. This patch arranges for this specific syntax error to generate a more specific and useful error message. Signed-off-by

Re: ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Scott Wood
Arnd Bergmann wrote: > From a code clarity perspective, the interesting point is that dma_addr_t is > what comes back from the functions in dma-mapping.h. If you don't use them, > a physical address is phys_addr_t. > > You can argue that the QS is really a DMA device, but in that case you > should

[FDT][PATCH] Fix padding options

2007-12-04 Thread Kumar Gala
"Add an option to pad the blob that is generated" broke the padding support. We were updating the fdt header after writing it. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Better commit message for this, since my commit ID is different. flattree.c | 12 +++- 1 files changed, 7 i

Re: [FDT][PATCH] Print out the total size as part of ftdump

2007-12-04 Thread Kumar Gala
On Dec 4, 2007, at 4:20 PM, David Gibson wrote: > On Tue, Dec 04, 2007 at 10:33:20AM -0600, Kumar Gala wrote: >> Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > > You know, the whole batch of fprintf()s of header information in > dt_from_blob() are really just a debugging hack that uglifies dtc's

Re: ucc_uart: add support for Freescale QUICCEngine UART

2007-12-04 Thread Arnd Bergmann
On Wednesday 05 December 2007, Scott Wood wrote: > > > You can argue that the QS is really a DMA device, but in that case you > > should convert the driver to use the DMA mapping interfaces correctly, > > which I would consider overkill. > > Why is it overkill? > Well, if the QE can never be us

dtc: Implement path references

2007-12-04 Thread David Gibson
This patch extends dtc syntax to allow references (&label, or &{/full/path}) directly within property definitions, rather than inside a cell list. Such references are expanded to the full path of the referenced node, as a string, instead of to a phandle as references within cell lists are evaluate

  1   2   >