Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver

2008-05-24 Thread Jochen Friedrich
Hi Grant, >> + - compatible : should be "linux,mmc-spi". >> + - linux,modalias - should be "of_mmc_spi". > > I'm not even sure if the whole linux,modalias is even a good idea. I > had kind of thrown it in there as a convenient way to override > compatible when needed, but I haven't re

Re: [spi-devel-general] [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread David Brownell
On Friday 23 May 2008, Grant Likely wrote: > Very good point.  Okay, so we cannot assume any correlation between > the number of CS lines and the number of child nodes to the SPI bus. That wasn't what I was implying ... all the devices hooked up to a given chipselect should be viewed as a single (

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread Grant Likely
On Sat, May 24, 2008 at 12:26 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > On Thu, May 22, 2008 at 8:05 PM, David Brownell <[EMAIL PROTECTED]> wrote: >> On Wednesday 21 May 2008, Anton Vorontsov wrote: >>> > +++ b/drivers/spi/spi_of.c >>> >>> I think better placement for this is drivers/of, no? >>

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread Jochen Friedrich
Grant Likely schrieb: > On Sat, May 24, 2008 at 12:26 AM, Grant Likely > <[EMAIL PROTECTED]> wrote: >> On Thu, May 22, 2008 at 8:05 PM, David Brownell <[EMAIL PROTECTED]> wrote: >>> On Wednesday 21 May 2008, Anton Vorontsov wrote: > +++ b/drivers/spi/spi_of.c I think better placement for t

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread Grant Likely
On Sat, May 24, 2008 at 11:14 AM, Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Grant Likely schrieb: >> On Sat, May 24, 2008 at 12:26 AM, Grant Likely >> <[EMAIL PROTECTED]> wrote: >>> On Thu, May 22, 2008 at 8:05 PM, David Brownell <[EMAIL PROTECTED]> wrote: On Wednesday 21 May 2008, Anton V

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread David Brownell
On Saturday 24 May 2008, Grant Likely wrote: > >>> > +++ b/drivers/spi/spi_of.c > >>> > >>> I think better placement for this is drivers/of, no? > >> > >> Yes please. > > > > Okay, I wasn't sure. Will do. > > I'm having second thoughts about this. I think this code is more SPI > centric than it

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread David Brownell
On Saturday 24 May 2008, Grant Likely wrote: > > Isn't the same true for drivers/of/gpio.c or drivers/of/of_i2c.c, as well? > > I would argue 'yes!' ... all the more reason to have the SPI glue go there too, matching the ACPI/PCI precedent as well as those others! ___

Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver

2008-05-24 Thread David Brownell
On Friday 23 May 2008, Anton Vorontsov wrote: > > This is second attempt to write the OpenFirmware bindings for the > MMC-over-SPI (and SPI bindings in general). Summary: an OF-specific wrapper around the mmc_spi platform code. I think a wrapper to encapsulate all the OF-specific knowledge make

Debian kernel updates for Cell platforms

2008-05-24 Thread Geoff Levand
I made an updated debian config.powerpc64 to enable support for the PS3 and fix the QS20 and QS21 options. I put a kernel, initrd and modules archive here: http://cell.gotdns.org/pub/debian-cell-kernel-1/ Could people please test and report on various powerpc64 platforms. -Geoff

Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver

2008-05-24 Thread Segher Boessenkool
+ Required properties: + - #address-cells : should be 0. + - #size-cells : should be 0. Are these properties required at all? Will this node have any children. You mean, "does this node define a bus". If it doesn't, there shouldn't be #a and #s; if it does, the binding should

Re: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver

2008-05-24 Thread Segher Boessenkool
The real problem is we don't yet have good method (or place) to apply a translation table from compatible values to modaliases. Ideally, the translations should be part of the drivers themselves, but that causes a chicken and egg problem of needing to load the driver to get access to the table to

Re: Debian kernel updates for Cell platforms

2008-05-24 Thread Sven Luther
On Sat, May 24, 2008 at 03:02:59PM -0700, Geoff Levand wrote: > I made an updated debian config.powerpc64 to enable support for > the PS3 and fix the QS20 and QS21 options. Hi Geoff, > I put a kernel, initrd and modules archive here: > > http://cell.gotdns.org/pub/debian-cell-kernel-1/ Thanks

Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver

2008-05-24 Thread Grant Likely
On Sat, May 24, 2008 at 1:56 PM, David Brownell <[EMAIL PROTECTED]> wrote: > On Friday 23 May 2008, Anton Vorontsov wrote: >> >> This is second attempt to write the OpenFirmware bindings for the >> MMC-over-SPI (and SPI bindings in general). > > Summary: an OF-specific wrapper around the mmc_spi p

Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

2008-05-24 Thread Grant Likely
On Sat, May 24, 2008 at 11:45 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Saturday 24 May 2008, Grant Likely wrote: >> > Isn't the same true for drivers/of/gpio.c or drivers/of/of_i2c.c, as well? >> >> I would argue 'yes!' > > ... all the more reason to have the SPI glue go there too, > matc