[PATCH 2.6.25.9] Make sure that include/asm-powerpc/spinlock.h does not trigger compilation warnings

2008-06-28 Thread Bart Van Assche
When compiling kernel modules for ppc that include , gcc prints a warning message every time it encounters a function declaration where the inline keyword appears after the return type. The patch below makes sure that the order of the inline keyword and the return type is as gcc expects it. Additio

Re: [PATCH 01/12] pata_mpc52xx: use linux/of_platform.h instead of asm

2008-06-28 Thread Stephen Rothwell
On Fri, 27 Jun 2008 22:31:54 -0700 "Grant Likely" <[EMAIL PROTECTED]> wrote: > > On Thu, Jun 26, 2008 at 11:37 PM, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > >> > >> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> > >> --- > >> drivers/ata/pata_mpc52xx.c |2 +- > >

Re: [PATCH 2.6.25.9] Make sure that include/asm-powerpc/spinlock.h does not trigger compilation warnings

2008-06-28 Thread Kumar Gala
On Jun 28, 2008, at 1:51 AM, Bart Van Assche wrote: When compiling kernel modules for ppc that include spinlock.h>, gcc prints a warning message every time it encounters a function declaration where the inline keyword appears after the return type. The patch below makes sure that the order o

Re: [PATCH 2.6.25.9] Make sure that include/asm-powerpc/spinlock.h does not trigger compilation warnings

2008-06-28 Thread Bart Van Assche
On Sat, Jun 28, 2008 at 5:07 PM, Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Jun 28, 2008, at 1:51 AM, Bart Van Assche wrote: > >> When compiling kernel modules for ppc that include , gcc >> prints a warning message every time it encounters a function declaration >> where >> the inline keyword app

[PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-06-28 Thread Wolfram Sang
If an I2C device node does not specify an interrupt, the .irq member of the board_info struct was set to -1. This caused crashes on following irq_dispose_mappings. Leave it NO_IRQ as returned from irq_of_parse_and_map. (Suggesting -1 as 'i2c-no-irq' used to be a bug in linux/i2c.h.) Signed-off-by:

Re: [PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-06-28 Thread Grant Likely
On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang <[EMAIL PROTECTED]> wrote: > If an I2C device node does not specify an interrupt, the .irq member of the > board_info struct was set to -1. This caused crashes on following > irq_dispose_mappings. Leave it NO_IRQ as returned from irq_of_parse_and_map.

Re: [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.

2008-06-28 Thread Grant Likely
On Fri, Jun 6, 2008 at 10:16 AM, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > > legacy_serial identifies a valid ns16550 on a simple-bus, but the > legacy_serial driver doesn't understand the shift and offset flags > necessary to get it to work, which results in no console. > > I think the eas

Re: FW: [PATCH] powerpc: Xilinx: adding virtex5 powerpc 440 support

2008-06-28 Thread Grant Likely
Hi John. Oops, you had also posted this patch to the list later, so I'm also forwarding my comments to the list. Cheers, g. On Sat, Jun 28, 2008 at 3:56 PM, Grant Likely <[EMAIL PROTECTED]> wrote: > Sorry for the late reply on this one, I had gotten rather busy. > > On Wed, Jun 18, 2008 at 03:09

Re: [PATCH 19/60] microblaze_v4: checksum support

2008-06-28 Thread Segher Boessenkool
+static inline unsigned int +csum_tcpudp_nofold(unsigned long saddr, unsigned long daddr, unsigned short len, + unsigned short proto, unsigned int sum) +{ + __asm__("add %0, %4, %1\n\t" + "addc %0, %4, %2\n\t" + "addc %0, %4, %3\n\t" +

Re: [PATCH v2] update crypto node definition and device tree instances

2008-06-28 Thread Segher Boessenkool
I'm really don't like "fsl,sec1.0" or any of the variants as a compatible property either because it can easily be abused (it's not anchored to a specific physical part so the meaning can shift over time); but that is another argument and it is well documented in other email threads (http://thre

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Jon Smirl
On 6/25/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > i2c->adap = mpc_ops; > > - i2c->adap.nr = pdev->id; > > i2c_set_adapdata(&i2c->adap, i2c); > > - i2c->adap.dev.parent = &pdev->dev; > > - if ((result = i2c_add_numbered_adapter(&i2c->adap)) < 0) { > > + i

[RFC] Non-numbered ibm iic driver

2008-06-28 Thread Sean MacLennan
This is a patch to the ibm iic driver that uses the non-numbered i2c call and therefore does not need an index. Instead, it registers the ibm iic, then walks all the child nodes and adds them. This is required for new style drivers, old style drivers "just work". The warp has both a new style driv

Re: [RFC] Non-numbered ibm iic driver

2008-06-28 Thread Jon Smirl
On 6/28/08, Sean MacLennan <[EMAIL PROTECTED]> wrote: > This is a patch to the ibm iic driver that uses the non-numbered > i2c call and therefore does not need an index. Instead, it registers the > ibm iic, then walks all the child nodes and adds them. This is required > for new style drivers, o

Re: [RFC] Non-numbered ibm iic driver

2008-06-28 Thread Sean MacLennan
On Sat, 28 Jun 2008 23:25:05 -0400 "Jon Smirl" <[EMAIL PROTECTED]> wrote: > On 6/28/08, Sean MacLennan <[EMAIL PROTECTED]> wrote: > > This is a patch to the ibm iic driver that uses the non-numbered > > i2c call and therefore does not need an index. Instead, it > > registers the ibm iic, then wal

Re: [RFC] Non-numbered ibm iic driver

2008-06-28 Thread Grant Likely
On Sat, Jun 28, 2008 at 11:43:39PM -0400, Sean MacLennan wrote: > On Sat, 28 Jun 2008 23:25:05 -0400 > "Jon Smirl" <[EMAIL PROTECTED]> wrote: > > > On 6/28/08, Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > This is a patch to the ibm iic driver that uses the non-numbered > > > i2c call and there

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Grant Likely
On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > On 6/25/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > > > i2c->adap = mpc_ops; > > > - i2c->adap.nr = pdev->id; > > > i2c_set_adapdata(&i2c->adap, i2c); > > > - i2c->adap.dev.parent = &pdev->dev; > > > -

Re: [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Grant Likely
On Tue, Jun 10, 2008 at 8:40 PM, Jon Smirl <[EMAIL PROTECTED]> wrote: > Convert i2c-mpc from a platform driver into an of_platform driver. > This patch is much smaller since Jochen already added > of_find_i2c_driver(). Versions of this have been posted before. > > Signed-ff-by: Jon Smirl <[EMAIL PR

Re: [PATCH 2/6] MPC5121 clock driver

2008-06-28 Thread Grant Likely
Mostly looks good, a few comments below. On Fri, Jun 20, 2008 at 10:58:35AM -0600, John Rigby wrote: > Implements the api defined in include/clk.h > > Current only getting frequencies is supported > not setting. Need a more detailed commit message. This doesn't tell me much. > > Signed-off-by

Re: [PATCH 3/6] MPC5121 Add generic board support

2008-06-28 Thread Grant Likely
Mostly looks good, but a few comments below. On Fri, Jun 20, 2008 at 10:58:36AM -0600, John Rigby wrote: > Move shared code from mpc5121_ads.c to mpc512x_shared.c. > Add new generic board setup mpc5121_generic.c > > Signed-off-by: John Rigby <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/512

Re: [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support

2008-06-28 Thread Grant Likely
Minor comments below. On Fri, Jun 20, 2008 at 10:58:37AM -0600, John Rigby wrote: > Add a interrupt host for the interrupt > controller in the mpc5121ads cpld. > PCI interrupts are 0-7 the rest are 8-15 > Touchscreen pendown irq is hardwired to irq1 > All other irqs are chainged to irq0 > > Signe

Re: [PATCH 5/6] MPC5121 Add PCI support

2008-06-28 Thread Grant Likely
On Fri, Jun 20, 2008 at 10:58:38AM -0600, John Rigby wrote: > Copied from 83xx minus support for two busses. If this is a copy, then can it be shared? g. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc

Re: [PATCH 6/6] MPC5121 Hide pci bridge

2008-06-28 Thread Grant Likely
On Fri, Jun 20, 2008 at 10:58:39AM -0600, John Rigby wrote: > The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER > while other freescale host bridges have class set to > PCI_CLASS_PROCESSOR_POWERPC. > > This patch makes fixup_hide_host_resource_fsl match > PCI_CLASS_BRIDGE_OTHER in

Re: [PATCH] [RFC] powerpc: Xilinx: adding virtex5 powerpc 440 support

2008-06-28 Thread Grant Likely
On Mon, Jun 23, 2008 at 09:35:56PM -0400, Josh Boyer wrote: > On Mon, 23 Jun 2008 15:30:35 -0600 John Linn <[EMAIL PROTECTED]> wrote: > > I'll try to better understand if we can detect the compressed device > > tree and if we really have to disable the APU. > > > > What's the reasoning for being i

Re: [PATCH] [RFC] powerpc: Xilinx: adding virtex5 powerpc 440 support

2008-06-28 Thread Grant Likely
On Tue, Jun 24, 2008 at 03:07:48PM -0600, John Linn wrote: > Hi Grant, > > It appears that you designed the simpleImage around Xilinx FPGAs. Yes. > Since we have to initialize the 16550 UART in the bootstrap and there's > no boot loader, were you thinking we would add the 16550 initialization >

Re: [PATCH 1/2] powerpc: pci config cleanup [rev2]

2008-06-28 Thread Grant Likely
On Thu, Jun 26, 2008 at 11:07:56AM -0600, John Rigby wrote: > Choosing PCI or not at config time is allowed on some > platforms via an if expression in arch/powerpc/Kconfig. > To add a new platform with PCI support selectable at > config time, you must change the if expression. This > patch makes

Re: [PATCH 2/2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c [rev2]

2008-06-28 Thread Grant Likely
On Thu, Jun 26, 2008 at 11:07:57AM -0600, John Rigby wrote: > This allows other platforms with the same pci > block like MPC5121 to use it. > > Signed-off-by: John Rigby <[EMAIL PROTECTED]> Acked-by: Grant Likely <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/83xx/Kconfig |2 +- >

Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-28 Thread Grant Likely
On Wed, Jun 18, 2008 at 02:24:46PM -0600, John Rigby wrote: > Updated device tree for MPC5121ADS Really should be more detailed in the commit message. > > Signed-off-by: John Rigby <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc5121ads.dts | 309 - > 1 fil

Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

2008-06-28 Thread Grant Likely
On Thu, Jun 26, 2008 at 09:40:57PM -0600, John Rigby wrote: > On Thu, Jun 26, 2008 at 7:42 PM, David Gibson <[EMAIL PROTECTED]> wrote: > > On Wed, Jun 18, 2008 at 02:24:46PM -0600, John Rigby wrote: > >> [EMAIL PROTECTED] { > >> compatible = "fsl,mpc5121-immr"; > >> +

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Jean Delvare
Hi Jon, Grant, On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: > On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > > On 6/25/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > > > > > i2c->adap = mpc_ops; > > > > - i2c->adap.nr = pdev->id; > > > > i2c_set_ad

Re: [i2c] [PATCH] Convert i2c-mpc from a platform driver to an of_platform one

2008-06-28 Thread Grant Likely
On Sun, Jun 29, 2008 at 08:31:43AM +0200, Jean Delvare wrote: > Hi Jon, Grant, > > On Sat, 28 Jun 2008 22:49:40 -0600, Grant Likely wrote: > > On Sat, Jun 28, 2008 at 10:05:28PM -0400, Jon Smirl wrote: > > > > > > > > The driver was previously using i2c_add_numbered_adapter(), giving MPC > > > >