[PATCH] powerpc/mpc5200: Fix locking on mpc52xx_spi driver

2008-07-26 Thread Grant Likely
From: Grant Likely [EMAIL PROTECTED] Locking was incorrect for the state machine processing since there are conditions where both the work queue and the IRQ can be active. This patch fixes the handling to ensure the spin lock is held whenever the state machine is being processed. Signed-off-by:

Re: [RFC PATCH] of_gpio: implement of_get_gpio_flags()

2008-07-26 Thread Trent Piepho
On Fri, 25 Jul 2008, Anton Vorontsov wrote: The name seems a bit unfortunate though, because one could read the function as it gets gpio flags only (though, we might implement this instead, but this way average driver will end up with parsing gpios = twice). It is kind of a confusing name.

Re: linux-next: kbuild tree build failure

2008-07-26 Thread Sam Ravnborg
On Fri, Jul 25, 2008 at 02:13:30PM +1000, Stephen Rothwell wrote: Hi Sam, On Mon, 7 Jul 2008 18:40:38 +1000 Stephen Rothwell [EMAIL PROTECTED] wrote: Today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/cell/spu_base.c: In function

Re: [PATCH] Memset the kernel copy of rtas args before using

2008-07-26 Thread Sergei Shtylyov
Hello. Nathan Fontenot wrote: Index: linux-2.6.git/arch/powerpc/kernel/rtas.c === --- linux-2.6.git.orig/arch/powerpc/kernel/rtas.c2008-07-22 09:34:03.0 -0500 +++ linux-2.6.git/arch/powerpc/kernel/rtas.c2008-07-25

Re: CONFIG_FRAME_POINTER [was [PATCH] x86: BUILD_IRQ say .text]

2008-07-26 Thread Hugh Dickins
On Sat, 26 Jul 2008, Benjamin Herrenschmidt wrote: On Fri, 2008-07-25 at 19:45 +0100, Hugh Dickins wrote: I've Cc'ed Ben and linuxppc-dev because I wonder if they're aware that several options (I got it from LATENCYTOP, but I think LOCKDEP and FTRACE and some others) are doing a select

ucc_geth_ethtool.c: removed duplicated include

2008-07-26 Thread Huang Weiyi
Removed duplicated include asm/uaccess.h in drivers/net/ucc_geth_ethtool.c. Signed-off-by: Huang Weiyi [EMAIL PROTECTED] --- a/drivers/net/ucc_geth_ethtool.c2008-05-10 08:41:10.0 +0800 +++ b/drivers/net/ucc_geth_ethtool.c2008-05-10 08:41:42.0 +0800 @@ -37,7 +37,6 @@

Re: CONFIG_FRAME_POINTER [was [PATCH] x86: BUILD_IRQ say .text]

2008-07-26 Thread Benjamin Herrenschmidt
On Sat, 2008-07-26 at 12:02 +0100, Hugh Dickins wrote: Hmm, perhaps it is doing sibling calls differently even without the explicit -fno-optimize-sibling-calls (but when I add that option, the vmlinux size does go up another 4400). Sorry, I'm most probably fussing over nothing, and

Re: [PATCH] powerpc/mpc5200: Fix locking on mpc52xx_spi driver

2008-07-26 Thread Daniel Walker
On Sat, 2008-07-26 at 02:24 -0400, Grant Likely wrote: From: Grant Likely [EMAIL PROTECTED] Locking was incorrect for the state machine processing since there are conditions where both the work queue and the IRQ can be active. This patch fixes the handling to ensure the spin lock is held

Re: linux-next: kbuild tree build failure

2008-07-26 Thread Stephen Rothwell
Hi Sam, On Sat, 26 Jul 2008 12:06:32 +0200 Sam Ravnborg [EMAIL PROTECTED] wrote: I removed the offending commits from kbuild-next before I sent the pull request. I will though revisit the issue after -rc1. Thanks again. -- Cheers, Stephen Rothwell[EMAIL PROTECTED]

[PATCH 1/2] [PPC64] add tuning options to Kconfig.cputype

2008-07-26 Thread Marvin
This patch adds CPU selection to Kconfig.cputype. I did my best to make oldconfig happy, but some things just don't work ;-) Maybe more CPUs and help texts can be added, but it should be enough for now. Subject: [PATCH 1/2] [PPC64] add tuning options to Kconfig.cputype ---

[PATCH 0/2] tuning options for PPC64

2008-07-26 Thread Marvin
Hi, this is my second attempt to introduce some tuning options for PPC64. These patches are much less invasive as the previous patchset. Because the power cpus seem to have various features I don't know/understand I didn't touch any feature flags/config options this time, but focused only on

[PATCH 2/2] [PPC64] change powerpc Makefile to use the new tuning options

2008-07-26 Thread Marvin
This patch modifies the Makefile to use the new tuning options. Most of the work is done in Kconfig now, so this looks a little bit more clearly (except the broken altivec hack). Subject: [PATCH 2/2] [PPC64] change powerpc Makefile to use the new tuning options --- arch/powerpc/Makefile |

Re: [RFC,PATCH] scripts/package: add powerpc images to tarball

2008-07-26 Thread Milton Miller
On Jul 25, 2008, at 11:55 PM, Grant Likely wrote: On Thu, Jul 24, 2008 at 9:08 PM, Milton Miller [EMAIL PROTECTED] wrote: Add support for powerpc builds in the buildtar script, to include a few default images. --- RFC: any requests for more/less boot images? .. + for img in zImage

Re: [RFC,PATCH] scripts/package: add powerpc images to tarball

2008-07-26 Thread Grant Likely
On Sat, Jul 26, 2008 at 1:20 PM, Milton Miller [EMAIL PROTECTED] wrote: On Jul 25, 2008, at 11:55 PM, Grant Likely wrote: On Thu, Jul 24, 2008 at 9:08 PM, Milton Miller [EMAIL PROTECTED] wrote: Add support for powerpc builds in the buildtar script, to include a few default images. --- RFC:

[PATCH] powerpc: Fix 8xx build failure

2008-07-26 Thread Kumar Gala
The 'powerpc ioremap_prot' broke 8xx builds: include2/asm/pgtable-ppc32.h:555: error: '_PAGE_WRITETHRU' undeclared (first use in this function) include2/asm/pgtable-ppc32.h:555: error: (Each undeclared identifier is reported only once include2/asm/pgtable-ppc32.h:555: error: for each function

Re: Cleanup for i2c driver changes.

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 09:45:10PM -0400, Sean MacLennan wrote: This patch removes the i2c code which is now obsolete due to the new ibm iic driver walking the device tree for child nodes. There are two other small cleanups that came indirectly from the ad7414 code review. Make sure Tlow is

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 05:34:49PM +0200, Wolfgang Grandegger wrote: Grant Likely wrote: On Fri, Jul 25, 2008 at 5:04 AM, Wolfgang Grandegger [EMAIL PROTECTED] wrote: I was also thinking to just overtake the U-Boot settings if fdt and dfsrr is not defined for the I2C node (instead of the

Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-07-26 Thread Grant Likely
On Thu, Jul 10, 2008 at 02:39:09PM +0200, Wolfram Sang wrote: Hello, today, I was debugging a kernel crash on a board with a MPC5200B using 2.6.26-rc9. I found the following code in drivers/net/fec_mpc52xx.c: static irqreturn_t mpc52xx_fec_interrupt(int irq, void *dev_id) { [...]

Re: [PATCH] of: i2c: improve last resort compatible entry selection

2008-07-26 Thread Grant Likely
On Mon, Jul 14, 2008 at 09:54:37PM +0400, Anton Vorontsov wrote: Currently of_i2c will select first compatible property as a last resort option. This isn't best choice though, because generic compatible entries are listed last, not first. For example, two compatible entries given for the MCU

Re: [PATCH 2/2] leds: Support OpenFirmware led bindings

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 02:01:45PM -0700, Trent Piepho wrote: Add bindings to support LEDs defined as of_platform devices in addition to the existing bindings for platform devices. (adding [EMAIL PROTECTED] to the cc list) New options in Kconfig allow the platform binding code and/or the

Re: [alsa-devel] [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple

2008-07-26 Thread Grant Likely
On Wed, Jul 23, 2008 at 04:14:32PM +0100, Mark Brown wrote: On Wed, Jul 23, 2008 at 10:09:01AM -0400, Jon Smirl wrote: On 7/23/08, Mark Brown [EMAIL PROTECTED] wrote: ...this doesn't just allow a custom machine driver, it requires that something configures at least the machine name.

Re: [PATCH 1/2] leds: make the default trigger name const

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: The default_trigger fields of struct gpio_led and thus struct led_classdev are pretty much always assigned from a string literal, which means the string can't be modified. Which is fine, since there is no reason to modify the

Re: [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple

2008-07-26 Thread Grant Likely
On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote: Allow a custom ASOC machine driver with soc-of-simple Signed-off-by: Jon Smirl [EMAIL PROTECTED] Sorry I didn't respond earlier. OLS kept me pretty distracted. Need a more detailed comment block about how your changing things and

Re: [PATCH v3 5/5] powerpc/mpc5200: Add mpc5200-spi (non-PSC) device driver

2008-07-26 Thread Grant Likely
On Mon, Jul 14, 2008 at 09:21:08AM -0400, Jon Smirl wrote: On 7/12/08, Grant Likely [EMAIL PROTECTED] wrote: From: Grant Likely [EMAIL PROTECTED] Adds support for the dedicated SPI device on the Freescale MPC5200(b) SoC. Can you adjust the existing PSC based SPI driver to use this

Re: [PATCH 1/2] Support internal I2S clock sources on MPC5200

2008-07-26 Thread Grant Likely
On Tue, Jul 22, 2008 at 07:53:49PM -0400, Jon Smirl wrote: Support internal I2S clock sources on MPC5200 Signed-off-by: Jon Smirl [EMAIL PROTECTED] I'll play with this when I get home. In the mean time I've got some comments below. Overall, it looks right to me. g. ---

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-26 Thread Grant Likely
On Fri, Jul 25, 2008 at 11:19:41AM -0500, Timur Tabi wrote: Wolfgang Grandegger wrote: I know but we still need an algorithm for MPC52xx and MPC82xx as well. That's true, but I still think hard-coding values of DFSR and FDR in the device tree is not a good way to do this. I agree, it

Re: [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple

2008-07-26 Thread Jon Smirl
On 7/26/08, Grant Likely [EMAIL PROTECTED] wrote: On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote: Allow a custom ASOC machine driver with soc-of-simple Signed-off-by: Jon Smirl [EMAIL PROTECTED] Sorry I didn't respond earlier. OLS kept me pretty distracted. Need a more

Re: [PATCH 1/2] Support internal I2S clock sources on MPC5200

2008-07-26 Thread Jon Smirl
On 7/26/08, Grant Likely [EMAIL PROTECTED] wrote: On Tue, Jul 22, 2008 at 07:53:49PM -0400, Jon Smirl wrote: Support internal I2S clock sources on MPC5200 Signed-off-by: Jon Smirl [EMAIL PROTECTED] I'll play with this when I get home. In the mean time I've got some comments below.

Re: [PATCH] of: i2c: improve last resort compatible entry selection

2008-07-26 Thread Jon Smirl
On 7/26/08, Grant Likely [EMAIL PROTECTED] wrote: On Mon, Jul 14, 2008 at 09:54:37PM +0400, Anton Vorontsov wrote: Currently of_i2c will select first compatible property as a last resort option. This isn't best choice though, because generic compatible entries are listed last, not first.

[PATCH 1/6] kill useless SMT code in prom_hold_cpus

2008-07-26 Thread Nathan Lynch
I think this code that counts SMT threads and compares against NR_CPUS is an artifact of pre-powerpc-merge ppc64. We care about starting only primary threads in the OF client code. Signed-off-by: Nathan Lynch [EMAIL PROTECTED] --- arch/powerpc/kernel/prom_init.c | 39

[PATCH 0/6] powerpc topology updates

2008-07-26 Thread Nathan Lynch
This series consists of a couple of cleanups and a few feature additions, all of which are more or less related to system topology (threads, cores, caches, sysfs...) These are independent of each other except for 4 and 5 (core sibling and core id info). I'd say the highlights are the last three

[PATCH 2/6] register_cpu_online should be __cpuinit

2008-07-26 Thread Nathan Lynch
It is called only in cpu online paths. (caught by CONFIG_DEBUG_SECTION_MISMATCH=y) Signed-off-by: Nathan Lynch [EMAIL PROTECTED] --- arch/powerpc/kernel/sysfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c

[PATCH 4/6] make core sibling information available to userspace

2008-07-26 Thread Nathan Lynch
Implement the notion of core siblings for powerpc. This makes /sys/devices/system/cpu/cpu*/topology/core_siblings present sensible values, indicating online CPUs which share an L2 cache. Signed-off-by: Nathan Lynch [EMAIL PROTECTED] --- arch/powerpc/kernel/smp.c | 71

[PATCH 3/6] Update cpu_sibling_maps dynamically

2008-07-26 Thread Nathan Lynch
Rather doing one initialization pass over all the per-cpu cpu_sibling_maps at boot, update the maps at cpu online/offline time. This is a behavior change -- the thread_siblings attribute now reflects only online siblings, whereas it would display offline siblings before. The new behavior matches

[PATCH 6/6] show processor cache information in sysfs

2008-07-26 Thread Nathan Lynch
Collect cache information from the OF device tree and display it in the cpu hierarchy in sysfs. This is intended to be compatible at the userspace level with x86's implementation[1], hence some of the funny attribute names. The arrangement of cache info is not immediately intuitive, but (again)

[PATCH 5/6] make core id information available to userspace

2008-07-26 Thread Nathan Lynch
Existing Open Firmware practice is to report each processor core as a separate node in the device tree. Report the value of the reg OF property corresponding to a logical CPU's device node as the core_id attribute in /sys/devices/system/cpu/cpu*/topology/core_id. Signed-off-by: Nathan Lynch

Re: [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple

2008-07-26 Thread Grant Likely
On Sun, Jul 27, 2008 at 12:44 AM, Jon Smirl [EMAIL PROTECTED] wrote: On 7/26/08, Grant Likely [EMAIL PROTECTED] wrote: On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote: Allow a custom ASOC machine driver with soc-of-simple Signed-off-by: Jon Smirl [EMAIL PROTECTED] diff

Re: [PATCH] of: i2c: improve last resort compatible entry selection

2008-07-26 Thread Grant Likely
On Sun, Jul 27, 2008 at 1:05 AM, Jon Smirl [EMAIL PROTECTED] wrote: On 7/26/08, Grant Likely [EMAIL PROTECTED] wrote: On Mon, Jul 14, 2008 at 09:54:37PM +0400, Anton Vorontsov wrote: Currently of_i2c will select first compatible property as a last resort option. This isn't best choice

Re: [PATCH] powerpc: Use new printk extension %pS to print symbols on oops

2008-07-26 Thread David Woodhouse
On Mon, 2008-07-07 at 10:08 -0700, Linus Torvalds wrote: On Mon, 7 Jul 2008, Benjamin Herrenschmidt wrote: This changes the oops and backtrace code to use the new %pS printk extension to print out symbols rather than manually calling print_symbol. Ok, I ended up committing the suppor