Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Grant Likely
On Wed, Aug 13, 2008 at 07:06:27AM +0100, Tim Yamin wrote: > On Wed, Aug 13, 2008 at 7:02 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > > While on this topic; have you had a chance to address the comments you > > received on v2 of your patch? I'm keen to get your change merged in, > > but there ar

Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Tim Yamin
On Wed, Aug 13, 2008 at 7:02 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > While on this topic; have you had a chance to address the comments you > received on v2 of your patch? I'm keen to get your change merged in, > but there are a few more things that need to be sorted out. I'm still trying t

Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Grant Likely
On Tue, Aug 12, 2008 at 11:57 PM, Tim Yamin <[EMAIL PROTECTED]> wrote: > On Tue, Aug 12, 2008 at 6:30 PM, Daniel Schnell > <[EMAIL PROTECTED]> wrote: >> Hi Tim, >> >> Continuing the discussion on the mailing list ... >> >> Looking at the original patch I don't undestand why you had to duplicate >>

Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Tim Yamin
On Tue, Aug 12, 2008 at 6:30 PM, Daniel Schnell <[EMAIL PROTECTED]> wrote: > Hi Tim, > > Continuing the discussion on the mailing list ... > > Looking at the original patch I don't undestand why you had to duplicate > the bestcomm data structures and functions. The only apparent difference > is tha

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-12 Thread Grant Likely
On Thu, Aug 07, 2008 at 04:12:54PM +1000, David Gibson wrote: > On Wed, Aug 06, 2008 at 11:46:47AM -0500, Timur Tabi wrote: > > On Wed, Aug 6, 2008 at 1:02 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > of_lookup_stdout() is useful for figuring

Re: [PATCH 4/5] Relocation support

2008-08-12 Thread Paul Mackerras
Mohan Kumar M writes: > Add relocatable kernel support like avoiding copying the vmlinux > image to compile address, adding relocation delta to the absolute > symbol references etc. ld does not provide relocation entries for > .got section, and the user space relocation extraction program > can no

Re: [PATCH 3/5] Apply relocation

2008-08-12 Thread Paul Mackerras
Mohan Kumar M writes: > This code is a wrapper around regular kernel. This checks whether the > kernel is loaded at 32MB, if its not loaded at 32MB, its treated as a > regular kernel and the control is given to the kernel immediately. If > the kernel is loaded at 32MB, it applies relocation delta

Re: [PATCH 5121 pci 3/3] powerpc: pci: 5121: Hide pci bridge.

2008-08-12 Thread Grant Likely
On Thu, Aug 07, 2008 at 11:36:27AM -0600, John Rigby wrote: > The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER > while other freescale host bridges have class set to > PCI_CLASS_PROCESSOR_POWERPC. > > This patch makes fixup_hide_host_resource_fsl match > PCI_CLASS_BRIDGE_OTHER in

Re: [PATCH 5121 pci 2/3] powerpc: 5121: Add PCI support.

2008-08-12 Thread Grant Likely
On Thu, Aug 07, 2008 at 11:36:26AM -0600, John Rigby wrote: > Uses mpc83xx_add_bridge in fsl_pci.c > > Adds second register tuple to pci node register property > as previously done for 83xx device trees in a previous patch. > > Signed-off-by: John Rigby <[EMAIL PROTECTED]> Looks good to me. Ack

Re: [PATCH 5121 pci 1/3] powerpc: 83xx: pci: Remove need for get_immrbase from mpc83xx_add_bridge.

2008-08-12 Thread Grant Likely
On Thu, Aug 07, 2008 at 11:36:25AM -0600, John Rigby wrote: > Modify mpc83xx_add_bridge to get config space register base address from the > device > tree instead of immr + hardcoded offset. > > 83xx pci nodes have these changes: > register properties now contain two address length tuples: >

[RFC/PATCH v2] powerpc: add ioremap_early() function for mapping IO regions before MMU_init()

2008-08-12 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> ioremap_early() is useful for things like mapping SoC internally memory mapped register and early text because it allows mappings to devices to be setup early in the boot process where they are needed, and the mappings persist after the MMU is configured. Wi

[PATCH 0/5] Relocatable 64-bit kernel using linker PIE support

2008-08-12 Thread Paul Mackerras
The following series of patches implement support for a relocatable kernel by building it as a position-independent executable (PIE). When the linker is given the -pie flag, it creates an executable that contains dynamic relocations which can be used to relocate the image at boot time for any desir

[PATCH 1/5] powerpc: Move interrupt handler code to the beginning of head_64.S

2008-08-12 Thread Paul Mackerras
This rearranges head_64.S so that we have all the first-level exception prologs together starting at 0x100, followed by all the second-level handlers that are invoked from the first-level prologs, followed by other code. This doesn't make any functional change but will make following changes for r

[PATCH 3/5] powerpc: Only use LOAD_REG_IMMEDIATE for constants on 64-bit

2008-08-12 Thread Paul Mackerras
Using LOAD_REG_IMMEDIATE to get the address of kernel symbols generates 5 instructions where LOAD_REG_ADDR can do it in one, and will generate R_PPC64_ADDR16_* relocations in the output when we get to making the kernel as a position-independent executable, which we'd rather not have to handle. Thi

[PATCH 5/5] powerpc: Run relocatable kernel where it's loaded

2008-08-12 Thread Paul Mackerras
This demonstrates that the relocatable kernel doesn't have to run at real address 0. It only copies the interrupt vectors down and leaves the rest of the kernel where it was loaded, and runs it there. This is mostly just a proof of concept, since it doesn't do anything to ensure that the kernel b

[PATCH 2/5] powerpc: Make it possible to move the interrupt handlers away from the kernel

2008-08-12 Thread Paul Mackerras
This changes the way that the exception prologs transfer control to the handlers in 64-bit kernels with the aim of making it possible to have the prologs separate from the main body of the kernel. Now, instead of computing the address of the handler by taking the top 32 bits of the paca address (t

[PATCH 4/5] powerpc: Make the 64-bit kernel as a position-independent executable

2008-08-12 Thread Paul Mackerras
This implements CONFIG_RELOCATABLE for 64-bit by making the kernel as a position-independent executable (PIE). This involves processing the dynamic relocations in the image in the early stages of booting, even if the kernel is being run at the address it is linked at, since the linker does not nec

[PATCH] remove redundant sysfs_remove_file calls for cache info

2008-08-12 Thread Nathan Lynch
When removing a directory, the sysfs core takes care of removing files in the directory (see sysfs_remove_dir()). So when we are about to delete a kobject (and thus cause its sysfs directory to be removed), we don't have to explicitly remove the files attached to it, although it's harmless to do s

Re: [PATCH] powerpc: some vmlinux files that should be ignored

2008-08-12 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > A couple of vmlinux output files that should be ignored: vmlinux.strip > and vmlinux.lds. > > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > --- > diff --git a/.gitignore b/.gitignore This will need to goto LKML. Mikey > index 869e1a3..f7e924a 10

[PATCH] gianfar: Call gfar_halt_nodisable() from gfar_halt().

2008-08-12 Thread Scott Wood
gfar_halt() was factored out into halting and disabling by commit d87eb12785c14de1586e3bad86ca2c0991300339, as the suspend() method only wants to do the former. However, the call to gfar_halt_nodisable() from gfar_halt() apparently got lost during the patch respin process. This adds it back. Sig

Re: [RFC/PATCH 1/3] powerpc: add ioremap_bat() function for setting up BAT translated IO regions.

2008-08-12 Thread Grant Likely
On Thu, Aug 07, 2008 at 07:04:04PM -0500, Kumar Gala wrote: >> mem_init_done isn't a good indication. We can do page tables when it's >> 0, we would have to use a separate mem_preinit_done or something :-) >> >> I initially also though about a flag to ioremap_prot to be honest. But >> it does obfus

[PATCH 1/1] powerpc: Fix vio_bus_probe oops on probe error

2008-08-12 Thread Brian King
When CMO is enabled and booted on a non CMO system and the VIO device's probe function fails, an oops can result since vio_cmo_bus_remove is called when it should not. cpu 0x0: Vector: 300 (Data Access) at [ce13b3d0] pc: c0020d34: .vio_cmo_bus_remove+0xc0/0x1f4 lr: c00

Re: [PATCH 5/5 try2] ib/ehca: discard double CQE for one WR

2008-08-12 Thread Roland Dreier
thanks, applied all 5. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

RE: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Daniel Schnell
Hi Tim, Continuing the discussion on the mailing list ... Looking at the original patch I don't undestand why you had to duplicate the bestcomm data structures and functions. The only apparent difference is that you have a minimal data length of 2 bytes instead of 1. Does this make any differenc

[PATCH 2/2] rtc: bunch of drivers: fix 'no irq' case handing

2008-08-12 Thread Anton Vorontsov
This patch fixes bunch of irq checking misuses. Most drivers were getting irq via platform_get_irq(), which returns -ENXIO or r->start. Platforms may specify r->start = 0 to emphasize 'no irq' case, and drivers should handle this correctly. rtc-cmos.c is special. It is using PNP and platform bindi

[PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-12 Thread Anton Vorontsov
On a PowerPC board with ds1374 RTC I'm getting this error while RTC tries to probe: rtc-ds1374 0-0068: unable to request IRQ This happens because I2C probing code (drivers/of/of_i2c.c) is specifying IRQ0 for 'no irq' case, which is correct. The driver handles this incorrectly, though. This patch

Re: Does Dev Tree WORK with [EMAIL PROTECTED] <#address/size> = <2/1>

2008-08-12 Thread Becky Bruce
On Aug 12, 2008, at 10:14 AM, Morrison, Tom wrote: Thank you Becky (and Kumar) for all the informationand help! To answer your questions, yes, we are using 4GB++ of memory (and plan more in the near future). But, for the initial bring up, I reduced the memory to 2Gig. Further, I have modif

RE: Does Dev Tree WORK with [EMAIL PROTECTED] <#address/size> = <2/1>

2008-08-12 Thread Morrison, Tom
Thank you Becky (and Kumar) for all the informationand help! To answer your questions, yes, we are using 4GB++ of memory (and plan more in the near future). But, for the initial bring up, I reduced the memory to 2Gig. Further, I have modified u-boot to NOT modify the memory reg properties (se

Re: [PATCH] pata_of_platform: fix no irq handling

2008-08-12 Thread Anton Vorontsov
On Tue, Aug 12, 2008 at 06:18:42PM +0400, Sergei Shtylyov wrote: > Anton Vorontsov wrote: > > 1. IDE status read does not work. (But am I understand correctly > that IDE works well if IRQ is unspecified? Then this is hardly > an issue.) > 2. IDE interrupt comes when it should no

Re: [PATCH] pata_of_platform: fix no irq handling

2008-08-12 Thread Sergei Shtylyov
Anton Vorontsov wrote: 1. IDE status read does not work. (But am I understand correctly that IDE works well if IRQ is unspecified? Then this is hardly an issue.) 2. IDE interrupt comes when it should not. I'd recommend to use oscilloscope to find out what is happening there, that is, if

Re: [PATCH] pata_of_platform: fix no irq handling

2008-08-12 Thread Stefan Roese
On Tuesday 12 August 2008, Anton Vorontsov wrote: > > > Another possibility is that you got the wrong interrupt number > > > in the device-tree... > > > > > > Ben. > > > > The platform is the AMCC Sequoia board. We've built a little adapter to > > connect a compact flash card to the processor bus.

Re: [PATCH] pata_of_platform: fix no irq handling

2008-08-12 Thread Anton Vorontsov
On Tue, Aug 12, 2008 at 10:00:40AM -0400, Steven A. Falco wrote: > Benjamin Herrenschmidt wrote: > > > >> 1. IDE status read does not work. (But am I understand correctly > >>that IDE works well if IRQ is unspecified? Then this is hardly > >>an issue.) > >> 2. IDE interrupt comes when it

Re: [RFC 1/3] add support for exporting symbols from .S files

2008-08-12 Thread Arnd Bergmann
This makes it possible to export symbols from assembly files, instead of having to export them through an extra ksyms.c file. Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- On Tuesday 12 August 2008, Stephen Rothwell wrote: > This won't be portable across architectures as .align is sometim

Re: [PATCH] pata_of_platform: fix no irq handling

2008-08-12 Thread Steven A. Falco
Benjamin Herrenschmidt wrote: > >> 1. IDE status read does not work. (But am I understand correctly >>that IDE works well if IRQ is unspecified? Then this is hardly >>an issue.) >> 2. IDE interrupt comes when it should not. I'd recommend to use >>oscilloscope to find out what is happ

[PATCH 2/5 try2] ib/ehca: rename goto label

2008-08-12 Thread Alexander Schmidt
Rename the "poll_cq_one_read_cqe" goto label to what it actually does, "repoll". Signed-off-by: Alexander Schmidt <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_reqs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- infiniband.git.orig/drivers/infiniband/hw/ehca/ehca_

[PATCH 5/5 try2] ib/ehca: discard double CQE for one WR

2008-08-12 Thread Alexander Schmidt
Under rare circumstances, the ehca hardware might erroneously generate two CQEs for the same WQE, which is not compliant to the IB spec and will cause unpredictable errors like memory being freed twice. To avoid this problem, the driver needs to detect the second CQE and discard it. For this purpo

[PATCH 3/5 try2] ib/ehca: repoll on invalid opcode

2008-08-12 Thread Alexander Schmidt
When the ehca driver detects an invalid opcode in a CQE, it currently passes the CQE to the application and returns with success. This patch changes the CQE handling to discard CQEs with invalid opcodes and to continue reading the next CQE from the CQ. Signed-off-by: Alexander Schmidt <[EMAIL PROT

[PATCH 4/5 try2] ib/ehca: check idr_find() return value

2008-08-12 Thread Alexander Schmidt
The idr_find() function may fail when trying to get the QP that is associated with a CQE, e.g. when a QP has been destroyed between the generation of a CQE and the poll request for it. In consequence, the return value of idr_find() must be checked and the CQE must be discarded when the QP cannot be

[PATCH 0/5 try2] ib/ehca: Fix stability issues

2008-08-12 Thread Alexander Schmidt
Hi Roland, Sorry, the first set was mangled because of a broken mailer, so here it is again, double checked... the following patchset contains four small fixes and one bigger patch (5/5) for addressing some ehca issues we found during cluster test. [1/5] update qp_state on cached modify_qp() [2/

[PATCH 1/5 try2] ib/ehca: update qp_state on cached modify_qp()

2008-08-12 Thread Alexander Schmidt
Since the introduction of the port auto-detect mode for ehca, calls to modify_qp() may be cached in the device driver when the ports are not activated yet. When a modify_qp() call is cached, the qp state remains untouched until the port is activated, which will leave the qp in the reset state. In t

[PATCH 4/5] ib/ehca: check idr_find() return value

2008-08-12 Thread Alexander Schmidt
The idr_find() function may fail when trying to get the QP that is associated with a CQE, e.g. when a QP has been destroyed between the generation of a CQE and the poll request for it. In consequence, the return value of idr_find() must be checked and the CQE must be discarded when the QP cannot be

[PATCH 3/5] ib/ehca: repoll on invalid opcode

2008-08-12 Thread Alexander Schmidt
When the ehca driver detects an invalid opcode in a CQE, it currently passes the CQE to the application and returns with success. This patch changes the CQE handling to discard CQEs with invalid opcodes and to continue reading the next CQE from the CQ. Signed-off-by: Alexander Schmidt <[EMAIL PROT

[PATCH 5/5] ib/ehca: discard double CQE for one WR

2008-08-12 Thread Alexander Schmidt
Under rare circumstances, the ehca hardware might erroneously generate two CQEs for the same WQE, which is not compliant to the IB spec and will cause unpredictable errors like memory being freed twice. To avoid this problem, the driver needs to detect the second CQE and discard it. For this purpo

[PATCH 2/5] ib/ehca: rename goto label

2008-08-12 Thread Alexander Schmidt
Rename the "poll_cq_one_read_cqe" goto label to what it actually does, "repoll". Signed-off-by: Alexander Schmidt <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_reqs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- infiniband.git.orig/drivers/infiniband/hw/ehca/ehca_

[PATCH 1/5] ib/ehca: update qp_state on cached modify_qp()

2008-08-12 Thread Alexander Schmidt
Since the introduction of the port auto-detect mode for ehca, calls to modify_qp() may be cached in the device driver when the ports are not activated yet. When a modify_qp() call is cached, the qp state remains untouched until the port is activated, which will leave the qp in the reset state. In t

[PATCH 0/5] ib/ehca: Fix stability issues

2008-08-12 Thread Alexander Schmidt
Hi Roland, the following patchset contains four small fixes and one bigger patch (5/5) for addressing some ehca issues we found during cluster test. [1/5] update qp_state on cached modify_qp() [2/5] rename goto label in ehca_poll_cq_one() [3/5] repoll on invalid opcode instead of returning succes

RE: Does Dev Tree WORK with [EMAIL PROTECTED] <#address/size> = <2/1>

2008-08-12 Thread Morrison, Tom
Thank you...I will take that recommendation... I will try that and get some results before I complete my response to Becky this morning... T -Original Message- From: Kumar Gala [mailto:[EMAIL PROTECTED] Sent: Tuesday, August 12, 2008 8:42 AM To: Morrison, Tom Cc: ppc-dev list; Becky

Re: Does Dev Tree WORK with [EMAIL PROTECTED] <#address/size> = <2/1>

2008-08-12 Thread Kumar Gala
I recommend you look at <2/2> instead of <2/1>. <2/1> is just a degenerate case and it doesn't really get you much value. - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 5/5] Relocation support for kdump kernel

2008-08-12 Thread Mohan Kumar M
Relocation support for kdump kernel Add relocation kernel support for kdump kernel path. Signed-off-by: Mohan Kumar M <[EMAIL PROTECTED]> --- arch/powerpc/kernel/crash_dump.c | 19 +++ arch/powerpc/kernel/iommu.c|7 +-- arch/powerpc/kernel/machine_kexe

[PATCH 4/5] Relocation support

2008-08-12 Thread Mohan Kumar M
Relocation support Add relocatable kernel support like avoiding copying the vmlinux image to compile address, adding relocation delta to the absolute symbol references etc. ld does not provide relocation entries for .got section, and the user space relocation extraction program can not process @go

[PATCH 3/5] Apply relocation

2008-08-12 Thread Mohan Kumar M
Apply relocation This code is a wrapper around regular kernel. This checks whether the kernel is loaded at 32MB, if its not loaded at 32MB, its treated as a regular kernel and the control is given to the kernel immediately. If the kernel is loaded at 32MB, it applies relocation delta to each offse

[PATCH 2/5] Build files needed for relocation

2008-08-12 Thread Mohan Kumar M
Build files needed for relocation This patch builds vmlinux file with relocation sections and contents so that relocs user space program can extract the required relocation offsets. This packs final relocatable vmlinux kernel as following: earlier part of relocation apply code, vmlinux, rest of re

[PATCH 2/5] Build files needed for relocation

2008-08-12 Thread Mohan Kumar M
As my scripts did wrong commit, I have posted wrong patches. I am posting the patches 3,4 and 5 again. Sorry for the inconvenience. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: Fix loss of vdso on fork on 32bit

2008-08-12 Thread Benjamin Herrenschmidt
When we fork, init_new_context() improperly resets the vdso_base of the new context to 0. That means that the new process loses access to the vdso for signal trampolines. The initialization should be unnecessary anyway as the context on a fresh mm should be 0 in the first place and binfmt_elf will