Re: [PATCH] powerpc: tiny memcpy_(to|from)io optimisation

2009-05-28 Thread Joakim Tjernlund
> Am 28.05.09 18:13 schrieb(en) Joakim Tjernlund: > > hmm, these do look a bit unoptimal anyway. Any reason not to write > > them something like below(written by me for uClibc long time ago). > > You will have to add eieio()/sync > > No (and I wasn't aware of the PPC pre-inc vs. post-inc stuff) - I

[PATCH 3/3] powerpc/ftrace: Use PPC_INST_NOP directly

2009-05-28 Thread Michael Ellerman
There's no need to wrap PPC_INST_NOP in a static inline. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/ftrace.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 8620ecb..f4ad248 100644 ---

[PATCH 2/3] powerpc/ftrace: Remove unused macros

2009-05-28 Thread Michael Ellerman
These macros were used in the original port, but since commit e4486fe316 (ftrace, use probe_kernel API to modify code) they are unused. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/ftrace.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/ke

[PATCH 1/3] powerpc/ftrace: Use ppc_function_entry() instead of GET_ADDR

2009-05-28 Thread Michael Ellerman
Use ppc_function_entry() from code-patching.h. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/ftrace.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 70e2a73..8585217 100644 --- a/arch

Re: [PATCH] powerpc ptrace block-step

2009-05-28 Thread Benjamin Herrenschmidt
On Wed, 2009-04-01 at 14:59 -0700, Roland McGrath wrote: > Maynard asked about user_enable_block_step() support on powerpc. > This is the old patch I've posted before. I haven't even tried > to compile it lately, but it rebased cleanly. > > AFAIK the only reason this didn't go in several months a

Re: [Patch 4/6] Modify process and processor handling code to recognise hardware debug registers

2009-05-28 Thread David Gibson
On Mon, May 25, 2009 at 06:46:50AM +0530, K.Prasad wrote: > Modify process handling code to recognise hardware debug registers during copy > and flush operations. Introduce a new TIF_DEBUG task flag to indicate a > process's use of debug register. Load the debug register values into a > new CPU dur

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-28 Thread David Gibson
On Mon, May 25, 2009 at 06:45:22AM +0530, K.Prasad wrote: > Introduce PPC64 implementation for the generic hardware breakpoint interfaces > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the > Makefile. [snip] > +/* Store the kernel-space breakpoint address value */ > +s

Re: 8544 external interrupt configuration problems

2009-05-28 Thread Nancy Isaac
Thank you for your response. My responses below. On Thu, May 28, 2009 at 1:02 PM, Scott Wood wrote: > On Thu, May 28, 2009 at 12:05:52PM -0700, Nancy Isaac wrote: > > My device tree has the following entry for my fpga: > > > > cpucp...@f000{ > > compatible = "MPC8544

Re: [Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-05-28 Thread David Gibson
On Mon, May 25, 2009 at 06:44:23AM +0530, K.Prasad wrote: > Prepare the PowerPC code for HW Breakpoint infrastructure patches by including > relevant constant definitions and function declarations. > > Signed-off-by: K.Prasad > --- > arch/powerpc/include/asm/hw_breakpoint.h | 57 > +++

Fwd: serial8250: too much work

2009-05-28 Thread Alemao
Im facing some problems with serial, getting flooded with this message: --- serial8250: too much work for irq16 --- Something I notice, in my .dts I have the following lines: serial0: ser...@4500, interrupts = <9  0x8> serial1: ser...@4600, interrupts = <10 0x8> spi:     s...@7000,     interr

Re: MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error

2009-05-28 Thread Daniel Ng
On Thu, May 28, 2009 at 10:33 PM, Wolfram Sang wrote: >> this is an example of how a simple 8313 Periodic Interval Timer (PIT) kernel >> driver >> registers for the PIT IRQ (Interrupt ID 65) >> >> #define PIT_IRQ 65 >> >> virq = irq_create_mapping(NULL, PIT_IRQ); >> set_irq_type(virq, IRQ

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
Peter Korsgaard wrote: "Esben" == Esben Haabendal writes: Hi, Esben> It's strange, that line looks perfectly fine when I check the Esben> mail in my GMail inbox and the outbox from the account I sent Esben> it from. Well, it is here and in the archive: http://ozlabs.org/piper

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
> "Esben" == Esben Haabendal writes: Hi, Esben> It's strange, that line looks perfectly fine when I check the Esben> mail in my GMail inbox and the outbox from the account I sent Esben> it from. Well, it is here and in the archive: http://ozlabs.org/pipermail/linuxppc-dev/2009-May/072274

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
>  Esben> I've checked both my copy in my "Sent" folder and the copy >  Esben> received from the list, and I cannot see any "line break" >  Esben> breakage of the patch. > > I guess Wolfram referred to the context line which was clearly word wrapped: > > @@ -456,17 +456,22 @@ static int mpc_xfer(st

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
> "Esben" == Esben Haabendal writes: Hi, >> I wanted to test it, but it does not apply due to line breaks (check >> @@-line). Also, I don't really have the time to dig into the topic, so I >> would only test it and give a tested-by-tag if it doesn't break anything >> here. I think Joakim

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
On Thu, May 28, 2009 at 9:31 PM, Grant Likely wrote: > On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote: >>> This fixes MAL (arbitration lost) bug caused by illegal use of >>> RSTA (repeated START) after STOP condition generated afte

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Esben Haabendal
On Thu, May 28, 2009 at 7:17 PM, Wolfram Sang wrote: >> > Any blockers to get this accepted? >> >> It would be nice to get an ack from someone who can actually test >> the driver before getting this merged. > > I wanted to test it, but it does not apply due to line breaks (check > @@-line). Also,

Re: 8544 external interrupt configuration problems

2009-05-28 Thread Scott Wood
On Thu, May 28, 2009 at 12:05:52PM -0700, Nancy Isaac wrote: > My device tree has the following entry for my fpga: > > cpucp...@f000{ > compatible = "MPC8544DS"; > device_type = "CpuCpld"; > reg = ; >

Re: [PATCH] powerpc: tiny memcpy_(to|from)io optimisation

2009-05-28 Thread Albrecht Dreß
Am 28.05.09 18:13 schrieb(en) Joakim Tjernlund: hmm, these do look a bit unoptimal anyway. Any reason not to write them something like below(written by me for uClibc long time ago). You will have to add eieio()/sync No (and I wasn't aware of the PPC pre-inc vs. post-inc stuff) - I just stu

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Grant Likely
On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: > On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > wrote: >> This fixes MAL (arbitration lost) bug caused by illegal use of >> RSTA (repeated START) after STOP condition generated after last byte >> of reads. With this patch, it is possib

[PATCH] fsldma: do not clear bandwidth control bits on the 83xx controller

2009-05-28 Thread Ira Snyder
The 83xx controller does not support the external pause feature. The bit in the mode register that controls external pause on the 85xx controller happens to be part of the bandwidth control settings for the 83xx controller. This patch fixes the driver so that it only clears the external pause bit

[PATCH] fsldma: enable external start for the 83xx controller

2009-05-28 Thread Ira Snyder
The 83xx controller has external start capability, but lacks external pause capability. Hook up the external start function pointer for the 83xx controller. Signed-off-by: Ira W. Snyder --- Though there is no way to enable external start in the mainline driver, the DMA_SLAVE patch I posted last

8544 external interrupt configuration problems

2009-05-28 Thread Nancy Isaac
Hi, I have a custom board that's using powerpc 8544. I am trying to setup the external interrupts using the device tree and I am having no luck getting the interrupt. I think my problem is that I don't have the hwirq to virq mapping correctly. We are using the freescale 8544ds as our base. We ha

Re: [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika

2009-05-28 Thread Jon Smirl
On Thu, May 28, 2009 at 10:00 AM, Peter Korsgaard wrote: >> "Jon" == Jon Smirl writes: > > Hi, > >  Jon> Fabric bindings for STAC9766 AC97 codec on the Efika. >  Jon> Signed-off-by: Jon Smirl >  Jon> --- >  Jon>  sound/soc/fsl/Kconfig              |    8 +++ >  Jon>  sound/soc/fsl/Makefile  

Kernel bug in 2.6.23...was: RE: How to debug a hung multi-core system....

2009-05-28 Thread Morrison, Tom
Kumar, To follow up on our postings from late last week... (which I was expecting a response (but never got) from you)... - We (well, mostly a very bright engineer who was very persistent) have(has) found the origin of how the kernel TLB got corrupted. We tracked down the problem to a prog

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Joakim Tjernlund
Wolfram Sang wrote on 28/05/2009 19:17:26: > > > > Any blockers to get this accepted? > > > > It would be nice to get an ack from someone who can actually test > > the driver before getting this merged. > > I wanted to test it, but it does not apply due to line breaks (check > @@-line). Also, I do

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Wolfram Sang
> > Any blockers to get this accepted? > > It would be nice to get an ack from someone who can actually test > the driver before getting this merged. I wanted to test it, but it does not apply due to line breaks (check @@-line). Also, I don't really have the time to dig into the topic, so I would

Re: [PATCH] powerpc: tiny memcpy_(to|from)io optimisation

2009-05-28 Thread Joakim Tjernlund
> > This trivial patch changes memcpy_(to|from)io as to transfer as many > 32-bit words as possible in 32-bit accesses (in the current solution, > the last 32-bit word was transferred as 4 byte accesses). > > Signed-off-by: Albrecht Dreß > --- > > diff -urpN -X linux-2.6.29.1.orig/Documentation/d

Re: [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika

2009-05-28 Thread Peter Korsgaard
> "Jon" == Jon Smirl writes: Hi, Jon> Fabric bindings for STAC9766 AC97 codec on the Efika. Jon> Signed-off-by: Jon Smirl Jon> --- Jon> sound/soc/fsl/Kconfig |8 +++ Jon> sound/soc/fsl/Makefile |1 Jon> sound/soc/fsl/efika-audio-fabric.c | 95

[PATCH 3/4] net/ucc_geth: Add SGMII support for UEC GETH driver Signed-off-by: Haiying Wang

2009-05-28 Thread Haiying Wang
--- arch/powerpc/include/asm/qe.h |2 + drivers/net/ucc_geth.c| 79 - drivers/net/ucc_geth.h| 28 ++- 3 files changed, 107 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/include/asm/qe.h b/arch/powerpc/include/as

[PATCH 1/4] net/phy/marvell: update m88e1111 support for SGMII mode

2009-05-28 Thread Haiying Wang
Disable fiber/copper auto selection for Marvell m88e SGMII support. Signed-off-by: Haiying Wang --- drivers/net/phy/marvell.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 7a3ec9d..dd6f54d 100644 --- a/dri

[PATCH 4/4] MPC85xx: Add UCC6 and UCC8 nodes in SGMII mode for MPC8569MDS

2009-05-28 Thread Haiying Wang
Signed-off-by: Haiying Wang --- arch/powerpc/boot/dts/mpc8569mds.dts | 63 ++ 1 files changed, 63 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts index 39c2927..4e95abd 100644 --- a/arch/pow

[PATCH 2/4] fsl_pq_mido: Set the first UCC as the mii management interface master

2009-05-28 Thread Haiying Wang
Current code makes the UCC whose register range includes the current mdio register to be the MII managemnt interface master of the QE. If there is more than one mdio bus for QE, the UCC of the last mdio bus will be the MII management interface master which will make the primary mdio bus working unp

Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

2009-05-28 Thread Kumar Gala
On May 28, 2009, at 1:11 AM, Benjamin Herrenschmidt wrote: On Wed, 2009-05-27 at 23:42 -0500, Kumar Gala wrote: Ben, Any comments on this.. need a decision so we can have patches ready for .31. Clamping the DMA mask is even worse than the additional indirection for us. We have valid scena

Re: MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error

2009-05-28 Thread Wolfram Sang
> this is an example of how a simple 8313 Periodic Interval Timer (PIT) kernel > driver > registers for the PIT IRQ (Interrupt ID 65) > > #define PIT_IRQ 65 > > virq = irq_create_mapping(NULL, PIT_IRQ); > set_irq_type(virq, IRQ_TYPE_LEVEL_LOW); > > if(request_irq(virq, (irq_handler_t)t

Re: MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error

2009-05-28 Thread Norbert van Bolhuis
Hi Daniel, "Ethos" driver... hmm. sounds familiar! (good to hear that it is still used in active development) About your question. Since almost 2 years (kernel 2.6.22 from july 2007) the rule is that you can't directly map a hardware irq number because the powerpc kernel keeps a mapping between

MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- "no_irq_chip" error

2009-05-28 Thread Daniel Ng
Hi, I'm attempting to port our Ethos HDLC driver from 2.6.14 to 2.6.27, on a MPC8272-based platform. So far, the kernel crashes when the driver tries to open (see below). It seems that the interrupt handler fails to register, with the following condition in setup_irq() in manage.c: desc->chip =