Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

2009-06-15 Thread Takashi Iwai
At Mon, 15 Jun 2009 15:51:03 +1000, Benjamin Herrenschmidt wrote: On Mon, 2009-06-15 at 07:43 +0200, Takashi Iwai wrote: The alsa part also already reached to the upstream, so we have to give revert patches if needed. But, in the case of sound bits, I think they can remain there as they

Re: [PATCH 24/33] usb/ps3: Add missing annotations

2009-06-15 Thread Benjamin Herrenschmidt
On Wed, 2009-06-10 at 16:38 +0200, Geert Uytterhoeven wrote: probe functions should be __devinit initialization functions should be __init Please send to USB maintainers or get an ack from them. Cheers, Ben. Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-15 Thread David Gibson
On Wed, Jun 10, 2009 at 12:13:49PM +0530, K.Prasad wrote: On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: Hi David, Sorry for the delay in response below. In the meanwhile, I discovered an issue in detecting

Re: [BUILD FAILURE 02/04] Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o]

2009-06-15 Thread Subrata Modak
On Fri, 2009-06-12 at 15:05 +0530, Subrata Modak wrote: On Tue, 2009-06-09 at 17:38 -0700, David Brownell wrote: On Friday 05 June 2009, Subrata Modak wrote: Correct, it fixes the issue. However, since few changes might have gone to the Kconfig, the patch does not apply cleanly. Below is

Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]

2009-06-15 Thread Subrata Modak
Hi Li/Nathan, On Thu, 2009-06-11 at 09:07 +0530, Subrata Modak wrote: Hi Nathan, On Wed, 2009-06-10 at 21:28 -0500, Nathan Lynch wrote: Subrata Modak subr...@linux.vnet.ibm.com writes: On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote: Hi Subrata, On Wed, 10 Jun 2009

Re: [Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-06-15 Thread David Gibson
On Wed, Jun 10, 2009 at 12:20:02PM +0530, K.Prasad wrote: On Fri, Jun 05, 2009 at 03:13:45PM +1000, David Gibson wrote: On Wed, Jun 03, 2009 at 10:05:24PM +0530, K.Prasad wrote: Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by:

fsl_pq_mdio warning

2009-06-15 Thread Benjamin Herrenschmidt
New warning: drivers/net/fsl_pq_mdio.c:468: warning: type defaults to ‘int’ in declaration of ‘subsys_initcall_sync’ Can whoever maintains that driver fix it please ? Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH v3] powerpc: add ioremap_early() for mapping IO regions before MMU_init()

2009-06-15 Thread Benjamin Herrenschmidt
On Wed, 2009-05-27 at 12:55 -0600, Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca ioremap_early() is useful for things like mapping SoC internally registers and early debug output because it allows mappings to devices to be setup early in the boot process where they are

Re: [PATCH 10/33] powerpc/cell: Extract duplicated IOPTE_* to asm/iommu.h

2009-06-15 Thread Arnd Bergmann
On Monday 15 June 2009, Benjamin Herrenschmidt wrote: On Wed, 2009-06-10 at 16:38 +0200, Geert Uytterhoeven wrote: Both arch/powerpc/platforms/cell/iommu.c and arch/powerpc/platforms/ps3/mm.c contain the same Cell IOMMU page table entry definitions. Extract them and move them to

Re: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 12:21 +0530, Subrata Modak wrote: Benjamin, I am not sure whether you liked the following patch to solve the above problem. Do, you want me address some other issue(s)/fixes for this ? I suppose ... in fact some old PReP machines can even have ISA slots iirc, but it's

Re: [PATCH 10/33] powerpc/cell: Extract duplicated IOPTE_* to asm/iommu.h

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 09:05 +0200, Arnd Bergmann wrote: Good point, that file does not contain hardware specific definitions but only interfaces. Geert, how about putting them into arch/powerpc/include/asm/cell-regs.h instead? I've put the patch in powerpc-next for now. But you may want

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-15 Thread K.Prasad
On Mon, Jun 15, 2009 at 04:40:45PM +1000, David Gibson wrote: On Wed, Jun 10, 2009 at 12:13:49PM +0530, K.Prasad wrote: On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: + else { + /* +

Re: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]

2009-06-15 Thread Subrata Modak
On Mon, 2009-06-15 at 17:11 +1000, Benjamin Herrenschmidt wrote: On Mon, 2009-06-15 at 12:21 +0530, Subrata Modak wrote: Benjamin, I am not sure whether you liked the following patch to solve the above problem. Do, you want me address some other issue(s)/fixes for this ? I suppose

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Michael Ellerman
On Wed, 2009-06-10 at 16:48 +1000, Michael Ellerman wrote: Add the option to build the code under arch/powerpc with -Werror. The intention is to make it harder for people to inadvertantly introduce warnings in the arch/powerpc code. It needs to be configurable so that if a warning is

[PATCH v5] 83xx: add support for the kmeter1 board.

2009-06-15 Thread Heiko Schocher
The following series implements basic board support for the kmeter1 board from keymile, based on a MPC8360. This series provides the following functionality: - The board can boot with a serial console on UART1 - Ethernet: UCC1 in RGMII mode UCC2 in RGMII mode UCC4 in RMII mode

Re: [PATCH 2/2] uio: add an of_genirq driver

2009-06-15 Thread Alan Cox
I did it that way because I saw IRQ 0 in /proc/interrupts on every PC... It is the job of the platform to map a physical IRQ 0 to some other representation if it exists outside of arch specific code. Funny. This was decided some years ago and a large part of the kernel simply

Re: [PATCH 23/33] net/ps3: gelic - Add missing annotations

2009-06-15 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Mon, 15 Jun 2009 16:31:24 +1000 On Wed, 2009-06-10 at 16:38 +0200, Geert Uytterhoeven wrote: probe functions should be __devinit Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Benjamin Herrenschmidt
Currently this appears to break only one of the defconfigs, chrp32. http://kisskb.ellerman.id.au/kisskb/head/1907/ And that's a legitimate error AFAICT: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 bytes is larger than 1024 bytes From: 367 void 368

Re: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 12:51 +0530, Subrata Modak wrote: On Mon, 2009-06-15 at 17:11 +1000, Benjamin Herrenschmidt wrote: On Mon, 2009-06-15 at 12:21 +0530, Subrata Modak wrote: Benjamin, I am not sure whether you liked the following patch to solve the above problem. Do, you want

Re: [PATCH 2/2] uio: add an of_genirq driver

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 00:12 +0100, Alan Cox wrote: + if (!uioinfo-irq) + uioinfo-irq = UIO_IRQ_NONE; Please don't do this. It's inconsistent if all other UIO drivers require people to use UIO_IRQ_NONE and you also allow zero. UIO_IRQ_NONE was introduced because 0 may be a

Re: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access

2009-06-15 Thread Li Yang
On Fri, Jun 12, 2009 at 9:58 PM, Kumar Galaga...@kernel.crashing.org wrote: On Jun 12, 2009, at 8:27 AM, Li Yang wrote: On Thu, Jun 11, 2009 at 9:32 PM, Kumar Galaga...@kernel.crashing.org wrote: On Jun 11, 2009, at 4:47 AM, Li Yang-R58472 wrote: On May 12, 2009, at 3:35 AM, Li Yang

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Michael Ellerman
On Mon, 2009-06-15 at 19:40 +1000, Benjamin Herrenschmidt wrote: Currently this appears to break only one of the defconfigs, chrp32. http://kisskb.ellerman.id.au/kisskb/head/1907/ And that's a legitimate error AFAICT: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size

Re: [OOPS] hugetlbfs tests with 2.6.30-rc8-git1

2009-06-15 Thread Sachin Sant
Michael Ellerman wrote: Hi Sachin, Rather than -git7 can you tell us the actual SHA, I don't know what git7 is. Corresponding SHA is 44b7532b8b464f606053562400719c9c21276037. Here is the supporting data. cpu 0x1: Vector: 300 (Data Access) at [c000fe9b3220] pc: c003d620:

Re: [PATCH] Fix oprofile sampling of marked events on POWER7

2009-06-15 Thread Maynard Johnson
Looks like this posting got overlooked, so I'm re-posting the original patch. Ben, can you please review? BTW, Anton reported the problem that this patch fixes. Thanks. -Maynard == Description --- Change ppc64 oprofile

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Timur Tabi
On Mon, Jun 15, 2009 at 2:50 AM, Michael Ellermanmich...@ellerman.id.au wrote: arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 bytes is larger than 1024 bytes What's so bad about a frame size larger than 1024? -- Timur Tabi Linux kernel developer at Freescale

RE: [PATCH] fbdev/xilinxfb: Fix improper casting and tighen up probe path

2009-06-15 Thread John Linn
-Original Message- From: Grant Likely [mailto:grant.lik...@secretlab.ca] Sent: Friday, June 12, 2009 11:57 AM To: linuxppc-...@ozlabs.org; linux-ker...@vger.kernel.org; b...@kernel.crashing.org; John Linn Subject: [PATCH] fbdev/xilinxfb: Fix improper casting and tighen up probe path

RE: [PATCH] fbdev/xilinxfb: Fix improper casting and tighen up probe path

2009-06-15 Thread John Linn
-Original Message- From: Grant Likely [mailto:grant.lik...@secretlab.ca] Sent: Friday, June 12, 2009 11:57 AM To: linuxppc-...@ozlabs.org; linux-ker...@vger.kernel.org; b...@kernel.crashing.org; John Linn Subject: [PATCH] fbdev/xilinxfb: Fix improper casting and tighen up probe path

Re: Chipselect in SPI binding with mpc5200-psc-spi

2009-06-15 Thread Grant Likely
On Mon, Jun 15, 2009 at 10:36 AM, Kári Davíðssonkari.davids...@marel.com wrote: Is this true? Grant Likely wrote: Yes, this is right.  The psc_spi driver automatically registers all spi children that it finds in the device tree onto the SPI bus. Therefore registering an spi_driver() is the

[PATCH 1/3] AMCC Crypto4xx Device Driver v7

2009-06-15 Thread Shasi Pulijala
Hi, I am re-sending this patch as a patch series of 3, I am assuming the earlier one did not go through the mailing lists because it was over the size limit. -Shasi From: Shasi Pulijala spulij...@amcc.com This is second release version for the PPC4XX Security driver that adds aead type

[PATCH 3/3] AMCC Crypto4xx Device Driver v7

2009-06-15 Thread Shasi Pulijala
From: Shasi Pulijala spulij...@amcc.com This patch further adds immediate hash functions to md5/sha1/sha2 algs. These immediate hash functions are used in hmac key generation in PPC Crypto4xx driver. Signed-off-by: Shasi Pulijala spulij...@amcc.com Acked-by: Loc Ho l...@amcc.com ---

[PATCH 2/3] AMCC Crypto4xx Device Driver v7

2009-06-15 Thread Shasi Pulijala
From: Shasi Pulijala spulij...@amcc.com This patch adds further support for AMCC ppc4xx security device driver. This is the second release that adds algorithms like: des/3des rfc3686(ctr(aes)) gcm, ccm hmac(md5,sha1,..,sha512) xcbc(aes), arc4 and kasumi. Signed-off-by: Shasi Pulijala

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-15 Thread Albrecht Dreß
Am 05.06.09 14:05 schrieb(en) Wolfram Sang: Create an of-aware driver using the now exported generic functions from plat-ram.c. Also add the documentation for the binding. Partitions are not yet supported. Tested on a phyCORE-MPC5200B-IO. Dumb question: what is the current status of this

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-06-15 Thread Benjamin Herrenschmidt
Yeah that occured to me, someone with a chrp machine would need to test it, do we have one? Yup, I think we do. I'll check that when I'm in the office. We can have a closer look tomorrow. In any case, stack alloc for that is indeed fishy. The obvious patch to make it static doesn't fly

Re: [OOPS] hugetlbfs tests with 2.6.30-rc8-git1

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 18:30 +0530, Sachin Sant wrote: The corresponding C code is : 278: 2f 80 00 00 cmpwi cr7,r0,0 } else { vsid = get_kernel_vsid(addr, mmu_kernel_ssize); ssize = mmu_kernel_ssize; } vaddr = hpt_va(addr,

Re: [OOPS] hugetlbfs tests with 2.6.30-rc8-git1

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 18:30 +0530, Sachin Sant wrote: 278: 2f 80 00 00 cmpwi cr7,r0,0 } else { vsid = get_kernel_vsid(addr, mmu_kernel_ssize); ssize = mmu_kernel_ssize; } vaddr = hpt_va(addr, vsid, ssize); rpte =

[PATCH] powerpc/mm: Fix potential access to freed pages when using hugetlbfs

2009-06-15 Thread Benjamin Herrenschmidt
When using 64k page sizes, our PTE pages are split in two halves, the second half containing the extension used to keep track of individual 4k pages when not using HW 64k pages. However, our page tables used for hugetlb have a slightly different format and don't carry that second half. Our code

[git pull] Please pull powerpc.git merge branch

2009-06-15 Thread Benjamin Herrenschmidt
Hi Linus ! Here's the other batch of powerpc stuff, including adding a small accessor to the generic BIO code (acked by Jens) and Paulus generic atomic64 implementation. A lot of PS3 updates in there, though I held back a couple for some purely mechanical merge reasons, so expect a 3rd batch with

Re: [PATCH -next 1/4] powerpc/85xx: Add platform support for X-ES MPC85xx boards

2009-06-15 Thread Kumar Gala
On Jun 11, 2009, at 2:42 PM, Nate Case wrote: Add support for X-ES single-board computers based on the Freescale MPC85xx processors. Signed-off-by: Nate Case nc...@xes-inc.com --- arch/powerpc/platforms/85xx/Kconfig | 10 + arch/powerpc/platforms/85xx/Makefile |1 +

Re: [PATCH -next 2/4] powerpc/85xx: Add dts files for X-ES MPC85xx boards

2009-06-15 Thread Kumar Gala
On Jun 11, 2009, at 2:42 PM, Nate Case wrote: Add device tree source files for various MPC85xx boards from Extreme Engineering Solutions. Supported boards include XPedite5370, XPedite5200, XPedite5301, XPedite5330, and XCalibur1501. Signed-off-by: Nate Case nc...@xes-inc.com ---

Re: [PATCH -next 3/4] powerpc/85xx: Add defconfig for X-ES MPC85xx boards

2009-06-15 Thread Kumar Gala
On Jun 11, 2009, at 2:43 PM, Nate Case wrote: Signed-off-by: Nate Case nc...@xes-inc.com --- arch/powerpc/configs/85xx/xes_mpc85xx_defconfig | 1821 ++ + 1 files changed, 1821 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/configs/85xx/xes_mpc85xx_defconfig

Re: [PATCH -next 4/4] powerpc/bootwrapper: Custom build options for XPedite52xx targets

2009-06-15 Thread Kumar Gala
On Jun 11, 2009, at 2:43 PM, Nate Case wrote: Some XPedite52xx boards have a legacy boot loader requiring some special care in the boot wrapper. The use of cuboot-85xx is needed to fix up embedded device trees, and a custom link address is specified to accommodate the boot loader and larger

Please pull from 'next' branch for 2.6.31

2009-06-15 Thread Kumar Gala
Please pull from 'next' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git next to receive the following updates: arch/powerpc/boot/cuboot-85xx.c |2 arch/powerpc/boot/dts/asp834x-redboot.dts |2 arch/powerpc/boot/dts/gef_sbc610.dts

Re: UIO: uio_mem does not handle devices above 4 GB address

2009-06-15 Thread Benjamin Herrenschmidt
On Thu, 2009-04-02 at 09:20 -0400, Steven A. Falco wrote: struct uio_mem { phys_addr_t addr; phys_addr_t size; int memtype; void __iomem*internal_addr; struct uio_map *map; }; A few other

Re: [PATCH v2] drivers/hvc: add missing __devexit_p()

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-05-18 at 03:44 -0400, Mike Frysinger wrote: The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by: Mike Frysinger vap...@gentoo.org CC: linuxppc-...@ozlabs.org --- v2 Thanks. Andrew, I'm

Re: [PATCH] RFC: powerpc: expose the multi-bit ops that underlie single-bit ops.

2009-06-15 Thread Benjamin Herrenschmidt
On Tue, 2009-05-26 at 14:19 -0400, Geoff Thorpe wrote: NOT FOR COMMIT, THIS IS A REQUEST FOR FEEDBACK. The bitops.h functions that operate on a single bit in a bitfield are implemented by operating on the corresponding word location. In all cases the inner logic appears to be valid if the

Re: [PATCH] Fix oprofile sampling of marked events on POWER7

2009-06-15 Thread Benjamin Herrenschmidt
On Mon, 2009-06-15 at 08:40 -0500, Maynard Johnson wrote: Looks like this posting got overlooked, so I'm re-posting the original patch. Ben, can you please review? BTW, Anton reported the problem that this patch fixes. It was merged upstream after 2.6.30 -rc6, see commit e5fc948b...