Re: [PATCH] spi: Correct SPI clock frequency setting in spi_mpc8xxx

2010-02-16 Thread Ernst Schwab
Grant Likely wrote: > The change forces the division to always round up instead of down. > Please describe (for me now, and for people looking at the commit in > the future) the mathematical reason for the changes. Ok, here are some infos on the problem I observed, and the fix. Example: When s

Re: [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-16 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Feb 10, 2010 at 7:55 AM, Wolfgang Grandegger > wrote: >> From: Wolfgang Grandegger >> >> "__devinit[data]" has not yet been used for all initialization functions >> and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has >> been renamed to "mpc_i2c_

Re: [PATCH/RFC 1/2] 5200: improve i2c bus error recovery

2010-02-16 Thread Albrecht Dre�
Hi Ira: [snip] > I see this exact hang on a MPC8349EA board. I poll my i2c sensors every > 500ms, and it takes around 12 hours to produce a hang. The usual hang > has (CF | BB) set, however I have seen a hang with just BB (only once so > far in about 2 weeks). > > I think the fixup should be run

Re: [PATCH/RFC 1/2] 5200: improve i2c bus error recovery

2010-02-16 Thread Albrecht Dre�
Hi Grant & Ira: Thanks a lot for reviewing the patch, and for the encouraging comments! I will re-submit a new version according according to them, hopefully tomorrow or on Thursday. Best, Albrecht. - Original Nachricht Von: Grant Likely An: Albrecht Dreß Datum: 16.02.2

Re: [PATCH] powerpc: mpc5121: correct DIU compatible property

2010-02-16 Thread Grant Likely
On Tue, Feb 16, 2010 at 12:32 PM, Anatolij Gustschin wrote: > The DIU driver should bind against "fsl,mpc5121-diu" > directly. Add this compatible property to the match > table and fix DTS and platform code accordingly. > > Signed-off-by: Anatolij Gustschin > --- >  arch/powerpc/boot/dts/mpc5121a

Re: [PATCH/RFC 1/2] 5200: improve i2c bus error recovery

2010-02-16 Thread Ira W. Snyder
On Fri, Jan 22, 2010 at 09:17:55PM +0100, Albrecht Dreß wrote: > Improve the recovery of the MPC5200B's I2C bus from errors like bus > hangs. > > Signed-off-by: Albrecht Dreß > > --- > > This patch introduces several improvements to the MPC5200B's I2C driver > as to improve the recovery from

Re: [PATCH] pata_mpc52xx: optimizing code size by change of ATA timing data types

2010-02-16 Thread Grant Likely
[cc'd linux-kernel, linux-ide and Jeff Garzik] Hi Roman. you should use ./scripts/get_maintainer.pl to make sure you're cc'ing the right people when posting patches. You should repost so that Jeff has a copy of the patch to pick up (and add my acked-by when you do). On Wed, Dec 16, 2009 at 6:29

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-02-16 Thread Grant Likely
On Fri, Jan 22, 2010 at 1:18 PM, Albrecht Dreß wrote: > Make the I2C adapter timeout configurable through a Device Tree property > which gives the timeout in microseconds. > > Signed-off-by: Albrecht Dreß > > --- > > --- linux-2.6.32-orig/Documentation/powerpc/dts-bindings/fsl/i2c.txt     > 2009-

[PATCH] powerpc: mpc5121: correct DIU compatible property

2010-02-16 Thread Anatolij Gustschin
The DIU driver should bind against "fsl,mpc5121-diu" directly. Add this compatible property to the match table and fix DTS and platform code accordingly. Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/mpc5121ads.dts |2 +- arch/powerpc/platforms/512x/mpc512x_shared.c |

Re: [PATCH/RFC 1/2] 5200: improve i2c bus error recovery

2010-02-16 Thread Grant Likely
Hi Albrecht, Comments below. On Fri, Jan 22, 2010 at 1:17 PM, Albrecht Dreß wrote: > Improve the recovery of the MPC5200B's I2C bus from errors like bus > hangs. > > Signed-off-by: Albrecht Dreß > > --- > > This patch introduces several improvements to the MPC5200B's I2C driver > as to improv

Re: [PATCH] powerpc/mpc512x: Add gpio driver

2010-02-16 Thread Grant Likely
Hi Matthias. Thanks for the patch. Some comments below... On Thu, Jan 28, 2010 at 6:48 AM, Matthias Fuchs wrote: > Signed-off-by: Matthias Fuchs Could use a commit log. It is useful to give some details about what this driver has been developed/tested on. > --- >  arch/powerpc/include/asm/m

Re: [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-16 Thread Grant Likely
On Wed, Feb 10, 2010 at 7:55 AM, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > "__devinit[data]" has not yet been used for all initialization functions > and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has > been renamed to "mpc_i2c_data", which is even the bett

Re: [PATCH v3 10/11] powerpc/mpc5121: update mpc5121ads DTS

2010-02-16 Thread Grant Likely
On Fri, Feb 5, 2010 at 6:42 AM, Anatolij Gustschin wrote: > Collects several changes needed after applying > previous mpc5121 platform and driver patches: I'll merge this one, but... >                disp...@2100 { > -                       compatible = "fsl,mpc5121-diu", "fsl-diu"; > +        

Re: [PATCH v3 09/11] powerpc/mpc5121: shared DIU framebuffer support

2010-02-16 Thread Grant Likely
On Fri, Feb 5, 2010 at 6:42 AM, Anatolij Gustschin wrote: > MPC5121 DIU configuration/setup as initialized by the boot > loader currently will get lost while booting Linux. As a > result displaying the boot splash is not possible through > the boot process. > > To prevent this we reserve configure

Re: [PATCH] spi: Correct SPI clock frequency setting in spi_mpc8xxx

2010-02-16 Thread Grant Likely
On Tue, Feb 16, 2010 at 9:43 AM, Ernst Schwab wrote: > Grant Likely wrote: > >> The change forces the division to always round up instead of down. >> Please describe (for me now, and for people looking at the commit in >> the future) the mathematical reason for the changes. > > Ok, here are some

Re: [PATCH 3/3] i2c/ibm-iic: drop NO_IRQ

2010-02-16 Thread Grant Likely
On Thu, Oct 22, 2009 at 2:11 PM, Wolfram Sang wrote: > Drop NO_IRQ as 0 is the preferred way to describe 'no irq' > (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is > only used on powerpc, where NO_IRQ is 0 anyhow. > > Signed-off-by: Wolfram Sang > Cc: Sean MacLennan

Re: [PATCH 2/3] i2c/cpm: drop NO_IRQ

2010-02-16 Thread Grant Likely
On Thu, Oct 22, 2009 at 2:11 PM, Wolfram Sang wrote: > Drop NO_IRQ as 0 is the preferred way to describe 'no irq' > (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is > only used on powerpc, where NO_IRQ is 0 anyhow. > > Signed-off-by: Wolfram Sang > Cc: Jochen Friedrich

Re: [PATCH 1/3] i2c/mpc: drop NO_IRQ

2010-02-16 Thread Grant Likely
On Thu, Oct 22, 2009 at 2:11 PM, Wolfram Sang wrote: > Drop NO_IRQ as 0 is the preferred way to describe 'no irq' > (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is > only used on powerpc, where NO_IRQ is 0 anyhow. > > Signed-off-by: Wolfram Sang > Cc: Grant Likely >

Re: [PATCH] spi: Correct SPI clock frequency setting in spi_mpc8xxx

2010-02-16 Thread Grant Likely
[cc'd spi-devel-general, linuxppc-dev & Kumar Gala] On Tue, Feb 16, 2010 at 7:12 AM, Ernst Schwab wrote: > From: Ernst Schwab > > Correct SPI clock frequency division factor rounding, preventing clock rates > higher than the maximum specified clock frequency being used. For a patch like this, i

Re: [PATCH v4 04/11] mtd: Add MPC5121 NAND Flash Controller driver

2010-02-16 Thread Artem Bityutskiy
On Mon, 2010-02-15 at 18:35 +0100, Anatolij Gustschin wrote: > Adds NAND Flash Controller driver for MPC5121 Revision 2. > All device features, except hardware ECC and power management, > are supported. > > Signed-off-by: Piotr Ziecik > Signed-off-by: Wolfgang Denk > Signed-off-by: Anatolij Gust