> -Original Message-
> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] On
> Behalf Of Geert Uytterhoeven
> Sent: Thursday, September 09, 2010 19:06 PM
> To: Zang Roy-R61911
> Cc: linux-...@lists.infradead.org; Wood Scott-B07421; dedeki...@gmail.com; Lan
> Chunhe-B
> -Original Message-
> From: Anton Vorontsov [mailto:cbouatmai...@gmail.com]
> Sent: Thursday, September 09, 2010 19:42 PM
> To: Zang Roy-R61911
> Cc: linux-...@lists.infradead.org; dw...@infradead.org; dedeki...@gmail.com;
> a...@linux-foundation.org; Lan Chunhe-B25806; Wood Scott-B07421
On Sat, Sep 11, 2010 at 10:10:59PM -0700, Joe Perches wrote:
> Signed-off-by: Joe Perches
> ---
> sound/ppc/snd_ps3.c |2 +-
> sound/soc/s3c24xx/s3c-dma.c |3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
Acked-by: Mark Brown
On 09/12/2010 09:39 PM, Stephen Rothwell wrote:
>
> Your patch fixes some of the warnings, but still leaves these for a
> powerpc allnoconfig build:
>
> WARNING: mm/built-in.o(.text+0x25d80): Section mismatch in reference from the
> function memblock_double_array() to the function .init.text:me
Hi Tiejun,
Firstly I think we'd better print the BAR0 and BAR1 on the probe function of
> your device driver because you have to make sure if a800-a803 is
> assigned to BAR0 and 0xa804-0xa807 for BAR1 as we expect.
>
> u32 value;
> pci_read_config_word(pdev, PCI_BASE_ADDRESS_0, &va
On 9/12/2010 2:57 PM, Vasiliy Kulikov wrote:
> hvc_alloc() may fail, if so exit from init() with error.
>
> Signed-off-by: Vasiliy Kulikov
Thanks, accepted into my tree (for the next merge window). In practice all
this means is in debug mode we'll get a warning from do_one_initcall()
rather tha
On Mon, Sep 13, 2010 at 09:12 -0400, Chris Metcalf wrote:
> Thanks, accepted into my tree (for the next merge window). In practice all
> this means is in debug mode we'll get a warning from do_one_initcall()
> rather than silence, but you're right, it's technically better. :-)
Anyway it's better,
On Mon, Sep 06, 2010 at 10:45:26AM -0500, Olof Johansson wrote:
>On Sun, Sep 05, 2010 at 10:19:53PM -0700, Tirumala Marri wrote:
>> >
>> > Then the device tree identifier, and the cpu setup functions, etc,
>> > should indicate
>> > 464, not APM821xx.
>> This is new SoC based on 464 cpu core. All th
On Fri, Sep 10, 2010 at 11:27:37AM -0700, tma...@apm.com wrote:
>From: Tirumala Marri
>
>This patch adds CPU, device tree, defconfig and bluestone board
>support for APM821xx SoC.
>
>Signed-off-by: Tirumala R Marri
>+ cpus {
>+ #address-cells = <1>;
>+ #size-cells =
On Mon, Sep 13, 2010 at 2:30 AM, Zang Roy-R61911 wrote:
> What is the different for unsigned int and u32? I think they are same.
Roy, please don't ever write code that assumes that sizeof(int) == 4.
There's a reason why we have unsized integer types (like int, long,
and short) and sized integer
On Mon, 2010-09-13 at 09:10 -0500, Timur Tabi wrote:
> On Mon, Sep 13, 2010 at 2:30 AM, Zang Roy-R61911 wrote:
>
> > What is the different for unsigned int and u32? I think they are same.
>
> Roy, please don't ever write code that assumes that sizeof(int) == 4.
> There's a reason why we have uns
On Mon, Sep 13, 2010 at 9:27 AM, Artem Bityutskiy wrote:
> Yes, sizeof(int) == 4 assumption is not good.
>
> But sizeof(int) >= 4 is perfectly fine.
I have to disagree. I don't see how you can say that == is not okay,
but >= is okay. That just doesn't make any sense. Obviously, you
have to m
On Mon, 13 Sep 2010 00:22:10 -0700
"Zang Roy-R61911" wrote:
>
>
> > -Original Message-
> > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] On
> > Behalf Of Geert Uytterhoeven
> > Sent: Thursday, September 09, 2010 19:06 PM
> > To: Zang Roy-R61911
> > Cc: linux-.
On Mon, 2010-09-13 at 09:35 -0500, Timur Tabi wrote:
> On Mon, Sep 13, 2010 at 9:27 AM, Artem Bityutskiy wrote:
>
> > Yes, sizeof(int) == 4 assumption is not good.
> >
> > But sizeof(int) >= 4 is perfectly fine.
>
> I have to disagree. I don't see how you can say that == is not okay,
> but >=
Hi Joe,
On 09/11/2010 10:10 PM, Joe Perches wrote:
> sound/ppc/snd_ps3.c |2 +-
>
> diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
> index 2f12da4..581a670 100644
> --- a/sound/ppc/snd_ps3.c
> +++ b/sound/ppc/snd_ps3.c
> @@ -579,7 +579,7 @@ static int snd_ps3_delay_to_bytes(st
On Mon, Sep 13, 2010 at 11:45 AM, Artem Bityutskiy wrote:
> Unsigned int is reliably >= 4 in Linux.
Not exactly. sizeof(unsigned int) is effectively never greater than 4
in Linux (I think it's still 32 bits even on a 64-bit kernel), so it
makes no sense to say >=. So since you can't say that si
On Mon, 2010-09-13 at 13:36 -0500, Timur Tabi wrote:
> On Mon, Sep 13, 2010 at 11:45 AM, Artem Bityutskiy
> wrote:
> > Unsigned int is reliably >= 4 in Linux.
>
> Not exactly. sizeof(unsigned int) is effectively never greater than 4
> in Linux
I know and said the same in the other paragraph wh
Signed-off-by: Joe Perches
---
arch/powerpc/boot/addnote.c|4 ++--
arch/powerpc/boot/cuboot-c2k.c |4 ++--
arch/powerpc/kernel/irq.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot/addnote.c
index b1e5611..
Signed-off-by: Joe Perches
---
drivers/char/hvc_vio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/hvc_vio.c b/drivers/char/hvc_vio.c
index 27370e9..5e2f52b 100644
--- a/drivers/char/hvc_vio.c
+++ b/drivers/char/hvc_vio.c
@@ -39,7 +39,7 @@
#include "hv
On Mon, 13 Sep 2010 13:36:45 -0500
Timur Tabi wrote:
> On Mon, Sep 13, 2010 at 11:45 AM, Artem Bityutskiy
> wrote:
> > Unsigned int is reliably >= 4 in Linux.
>
> Not exactly. sizeof(unsigned int) is effectively never greater than 4
> in Linux (I think it's still 32 bits even on a 64-bit kern
At Sat, 11 Sep 2010 22:10:59 -0700,
Joe Perches wrote:
>
> Signed-off-by: Joe Perches
Applied to sound git tree now. Thanks.
Takashi
> ---
> sound/ppc/snd_ps3.c |2 +-
> sound/soc/s3c24xx/s3c-dma.c |3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/
> >+clock-frequency = <0>; /* Filled in by U-Boot */
>
> Out of curiosity, which version of U-Boot has (or will have) this
> support?
[Marri] Currently I am working with u-boot list to accept my patch. It
should
be available as soon as it is accepted.
>
> >diff --git a/arch/pow
From: Tirumala Marri
This patch adds CPU, device tree, defconfig and bluestone board
support for APM821xx SoC.
Signed-off-by: Tirumala R Marri
---
V1:
* CPU name changed to 464.
* defconfig is created using "make savedefconfig".
V2:
* CPU name changed back to apm821xx for now.
* some wh
Using static const char foo[] = "bar" can save some
code and text space, so change the places where it's possible.
Also change the places that use
char foo[] = "barX";
...
foo[3] = value + '0';
where X is typically changed
char foo[sizeof("barX")];
...
Hi Joe,
On Mon, 13 Sep 2010 12:47:40 -0700 Joe Perches wrote:
>
> Signed-off-by: Joe Perches
> ---
> arch/powerpc/boot/addnote.c|4 ++--
> arch/powerpc/boot/cuboot-c2k.c |4 ++--
> arch/powerpc/kernel/irq.c |2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
I am als
BTW, Ben Herrenschmidt is the current PowerPC maintainer.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
pgp8aPticOorB.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@li
Hi Joe,
On Mon, 13 Sep 2010 12:47:42 -0700 Joe Perches wrote:
>
> Signed-off-by: Joe Perches
Reviewed-by: Stephen Rothwell
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
pgpxIwQxoYC6E.pgp
Description: PGP signature
___
> -Original Message-
> From: Wood Scott-B07421
> Sent: Tuesday, September 14, 2010 0:28 AM
> To: Zang Roy-R61911
> Cc: Geert Uytterhoeven; linux-...@lists.infradead.org; Wood Scott-B07421;
> dedeki...@gmail.com; Lan Chunhe-B25806; linuxppc-...@ozlabs.org; a...@linux-
> foundation.org; dw.
Hi Yinghai,
On Mon, 13 Sep 2010 01:24:20 -0700 Yinghai Lu wrote:
>
> On 09/12/2010 09:39 PM, Stephen Rothwell wrote:
> >
> > Your patch fixes some of the warnings, but still leaves these for a
> > powerpc allnoconfig build:
> >
> > WARNING: mm/built-in.o(.text+0x25d80): Section mismatch in refe
Ravi Gupta wrote:
> Hi Tiejun,
>
> Firstly I think we'd better print the BAR0 and BAR1 on the probe function of
>> your device driver because you have to make sure if a800-a803 is
>> assigned to BAR0 and 0xa804-0xa807 for BAR1 as we expect.
>>
>> u32 value;
>> pci_read_config_word(
> -Original Message-
> From: Artem Bityutskiy [mailto:dedeki...@gmail.com]
> Sent: Monday, September 13, 2010 22:28 PM
> To: Timur Tabi
> Cc: Zang Roy-R61911; Anton Vorontsov; Wood Scott-B07421; Lan Chunhe-B25806;
> linuxppc-...@ozlabs.org; linux-...@lists.infradead.org; a...@linux-
> fou
Unnecessary cast from void* in assignment.
Signed-off-by: matt mooney
---
arch/powerpc/platforms/pseries/hvCall_inst.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c
b/arch/powerpc/platforms/pseries/hvCall_inst.c
index e19f
32 matches
Mail list logo
