fsl_udc_core not initializing properly?

2011-02-18 Thread Matthew L. Creech
Hi, I'm upgrading from 2.6.36 to 2.6.37 on a MPC8313 ERDB-like board. On the new kernel, it seems like the USB gadget driver (fsl_usb2_udc) is never initialized, so USB no longer works. Adding some printks to the code shows that udc_init() is being run, which calls platform_driver_probe(). Howe

MPC866, Help, SPI blocked at startup

2011-02-18 Thread LEROY Christophe
Hello, Sometimes (but rather often) I get SPI tasks hanging. I get the following trace, as if both tasks where blocking each other, or they are waiting for a third task ? Can someone help or tell what I should look at ? [ 240.939898] INFO: task ff000a80.spi:197 blocked for more than 120 seco

RE: [PATCH] driver/FSL SATA:Fix wrong Device Error Register usage

2011-02-18 Thread Kushwaha Prabhakar-B32579
Thanks David for review comments!! Please find my reply in-lined > -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, February 18, 2011 2:12 PM > To: Kushwaha Prabhakar-B32579; linuxppc-dev@lists.ozlabs.org > Cc: Kalra Ashish-B00888 > Subject: RE: [P

RE: [PATCH] driver/FSL SATA:Fix wrong Device Error Register usage

2011-02-18 Thread Kushwaha Prabhakar-B32579
Thanks David for review comments!! Please find my reply in-lined > -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, February 18, 2011 2:12 PM > To: Kushwaha Prabhakar-B32579; linuxppc-dev@lists.ozlabs.org > Cc: Kalra Ashish-B00888 > Subject: RE: [PA

RE: [PATCH] driver/FSL SATA:Fix wrong Device Error Register usage

2011-02-18 Thread David Laight
> + if ((ffs(dereg)-1) < ap->nr_pmp_links) { > + /* array start from 0 */ > + link = &ap->pmp_link[ffs(dereg)-1]; I'd only call ffs() once - it could be a slow library function. Any comment should note that ffs() returns