Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Benjamin Herrenschmidt
Nice, looks like I forgot to add the new drivers/pci/of.c file :-) Here's a new patch. Also added linux-pci to the CC list. And this one removes a lot more cruft from the powermac code while at it, and moves the core matching logic to drivers/of/of_pci.c... From

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Mon, 04 Apr 2011 13:27:10 +1000 +struct device_node * __weak pcibios_get_phb_of_node(struct pci_bus *bus) +{ + /* This should only be called for PHBs */ + if (WARN_ON(bus-self || bus-parent)) + return NULL; This

Re: [PATCH v13 02/10] USB/ppc4xx: Add Synopsys DWC OTG driver framework

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:16:50PM -0700, tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Tirumala R Marri tma...@apm.com Signed-off-by: Fushen Chen

Re: [PATCH v13 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-04 Thread Felipe Balbi
Hi, On Sun, Apr 03, 2011 at 04:16:53PM -0700, tma...@apm.com wrote: +const char *op_state_str(enum usb_otg_state state) please don't introduce yet another version of this. Make the ones available generic. Place a static inline const char *otg_state_string(struct otg_transceiver *x) on

Re: [PATCH v13 07/10] USB/ppc4xx: Add Synopsys DWC OTG PCD function

2011-04-04 Thread Felipe Balbi
Hi, On Sun, Apr 03, 2011 at 04:17:10PM -0700, tma...@apm.com wrote: +static const struct usb_gadget_ops dwc_otg_pcd_ops = { + .get_frame = dwc_otg_pcd_get_frame, + .wakeup = dwc_otg_pcd_wakeup, + /* not selfpowered */ will you really have a board running this top operating system

Re: [PATCH v13 09/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:17:24PM -0700, tma...@apm.com wrote: From: Tirumala Marri tma...@apm.com Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use

Re: [PATCH v13 08/10] USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function

2011-04-04 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 04:17:13PM -0700, tma...@apm.com wrote: +void start_next_request(struct pcd_ep *ep) this will probably cause namespace clashes at some point. prepent with dwc_ or make it static. -- balbi ___ Linuxppc-dev mailing list

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Bjorn Helgaas
On Mon, Apr 4, 2011 at 1:37 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: powerpc has two different ways of matching PCI devices to their corresponding OF node (if any) for historical reasons. The ppc64 one does a scan looking for matching bus/dev/fn, while the ppc32 one does a

Re: problem PCIe LSI detected at 32 device addresses (ppc460ex)

2011-04-04 Thread Grant Likely
On Sun, Apr 03, 2011 at 06:22:13PM -0500, Ayman El-Khashab wrote: On Sun, Apr 03, 2011 at 04:09:26PM -0600, Grant Likely wrote: On Sun, Apr 3, 2011 at 3:52 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Ok, I've narrowed the scope of the problem some. ?I moved forward

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Benjamin Herrenschmidt
On Mon, 2011-04-04 at 00:48 -0700, David Miller wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Mon, 04 Apr 2011 13:27:10 +1000 +struct device_node * __weak pcibios_get_phb_of_node(struct pci_bus *bus) +{ + /* This should only be called for PHBs */ + if

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Tue, 05 Apr 2011 07:03:17 +1000 On Mon, 2011-04-04 at 00:48 -0700, David Miller wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Mon, 04 Apr 2011 13:27:10 +1000 +struct device_node * __weak

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Benjamin Herrenschmidt
On Mon, 2011-04-04 at 09:25 -0600, Bjorn Helgaas wrote: Some of this is reminiscent of the ACPI/PCI binding we do on x86/ia64, e.g., acpi_get_pci_dev() and the stuff in drivers/acpi/glue.c. Have you looked at that to see if there's any hope of covering both OF and ACPI with something more

Re: Pegasos i8042 broken again

2011-04-04 Thread Benjamin Herrenschmidt
Ok, I got fed up about it. The patch referred above is obviously wrong since it leaves interrupts at 0 when a device_type or name of 8042 is found, so what about the following? I can ship it with a signed-off-by and proper comments a bit later if people agree. Compiled and tested,

Re: Pegasos i8042 broken again

2011-04-04 Thread Gabriel Paubert
On Sun, Oct 10, 2010 at 06:35:47PM +1100, Benjamin Herrenschmidt wrote: On Sat, 2010-10-09 at 20:37 -0500, pac...@kosh.dhis.org wrote: Pegasos has no keyboard again. I blame commit 540c6c392f01887dcc96bef0a41e63e6c1334f01, which tries to find i8042 IRQs in the device-tree but doesn't fall

Re: Pegasos i8042 broken again

2011-04-04 Thread Gabriel Paubert
On Tue, Apr 05, 2011 at 08:28:50AM +1000, Benjamin Herrenschmidt wrote: Ok, I got fed up about it. The patch referred above is obviously wrong since it leaves interrupts at 0 when a device_type or name of 8042 is found, so what about the following? I can ship it with a signed-off-by

Re: Pegasos i8042 broken again

2011-04-04 Thread pacman
Gabriel Paubert writes: Ok, I got fed up about it. The patch referred above is obviously wrong since it leaves interrupts at 0 when a device_type or name of 8042 is found, so what about the following? Looks like the workaround I was using for a while. In the original report I said I wasn't

Revert 737a3bb9416ce2a7c7a4170852473a4fcc9c67e8 ?

2011-04-04 Thread Gabriel Paubert
Hi, I've had the following funny crashes on PPC machines, with cataleptic X server as a consequence: kernel: [drm] Setting GART location based on new memory map kernel: Oops: Exception in kernel mode, sig: 4 [#1] kernel: CHRP kernel: last sysfs file:

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Benjamin Herrenschmidt
On Mon, 2011-04-04 at 09:25 -0600, Bjorn Helgaas wrote: Some of this is reminiscent of the ACPI/PCI binding we do on x86/ia64, e.g., acpi_get_pci_dev() and the stuff in drivers/acpi/glue.c. Have you looked at that to see if there's any hope of covering both OF and ACPI with something more

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Grant Likely
On Mon, Apr 04, 2011 at 05:37:44PM +1000, Benjamin Herrenschmidt wrote: Nice, looks like I forgot to add the new drivers/pci/of.c file :-) Here's a new patch. Also added linux-pci to the CC list. And this one removes a lot more cruft from the powermac code while at it, and moves the core

[git pull] Please pull powerpc.git merge branch

2011-04-04 Thread Kumar Gala
The following changes since commit c0bb9e45f3a7f67fc358946727bc3d5f23d0f55d: kdump: Allow shrinking of kdump region to be overridden (2011-04-01 16:14:30 +1100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git merge Kumar Gala (1):