Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/20/2011 07:51 PM, Alex Williamson wrote: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this typically happens when a PCI-to-PCI bridge exists between the set of

Re: [PATCH] mtd/physmap_of: Don't add disabled flash devices

2011-08-22 Thread Lan Chunhe
On Wed, 17 Aug 2011 05:44:56 +0800, Scott Wood scottw...@freescale.com wrote: On 08/16/2011 04:25 AM, Chunhe Lan wrote: Flash(cfi-flash, jedec-flash, and so on) nodes with the property status=disabled are not usable and so avoid adding disabled flash devices with the system. Signed-off-by:

Re: [PATCH] mtd/nand: Don't add disabled nand flash devices

2011-08-22 Thread Lan Chunhe
On Wed, 17 Aug 2011 05:46:29 +0800, Scott Wood scottw...@freescale.com wrote: On 08/16/2011 04:27 AM, Chunhe Lan wrote: Nand flash nodes with the property status=disabled are not usable and so avoid adding disabled nand flash devices with the system. Signed-off-by: Chunhe Lan

Re: [PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-22 Thread Julia Lawall
On Mon, 22 Aug 2011, walter harms wrote: Am 21.08.2011 18:10, schrieb Julia Lawall: From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match

Re: [PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-22 Thread walter harms
Am 21.08.2011 18:10, schrieb Julia Lawall: From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match that finds this problem is as follows:

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Joerg Roedel
On Mon, Aug 22, 2011 at 02:30:26AM -0400, Avi Kivity wrote: On 08/20/2011 07:51 PM, Alex Williamson wrote: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Artem Bityutskiy
On Thu, 2011-08-18 at 10:33 +0800, b35...@freescale.com wrote: From: Liu Shuo b35...@freescale.com Freescale FCM controller has a 2K size limitation of buffer RAM. In order to support the Nand flash chip whose page size is larger than 2K bytes, we divide a page into multi-2K pages for MTD

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 01:46 PM, Joerg Roedel wrote: $ readlink /sys/devices/pci:00/:00:19.0/iommu_group ../../../path/to/device/which/represents/the/resource/constraint (the pci-to-pci bridge on x86, or whatever node represents partitionable endpoints on power) That does not work. The

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Artem Bityutskiy
On Fri, 2011-08-19 at 13:10 -0500, Scott Wood wrote: On 08/19/2011 03:57 AM, Matthieu CASTET wrote: LiuShuo a écrit : 于 2011年08月19日 01:00, Matthieu CASTET 写道: b35...@freescale.com a écrit : From: Liu Shuob35...@freescale.com Freescale FCM controller has a 2K size limitation of buffer

Re: [PATCH] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Liam Girdwood
On 20/08/11 08:23, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) //

Re: [PATCH 2/2] arch/powerpc/platforms/powermac/setup.c: add missing of_node_put

2011-08-22 Thread Julia Lawall
On Mon, 22 Aug 2011, walter harms wrote: Am 21.08.2011 18:10, schrieb Julia Lawall: From: Julia Lawall ju...@diku.dk np is initialized to the result of calling a function that calls of_node_get, so of_node_put should be called before the pointer is dropped. The semantic match

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 06:51:35AM -0400, Avi Kivity wrote: On 08/22/2011 01:46 PM, Joerg Roedel wrote: That does not work. The bridge in question may not even be visible as a PCI device, so you can't link to it. This is the case on a few PCIe cards which only have a PCIx chip and a

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 06:51:35AM -0400, Avi Kivity wrote: On 08/22/2011 01:46 PM, Joerg Roedel wrote: That does not work. The bridge in question may not even be visible as a PCI device, so you can't link to it. This is the case on a few

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On the AMD IOMMU side this information is stored in the IVRS ACPI table. Not sure about the VT-d side, though. I see. There is no sysfs node representing it? No. It also doesn't exist

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 03:55 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: On 08/22/2011 03:36 PM, Roedel, Joerg wrote: On the AMD IOMMU side this information is stored in the IVRS ACPI table. Not sure about the VT-d side, though. I see. There is no

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: On 08/22/2011 03:55 PM, Roedel, Joerg wrote: Well, I don't think its really meaningless, but we need some way to communicate the information about device groups to userspace. I mean the contents of the group descriptor. There

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Avi Kivity
On 08/22/2011 04:15 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: On 08/22/2011 03:55 PM, Roedel, Joerg wrote: Well, I don't think its really meaningless, but we need some way to communicate the information about device groups to userspace. I

Re: [PATCH] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Timur Tabi
Julia Lawall wrote: diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index 0efc04a..b33271b 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -880,10 +880,12 @@ static struct device_node *find_ssi_node(struct device_node *dma_channel_np) np =

Re: [PATCH] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Julia Lawall
On Mon, 22 Aug 2011, Timur Tabi wrote: Julia Lawall wrote: diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index 0efc04a..b33271b 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -880,10 +880,12 @@ static struct device_node *find_ssi_node(struct

[PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Timur Tabi
of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. Since we don't actually use np, we can decrement the reference count immediately. Reported-by: Julia Lawall ju...@diku.dk Signed-off-by: Timur Tabi ti...@freescale.com ---

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 09:17:41AM -0400, Avi Kivity wrote: On 08/22/2011 04:15 PM, Roedel, Joerg wrote: On Mon, Aug 22, 2011 at 09:06:07AM -0400, Avi Kivity wrote: On 08/22/2011 03:55 PM, Roedel, Joerg wrote: Well, I don't think its really meaningless, but we need some way to

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Ivan Djelic
On Mon, Aug 22, 2011 at 11:58:33AM +0100, Artem Bityutskiy wrote: On Fri, 2011-08-19 at 13:10 -0500, Scott Wood wrote: On 08/19/2011 03:57 AM, Matthieu CASTET wrote: LiuShuo a écrit : ??? 2011???08???19??? 01:00, Matthieu CASTET ??: b35...@freescale.com a écrit : From: Liu

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Alex Williamson
On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Scott Wood
On 08/22/2011 05:58 AM, Artem Bityutskiy wrote: On Fri, 2011-08-19 at 13:10 -0500, Scott Wood wrote: On 08/19/2011 03:57 AM, Matthieu CASTET wrote: How the bad block marker are handled with this remapping ? It has to be migrated prior to first use (this needs to be documented, and ideally a

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Scott Wood
On 08/22/2011 10:25 AM, Ivan Djelic wrote: Did you take into account the fact that because MTD thinks this a 2K chip, you will have to wait twice for the nand busy read time (typically 25 us) per each 4K read. In other words, to read 4 kBytes you will do: 1. send read0 (00), send address,

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Matthieu CASTET
Scott Wood a écrit : On 08/22/2011 10:25 AM, Ivan Djelic wrote: Did you take into account the fact that because MTD thinks this a 2K chip, you will have to wait twice for the nand busy read time (typically 25 us) per each 4K read. In other words, to read 4 kBytes you will do: 1. send read0

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Scott Wood
On 08/22/2011 11:13 AM, Matthieu CASTET wrote: Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to work. That's weird because our controller seems quite flexible [1]. Something like that should work ?

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread Matthieu CASTET
Scott Wood a écrit : On 08/22/2011 11:13 AM, Matthieu CASTET wrote: Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to work. That's weird because our controller seems quite flexible [1]. Something like

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Joerg Roedel
On Sat, Aug 20, 2011 at 12:51:39PM -0400, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and enforcement of device groups. Groups are formed any time the

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Alex Williamson
On Mon, 2011-08-22 at 19:25 +0200, Joerg Roedel wrote: On Sat, Aug 20, 2011 at 12:51:39PM -0400, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and

Re: [PATCH] RapidIO: Fix use of non-compatible registers

2011-08-22 Thread Andrew Morton
On Tue, 26 Jul 2011 14:07:26 -0400 Alexandre Bounine alexandre.boun...@idt.com wrote: Replace/remove use of RIO v.1.2 registers/bits that are not forward-compatible with newer versions of RapidIO specification. RapidIO specification v. 1.3 removed Write Port CSR, Doorbell CSR, Mailbox CSR

Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Liam Girdwood
On 22/08/11 15:22, Timur Tabi wrote: of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. Since we don't actually use np, we can decrement the reference count immediately. Reported-by: Julia Lawall ju...@diku.dk

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
On Mon, 2011-08-22 at 13:29 -0700, aafabbri wrote: Each device fd would then support a similar set of ioctls and mapping (mmio/pio/config) interface as current vfio, except for the obvious domain and dma ioctls superseded by the group fd. Another valid model might be that

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
On Mon, 2011-08-22 at 09:30 +0300, Avi Kivity wrote: On 08/20/2011 07:51 PM, Alex Williamson wrote: We need to address both the description and enforcement of device groups. Groups are formed any time the iommu does not have resolution between a set of devices. On x86, this typically

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
On Mon, 2011-08-22 at 09:45 -0600, Alex Williamson wrote: Yes, that's the idea. An open question I have towards the configuration side is whether we might add iommu driver specific options to the groups. For instance on x86 where we typically have B:D.F granularity, should we have an option

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
I am in favour of /dev/vfio/$GROUP. If multiple devices should be assigned to a guest, there can also be an ioctl to bind a group to an address-space of another group (certainly needs some care to not allow that both groups belong to different processes). Btw, a problem we havn't talked

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread Benjamin Herrenschmidt
I wouldn't use uiommu for that. Any particular reason besides saving a file descriptor? We use it today, and it seems like a cleaner API than what you propose changing it to. Well for one, we are back to square one vs. grouping constraints. .../... If we in singleton-group land were

Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Mark Brown
On Mon, Aug 22, 2011 at 09:22:41AM -0500, Timur Tabi wrote: of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. Since we don't actually use np, we can decrement the reference count immediately. Applied, thanks.

Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Mark Brown
On Mon, Aug 22, 2011 at 09:22:41AM -0500, Timur Tabi wrote: of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. Since we don't actually use np, we can decrement the reference count immediately. Applied, thanks.

Re: [PATCH 2/2] sound/soc/fsl/mpc8610_hpcd.c: add missing of_node_put

2011-08-22 Thread Mark Brown
On Sat, Aug 20, 2011 at 09:02:01AM +0200, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk The first change is to add an of_node_put, since codec_np has previously been allocated. The rest of the patch reorganizes the error handling code so the only code executed is that which is

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread aafabbri
On 8/20/11 9:51 AM, Alex Williamson alex.william...@redhat.com wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think we agreed to: We need to address both the description and enforcement of device groups. Groups are formed any time

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread aafabbri
On 8/22/11 1:49 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2011-08-22 at 13:29 -0700, aafabbri wrote: Each device fd would then support a similar set of ioctls and mapping (mmio/pio/config) interface as current vfio, except for the obvious domain and dma ioctls

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread aafabbri
On 8/22/11 2:49 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: I wouldn't use uiommu for that. Any particular reason besides saving a file descriptor? We use it today, and it seems like a cleaner API than what you propose changing it to. Well for one, we are back to

Re: linux-next: boot test failure (net tree)

2011-08-22 Thread Stephen Rothwell
Hi Dave, On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Here's what I am applying as a merge fixup to the net tree today so that my ppc64_defconfig builds actually build more or less the same set of drivers as before this rearrangement. And this today:

Re: linux-next: boot test failure (net tree)

2011-08-22 Thread Stephen Rothwell
Hi Dave, On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Here's what I am applying as a merge fixup to the net tree today so that my ppc64_defconfig builds actually build

Re: linux-next: boot test failure (net tree)

2011-08-22 Thread David Miller
From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 23 Aug 2011 11:41:29 +1000 On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Here's what I am applying as a merge

Re: linux-next: boot test failure (net tree)

2011-08-22 Thread Jeff Kirsher
On Mon, 2011-08-22 at 19:13 -0700, David Miller wrote: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 23 Aug 2011 11:41:29 +1000 On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 22 Aug 2011 11:30:32 +1000 Stephen Rothwell

Re: kvm PCI assignment VFIO ramblings

2011-08-22 Thread David Gibson
On Mon, Aug 22, 2011 at 09:45:48AM -0600, Alex Williamson wrote: On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: We had an extremely productive VFIO BoF on Monday. Here's my attempt to capture the plan that I think

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-22 Thread LiuShuo
于 2011年08月23日 00:19, Scott Wood 写道: On 08/22/2011 11:13 AM, Matthieu CASTET wrote: Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to work. That's weird because our controller seems quite flexible [1].

Re: linux-next: boot test failure (net tree)

2011-08-22 Thread Arnaud Lacombe
Hi, [Added linux-kbuild@ to the Cc: list.] On Mon, Aug 22, 2011 at 10:13 PM, David Miller da...@davemloft.net wrote: From: Stephen Rothwell s...@canb.auug.org.au Date: Tue, 23 Aug 2011 11:41:29 +1000 On Tue, 23 Aug 2011 11:40:11 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Mon,

Re: linux-next: boot test failure (net tree)

2011-08-22 Thread David Miller
From: Arnaud Lacombe lacom...@gmail.com Date: Mon, 22 Aug 2011 23:50:02 -0400 Are you implying we need some kind of way to migrate config ? The issue is that the dependencies for every single ethernet driver have changed. Some dependencies have been dropped (f.e. NETDEV_1 and some have

Re: [PATCH 1/2] [hw-breakpoint] Use generic hw-breakpoint interfaces for new PPC ptrace flags

2011-08-22 Thread David Gibson
On Fri, Aug 19, 2011 at 01:21:36PM +0530, K.Prasad wrote: PPC_PTRACE_GETHWDBGINFO, PPC_PTRACE_SETHWDEBUG and PPC_PTRACE_DELHWDEBUG are PowerPC specific ptrace flags that use the watchpoint register. While they are targeted primarily towards BookE users, user-space applications such as GDB have

Re: [PATCH 2/2] [PowerPC Book3E] Introduce new ptrace debug feature flag

2011-08-22 Thread David Gibson
On Fri, Aug 19, 2011 at 01:23:38PM +0530, K.Prasad wrote: While PPC_PTRACE_SETHWDEBUG ptrace flag in PowerPC accepts PPC_BREAKPOINT_MODE_EXACT mode of breakpoint, the same is not intimated to the user-space debuggers (like GDB) who may want to use it. Hence we introduce a new