Re: [RFC PATCH 17/17] phy_device: Rename phy_start_aneg() to phy_start_link()

2011-11-03 Thread Andy Fleming
2011/10/20 Kyle Moffett : > The name of the "phy_start_aneg()" function is very confusing, because > it also handles forced-mode (AUTONEG_DISABLE) links. > > Rename the function to phy_start_link() and fix up all users. > > Signed-off-by: Kyle Moffett Sounds good to me. Acked-by: Andy Fleming _

RE: fpga driver on custom PPC target platform (P4080) ...

2011-11-03 Thread Robert Sciuk
> -Original Message- > From: Segher Boessenkool [mailto:seg...@kernel.crashing.org] > Sent: Thursday, November 03, 2011 5:22 PM > To: Robert Sciuk > Cc: devicetree-disc...@lists.ozlabs.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: fpga driver on custom PPC target platform (P4080) ...

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Segher Boessenkool
Arithmetic on 'void *' should not be done. I know some versions of gcc allow it (provided some warning level/option is enabled) but that doesn't mean it is valid. All relevant GCC versions support it (going back to 2.x at least). It is _always_ allowed, whatever compiler options you use; -pedant

Re: fpga driver on custom PPC target platform (P4080) ...

2011-11-03 Thread Segher Boessenkool
- How does one specify in the device tree an FPGA which uses both I2c bus and localbus for programming? You have two device nodes, one on the localbus and one on the IIC bus. One of the nodes points to the other, or both do; you point to another node by having a property containing the p

Re: [PATCH] powerpc/85xx: do not force PHYS_64BIT on Freescale reference boards

2011-11-03 Thread Kumar Gala
On Nov 3, 2011, at 2:01 PM, Timur Tabi wrote: > Kumar Gala wrote: >> Nak. For certain boards like P204x-P50xx we only support a 36-bit address >> map. > > I understand that we don't supply a 32-bit U-boot or device tree, but is > there any hard requirement that we force 36-bit kernels? If it'

[PATCH] powerpc/85xx: do not force PHYS_64BIT on the P1022DS

2011-11-03 Thread Timur Tabi
Kconfig option PHYS_64BIT sets the size of phys_addr_t to 64 bits, which allows support for a 36-bit physical address space. With this option, the kernel can support more than 2GB of RAM, but the larger address size impacts performance slightly. By including "select PHYS_64BIT" in the Kconfig for

Re: [PATCH] powerpc/85xx: do not force PHYS_64BIT on Freescale reference boards

2011-11-03 Thread Timur Tabi
Kumar Gala wrote: > Nak. For certain boards like P204x-P50xx we only support a 36-bit address > map. I understand that we don't supply a 32-bit U-boot or device tree, but is there any hard requirement that we force 36-bit kernels? If it's really a requirement, then adding to the Kconfig of each

Re: [PATCH] powerpc/85xx: do not force PHYS_64BIT on Freescale reference boards

2011-11-03 Thread Kumar Gala
On Nov 3, 2011, at 1:50 PM, Timur Tabi wrote: > Kconfig option PHYS_64BIT sets the size of phys_addr_t to 64 bits, which > allows support for a 36-bit physical address space. With this option, the > kernel can support more than 2GB of RAM, but the larger address size > impacts performance slight

[PATCH] powerpc/85xx: do not force PHYS_64BIT on Freescale reference boards

2011-11-03 Thread Timur Tabi
Kconfig option PHYS_64BIT sets the size of phys_addr_t to 64 bits, which allows support for a 36-bit physical address space. With this option, the kernel can support more than 2GB of RAM, but the larger address size impacts performance slightly. By including "select PHYS_64BIT" in the Kconfig for

[git pull] Please pull powerpc.git next branch

2011-11-03 Thread Kumar Gala
The following changes since commit 7680057cc4c7d9caada12767831bfd9738dd7b43: powerpc: Don't try OPAL takeover on old 970 blades (2011-09-29 17:04:59 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git next Anatolij Gustschin (1):

Re: [PATCH] Fix interrupt handling in MPC8xxx GPIO driver

2011-11-03 Thread Kumar Gala
On Oct 11, 2011, at 3:24 AM, Felix Radensky wrote: > Interrupt handler in MPC8xxx GPIO driver is missing the call > to PIC EOI (end of interrupt) handler. As a result, at least > on 85XX systems, GPIO interrupt is delivered only once. This > patch adds the missing EOI call. Tested on custom P1022

Re: [PATCH] mcu_mpc8349emitx.c: add shutdown request support

2011-11-03 Thread Kumar Gala
On Aug 15, 2011, at 9:19 AM, Fabio Baltieri wrote: > This patch add support for calling ctrl_alt_del() when the power button is > pressed for more than about 2 seconds on some freescale MPC83xx > evaluation boards and reference design. > > The code uses a kthread to poll the CTRL_BTN bit each se

Re: [PATCH] powerpc/85xx: Setup secondary cores PIR with hard SMP id

2011-11-03 Thread Kumar Gala
On Oct 14, 2011, at 2:52 AM, Kumar Gala wrote: > Normally logical and hard cpu ID are the same, however in same cases like > on the P3060 they may differ. Where the logical is 0..5, the hard id > goes 0,1,4..7. This can causes issues for places we utilize PIR to index > into array like in debug

Re: [PATCH] powerpc/cpm: Clear muram before it is in use.

2011-11-03 Thread Kumar Gala
On Oct 19, 2011, at 2:18 AM, Kumar Gala wrote: > From: Hongjun Chen > > We need to ensure that MURAM is in a known and cleared out state before > using it as the bootloader could have utilized it from its own purposes > and left it in an unknown state. > > If we don't clear it out we've seen i

Re: [PATCH 3/5] powerpc/85xx: Make kexec to interate over online cpus

2011-11-03 Thread Kumar Gala
On Oct 25, 2011, at 5:54 PM, Matthew McClintock wrote: > This is not strictly required, because this iterates over logical > cpus and they are not (currently) discontigous. But, it's cleaner > code and more obvious what is going on > > Signed-off-by: Matthew McClintock > --- > arch/powerpc/plat

Re: [PATCH 2/5] powerpc/fsl_booke: Fix comment in head_fsl_booke.S

2011-11-03 Thread Kumar Gala
On Oct 25, 2011, at 5:54 PM, Matthew McClintock wrote: > Fix typo in comments introduced by: > > commit 6dece0eb69b2a28e18d104bc5d707f1cb673f5e0 > Author: Scott Wood > Date: Mon Jul 25 11:29:33 2011 + > >powerpc/32: Pass device tree address as u64 to machine_init > > Signed-off-by:

Re: [PATCH v4 1/5] powerpc/85xx: issue 15 EOI after core reset for FSL CoreNet devices

2011-11-03 Thread Kumar Gala
On Oct 26, 2011, at 1:46 PM, Matthew McClintock wrote: > This is listed as a requirement for Freescale CoreNet based devices (e.g > p4080ds with MPIC v4.x) after issuing a core reset to properly clear pending > interrupts. > > Signed-off-by: Matthew McClintock > --- > v2: Updated commit messag

Re: [PATCH 01/11] powerpc/85xx: Add 'fsl, pq3-gpio' compatiable for GPIO driver

2011-11-03 Thread Kumar Gala
On Oct 22, 2011, at 4:20 PM, Kumar Gala wrote: > Support MPC85xx platforms outside of MPC8572/MPC8536. The > MPC8572/MPC8536 have an erratum that is worked around based on having > "fsl,mpc8572-gpio" in the compatiable list. All other MPC85xx SoCs > don't require this workaround and thus utiliz

Re: [PATCH] powerpc/86xx: Correct Gianfar support for GE boards

2011-11-03 Thread Kumar Gala
On Nov 3, 2011, at 12:37 PM, Martyn Welch wrote: > The GE DTBs were not updated when the Gianfar driver was converted to an > of_platform_driver in commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4. Update > the DTBs, adding the required TBI entries. > > Signed-off-by: Martyn Welch > --- > > arc

[PATCH] powerpc/86xx: Correct Gianfar support for GE boards

2011-11-03 Thread Martyn Welch
The GE DTBs were not updated when the Gianfar driver was converted to an of_platform_driver in commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4. Update the DTBs, adding the required TBI entries. Signed-off-by: Martyn Welch --- arch/powerpc/boot/dts/gef_ppc9a.dts | 33 +

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Timur Tabi
On Nov 3, 2011, at 7:16 AM, David Laight wrote: > Arithmetic on 'void *' should not be done. I know some versions of > gcc allow it (provided some warning level/option is enabled) but > that doesn't mean it is valid. > My suspicions are that is was allowed due to the way 'void *' > was originally

Re: [PATCH 2/4] powerpc/time: Use clocksource_register_hz

2011-11-03 Thread John Stultz
On Thu, 2011-11-03 at 11:59 +1100, Anton Blanchard wrote: > plain text document attachment (clock3) > Use clocksource_register_hz which calculates the shift/mult > factors for us. > > Signed-off-by: Anton Blanchard > --- > > Index: linux-build/arch/powerpc/kernel/time.c > ===

RE: Support for multiple MSI interrupts on MPC8377

2011-11-03 Thread Giffel, Brad
A single MSI interrupt it is then. Thanks, - Brad -Original Message- From: Michael Ellerman [mailto:mich...@ellerman.id.au] Sent: Wednesday, November 02, 2011 10:51 PM To: Giffel, Brad Cc: linuxppc-dev@lists.ozlabs.org; Matthew Wilcox Subject: Re: Support for multiple MS

RE: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread David Laight
> >> > usb_sys_regs = (void *)dr_regs + USB_DR_SYS_OFFSET; > > > But that is invalid C. > > What's invalid about it? I haven't tried compiling this > specific line of code, but I've done stuff like it in the past many times. > > Are you talking about adding an integer to a void pointer? > I

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Tabi Timur-B04825
David Laight wrote: >> > usb_sys_regs = (void *)dr_regs + USB_DR_SYS_OFFSET; > But that is invalid C. What's invalid about it? I haven't tried compiling this specific line of code, but I've done stuff like it in the past many times. Are you talking about adding an integer to a void pointer?

RE: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread David Laight
> On Thu, Nov 3, 2011 at 4:58 AM, Shaohui Xie wrote: > > > >                usb_sys_regs = (struct usb_sys_interface *) > > -                               ((u32)dr_regs + USB_DR_SYS_OFFSET); > > +                               ((unsigned long)dr_regs + > > USB_DR_SYS_OFFSET); > > This makes m

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Tabi Timur-B04825
On Thu, Nov 3, 2011 at 4:58 AM, Shaohui Xie wrote: > >                usb_sys_regs = (struct usb_sys_interface *) > -                               ((u32)dr_regs + USB_DR_SYS_OFFSET); > +                               ((unsigned long)dr_regs + USB_DR_SYS_OFFSET); This makes more sense: usb_sys_r

RE: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread David Laight
> Below are codes for accessing usb sysif_regs in driver: > > usb_sys_regs = (struct usb_sys_interface *) > ((u32)dr_regs + USB_DR_SYS_OFFSET); > > these codes work in 32-bit, but in 64-bit, use u32 to type cast the address > of ioremap is not right, and accessing members of 'usb_sys_regs

[PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Shaohui Xie
Below are codes for accessing usb sysif_regs in driver: usb_sys_regs = (struct usb_sys_interface *) ((u32)dr_regs + USB_DR_SYS_OFFSET); these codes work in 32-bit, but in 64-bit, use u32 to type cast the address of ioremap is not right, and accessing members of 'usb_sys_regs' will cause c