Re: net: fix typo in freescale/ucc_geth.c

2012-10-09 Thread Eric Dumazet
On Tue, 2012-10-09 at 10:52 +1100, Michael Neuling wrote: The following patch: acb600d net: remove skb recycling added dev_free_skb() to drivers/net/ethernet/freescale/ucc_geth.c This is a typo and should be dev_kfree_skb(). This fixes this. Signed-off-by: Michael Neuling

Re: [RFC v9 PATCH 00/21] memory-hotplug: hot-remove physical memory

2012-10-09 Thread Wen Congyang
At 09/27/2012 12:46 AM, Vasilis Liaskovitis Wrote: Hi, I am testing 3.6.0-rc7 with this v9 patchset plus more recent fixes [1],[2],[3] Running in a guest (qemu+seabios from [4]). CONFIG_SLAB=y CONFIG_DEBUG_SLAB=y After succesfull hot-add and online, I am doing a hot-remove with echo 1

Re: [RFC v9 PATCH 00/21] memory-hotplug: hot-remove physical memory

2012-10-09 Thread Wen Congyang
At 09/27/2012 12:46 AM, Vasilis Liaskovitis Wrote: Hi, I am testing 3.6.0-rc7 with this v9 patchset plus more recent fixes [1],[2],[3] Running in a guest (qemu+seabios from [4]). CONFIG_SLAB=y CONFIG_DEBUG_SLAB=y After succesfull hot-add and online, I am doing a hot-remove with echo 1

Re: [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-09 Thread wujianguo
Hi Congyang, I think we should also free pages which are used by page tables after removing page tables of the memory. From: Jianguo Wu wujian...@huawei.com Signed-off-by: Jianguo Wu wujian...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- arch/x86/mm/init_64.c | 110

[GIT PULL] Disintegrate UAPI for powerpc [ver #2]

2012-10-09 Thread David Howells
' (Andrew's patch-bomb) (2012-10-09 16:23:15 +0900) are available in the git repository at: git://git.infradead.org/users/dhowells/linux-headers.git tags/disintegrate-powerpc-20121009 for you to fetch changes up to c3617f72036c909e1f6086b5b9e364e0ef90a6da: UAPI: (Scripted) Disintegrate arch/powerpc

[m68k,powerpc,dma,ethernet,freescale RFA] Coldfire m54xx FEC ethernet driver

2012-10-09 Thread Philippe De Muyter
[CCing lkml, linux-ppc, netdev, linux-m68k] Hello kernel sources architects I have a working driver for the m54xx FEC ethernet driver that I would like to integrate in the kernel tree. Problems are that - this driver needs an associated DMA driver (provided by FreeScale) wich is not dma-engine

[RFC Patch] 405gp IBM EMAC Phy probe fails with no link

2012-10-09 Thread Andrew May
I have an older PPC 405GP board with a 2.6.33 kernel that fails to install a eth0 instance because the phy probe fails when there is no good ethernet link. I have looked at the latest kernel code and it seems just about the same in this area, but I have not tried it. Does anyone else still

support for Xilinx PCIe BUS IP core

2012-10-09 Thread Bashar Romanous
Dear All, This is the first thread in the list, I'm working on research project that requires me to have PCI Express Bus Support for Xilinx FPGA board ML605 running PetaLinux (kernel 2.6.37.6) on MicroBlaze. I'm using Xilinx soft IP core PLB2PCIe bridge configured as Root Complex. the problem is

Re: gianfar driver crash on P1020

2012-10-09 Thread Avi Tsarfati
Hi, I have the same problem as you do. Have you found the CPU stuck reason (or fix) in P1020RDB board ? Thanks, Avi Tsarfati. This footnote confirms that this email message has been scanned by

答复: [RFC PATCH] powerpc/fsl: add timer wakeup source

2012-10-09 Thread Wang Dongsheng-B40534
I'm pretty sure /proc/ is NOT where we want this exposed. Should probably go under the sysfs directory of the mpic device. Or better, make a generic interface for timer-based suspend wakeup (if there isn't one already). This current approach sits in an unpleasant middle

[PATCH 01/20] powerpc/udbg: Remove unused udbg_read()

2012-10-09 Thread Michael Ellerman
The last user of udbg_read() was removed in 2005, in commit fca5dcd Simplify and clean up the xmon terminal I/O. Given we haven't needed it for 7 years we can probably drop it. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/include/asm/udbg.h |1 -

[PATCH 02/20] powerpc/xmon: Remove unused xmon_expect() xmon_read_poll()

2012-10-09 Thread Michael Ellerman
It looks like xmon_expect() was used for doing xmon over a modem (!?), that code was dropped in 2005 in commit 51d3082 Unify udbg (#2). Once xmon_expect() is gone xmon_read_poll() is unused, drop it too. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/nonstdio.c |

[PATCH 03/20] powerpc/xmon: Remove empty xmon_map_scc()

2012-10-09 Thread Michael Ellerman
This has been empty since 2005, commit 51d3082 Unify udbg (#2). Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/nonstdio.h |1 - arch/powerpc/xmon/start.c|4 arch/powerpc/xmon/xmon.c |1 - 3 files changed, 6 deletions(-) diff --git

[PATCH 04/20] powerpc/xmon: Make xmon_getchar() static

2012-10-09 Thread Michael Ellerman
xmon_getchar() is only called from within nonstdio.c, so make it static. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/nonstdio.c |2 +- arch/powerpc/xmon/nonstdio.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 05/20] powerpc/xmon: Merge start.c into nonstdio.c

2012-10-09 Thread Michael Ellerman
The routines in start.c are only ever called from nonstdio.c, so if we move them in there they can become static which is nice. I suspect the idea behind the separation was that start.c could be replaced in order to build xmon in userland. If anyone still cares about doing that we could handle

[PATCH 06/20] powerpc/xmon: Remove renaming #defines of scanhex() and skipbl()

2012-10-09 Thread Michael Ellerman
We have two #defines that rename scanhex() and skipbl() to xmon_scanhex() and xmon_skipbl() - but no one ever uses those names. So the only effect is to rename the actual symbols in the generated code, and AFACIS there is no reason to do that, so drop them. Signed-off-by: Michael Ellerman

[PATCH 07/20] powerpc/xmon: Remove unused #defines

2012-10-09 Thread Michael Ellerman
Neither REGS_PER_LINE or LAST_VOLATILE are used, nor have they ever been as far back as I can see. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c |4 1 file changed, 4 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c

[PATCH 08/20] powerpc/xmon: Use STACK_FRAME_OVERHEAD in xmon_show_stack()

2012-10-09 Thread Michael Ellerman
We use STACK_FRAME_OVERHEAD in the exception vectors to establish the exception frame, so it should be good enough to use here. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git

[PATCH 10/20] powerpc/xmon: Factor out the oft-repeated setjmp logic

2012-10-09 Thread Michael Ellerman
We have over 15 routines that implement essentially the same logic in terms of catching faults. Pull the logic out into two helper routines. The pattern becomes: if (start_bus_error_jump() == 0) { do potentially faulting things end_bus_error_jump();

[PATCH 11/20] powerpc/xmon: Move handle_fault() next to related routines

2012-10-09 Thread Michael Ellerman
Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c | 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 168c5e7..65c3d22 100644 ---

[PATCH 12/20] powerpc/xmon: Do so simple conversions to start/end_bus_error_jump()

2012-10-09 Thread Michael Ellerman
Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c | 79 +++--- 1 file changed, 18 insertions(+), 61 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 65c3d22..45be9ce 100644 ---

[PATCH 13/20] powerpc/xmon: Use start/end_bus_error_jump() in more routines

2012-10-09 Thread Michael Ellerman
These are not entirely equivalent to the old code. In most cases they just gain a call to __delay() via end_bus_error_jump(). In symbol_lookup() we also move the printf() outside the protected area, this should be safe as we are not derefencing the value we lookup, just printing its value.

[PATCH 14/20] powerpc/xmon: Convert read/write_spr() to use start_bus_error_jump()

2012-10-09 Thread Michael Ellerman
read_spr() and write_spr() were both forgetting to clear catch_memory_errors, that's fixed now that they use start/end_bus_error_jump(). Also drop the setting of n in both routines, it's never used. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c | 22

[PATCH 15/20] powerpc/xmon: Deindent stop/restart_spus()

2012-10-09 Thread Michael Ellerman
Should be no logic change, use continue to avoid an indent. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c | 72 -- 1 file changed, 38 insertions(+), 34 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c

[PATCH 16/20] powerpc/xmon: Use start_bus_error_jump() in spu routines

2012-10-09 Thread Michael Ellerman
Moves the printfs setting of stopped_ok out of the protected area. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c

[PATCH 17/20] powerpc/xmon: Make less variables global

2012-10-09 Thread Michael Ellerman
Move a number of variables into their only user, reducing some of the global variable clutter. They remain static, so their behaviour across calls is unchanged. Also use ARRAY_SIZE for regnames in scanhex(). Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c |

[PATCH 18/20] powerpc/xmon: Use kallsyms_lookup_size_offset() in get_function_bounds()

2012-10-09 Thread Michael Ellerman
We throw away the name so we should use kallsyms_lookup_size_offset(), which does what we need and nothing more. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c

[PATCH 19/20] powerpc/xmon: Remove externs for non-existant routines

2012-10-09 Thread Michael Ellerman
The implementation of both xmon_enter() xmon_leave() was removed in commit 51d3082 Unify udbg (#2). I can't find any reference to exc_prolog or dec_exc since the epoch. Signed-off-by: Michael Ellerman mich...@ellerman.id.au --- arch/powerpc/xmon/xmon.c |6 -- 1 file changed, 6

[PATCH 20/20] powerpc/xmon: Fallback to printk() in xmon_printf() if udbg is not setup

2012-10-09 Thread Michael Ellerman
It is possible to configure a kernel which has xmon enabled, but has no udbg backend to provide IO. This can make xmon rather confusing, as it produces no output, blocks for two seconds, and then returns. As a last resort we can instead try to printk(), which may deadlock or otherwise crash, but

RE: [PATCH 06/20] powerpc/xmon: Remove renaming #defines of scanhex() and skipbl()

2012-10-09 Thread David Laight
We have two #defines that rename scanhex() and skipbl() to xmon_scanhex() and xmon_skipbl() - but no one ever uses those names. It looks like they are there for namespace protection. David ___ Linuxppc-dev mailing list

Re: 答复: [RFC PATCH] powerpc/fsl: add timer wakeup source

2012-10-09 Thread Scott Wood
On 10/09/2012 08:56:53 AM, Wang Dongsheng-B40534 wrote: I'm pretty sure /proc/ is NOT where we want this exposed. Should probably go under the sysfs directory of the mpic device. Or better, make a generic interface for timer-based suspend wakeup (if there isn't one

Re: gianfar driver crash on P1020

2012-10-09 Thread Claudiu Manoil
Hello, Did you try this patch? http://patchwork.ozlabs.org/patch/186315/ Claudiu On 10/9/2012 3:22 PM, Avi Tsarfati wrote: Hi, I have the same problem as you do. Have you found the CPU stuck reason (or fix) in P1020RDB board ? Thanks, Avi Tsarfati.

RE: gianfar driver crash on P1020

2012-10-09 Thread Avi Tsarfati
Thank you very much for your quick response and willing to share. I'll test it and let you know. From: Claudiu Manoil [mailto:claudiu.man...@freescale.com] Sent: Tuesday, October 09, 2012 6:37 PM To: Avi Tsarfati Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: gianfar driver crash on P1020

[PATCH 3/3] rapidio: update for destination ID allocation

2012-10-09 Thread Alexandre Bounine
This patch address comments provided by Andrew Morton: https://lkml.org/lkml/2012/10/3/550 - Keeps consistent kerneldoc compatible comments style for new static functions. - Removes unnecessary complexity from destination ID allocation routine. - Uses kcalloc() for code clarity. Signed-off-by:

[PATCH 0/3] rapidio: updates for multiple mport patches

2012-10-09 Thread Alexandre Bounine
This is a set of updates for patches submitted earlier: https://lkml.org/lkml/2012/10/3/460. Alexandre Bounine (3): rapidio: use msleep in discovery wait rapidio: update asynchronous discovery initialization rapidio: update for destination ID allocation drivers/rapidio/rio-scan.c | 40

[PATCH 1/3] rapidio: use msleep in discovery wait

2012-10-09 Thread Alexandre Bounine
Use msleep() routine for code clarity as suggested by Andrew Morton in his comments for the original patch: https://lkml.org/lkml/2012/10/3/546. Signed-off-by: Alexandre Bounine alexandre.boun...@idt.com Cc: Matt Porter mpor...@kernel.crashing.org Cc: Li Yang le...@freescale.com ---

[PATCH 2/3] rapidio: update asynchronous discovery initialization

2012-10-09 Thread Alexandre Bounine
Update discovery process initialization based on Andrew Morton's comments: https://lkml.org/lkml/2012/10/3/552. This update processes all enumerating mports first and schedules discovery work after that. If the initialization routine fails to allocate resources needed to execute discovery, it

Re: memory-hotplug : suppres Trying to free nonexistent resource XXXXXXXXXXXXXXXX-YYYYYYYYYYYYYYYY warning

2012-10-09 Thread Andrew Morton
On Tue, 9 Oct 2012 11:51:38 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: Anyway, please have a think, and see if we can come up with the best and most accurate choice of types and identifiers in this code. Your concern is right. Overflow bug may occur in the future. So I

Re: [PATCH 10/20] powerpc/xmon: Factor out the oft-repeated setjmp logic

2012-10-09 Thread Paul Mackerras
On Wed, Oct 10, 2012 at 01:20:37AM +1100, Michael Ellerman wrote: We have over 15 routines that implement essentially the same logic in terms of catching faults. Pull the logic out into two helper routines. The pattern becomes: if (start_bus_error_jump() == 0) { do

Re: [PATCH 06/20] powerpc/xmon: Remove renaming #defines of scanhex() and skipbl()

2012-10-09 Thread Paul Mackerras
On Wed, Oct 10, 2012 at 01:20:33AM +1100, Michael Ellerman wrote: We have two #defines that rename scanhex() and skipbl() to xmon_scanhex() and xmon_skipbl() - but no one ever uses those names. So the only effect is to rename the actual symbols in the generated code, and AFACIS there is no

linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function 'pseries_remove_memblock': arch/powerpc/platforms/pseries/hotplug-memory.c:103:17: error: unused variable 'pfn' [-Werror=unused-variable]

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Andrew Morton
On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function 'pseries_remove_memblock':

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Yasuaki Ishimatsu
Hi Stephen, 2012/10/10 8:45, Andrew Morton wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/pseries/hotplug-memory.c: In function

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi Andrew, On Tue, 9 Oct 2012 16:45:14 -0700 Andrew Morton a...@linux-foundation.org wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: I can't see what the point of the pfn variable is This: ---

Re: [PATCH 10/20] powerpc/xmon: Factor out the oft-repeated setjmp logic

2012-10-09 Thread Michael Ellerman
On Wed, 2012-10-10 at 09:23 +1100, Paul Mackerras wrote: On Wed, Oct 10, 2012 at 01:20:37AM +1100, Michael Ellerman wrote: We have over 15 routines that implement essentially the same logic in terms of catching faults. Pull the logic out into two helper routines. The pattern becomes:

Re: [PATCH 06/20] powerpc/xmon: Remove renaming #defines of scanhex() and skipbl()

2012-10-09 Thread Michael Ellerman
On Wed, 2012-10-10 at 09:15 +1100, Paul Mackerras wrote: On Wed, Oct 10, 2012 at 01:20:33AM +1100, Michael Ellerman wrote: We have two #defines that rename scanhex() and skipbl() to xmon_scanhex() and xmon_skipbl() - but no one ever uses those names. So the only effect is to rename the

Re: [GIT PULL] Disintegrate UAPI for powerpc [ver #2]

2012-10-09 Thread Benjamin Herrenschmidt
/dhowells/linux-headers.git tags/disintegrate-powerpc-20121009 for you to fetch changes up to c3617f72036c909e1f6086b5b9e364e0ef90a6da: UAPI: (Scripted) Disintegrate arch/powerpc/include/asm (2012-10-09 09:47:26 +0100

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Stephen Rothwell
Hi, On Wed, 10 Oct 2012 08:52:21 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: 2012/10/10 8:45, Andrew Morton wrote: On Wed, 10 Oct 2012 10:21:50 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Linus, In Linus' tree, today's linux-next build (powerpc

Re: [GIT PULL] Disintegrate UAPI for powerpc [ver #2]

2012-10-09 Thread Benjamin Herrenschmidt
at: git://git.infradead.org/users/dhowells/linux-headers.git tags/disintegrate-powerpc-20121009 for you to fetch changes up to c3617f72036c909e1f6086b5b9e364e0ef90a6da: UAPI: (Scripted) Disintegrate arch/powerpc/include/asm (2012-10-09 09:47:26 +0100