Re: [RFC PATCH v2 3/4] powerpc: Don't bolt the hpte in kernel_map_linear_page()

2013-04-15 Thread Benjamin Herrenschmidt
On Mon, 2013-04-15 at 13:50 +1000, Paul Mackerras wrote: > On Fri, Apr 12, 2013 at 10:16:59AM +0800, Li Zhong wrote: > > It seems that in kernel_unmap_linear_page(), it only checks whether there > > is a map in the linear_map_hash_slots array, so seems we don't need bolt > > the hpte. > > I don't

Re: [PATCH 1/8] Remove syslog prefix in uncompressed oops text

2013-04-15 Thread Michael Ellerman
On Wed, Apr 10, 2013 at 12:51:00PM +0530, Aruna Balakrishnaiah wrote: > Removal of syslog prefix in the uncompressed oops text will > help in capturing more oops data. Why does it help? Does this effect any existing tools? cheers ___ Linuxppc-dev mailin

Re: [PATCH] powerpc/perf: Power8 PMU support

2013-04-15 Thread Benjamin Herrenschmidt
On Mon, 2013-04-15 at 14:17 +1000, Michael Ellerman wrote: > This patch adds preliminary support for the power8 PMU to perf. Might be worthwhile to have a small blurb explaining roughly what you mean by "preliminary" :-) Cheers, Ben. > Signed-off-by: Michael Ellerman > --- > arch/powerpc/perf/

Re: [PATCH 2/8] Add version and timestamp to oops header

2013-04-15 Thread Michael Ellerman
On Wed, Apr 10, 2013 at 12:51:12PM +0530, Aruna Balakrishnaiah wrote: > Introduce version and timestamp information in the oops header. > oops_log_info (oops header) holds version (to distinguish between old > and new format oops header), length of the oops text > (compressed or uncompressed) and t

Re: [PATCH 3/8] Introduce generic read function to read nvram-partitions

2013-04-15 Thread Michael Ellerman
On Wed, Apr 10, 2013 at 12:51:25PM +0530, Aruna Balakrishnaiah wrote: > Introduce generic read function to read nvram partitions other than rtas. > nvram_read_error_log will be retained which is used to read rtas partition > from rtasd. nvram_read_partition is the generic read function to read from

Re: [PATCH 0/8] Nvram-to-pstore

2013-04-15 Thread Michael Ellerman
On Wed, Apr 10, 2013 at 12:50:47PM +0530, Aruna Balakrishnaiah wrote: > Currently the kernel provides the contents of p-series NVRAM only as a > simple stream of bytes via /dev/nvram, which must be interpreted in user > space by the nvram command in the powerpc-utils package. This patch set > expl

Re: [PATCH 1/8] Remove syslog prefix in uncompressed oops text

2013-04-15 Thread aruna
On Monday 15 April 2013 12:50 PM, Michael Ellerman wrote: On Wed, Apr 10, 2013 at 12:51:00PM +0530, Aruna Balakrishnaiah wrote: Removal of syslog prefix in the uncompressed oops text will help in capturing more oops data. Why does it help? Does this effect any existing tools? cheers By sett

Re: [PATCH 4/8] Read/Write oops nvram partition via pstore

2013-04-15 Thread Michael Ellerman
On Wed, Apr 10, 2013 at 12:53:03PM +0530, Aruna Balakrishnaiah wrote: > This patch exploits pstore infrastructure in power systems. > IBM's system p machines provide persistent storage for LPARs In the kernel we use "pseries" instead of "system p". > through NVRAM. NVRAM's lnx,oops-log partition

Re: [PATCH 2/8] Add version and timestamp to oops header

2013-04-15 Thread aruna
On Monday 15 April 2013 01:01 PM, Michael Ellerman wrote: On Wed, Apr 10, 2013 at 12:51:12PM +0530, Aruna Balakrishnaiah wrote: Introduce version and timestamp information in the oops header. oops_log_info (oops header) holds version (to distinguish between old and new format oops header), lengt

Re: [PATCH 5/8] Read rtas partition via pstore

2013-04-15 Thread Michael Ellerman
On Wed, Apr 10, 2013 at 12:53:27PM +0530, Aruna Balakrishnaiah wrote: > This patch exploits pstore infrastructure to read the details > from NVRAM's rtas partition. Does that mean it's exposed in the pstore filesystem? > Signed-off-by: Aruna Balakrishnaiah > Reviewed-by: Jim Keniston > --- > a

Re: [RFC PATCH v2 3/4] powerpc: Don't bolt the hpte in kernel_map_linear_page()

2013-04-15 Thread Li Zhong
On Mon, 2013-04-15 at 08:56 +0200, Benjamin Herrenschmidt wrote: > On Mon, 2013-04-15 at 13:50 +1000, Paul Mackerras wrote: > > On Fri, Apr 12, 2013 at 10:16:59AM +0800, Li Zhong wrote: > > > It seems that in kernel_unmap_linear_page(), it only checks whether there > > > is a map in the linear_map_

Re: [RFC PATCH v2 1/4] powerpc: Move the setting of rflags out of loop in __hash_page_huge

2013-04-15 Thread Li Zhong
On Mon, 2013-04-15 at 16:32 +1000, Michael Ellerman wrote: > On Fri, Apr 12, 2013 at 10:16:57AM +0800, Li Zhong wrote: > > It seems that rflags don't get changed in the repeating loop, so move > > it out of the loop. > You've also changed the way new_pte is handled on repeat, but I think > that's

Re: [RFC PATCH v2 4/4] powerpc: Try to insert the hptes repeatedly in kernel_map_linear_page()

2013-04-15 Thread Li Zhong
On Mon, 2013-04-15 at 16:36 +1000, Michael Ellerman wrote: > On Fri, Apr 12, 2013 at 10:17:00AM +0800, Li Zhong wrote: > > This patch tries to fix following issue when CONFIG_DEBUG_PAGEALLOC > > is enabled: > > Please include a better changelog. OK, I'll use the following as a template, thank you

Re: [PATCH] powerpc/perf: Power8 PMU support

2013-04-15 Thread Michael Ellerman
On Mon, Apr 15, 2013 at 09:31:26AM +0200, Benjamin Herrenschmidt wrote: > On Mon, 2013-04-15 at 14:17 +1000, Michael Ellerman wrote: > > This patch adds preliminary support for the power8 PMU to perf. > > Might be worthwhile to have a small blurb explaining roughly what you > mean by "preliminary"

Re: [RFC PATCH v2 3/4] powerpc: Don't bolt the hpte in kernel_map_linear_page()

2013-04-15 Thread Benjamin Herrenschmidt
On Mon, 2013-04-15 at 16:15 +0800, Li Zhong wrote: > So the code is implemented in ppc_md.hpte_remove(), may be called by > __hash_huge_page(), and asm code htab_call_hpte_remove? > > > This is why the linear mapping (and the vmemmap) must be bolted. > > If not, it would result the infinite recu

Re: [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection

2013-04-15 Thread Michael Ellerman
On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote: > On pseries machines the detection for max_bus_speed should be done > through an OpenFirmware property. This patch adds a function to perform this > detection and a hook to perform dynamic adding of the function only for > ps

Re: [PATCH 1/2] powerpc: remove section changes from _GLOBAL() and friends

2013-04-15 Thread Michael Ellerman
On Thu, Nov 29, 2012 at 10:55:25AM +1100, Stephen Rothwell wrote: > These sometimes produce unexpected results and make it hard to put the > start up code (for 64 bit) into the .head.text section. ... > diff --git a/arch/powerpc/kernel/head_fsl_booke.S > b/arch/powerpc/kernel/head_fsl_booke.S >

Re: [PATCH 1/2] powerpc: remove section changes from _GLOBAL() and friends

2013-04-15 Thread Stephen Rothwell
Hi Michael, On Mon, 15 Apr 2013 22:00:17 +1000 Michael Ellerman wrote: > > On Thu, Nov 29, 2012 at 10:55:25AM +1100, Stephen Rothwell wrote: > > These sometimes produce unexpected results and make it hard to put the > > start up code (for 64 bit) into the .head.text section. > > ... > > > diff

Re: [PATCH 1/3] iommu: Move swap_pci_ref function to pci.h.

2013-04-15 Thread Joerg Roedel
On Mon, Apr 15, 2013 at 12:42:00AM +0530, Varun Sethi wrote: > swap_pci_ref function is used by the IOMMU API code for swapping pci device > pointers, while determining the iommu group for the device. > Currently this function was being implemented for different IOMMU drivers. > This patch moves th

Re: [PATCH 1/3] iommu: Move swap_pci_ref function to pci.h.

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 8:58 AM, Joerg Roedel wrote: > On Mon, Apr 15, 2013 at 12:42:00AM +0530, Varun Sethi wrote: >> swap_pci_ref function is used by the IOMMU API code for swapping pci device >> pointers, while determining the iommu group for the device. >> Currently this function was being imp

Re: [PATCH 1/2] powerpc: remove section changes from _GLOBAL() and friends

2013-04-15 Thread Stephen Rothwell
Hi Michael, On Mon, 15 Apr 2013 23:30:40 +1000 Stephen Rothwell wrote: > > On Mon, 15 Apr 2013 22:00:17 +1000 Michael Ellerman > wrote: > > > > On Thu, Nov 29, 2012 at 10:55:25AM +1100, Stephen Rothwell wrote: > > > These sometimes produce unexpected results and make it hard to put the > > > s

Re: [PATCH] powerpc: fix usage of setup_pci_atmu()

2013-04-15 Thread Kim Phillips
On Mon, 15 Apr 2013 15:42:01 +1000 Michael Neuling wrote: > Linux next is currently failing to compile mpc85xx_defconfig with: > arch/powerpc/sysdev/fsl_pci.c:944:2: error: too many arguments to function > 'setup_pci_atmu' > > This is caused by (from Kumar's next branch): > commit 34642bbb3

RE: [PATCH 1/3] iommu: Move swap_pci_ref function to pci.h.

2013-04-15 Thread Sethi Varun-B16395
Fine, I will move it to iommu.h. -Varun > -Original Message- > From: Joerg Roedel [mailto:j...@8bytes.org] > Sent: Monday, April 15, 2013 8:29 PM > To: Sethi Varun-B16395 > Cc: Yoder Stuart-B08248; Wood Scott-B07421; iommu@lists.linux- > foundation.org; linuxppc-dev@lists.ozlabs.org; linu

Re: [PATCH v2 2/11] Add PRRN Event Handler

2013-04-15 Thread Nathan Fontenot
On 04/10/2013 03:30 AM, Michael Ellerman wrote: > On Mon, Mar 25, 2013 at 01:52:32PM -0500, Nathan Fontenot wrote: >> From: Jesse Larrew >> >> A PRRN event is signaled via the RTAS event-scan mechanism, which >> returns a Hot Plug Event message "fixed part" indicating "Platform >> Resource Reassig

Re: [RFC PATCH v2 3/4] powerpc: Don't bolt the hpte in kernel_map_linear_page()

2013-04-15 Thread Li Zhong
On Mon, 2013-04-15 at 13:27 +0200, Benjamin Herrenschmidt wrote: > On Mon, 2013-04-15 at 16:15 +0800, Li Zhong wrote: > > > So the code is implemented in ppc_md.hpte_remove(), may be called by > > __hash_huge_page(), and asm code htab_call_hpte_remove? > > > > > This is why the linear mapping (an

[RFC PATCH v3 1/3] powerpc: Move the setting of rflags out of loop in __hash_page_huge

2013-04-15 Thread Li Zhong
It seems that new_pte and rflags don't get changed in the repeating loop, so move their assignment out of the loop. Signed-off-by: Li Zhong --- arch/powerpc/mm/hugetlbpage-hash64.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/mm/hugetlbpage-hash64.c

[RFC PATCH v3 2/3] powerpc: Split the code trying to insert hpte repeatedly as an helper function

2013-04-15 Thread Li Zhong
Move the logic trying to insert hpte in __hash_page_huge() to an helper function, so it could also be used by others. Signed-off-by: Li Zhong --- arch/powerpc/mm/hash_utils_64.c | 35 ++ arch/powerpc/mm/hugetlbpage-hash64.c | 31 ++

[RFC PATCH v3 3/3] powerpc: Try to insert the hptes repeatedly in kernel_map_linear_page()

2013-04-15 Thread Li Zhong
This patch fixes the following oops, which could be trigged by build the kernel with many concurrent threads, under CONFIG_DEBUG_PAGEALLOC. hpte_insert() might return -1, indicating that the bucket (primary here) is full. We are not necessarily reporting a BUG in this case. Instead, we could try r

Re: [PATCHv3 2/2] radeon: use max_bus_speed to activate gen2 speeds

2013-04-15 Thread Dave Airlie
>> >> diff --git a/drivers/gpu/drm/radeon/evergreen.c >> b/drivers/gpu/drm/radeon/evergreen.c >> index 305a657..3291f62 100644 >> --- a/drivers/gpu/drm/radeon/evergreen.c >> +++ b/drivers/gpu/drm/radeon/evergreen.c >> @@ -3855,8 +3855,7 @@ void evergreen_fini(struct radeon_device *rdev) >> >> voi

Re: [PATCH] powerpc: Fix audit crash due to save/restore PPR changes

2013-04-15 Thread Haren Myneni
On 04/14/2013 06:44 PM, Alistair Popple wrote: > The current mainline crashes when hitting userspace with the following: > > kernel BUG at /home/alistair/Source/linux-stable/kernel/auditsc.c:1769! > cpu 0x1: Vector: 700 (Program Check) at [c00023883a60] > pc: c01047a8: .__audit_sys

Re: [PATCH 4/8] Read/Write oops nvram partition via pstore

2013-04-15 Thread Aruna Balakrishnaiah
Hi Michael, Thanks for reviewing my patches. On Monday 15 April 2013 01:25 PM, Michael Ellerman wrote: On Wed, Apr 10, 2013 at 12:53:03PM +0530, Aruna Balakrishnaiah wrote: This patch exploits pstore infrastructure in power systems. IBM's system p machines provide persistent storage for LPARs

Re: [PATCH 5/8] Read rtas partition via pstore

2013-04-15 Thread Aruna Balakrishnaiah
On Monday 15 April 2013 01:31 PM, Michael Ellerman wrote: On Wed, Apr 10, 2013 at 12:53:27PM +0530, Aruna Balakrishnaiah wrote: This patch exploits pstore infrastructure to read the details from NVRAM's rtas partition. Does that mean it's exposed in the pstore filesystem? Yeah thats right.

[PATCH] powerpc: Fix build errors with UP configs in HV-style KVM

2013-04-15 Thread Paul Mackerras
This fixes these errors when building UP with CONFIG_KVM_BOOK3S_64_HV=y: arch/powerpc/kvm/book3s_hv.c:1855:2: error: implicit declaration of function 'inhibit_secondary_onlining' [-Werror=implicit-function-declaration] arch/powerpc/kvm/book3s_hv.c:1862:2: error: implicit declaration of function

RE: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args()

2013-04-15 Thread Tang Yuantian-B29983
Hi Grant.likely, I really preciate if you can spend some times to review this patch. Thanks, Yuantian > -Original Message- > From: Tang Yuantian-B29983 > Sent: 2013年4月10日 11:37 > To: grant.lik...@secretlab.ca > Cc: rob.herr...@calxeda.com; devicetree-disc...@lists.ozlabs.org; linux- > ke

RE: [PATCH v3] clk: add PowerPC corenet clock driver support

2013-04-15 Thread Tang Yuantian-B29983
Hi Mike, I really appreciate if you can spend some times to review this patch. Thanks, Yuantian > -Original Message- > From: Tang Yuantian-B29983 > Sent: 2013年4月9日 16:46 > To: mturque...@linaro.org > Cc: linus.wall...@linaro.org; viresh.ku...@linaro.org; > shawn@linaro.org; ulf.hans