RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-28 Thread Tang Yuantian-B29983
Thanks for your review. > -Original Message- > From: Wood Scott-B07421 > Sent: 2013年10月29日 星期二 11:26 > To: Tang Yuantian-B29983 > Cc: Wood Scott-B07421; Mark Rutland; devicet...@vger.kernel.org; > linuxppc-dev@lists.ozlabs.org; Li Yang-Leo-R58472 > Subject: Re: [PATCH v5] powerpc/mpc85xx:

Re: [PATCH 3/3] sched: Aggressive balance in domains whose groups share package resources

2013-10-28 Thread Preeti U Murthy
Hi Peter, On 10/28/2013 09:23 PM, Peter Zijlstra wrote: > On Mon, Oct 21, 2013 at 05:15:02PM +0530, Vaidyanathan Srinivasan wrote: >> From: Preeti U Murthy >> >> The current logic in load balance is such that after picking the >> busiest group, the load is attempted to be moved from the busiest c

[PATCH] powerpc: boot: Don't change link address for OF-based platforms

2013-10-28 Thread Paul Mackerras
Commit c55aef0e5bc6 ("powerpc/boot: Change the load address for the wrapper to fit the kernel") adjusts the wrapper address unnecessarily for platforms that use arch/powerpc/boot/of.c, since the code there allocates space for the kernel wherever it can find it and doesn't necessarily load the kerne

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Nicolin Chen
On Tue, Oct 29, 2013 at 12:00:57PM +0800, Xiubo Li-B47053 wrote: > > There's a patch in -next that lets the generic dmaengine code figure out > > some settings from the dmacontroller rather than requiring the driver to > > explicitly provide configuration - it's "ASoC: dmaengine-pcm: Provide > > de

RE: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Xiubo Li-B47053
> > +static struct snd_pcm_hardware snd_fsl_hardware = { > > + .info = SNDRV_PCM_INFO_INTERLEAVED | > > + SNDRV_PCM_INFO_BLOCK_TRANSFER | > > + SNDRV_PCM_INFO_MMAP | > > + SNDRV_PCM_INFO_MMAP_VALID | > > + SNDRV_PCM_INFO_PAUSE | > > + SNDRV_PCM_I

Re: [PATCH 1/2][v8] powerpc/mpc85xx:Add initial device tree support of T104x

2013-10-28 Thread Prabhakar Kushwaha
On 10/29/2013 6:41 AM, Scott Wood wrote: On Mon, 2013-10-21 at 09:07 +0530, Prabhakar Kushwaha wrote: Hi Ben, This patch is present in upstream review list from a long time. There are no review comments. So, I request you to pick this patch-set for powerpc.git repository. http://patchwork.ozl

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-28 Thread Preeti U Murthy
Hi Peter, On 10/28/2013 07:20 PM, Peter Zijlstra wrote: > On Thu, Oct 24, 2013 at 01:37:38PM +0530, Preeti U Murthy wrote: >> kernel/sched/core.c |5 + >> kernel/sched/fair.c | 38 -- >> kernel/sched/sched.h |1 + >> 3 files changed, 26 insertio

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-28 Thread Scott Wood
On Sun, 2013-10-20 at 21:55 -0500, Tang Yuantian-B29983 wrote: > I didn't see how your suggestion is a better matching. > > OSC > PLL1 > mux > CPU > | | > |--> PLL2 --| > > As your suggestion, the clock tree looks like the above. > In this case,

[PATCH] powerpc: Fix PPC_EMULATED_STATS build break with sync patch

2013-10-28 Thread Scott Wood
Commit 9863c28a2af90a56c088f5f6288d7f6d2c923c14 ("powerpc: Emulate sync instruction variants") introduced a build breakage with CONFIG_PPC_EMULATED_STATS enabled. Signed-off-by: Scott Wood Cc: Kumar Gala Cc: James Yang --- --- arch/powerpc/include/asm/emulated_ops.h | 1 + arch/powerpc/kernel/

Re: Pull request: scottwood/linux.git next

2013-10-28 Thread Scott Wood
On Mon, 2013-10-28 at 21:44 -0500, Scott Wood wrote: > Sorry again for the lateness. I tried to get this done before the > conferences last week, but it just didn't happen. > > Highlights include corenet board file consolidation, the ability to run > userspaces with lwsync on e500v1/v2, some clea

Pull request: scottwood/linux.git next

2013-10-28 Thread Scott Wood
Sorry again for the lateness. I tried to get this done before the conferences last week, but it just didn't happen. Highlights include corenet board file consolidation, the ability to run userspaces with lwsync on e500v1/v2, some cleanup patches that other KVM patches will build on, support for s

Re: [PATCH 1/2][v8] powerpc/mpc85xx:Add initial device tree support of T104x

2013-10-28 Thread Scott Wood
On Mon, 2013-10-21 at 09:07 +0530, Prabhakar Kushwaha wrote: > Hi Ben, > > This patch is present in upstream review list from a long time. > There are no review comments. > > So, I request you to pick this patch-set for powerpc.git repository. > http://patchwork.ozlabs.org/patch/280207/ > http://

Re: [5/7] powerpc/corenet64_smp_defconfig: Enable most SPI splash

2013-10-28 Thread York Sun
On 10/28/2013 05:28 PM, Scott Wood wrote: > On Fri, Sep 06, 2013 at 08:43:17AM -0700, York Sun wrote: >> Enable CONFIG_MTD_M25P80 for corenet64_smp_defconfig. Verified on >> P5040DS. >> >> Signed-off-by: York Sun >> Reviewed-by: Wood Scott-B07421 >> Reviewed-by: Fleming Andrew-AFLEMING >> Tested

Re: [5/7] powerpc/corenet64_smp_defconfig: Enable most SPI splash

2013-10-28 Thread Scott Wood
On Fri, Sep 06, 2013 at 08:43:17AM -0700, York Sun wrote: > Enable CONFIG_MTD_M25P80 for corenet64_smp_defconfig. Verified on > P5040DS. > > Signed-off-by: York Sun > Reviewed-by: Wood Scott-B07421 > Reviewed-by: Fleming Andrew-AFLEMING > Tested-by: Fleming Andrew-AFLEMING > > --- > arch/powe

Re: [tpmdd-devel] Has anyone a ATMEL TPM Chip on PPC64 (CONFIG_TCG_ATMEL)?

2013-10-28 Thread Jason Gunthorpe
On Mon, Oct 28, 2013 at 01:03:43PM -0500, Joel Schopp wrote: > On 10/27/2013 05:06 PM, Peter H?we wrote: > > Hi, > > > > I was wondering if anyone here on this list still has a machine with an old > > ATMEL TPM (trusted platform module) lying around? > > > >>From the kconfig entry it becomes evi

Re: [tpmdd-devel] Has anyone a ATMEL TPM Chip on PPC64 (CONFIG_TCG_ATMEL)?

2013-10-28 Thread Peter Hüwe
Am Dienstag, 29. Oktober 2013, 00:47:45 schrieb Jason Gunthorpe: > On Mon, Oct 28, 2013 at 01:03:43PM -0500, Joel Schopp wrote: > > On 10/27/2013 05:06 PM, Peter H?we wrote: > > > Hi, > > > > > > I was wondering if anyone here on this list still has a machine with an > > > old ATMEL TPM (trusted p

Re: linux-next: build failure after merge of the dt-rh tree

2013-10-28 Thread Rob Herring
On 10/28/2013 03:38 AM, Stephen Rothwell wrote: > Hi Rob, > > After merging the dt-rh tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > arch/powerpc/platforms/powernv/rng.c: In function > 'rng_init_per_cpu': arch/powerpc/platforms/powernv/rng.c:64:2: > error: impli

Re: [tpmdd-devel] Has anyone a ATMEL TPM Chip on PPC64 (CONFIG_TCG_ATMEL)?

2013-10-28 Thread Joel Schopp
On 10/27/2013 05:06 PM, Peter Hüwe wrote: > Hi, > > I was wondering if anyone here on this list still has a machine with an old > ATMEL TPM (trusted platform module) lying around? > >>From the kconfig entry it becomes evident that it was only supported on ppc64 > machines. > > config TCG_ATMEL

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Victor Kaplansky
Oleg Nesterov wrote on 10/28/2013 10:17:35 PM: > mb(); // : do we really need it? I think yes. Oh, it is hard to argue with feelings. Also, it is easy to be on conservative side and put the barrier here just in case. But I still insist that the barrier is redundant in your exampl

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Oleg Nesterov
On 10/28, Paul E. McKenney wrote: > > On Mon, Oct 28, 2013 at 02:26:34PM +0100, Peter Zijlstra wrote: > > --- linux-2.6.orig/kernel/events/ring_buffer.c > > +++ linux-2.6/kernel/events/ring_buffer.c > > @@ -87,10 +87,31 @@ static void perf_output_put_handle(struc > > goto out; > > > >

Re: Build regressions/improvements in v3.12-rc7

2013-10-28 Thread Geert Uytterhoeven
On Mon, 28 Oct 2013, Geert Uytterhoeven wrote: > JFYI, when comparing v3.12-rc7 to v3.12-rc6[3], the summaries are: > - build errors: +9/-10 + /scratch/kisskb/src/arch/powerpc/kernel/cacheinfo.c: error: 'associativity' may be used uninitialized in this function [-Werror=uninitialized]: => 57

Re: [PATCH 02/12][v3] pci: fsl: add structure fsl_pci

2013-10-28 Thread Scott Wood
On Fri, 2013-10-25 at 13:58 +0800, Lian Minghuan-b31939 wrote: > Hi Kumar, > > please see my comment inline. > > On 10/24/2013 12:11 PM, Kumar Gala wrote: > > On Oct 23, 2013, at 5:41 AM, Minghuan Lian wrote: > > > >> PowerPC uses structure pci_controller to describe PCI controller, > >> but ARM

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Oleg Nesterov
On 10/28, Peter Zijlstra wrote: > > Lets add Paul and Oleg to the thread; this is getting far more 'fun' > that it should be ;-) Heh. All I can say is that I would like to see the authoritative answer, you know who can shed a light ;) But to avoid the confusion, wmb() added by this patch looks "o

Re: [PATCH] [RFC] Emulate "lwsync" to run standard user land on e500 cores

2013-10-28 Thread Scott Wood
On Fri, 2013-10-25 at 10:25 -0500, James Yang wrote: > On Fri, 25 Oct 2013, Scott Wood wrote: > > > Has anyone measured how much this slows things down with a typical > > userspace? > > Not a measurement of the patch in question but an older similar patch > on 3.0.51 (8572 running Debian 5.0.3):

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Paul E. McKenney
On Mon, Oct 28, 2013 at 02:26:34PM +0100, Peter Zijlstra wrote: > On Mon, Oct 28, 2013 at 02:38:29PM +0200, Victor Kaplansky wrote: > > > 2013/10/25 Peter Zijlstra : > > > > On Wed, Oct 23, 2013 at 03:19:51PM +0100, Frederic Weisbecker wrote: > > > > I would argue for > > > > > > > > READ ->data_

Re: [PATCH 3/3] sched: Aggressive balance in domains whose groups share package resources

2013-10-28 Thread Peter Zijlstra
On Mon, Oct 21, 2013 at 05:15:02PM +0530, Vaidyanathan Srinivasan wrote: > From: Preeti U Murthy > > The current logic in load balance is such that after picking the > busiest group, the load is attempted to be moved from the busiest cpu > in that group to the dst_cpu. If the load cannot be moved

[PATCH v2 2/2] powerpc: Move local setup.h declarations to arch includes

2013-10-28 Thread Robert C Jennings
Move the few declarations from arch/powerpc/kernel/setup.h into arch/powerpc/include/asm/setup.h. This resolves a sparse warning for arch/powerpc/mm/numa.c which defines do_init_bootmem() but can't include the setup.h header in the prior path. Resolves: arch/powerpc/mm/numa.c:998:13: warn

[PATCH v2 0/2] powerpc: Sparse fixes for numa.c

2013-10-28 Thread Robert C Jennings
Cleaning out some stashed fixes for sparse warnings found while working on 3be7db6: (powerpc: VPHN topology change updates all siblings) I don't see a reason why the declarations in arch/powerpc/kernel/setup.h can't live in arch/powerpc/include/asm/setup.h and .../mm/numa.c should include these de

[PATCH v2 1/2] powerpc: Fix warnings for arch/powerpc/mm/numa.c

2013-10-28 Thread Robert C Jennings
Simple fixes for sparse warnings in this file. Resolves: arch/powerpc/mm/numa.c:198:24: warning: Using plain integer as NULL pointer arch/powerpc/mm/numa.c:1157:5: warning: symbol 'hot_add_node_scn_to_nid' was not declared. Should it be static? arch/powerpc/mm/numa

Re: [PATCH 2/2] powerpc: Move local setup.h declarations to arch includes

2013-10-28 Thread Robert Jennings
* Michael Ellerman (mich...@ellerman.id.au) wrote: > On Fri, Oct 25, 2013 at 02:25:07PM -0500, Robert C Jennings wrote: > > Move the few declarations from arch/powerpc/kernel/setup.h > > into arch/powerpc/include/asm/setup.h. This resolves a > > sparse warning for arch/powerpc/mm/numa.c which defi

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-28 Thread Peter Zijlstra
On Thu, Oct 24, 2013 at 01:37:38PM +0530, Preeti U Murthy wrote: > kernel/sched/core.c |5 + > kernel/sched/fair.c | 38 -- > kernel/sched/sched.h |1 + > 3 files changed, 26 insertions(+), 18 deletions(-) > > diff --git a/kernel/sched/core.c b/

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Peter Zijlstra
On Mon, Oct 28, 2013 at 02:38:29PM +0200, Victor Kaplansky wrote: > > 2013/10/25 Peter Zijlstra : > > > On Wed, Oct 23, 2013 at 03:19:51PM +0100, Frederic Weisbecker wrote: > > > I would argue for > > > > > > READ ->data_tail READ ->data_head > > > smp_rmb() (A)

[PATCH] warning: symbol value 'm' invalid for MCU_MPC8349EMITX

2013-10-28 Thread Christian Kujau
Hi, during "make ppc6xx_defconfig" the following happens: HOSTCC scripts/basic/fixdep GEN /usr/local/src/tmp/lnx/Makefile HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf arch/powerpc/configs/ppc6xx_defconfig:74:warning: symbol value '

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Victor Kaplansky
> From: Frederic Weisbecker > > 2013/10/25 Peter Zijlstra : > > On Wed, Oct 23, 2013 at 03:19:51PM +0100, Frederic Weisbecker wrote: > > I would argue for > > > > READ ->data_tail READ ->data_head > > smp_rmb() (A) smp_rmb() (C) > > WRITE $d

[PATCH] ADB_PMU_LED_IDE selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies

2013-10-28 Thread Christian Kujau
Hi, for quite some time the following is printed (twice) after doing "make oldconfig": [...] scripts/kconfig/conf --oldconfig Kconfig warning: (ADB_PMU_LED_IDE) selects LEDS_TRIGGER_IDE_DISK which has unmet direct dependencies (NEW_LEDS && IDE_GD_ATA && LEDS_TRIGGERS) warning: (ADB_PMU_LED_IDE)

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Frederic Weisbecker
2013/10/25 Peter Zijlstra : > On Wed, Oct 23, 2013 at 03:19:51PM +0100, Frederic Weisbecker wrote: > I would argue for: > > READ ->data_tail READ ->data_head > smp_rmb() (A) smp_rmb() (C) > WRITE $data READ $data >

Re: perf events ring buffer memory barrier on powerpc

2013-10-28 Thread Peter Zijlstra
On Sun, Oct 27, 2013 at 11:00:33AM +0200, Victor Kaplansky wrote: > Peter Zijlstra wrote on 10/25/2013 07:37:49 PM: > > > I would argue for: > > > > READ ->data_tail READ ->data_head > > smp_rmb() (A) smp_rmb() (C) > > WRITE $data READ $data > > smp_w

linux-next: build failure after merge of the dt-rh tree

2013-10-28 Thread Stephen Rothwell
Hi Rob, After merging the dt-rh tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/powernv/rng.c: In function 'rng_init_per_cpu': arch/powerpc/platforms/powernv/rng.c:64:2: error: implicit declaration of function 'of_get_ibm_chip_id' [-Werror=implic

RE: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Xiubo Li-B47053
> > +static struct snd_pcm_hardware snd_fsl_hardware = { > > + .info = SNDRV_PCM_INFO_INTERLEAVED | > > + SNDRV_PCM_INFO_BLOCK_TRANSFER | > > + SNDRV_PCM_INFO_MMAP | > > + SNDRV_PCM_INFO_MMAP_VALID | > > + SNDRV_PCM_INFO_PAUSE | > > + SNDRV_PCM_I