Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Hans-Christian Egtvedt
Around Thu 23 Jan 2014 15:12:46 +0800 or thereabout, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value.

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Yijing Wang
On 2014/1/23 16:04, Tony Prisk wrote: On 23/01/14 20:58, Geert Uytterhoeven wrote: On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk li...@prisktech.co.nz wrote: -static inline int clocksource_register_hz(struct clocksource *cs, u32 hz) +static inline void clocksource_register_hz(struct

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Daniel Lezcano
On 01/23/2014 08:12 AM, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value. Signed-off-by: Yijing Wang

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Yijing Wang
On 2014/1/23 16:40, Daniel Lezcano wrote: On 01/23/2014 08:12 AM, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-23 Thread Preeti U Murthy
Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: On 01/17/2014 05:33 AM, Preeti U Murthy wrote: diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index a55e68f..831b664 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Tony Prisk
On 23/01/14 20:58, Geert Uytterhoeven wrote: On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk li...@prisktech.co.nz wrote: -static inline int clocksource_register_hz(struct clocksource *cs, u32 hz) +static inline void clocksource_register_hz(struct clocksource *cs, u32 hz) { return

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Tony Prisk
On 23/01/14 20:12, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value. Signed-off-by: Yijing Wang

RE: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread David Laight
From: Linuxppc-dev Tony Prisk On 23/01/14 20:12, Yijing Wang wrote: Currently, clocksource_register() and __clocksource_register_scale() functions always return 0, it's pointless, make functions void. And remove the dead code that check the clocksource_register_hz() return value. ..

Re: [PATCH 2/3] powerpc/85xx: Provide two functions to save/restore the core registers

2014-01-23 Thread Scott Wood
On Wed, 2014-01-22 at 20:49 -0600, Wang Dongsheng-B40534 wrote: The whole point of calling enable_kernel_fp() in C code before suspending is to ensure that the FP state gets saved. If FP is used after that point it is a bug. If you're worried about such bugs, then clear

Re: [PATCH] clk: corenet: Update the clock bindings

2014-01-23 Thread Scott Wood
On Wed, 2014-01-22 at 20:47 -0600, Tang Yuantian-B29983 wrote: -Original Message- From: Wood Scott-B07421 Sent: 2014年1月23日 星期四 8:44 To: Tang Yuantian-B29983 Cc: Wood Scott-B07421; ga...@kernel.crashing.org; linuxppc- d...@lists.ozlabs.org; devicet...@vger.kernel.org; Kushwaha

RE: [PATCH] clk: corenet: Update the clock bindings

2014-01-23 Thread Yuantian Tang
Instead, how about a note like this near the top of the file: All references to 1.0 and 2.0 refer to the QorIQ chassis version to which the chip complies. Chassis Version Example Chips --- - 1.0 p4080, p5020,

Re: [PATCH] clk: corenet: Update the clock bindings

2014-01-23 Thread Scott Wood
On Thu, 2014-01-23 at 20:33 -0600, Tang Yuantian-B29983 wrote: Instead, how about a note like this near the top of the file: All references to 1.0 and 2.0 refer to the QorIQ chassis version to which the chip complies. Chassis Version Example Chips

RE: [PATCH] clk: corenet: Update the clock bindings

2014-01-23 Thread Yuantian Tang
-Original Message- From: Wood Scott-B07421 Sent: 2014年1月24日 星期五 10:36 To: Tang Yuantian-B29983 Cc: ga...@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org; devicet...@vger.kernel.org; Kushwaha Prabhakar-B32579 Subject: Re: [PATCH] clk: corenet: Update the clock bindings On Thu,

Re: [PATCH] clk: corenet: Update the clock bindings

2014-01-23 Thread Scott Wood
On Thu, 2014-01-23 at 20:46 -0600, Tang Yuantian-B29983 wrote: -Original Message- From: Wood Scott-B07421 Sent: 2014年1月24日 星期五 10:36 To: Tang Yuantian-B29983 Cc: ga...@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org; devicet...@vger.kernel.org; Kushwaha Prabhakar-B32579

RE: [PATCH] clk: corenet: Update the clock bindings

2014-01-23 Thread Yuantian Tang
In any case, if qoriq makes sense for the compatible, I don't see why it doesn't make sense for the driver. So, Corenet is appropriate for driver. If something should change, that must be compatible string. No. Corenet is a bus interconnect, not a chip family (despite

Re: [PATCH] slub: Don't throw away partial remote slabs if there is no local memory

2014-01-23 Thread Wanpeng Li
Hi Christoph, On Mon, Jan 20, 2014 at 04:13:30PM -0600, Christoph Lameter wrote: On Mon, 20 Jan 2014, Wanpeng Li wrote: + enum zone_type high_zoneidx = gfp_zone(flags); + if (!node_present_pages(searchnode)) { + zonelist = node_zonelist(searchnode, flags); +

Re: [PATCH] slub: Don't throw away partial remote slabs if there is no local memory

2014-01-23 Thread Wanpeng Li
On Fri, Jan 24, 2014 at 11:09:07AM +0800, Wanpeng Li wrote: Hi Christoph, On Mon, Jan 20, 2014 at 04:13:30PM -0600, Christoph Lameter wrote: On Mon, 20 Jan 2014, Wanpeng Li wrote: + enum zone_type high_zoneidx = gfp_zone(flags); + if (!node_present_pages(searchnode)) { +

[PATCH] powerpc/perf: Add Power8 cache TLB events

2014-01-23 Thread Michael Ellerman
Signed-off-by: Michael Ellerman m...@ellerman.id.au --- arch/powerpc/perf/power8-pmu.c | 144 + 1 file changed, 144 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c index a3f7abd..96cee20 100644 ---

Re: [PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-23 Thread Preeti U Murthy
Hi Thomas, The below patch works pretty much as is. I tried this out with deep idle states on our system. Looking through the code and analysing corner cases also did not bring out any issues to me. I will send out a patch V2 of this. Regards Preeti U Murthy On 01/22/2014 06:57 PM, Thomas

[PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-01-23 Thread Preeti U Murthy
This earlier version of this patchset can be found here: https://lkml.org/lkml/2013/12/12/687. This version has been based on the discussion in http://www.kernelhub.org/?p=2msg=399516. This patchset provides the hooks that the architectures without an external clock device and deep idle states

[PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer

2014-01-23 Thread Preeti U Murthy
The broadcast framework can potentially be made use of by archs which do not have an external clock device as well. Then, it is required that one of the CPUs need to handle the broadcasting of wakeup IPIs to the CPUs in deep idle. As a result its local timers should remain functional all the

[PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-01-23 Thread Preeti U Murthy
From: Thomas Gleixner t...@linutronix.de On some architectures, in certain CPU deep idle states the local timers stop. An external clock device is used to wakeup these CPUs. The kernel support for the wakeup of these CPUs is provided by the tick broadcast framework by using the external clock