Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-23 Thread Mike Qiu
On 06/24/2014 02:36 PM, Benjamin Herrenschmidt wrote: Is it reasonable to do error injection with "CONFIG_IOMMU_API" ? That means if use default config(CONFIG_IOMMU_API = n), we can not do error injection to pci devices? Well we can't pass them through either so ... In any case, this is not a

Re: [PATCH] powerpc: Fix build warning

2014-06-23 Thread Benjamin Herrenschmidt
On Mon, 2014-06-23 at 23:01 -0700, Guenter Roeck wrote: > I thought that only happens if a const is dropped, but maybe not. > > Sigh. Much easier to break something than to fix it. That would mean > to get approval > from at least three maintainers, and all that to get rid of a warning. > I don't

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-23 Thread Benjamin Herrenschmidt
> Is it reasonable to do error injection with "CONFIG_IOMMU_API" ? > > That means if use default config(CONFIG_IOMMU_API = n), we can not do > error injection to pci devices? Well we can't pass them through either so ... In any case, this is not a priority. First we need to implement a solid

[PATCH] powerpc/kvm: Fix build break with CONFIG_KVM_BOOK3S_64_HV=y

2014-06-23 Thread Michael Ellerman
Commit e58e263 "PPC, KVM, CMA: use general CMA reserved area management framework" in next-20140624 removed arch/powerpc/kvm/book3s_hv_cma.c but neglected to update the Makefile, thus breaking the build. Signed-off-by: Michael Ellerman --- Hi Andrew, This is in your akpm-current and is breaking

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-23 Thread Mike Qiu
On 06/23/2014 10:14 AM, Gavin Shan wrote: The patch implements one OPAL firmware sysfs file to support PCI error injection: "/sys/firmware/opal/errinjct", which will be used like the way described as follows. According to PAPR spec, there are 3 RTAS calls related to error injection: "ibm,open-er

Re: [PATCH] powerpc: Fix build warning

2014-06-23 Thread Guenter Roeck
On 06/23/2014 10:34 PM, Benjamin Herrenschmidt wrote: On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote: On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. ar

Re: [PATCH] powerpc: Fix build warning

2014-06-23 Thread Benjamin Herrenschmidt
On Mon, 2014-06-23 at 22:05 -0700, Guenter Roeck wrote: > On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: > >> If compiled with W=1, the following warning is seen in powerpc builds. > >> > >> arch/powerpc/kernel/smp.c:750:18: warning

Re: [PATCH] powerpc: Fix build warning

2014-06-23 Thread Guenter Roeck
On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: If compiled with W=1, the following warning is seen in powerpc builds. arch/powerpc/kernel/smp.c:750:18: warning: type qualifiers ignored on function return type static const in

Re: [PATCH] powerpc: Fix build warning

2014-06-23 Thread Benjamin Herrenschmidt
On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: > If compiled with W=1, the following warning is seen in powerpc builds. > > arch/powerpc/kernel/smp.c:750:18: warning: > type qualifiers ignored on function return type > static const int powerpc_smt_flags(void) > ^ >

Re: [PATCH] powerpc: module: fix TOC symbol CRC

2014-06-23 Thread Benjamin Herrenschmidt
On Thu, 2014-06-19 at 09:44 +1000, Anton Blanchard wrote: > Hi Laurent, > > > The commit 71ec7c55ed91 introduced the magic symbol ".TOC." for ELFv2 > > ABI. This symbol is built manually and has no CRC value computed. A > > zero value is put in the CRC section to avoid modpost complaining > > abou

[PATCH] qe: move qe from arch/powerpc to drivers

2014-06-23 Thread Zhao Qiang
ls1 has qe and ls1 has arm cpu. move qe from arch/powerpc to drivers. Signed-off-by: Zhao Qiang --- arch/powerpc/platforms/83xx/km83xx.c | 4 +-- arch/powerpc/platforms/83xx/misc.c | 2 +- arch/powerpc/platforms/83xx/mpc832x_mds.c | 4 +-- arch/powerpc/p

Re: [PATCH 04/24] powerpc: check/return actual error on sysfs functions

2014-06-23 Thread Benjamin Herrenschmidt
On Tue, 2014-06-17 at 12:23 -0700, Greg KH wrote: > On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote: > > From: Jie Liu > > > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Signed-off-by: Jie Liu > > --- > > arch/powerpc/platforms/powernv/opal-dump.c | 2 +- > > arch/powerpc/

Re: [PATCH 5/9] [arch/powerpc] replace obsolete strict_strto* calls

2014-06-23 Thread Benjamin Herrenschmidt
On Sat, 2014-06-21 at 13:05 +0100, Daniel Walter wrote: > Replace strict_strto calls with more appropriate kstrto calls > > Signed-off-by: Daniel Walter > --- Acked-by: Benjamin Herrenschmidt -- Should I put that in the powerpc tree ? > arch/powerpc/kernel/setup_64.c| 6 +++--- >

[PATCH] powerpc: Remove __arch_swab*

2014-06-23 Thread Benjamin Herrenschmidt
The generic code uses gcc built-ins which work fine so there's no benefit in implementing our own anymore. We can't completely remove the ld/st_le* functions as some historical cruft still uses them, but that's next on the radar Signed-off-by: Benjamin Herrenschmidt --- diff --git a/arch/powerp

Re: [RFC PATCH V3 12/17] powerpc/powernv: implement pcibios_sriov_resource_alignment on powernv

2014-06-23 Thread Wei Yang
On Tue, Jun 24, 2014 at 09:29:22AM +1000, Gavin Shan wrote: >On Mon, Jun 23, 2014 at 04:21:42PM +0800, Wei Yang wrote: >>On Mon, Jun 23, 2014 at 04:09:47PM +1000, Gavin Shan wrote: >>>On Tue, Jun 10, 2014 at 09:56:34AM +0800, Wei Yang wrote: This patch implements the pcibios_sriov_resource_alig

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-23 Thread Michael Neuling
On Mon, 2014-06-23 at 12:14 +1000, Gavin Shan wrote: > The patch implements one OPAL firmware sysfs file to support PCI error > injection: "/sys/firmware/opal/errinjct", which will be used like the > way described as follows. > > According to PAPR spec, there are 3 RTAS calls related to error inje

Re: [PATCH v1 1/3] powerpc/powernv: Sync header with firmware

2014-06-23 Thread Benjamin Herrenschmidt
On Tue, 2014-06-24 at 09:44 +1000, Gavin Shan wrote: > >I much'd prefer see a opal_pci_err_inject that is specific to > >IO(D)A errors, which takes a PHB ID and goes via the normal dispatch > >to PHB ops inside OPAL. For the rest, especially core specific > >injections, we can provide a separate de

Re: [PATCH v1 1/3] powerpc/powernv: Sync header with firmware

2014-06-23 Thread Gavin Shan
On Tue, Jun 24, 2014 at 07:10:14AM +1000, Benjamin Herrenschmidt wrote: >On Mon, 2014-06-23 at 12:14 +1000, Gavin Shan wrote: >> The patch synchronizes firmware header file (opal.h) for PCI error >> injection > >The FW API you expose is not PCI specific. I haven't seen the >corresponding FW patches

Re: [RFC PATCH V3 12/17] powerpc/powernv: implement pcibios_sriov_resource_alignment on powernv

2014-06-23 Thread Gavin Shan
On Mon, Jun 23, 2014 at 04:21:42PM +0800, Wei Yang wrote: >On Mon, Jun 23, 2014 at 04:09:47PM +1000, Gavin Shan wrote: >>On Tue, Jun 10, 2014 at 09:56:34AM +0800, Wei Yang wrote: >>>This patch implements the pcibios_sriov_resource_alignment() on powernv >>>platform. >>> >>>Signed-off-by: Wei Yang

Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection

2014-06-23 Thread Benjamin Herrenschmidt
On Mon, 2014-06-23 at 12:14 +1000, Gavin Shan wrote: > The patch implements one OPAL firmware sysfs file to support PCI error > injection: "/sys/firmware/opal/errinjct", which will be used like the > way described as follows. > > According to PAPR spec, there are 3 RTAS calls related to error inje

Re: [PATCH v1 1/3] powerpc/powernv: Sync header with firmware

2014-06-23 Thread Benjamin Herrenschmidt
On Mon, 2014-06-23 at 12:14 +1000, Gavin Shan wrote: > The patch synchronizes firmware header file (opal.h) for PCI error > injection The FW API you expose is not PCI specific. I haven't seen the corresponding FW patches yet but I'm not fan of that single call that collates unrelated things. I mu

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Grant Likely
On Mon, 23 Jun 2014 18:26:04 +0300, Pantelis Antoniou wrote: > On Jun 23, 2014, at 5:58 PM, Grant Likely wrote: > > We'll also need a transition plan to move to RCU. I think the existing > > iterators can be modified to do the rcu locking in-line, but still require > > the of_node_get/put stuff (

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-06-23 Thread Alexander Gordeev
Hi Bjorn, Any feedback? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Pantelis Antoniou
Hi Grant, On Jun 23, 2014, at 5:58 PM, Grant Likely wrote: > On Thu, 19 Jun 2014 11:33:20 +0300, Pantelis Antoniou > wrote: >> Hi Grant, >> >> CCing Thomas Gleixner & Steven Rostedt, since they might have a few >> ideas... >> >> On Jun 18, 2014, at 11:07 PM, Grant Likely wrote: >> >>> Hi Nat

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Grant Likely
On Thu, 19 Jun 2014 11:33:20 +0300, Pantelis Antoniou wrote: > Hi Grant, > > CCing Thomas Gleixner & Steven Rostedt, since they might have a few > ideas... > > On Jun 18, 2014, at 11:07 PM, Grant Likely wrote: > > > Hi Nathan and Tyrel, > > > > I'm looking into lifecycle issues on nodes modif

Re: OF_DYNAMIC node lifecycle

2014-06-23 Thread Grant Likely
On Thu, 19 Jun 2014 10:26:15 -0500, Nathan Fontenot wrote: > On 06/18/2014 03:07 PM, Grant Likely wrote: > > Hi Nathan and Tyrel, > > > > I'm looking into lifecycle issues on nodes modified by OF_DYNAMIC, and > > I'm hoping you can help me. Right now, pseries seems to be the only > > user of OF_

[PATCH v2] fsl-rio: add support for mapping inbound windows

2014-06-23 Thread Martijn de Gouw
From: Martijn de Gouw Add support for mapping and unmapping of inbound rapidio windows. Signed-off-by: Martijn de Gouw --- arch/powerpc/sysdev/fsl_rio.c | 92 + arch/powerpc/sysdev/fsl_rio.h | 12 ++ 2 files changed, 104 insertions(+) diff --git

Re: [PATCH] fsl-rio: add support for mapping inbound windows

2014-06-23 Thread Martijn de Gouw
On 06/18/2014 05:17 PM, Bounine, Alexandre wrote: On Friday, June 13, 2014 7:09 AM Martijn de Gouw [mailto:martijn.de.gouw@prodrive- technologies.com] wrote: Add support for mapping and unmapping of inbound rapidio windows. Signed-off-by: Martijn de Gouw --- ... skip ... + +int fsl_map_in

Re: [RFC PATCH V3 07/17] ppc/pnv: Add function to deconfig a PE

2014-06-23 Thread Wei Yang
On Mon, Jun 23, 2014 at 03:27:21PM +1000, Gavin Shan wrote: >On Tue, Jun 10, 2014 at 09:56:29AM +0800, Wei Yang wrote: >>On PowerNV platform, it will support dynamic PE allocation and deallocation. >> >>This patch adds a function to release those resources related to a PE. >> >>Signed-off-by: Wei Y

Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Marc Kleine-Budde
On 06/23/2014 10:15 AM, qiang.z...@freescale.com wrote: [...] > + reg_esr = flexcan_read(®s->esr); > + reg_ctrl = flexcan_read(®s->ctrl); > + if (reg_esr & FLEXCAN_ESR_TX_WRN) { When does the hardware trigger the interrupt? >>> >>> When there is no wire link between tx and rx,

Re: Build regressions/improvements in v3.16-rc2

2014-06-23 Thread Geert Uytterhoeven
On Mon, Jun 23, 2014 at 10:24 AM, Geert Uytterhoeven wrote: > JFYI, when comparing v3.16-rc2[1] to v3.16-rc1[3], the summaries are: > - build errors: +1/-6 + /scratch/kisskb/src/drivers/edac/ppc4xx_edac.c: error: request for member 'dimm' in something not a structure or union: => 977:45 po

Re: [RFC PATCH V3 12/17] powerpc/powernv: implement pcibios_sriov_resource_alignment on powernv

2014-06-23 Thread Wei Yang
On Mon, Jun 23, 2014 at 04:09:47PM +1000, Gavin Shan wrote: >On Tue, Jun 10, 2014 at 09:56:34AM +0800, Wei Yang wrote: >>This patch implements the pcibios_sriov_resource_alignment() on powernv >>platform. >> >>Signed-off-by: Wei Yang >>--- >> arch/powerpc/include/asm/machdep.h|1 + >> a

RE: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread qiang.z...@freescale.com
On 06/23/2014 03:37 PM, Marc Kleine-Budde wrote: > -Original Message- > From: Marc Kleine-Budde [mailto:m...@pengutronix.de] > Sent: Monday, June 23, 2014 3:37 PM > To: Zhao Qiang-B45475; linuxppc-dev@lists.ozlabs.org; linux- > c...@vger.kernel.org; w...@grandegger.com; Wood Scott-B07421 >

Re: [RFC PATCH V3 08/17] PCI: Add weak pcibios_sriov_resource_size() interface

2014-06-23 Thread Wei Yang
On Mon, Jun 23, 2014 at 03:41:28PM +1000, Gavin Shan wrote: >On Tue, Jun 10, 2014 at 09:56:30AM +0800, Wei Yang wrote: >>When retrieving sriov resource size in pci_sriov_resource_size(), it will >>divide the total IOV resource size with the totalVF number. This is true for >>most cases, while may n

Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Marc Kleine-Budde
On 06/23/2014 09:26 AM, qiang.z...@freescale.com wrote: > > On 06/23/2014 03:18 PM, Marc Kleine-Budde wrote: > >> >> On 06/23/2014 09:11 AM, Zhao Qiang wrote: >>> when flexcan is not physically linked, command 'cantest' will trigger >>> an err_irq, add err_irq handler for it. >>> >>> Signed-off-b

RE: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread qiang.z...@freescale.com
On 06/23/2014 03:18 PM, Marc Kleine-Budde wrote: > > On 06/23/2014 09:11 AM, Zhao Qiang wrote: > > when flexcan is not physically linked, command 'cantest' will trigger > > an err_irq, add err_irq handler for it. > > > > Signed-off-by: Zhao Qiang > > --- > > Changes for v2: > > - use a spac

Re: [PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Marc Kleine-Budde
On 06/23/2014 09:11 AM, Zhao Qiang wrote: > when flexcan is not physically linked, command 'cantest' will > trigger an err_irq, add err_irq handler for it. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - use a space instead of tab > - use flexcan_poll_state instead of print

[PATCH v3 2/2] flexcan: add err interrupt for p1010rdb

2014-06-23 Thread Zhao Qiang
add err interrupt for p1010rdb into dts. Signed-off-by: Zhao Qiang --- Changes for v2: - add binding documentation update Changes for v3: - update binding documentation Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 15 +-- arch/powerpc/boot/dts/fsl/p101

[PATCH v3 1/2] flexcan: add err_irq handler for flexcan

2014-06-23 Thread Zhao Qiang
when flexcan is not physically linked, command 'cantest' will trigger an err_irq, add err_irq handler for it. Signed-off-by: Zhao Qiang --- Changes for v2: - use a space instead of tab - use flexcan_poll_state instead of print Changes for v3: - return IRQ_HANDLED if err is

Re: [RFC PATCH V3 11/17] ppc/pnv: Expand VF resources according to the number of total_pe

2014-06-23 Thread Gavin Shan
On Mon, Jun 23, 2014 at 02:56:52PM +0800, Wei Yang wrote: >On Mon, Jun 23, 2014 at 04:07:07PM +1000, Gavin Shan wrote: >>On Tue, Jun 10, 2014 at 09:56:33AM +0800, Wei Yang wrote: >>>On PHB3, VF resources will be covered by M64 BAR to have better PE isolation. >>>Mostly the total_pe number is differ