Re: [PATCH] powerpc: Remove more traces of bootmem

2014-11-18 Thread Michael Ellerman
On Wed, 2014-11-19 at 16:29 +1100, Michael Ellerman wrote: > On Tue, 2014-11-18 at 10:26 +, David Laight wrote: > > From: Michael Ellerman > > > Although we are now selecting NO_BOOTMEM, we still have some traces of > > > bootmem lying around. That is because even with NO_BOOTMEM there is > > >

Re: [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time

2014-11-18 Thread Preeti U Murthy
Hi Joel, On 11/19/2014 08:04 AM, Joel Stanley wrote: > Hey Preeti, > > On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy > wrote: >> Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time. > > I couldn't find this commit in any tree; upstream, mpe's next, nor powerkvm. Oh yes you

Re: [PATCH] powerpc: Remove more traces of bootmem

2014-11-18 Thread Michael Ellerman
On Tue, 2014-11-18 at 10:26 +, David Laight wrote: > From: Michael Ellerman > > Although we are now selecting NO_BOOTMEM, we still have some traces of > > bootmem lying around. That is because even with NO_BOOTMEM there is > > still a shim that converts bootmem calls into memblock calls, but >

[git pull] Please pull mpe.git for-linus branch (for powerpc)

2014-11-18 Thread Michael Ellerman
Hi Linus, Please pull one fix from Scott, he says: This patch fixes a crash (introduced in v3.18-rc1) in the FSL MSI driver when threaded IRQs are enabled. The following changes since commit 8a97577a5967c1234ccc3bc1b45e4b1a58b39ea8: Merge branch 'for-linus' of git://git.kernel.org/pub/s

Re: [PATCH V9 03/18] PCI: Add weak pcibios_iov_resource_size() interface

2014-11-18 Thread Bjorn Helgaas
On Wed, Nov 19, 2014 at 11:21:00AM +0800, Wei Yang wrote: > On Wed, Nov 19, 2014 at 01:15:32PM +1100, Benjamin Herrenschmidt wrote: > >On Tue, 2014-11-18 at 18:12 -0700, Bjorn Helgaas wrote: > >> > >> Can you help me understand this? > >> > >> We have previously called sriov_init() on the PF. Th

Re: [PATCH V9 03/18] PCI: Add weak pcibios_iov_resource_size() interface

2014-11-18 Thread Wei Yang
On Wed, Nov 19, 2014 at 01:15:32PM +1100, Benjamin Herrenschmidt wrote: >On Tue, 2014-11-18 at 18:12 -0700, Bjorn Helgaas wrote: >> >> Can you help me understand this? >> >> We have previously called sriov_init() on the PF. There, we sized the VF >> BARs, which are in the PF's SR-IOV Capability

Re: [PATCH] cpuidle/powernv: Re-enable fastsleep at boot time

2014-11-18 Thread Joel Stanley
Hey Preeti, On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy wrote: > Commit dcb18694 "Fix ipi on palmeto" disabled fastsleep at boot time. I couldn't find this commit in any tree; upstream, mpe's next, nor powerkvm. I remember testing this as a workaround for the palmetto, but I don't recall s

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Yijing Wang
>> We need, some platforms pass NULL pointer as host bridge parent. > > Yijing, > > May I suggest a different approach here? Rather than having to pass an opaque > pointer that gets converted by the host bridge driver back to the private > structure, what about promoting a new style of usage, tha

Re: [PATCH V9 03/18] PCI: Add weak pcibios_iov_resource_size() interface

2014-11-18 Thread Benjamin Herrenschmidt
On Tue, 2014-11-18 at 18:12 -0700, Bjorn Helgaas wrote: > > Can you help me understand this? > > We have previously called sriov_init() on the PF. There, we sized the VF > BARs, which are in the PF's SR-IOV Capability (SR-IOV spec sec 3.3.14). > The size we discover is the amount of space requir

Re: [RFC PATCH 08/16] PCI: Introduce pci_scan_host_bridge() and pci_host_info

2014-11-18 Thread Yijing Wang
>> struct pci_host_bridge *pci_create_host_bridge( >> -struct device *parent, u32 db, >> -struct pci_ops *ops, void *sysdata, >> -struct list_head *resources) >> +struct device *parent, u32 db, struct pci_ops *ops, >> +struct pci_host_

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Yijing Wang
On 2014/11/18 23:30, Liviu Dudau wrote: > On Mon, Nov 17, 2014 at 10:21:41AM +, Yijing Wang wrote: >> There are some common PCI infos like domain, msi_controller, these >> infos are saved in arch PCI sysdata, and lots arch specific functions >> like pci_domain_nr() and pcibios_msi_controller()

Re: [RFC PATCH 04/16] PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus()

2014-11-18 Thread Yijing Wang
On 2014/11/18 22:34, Liviu Dudau wrote: > On Mon, Nov 17, 2014 at 10:21:38AM +, Yijing Wang wrote: >> Rip out pci_bus_add_devices() from pci_scan_root_bus() >> for following reasons. >> 1. pci_scan_root_bus() means we only do the scan, we should >> not add pci busses. >> 2. A lots of drviers wh

Re: [RFC PATCH 02/16] PCI: Use pci_scan_root_bus() instead of pci_scan_bus()

2014-11-18 Thread Yijing Wang
On 2014/11/18 22:28, Liviu Dudau wrote: > On Mon, Nov 17, 2014 at 10:21:36AM +, Yijing Wang wrote: >> From: Yijing Wang >> >> Now we could use pci_scan_root_bus() instead of >> pci_scan_bus(), pass NULL resources means use the default >> io/mem. > > Actually, I think this patch goes in the wr

Re: [RFC PATCH 01/16] PCI: Enhance pci_scan_root_bus() to support default IO/MEM resources

2014-11-18 Thread Yijing Wang
On 2014/11/18 22:23, Liviu Dudau wrote: > On Tue, Nov 18, 2014 at 11:46:06AM +, Yijing Wang wrote: >> On 2014/11/18 17:36, Arnd Bergmann wrote: >>> On Tuesday 18 November 2014 15:44:23 Yijing Wang wrote: On 2014/11/17 18:08, Arnd Bergmann wrote: > On Monday 17 November 2014 18:21:35 Yi

Re: [PATCH V9 03/18] PCI: Add weak pcibios_iov_resource_size() interface

2014-11-18 Thread Bjorn Helgaas
[+cc Don, Myron] Hi Wei, On Sun, Nov 02, 2014 at 11:41:19PM +0800, Wei Yang wrote: > When retrieving VF IOV BAR in virtfn_add(), it will divide the total PF's IOV > BAR size with the totalVF number. This is true for most cases, while may not > be correct on some specific platform. > > For exampl

Re: [PATCH V9 00/18] Enable SRIOV on PowerNV

2014-11-18 Thread Bjorn Helgaas
On Tue, Nov 18, 2014 at 4:11 PM, Gavin Shan wrote: > On Sun, Nov 02, 2014 at 11:41:16PM +0800, Wei Yang wrote: > > Hello Bjorn, > > Did you have available bandwidth to review it? :-) I'm working on it right now :) >>This patchset enables the SRIOV on POWER8. >> >>The gerneral idea is put each VF

Re: [PATCH V9 00/18] Enable SRIOV on PowerNV

2014-11-18 Thread Gavin Shan
On Sun, Nov 02, 2014 at 11:41:16PM +0800, Wei Yang wrote: Hello Bjorn, Did you have available bandwidth to review it? :-) Thanks, Gavin >This patchset enables the SRIOV on POWER8. > >The gerneral idea is put each VF into one individual PE and allocate required >resources like MMIO/DMA/MSI. The

Re: [PATCH v2 0/6] pseries: Move memory hotplug to the kernel

2014-11-18 Thread Cyril Bur
On Tue, 2014-11-18 at 12:34 -0600, Nathan Fontenot wrote: > On 11/17/2014 08:00 PM, Cyril Bur wrote: > > Hi Nathan, > > > > I tried to apply these to Linus' tree and Mpes tree and to stable and > > got several problems, I got stuck at the third hunk in patch 5. > > I based these patches off of mp

Re: [PATCH V4 1/8] elf: Add new PowerPC specifc core note sections

2014-11-18 Thread Sukadev Bhattiprolu
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote: | This patch adds four new core note sections for PowerPC transactional | memory and one core note section for general miscellaneous debug registers. | These addition of new elf core note sections extends the existing elf ABI | without affectin

Re: [PATCH V4 6/8] powerpc, ptrace: Enable support for transactional memory register sets

2014-11-18 Thread Sukadev Bhattiprolu
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote: | This patch enables get and set of transactional memory related register | sets through PTRACE_GETREGSET-PTRACE_SETREGSET interface by implementing | four new powerpc specific register sets i.e REGSET_TM_SPR, REGSET_TM_CGPR, | REGSET_TM_CFPR,

Re: [RFC PATCH 08/16] PCI: Introduce pci_scan_host_bridge() and pci_host_info

2014-11-18 Thread Liviu Dudau
On Mon, Nov 17, 2014 at 10:21:42AM +, Yijing Wang wrote: > From: Yijing Wang > > Now pci_host_bridge has been ripped out from pci root > bus creation. Currently pci_scan_root_bus() lacks > scalability, so platform host drivers have no proper > way to configure pci_host_bridge. E.g we should a

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Liviu Dudau
On Mon, Nov 17, 2014 at 10:21:41AM +, Yijing Wang wrote: > There are some common PCI infos like domain, msi_controller, these > infos are saved in arch PCI sysdata, and lots arch specific functions > like pci_domain_nr() and pcibios_msi_controller() required. > We could separate pci_host_bridge

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Liviu Dudau
On Tue, Nov 18, 2014 at 08:32:26AM +, Yijing Wang wrote: > > >> +LIST_HEAD(pci_host_bridge_list); > >> +DECLARE_RWSEM(pci_host_bridge_sem); > > > > Unless the pci_host_bridge_sem is accessed thousands of times per second, > > it's normally better to use a simple mutex instead. > > OK, I will

Re: [RFC PATCH 04/16] PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus()

2014-11-18 Thread Liviu Dudau
On Mon, Nov 17, 2014 at 10:21:38AM +, Yijing Wang wrote: > Rip out pci_bus_add_devices() from pci_scan_root_bus() > for following reasons. > 1. pci_scan_root_bus() means we only do the scan, we should > not add pci busses. > 2. A lots of drviers which use pci_scan_root_bus() call > pci_bus_size

Re: [RFC PATCH 02/16] PCI: Use pci_scan_root_bus() instead of pci_scan_bus()

2014-11-18 Thread Liviu Dudau
On Mon, Nov 17, 2014 at 10:21:36AM +, Yijing Wang wrote: > From: Yijing Wang > > Now we could use pci_scan_root_bus() instead of > pci_scan_bus(), pass NULL resources means use the default > io/mem. Actually, I think this patch goes in the wrong direction. You are adding two additional param

Re: [RFC PATCH 01/16] PCI: Enhance pci_scan_root_bus() to support default IO/MEM resources

2014-11-18 Thread Liviu Dudau
On Tue, Nov 18, 2014 at 11:46:06AM +, Yijing Wang wrote: > On 2014/11/18 17:36, Arnd Bergmann wrote: > > On Tuesday 18 November 2014 15:44:23 Yijing Wang wrote: > >> On 2014/11/17 18:08, Arnd Bergmann wrote: > >>> On Monday 17 November 2014 18:21:35 Yijing Wang wrote: > - list_for_ea

Re: [v4,17/21] powerpc/8xx: set PTE bit 22 off TLBmiss

2014-11-18 Thread christophe leroy
Le 08/11/2014 01:08, Scott Wood a écrit : OK, so the _PAGE_KERNEL_RO(X) stuff is because initially setting the PTE doesn't go through pte_update(). I'll apply this, though it'd be cleaner to just have 8xx versions of the relevant PTE accessor functions to maintain the PTE the way the hardware

Re: [PATCH v2 0/6] pseries: Move memory hotplug to the kernel

2014-11-18 Thread Nathan Fontenot
On 11/17/2014 08:00 PM, Cyril Bur wrote: > Hi Nathan, > > I tried to apply these to Linus' tree and Mpes tree and to stable and > got several problems, I got stuck at the third hunk in patch 5. I based these patches off of mpe's -next tree. I did a fresh pull of mpe's tree and found that they do

Re: [PATCH net-next] PPC: bpf_jit_comp: Unify BPF_MOD | BPF_X and BPF_DIV | BPF_X

2014-11-18 Thread David Miller
From: Alexei Starovoitov Date: Tue, 18 Nov 2014 07:37:21 -0800 > On Mon, Nov 17, 2014 at 10:58 PM, Denis Kirjanov > wrote: >> Hi Michael, >> >> This patch added no new functionality so I haven't put the test >> results (of course I ran the test suite to check the patch). >> >> The output : >> [

Re: [PATCH v2 3/6] pseries: Create new device hotplug entry point

2014-11-18 Thread Nathan Fontenot
On 11/17/2014 04:53 PM, Gavin Shan wrote: > On Mon, Nov 17, 2014 at 03:51:42PM -0600, Nathan Fontenot wrote: >> Create a new entry point for device hotplug on pseries that will >> work for both PowerVM and PowerKVM systems. >> >> The current process to hotplug (or dlpar) devices (generally the same

Re: [RFC 00/11]: powerKVM, release the compute power of secondary hwthread on host

2014-11-18 Thread Alexander Graf
On 16.10.14 21:29, kernelf...@gmail.com wrote: > Nowadays, when running powerKVM(book3s, hv mode), we should make the > secondary hwthread > offline. Which means that if we run misc tsks other than dedicated KVM (e.g > mix java and KVM), > we will lose the compute power of the secondary hwthrea

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Tue, Nov 18, 2014 at 10:03:30PM +0530, Aneesh Kumar K.V wrote: > > diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.c > > index 5a236f0..46152aa 100644 > > --- a/arch/powerpc/mm/copro_fault.c > > +++ b/arch/powerpc/mm/copro_fault.c > > @@ -64,7 +64,12 @@ int copro_handle_

Re: [PATCH v3] of/base: Fix PowerPC address parsing hack

2014-11-18 Thread Grant Likely
On Fri, 14 Nov 2014 17:55:03 +1100 , Benjamin Herrenschmidt wrote: > We have a historical hack that treats missing ranges properties as the > equivalent of an empty one. This is needed for ancient PowerMac "bad" > device-trees, and shouldn't be enabled for any other PowerPC platform, > otherwise

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Aneesh Kumar K.V
Mel Gorman writes: > On Mon, Nov 17, 2014 at 01:56:19PM +0530, Aneesh Kumar K.V wrote: >> Mel Gorman writes: >> >> > This is follow up from the "pipe/page fault oddness" thread. >> > >> > Automatic NUMA balancing depends on being able to protect PTEs to trap a >> > fault and gather reference lo

Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-18 Thread Grant Likely
On Tue, 18 Nov 2014 11:36:19 +0100 , Andrzej Hajda wrote: > On 11/04/2014 11:45 AM, Grant Likely wrote: > > Currently the devices created by drivers/of/platform.c get created at > > the root of /sys/devices. This goes against the typical pattern for > > sysfs where the top level /sys/devices stru

Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections

2014-11-18 Thread Mel Gorman
On Mon, Nov 17, 2014 at 01:56:19PM +0530, Aneesh Kumar K.V wrote: > Mel Gorman writes: > > > This is follow up from the "pipe/page fault oddness" thread. > > > > Automatic NUMA balancing depends on being able to protect PTEs to trap a > > fault and gather reference locality information. Very broa

Re: [PATCH net-next] PPC: bpf_jit_comp: Unify BPF_MOD | BPF_X and BPF_DIV | BPF_X

2014-11-18 Thread Alexei Starovoitov
On Mon, Nov 17, 2014 at 10:58 PM, Denis Kirjanov wrote: > Hi Michael, > > This patch added no new functionality so I haven't put the test > results (of course I ran the test suite to check the patch). > > The output : > [ 650.198958] test_bpf: Summary: 60 PASSED, 0 FAILED Acked-by: Alexei Starov

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Yijing Wang
We need, some platforms pass NULL pointer as host bridge parent. >>> >>> But those don't have to use the new pci_create_host_bridge() function, >>> right? >> >> As I mentioned in another reply, I hope all pci host drivers could use >> pci_create_host_bridge(), keep different PCI scan interface

Re: [RFC PATCH 00/16] Refine PCI host bridge scan interfaces

2014-11-18 Thread Arnd Bergmann
On Tuesday 18 November 2014 20:17:57 Yijing Wang wrote: > > >> > >> I hope platforms with ACPI or DT could both use pci_create_host_bridge(). > >> Why we need to use two different ways to process it ? > > > > These are completely different use cases: > > > > a) For DT, we want loadable device dr

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Arnd Bergmann
On Tuesday 18 November 2014 19:44:36 Yijing Wang wrote: > On 2014/11/18 17:30, Arnd Bergmann wrote: > > On Tuesday 18 November 2014 16:32:26 Yijing Wang wrote: > > > +static struct resource busn_resource = { > +.name = "PCI busn", > +.start = 0, > +.e

Re: [RFC PATCH 00/16] Refine PCI host bridge scan interfaces

2014-11-18 Thread Yijing Wang
On 2014/11/18 19:30, Arnd Bergmann wrote: > On Tuesday 18 November 2014 19:17:32 Yijing Wang wrote: >> On 2014/11/17 22:13, Arnd Bergmann wrote: >>> On Monday 17 November 2014 18:21:34 Yijing Wang wrote: This series is based Linux 3.18-rc1 and Lorenzo Pieralisi's arm PCI domain cleanup pa

Re: [RFC PATCH 00/16] Refine PCI host bridge scan interfaces

2014-11-18 Thread Yijing Wang
On 2014/11/18 19:45, Lorenzo Pieralisi wrote: > On Tue, Nov 18, 2014 at 11:30:11AM +, Arnd Bergmann wrote: >> On Tuesday 18 November 2014 19:17:32 Yijing Wang wrote: >>> On 2014/11/17 22:13, Arnd Bergmann wrote: On Monday 17 November 2014 18:21:34 Yijing Wang wrote: > This series is ba

Re: [RFC PATCH 01/16] PCI: Enhance pci_scan_root_bus() to support default IO/MEM resources

2014-11-18 Thread Yijing Wang
On 2014/11/18 17:36, Arnd Bergmann wrote: > On Tuesday 18 November 2014 15:44:23 Yijing Wang wrote: >> On 2014/11/17 18:08, Arnd Bergmann wrote: >>> On Monday 17 November 2014 18:21:35 Yijing Wang wrote: - list_for_each_entry(window, resources, list) - if (window->res-

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Yijing Wang
On 2014/11/18 17:30, Arnd Bergmann wrote: > On Tuesday 18 November 2014 16:32:26 Yijing Wang wrote: > +static struct resource busn_resource = { + .name = "PCI busn", + .start = 0, + .end= 255, + .flags = IORESOURCE_BUS, +}; >>> >>> I think it would be bett

Re: [RFC PATCH 00/16] Refine PCI host bridge scan interfaces

2014-11-18 Thread Lorenzo Pieralisi
On Tue, Nov 18, 2014 at 11:30:11AM +, Arnd Bergmann wrote: > On Tuesday 18 November 2014 19:17:32 Yijing Wang wrote: > > On 2014/11/17 22:13, Arnd Bergmann wrote: > > > On Monday 17 November 2014 18:21:34 Yijing Wang wrote: > > >> This series is based Linux 3.18-rc1 and Lorenzo Pieralisi's > >

Re: [RFC PATCH 00/16] Refine PCI host bridge scan interfaces

2014-11-18 Thread Arnd Bergmann
On Tuesday 18 November 2014 19:17:32 Yijing Wang wrote: > On 2014/11/17 22:13, Arnd Bergmann wrote: > > On Monday 17 November 2014 18:21:34 Yijing Wang wrote: > >> This series is based Linux 3.18-rc1 and Lorenzo Pieralisi's > >> arm PCI domain cleanup patches, link: > >> https://patchwork.ozlabs.o

Re: [RFC PATCH 00/16] Refine PCI host bridge scan interfaces

2014-11-18 Thread Yijing Wang
On 2014/11/17 22:13, Arnd Bergmann wrote: > On Monday 17 November 2014 18:21:34 Yijing Wang wrote: >> This series is based Linux 3.18-rc1 and Lorenzo Pieralisi's >> arm PCI domain cleanup patches, link: >> https://patchwork.ozlabs.org/patch/407585/ >> >> Current pci scan interfaces like pci_scan_r

Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-18 Thread Andrzej Hajda
On 11/04/2014 11:45 AM, Grant Likely wrote: > Currently the devices created by drivers/of/platform.c get created at > the root of /sys/devices. This goes against the typical pattern for > sysfs where the top level /sys/devices structure contains categories of > devices, and the structure of devices

RE: [PATCH] powerpc: Remove more traces of bootmem

2014-11-18 Thread David Laight
From: Michael Ellerman > Although we are now selecting NO_BOOTMEM, we still have some traces of > bootmem lying around. That is because even with NO_BOOTMEM there is > still a shim that converts bootmem calls into memblock calls, but > ultimately we want to remove all traces of bootmem. > > Most o

Re: [PATCH] powerpc: Remove more traces of bootmem

2014-11-18 Thread Michael Ellerman
On Tue, 2014-11-18 at 17:52 +1100, Michael Ellerman wrote: > diff --git a/arch/powerpc/platforms/ps3/setup.c > b/arch/powerpc/platforms/ps3/setup.c > index 009a2004b876..86ed156f468f 100644 > --- a/arch/powerpc/platforms/ps3/setup.c > +++ b/arch/powerpc/platforms/ps3/setup.c > @@ -125,12 +125,8 @@

Re: [PATCH] [powerpc] Fix Text randomization

2014-11-18 Thread Michael Ellerman
On Tue, 2014-11-18 at 12:50 +0530, Vineeth Vijayan wrote: > On Mon, Nov 17, 2014 at 12:23 PM, Michael Ellerman > wrote: > > On Fri, 2014-11-14 at 14:42 +0530, Vineeth Vijayan wrote: > >> Now there is no way to disable TEXT randomization on a PPC32/PPC64 > >> machine. Text randomization happens ev

Re: [RFC PATCH 01/16] PCI: Enhance pci_scan_root_bus() to support default IO/MEM resources

2014-11-18 Thread Arnd Bergmann
On Tuesday 18 November 2014 15:44:23 Yijing Wang wrote: > On 2014/11/17 18:08, Arnd Bergmann wrote: > > On Monday 17 November 2014 18:21:35 Yijing Wang wrote: > >> - list_for_each_entry(window, resources, list) > >> - if (window->res->flags & IORESOURCE_BUS) { > >> -

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Arnd Bergmann
On Tuesday 18 November 2014 16:32:26 Yijing Wang wrote: > >> +static struct resource busn_resource = { > >> + .name = "PCI busn", > >> + .start = 0, > >> + .end= 255, > >> + .flags = IORESOURCE_BUS, > >> +}; > > > > I think it would be better to require callers to pass the bus resourc

Re: [RFC PATCH 07/16] PCI: Separate pci_host_bridge creation out of pci_create_root_bus()

2014-11-18 Thread Yijing Wang
>> +LIST_HEAD(pci_host_bridge_list); >> +DECLARE_RWSEM(pci_host_bridge_sem); > > Unless the pci_host_bridge_sem is accessed thousands of times per second, > it's normally better to use a simple mutex instead. OK, I will use simple mutex instead. > >> +static struct resource busn_resource = { >