Re: [PATCH] powerpc/kernel: Avoid memory corruption at early stage

2015-01-21 Thread Gavin Shan
On Thu, Jan 22, 2015 at 05:21:22PM +1100, Michael Ellerman wrote: >On Thu, 2015-01-08 at 16:40 +1100, Gavin Shan wrote: >> When calling to early_setup(), we picks "boot_paca" up for the >> master CPU and initialize that with initialise_paca(). At the >> point, SLB shadow buffer isn't populated yet.

Re: offlining cpus breakage

2015-01-21 Thread Preeti U Murthy
On 01/22/2015 10:59 AM, Michael Ellerman wrote: > On Fri, 2015-01-16 at 14:40 +0530, Preeti U Murthy wrote: >> On 01/16/2015 02:26 PM, Preeti U Murthy wrote: >>> On 01/16/2015 08:34 AM, Michael Ellerman wrote: On Fri, 2015-01-16 at 13:28 +1300, Alexey Kardashevskiy wrote: > On 01/16/2015 0

Re: powerpc/powernv: Don't alloc IRQ map if necessary

2015-01-21 Thread Gavin Shan
On Thu, Jan 22, 2015 at 04:54:59PM +1100, Michael Ellerman wrote: >On Thu, 2015-08-01 at 05:42:32 UTC, Gavin Shan wrote: >> On PowerNV platform, the OPAL interrupts are exported by firmware >> through device-node property (/ibm,opal::opal-interrupts). Under >> some extreme circumstances (e.g. simul

Re: [PATCH] powerpc/kernel: Avoid memory corruption at early stage

2015-01-21 Thread Michael Ellerman
On Thu, 2015-01-08 at 16:40 +1100, Gavin Shan wrote: > When calling to early_setup(), we picks "boot_paca" up for the > master CPU and initialize that with initialise_paca(). At the > point, SLB shadow buffer isn't populated yet. Updating the SLB > shadow buffer should corrupt what we had in physic

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Zidan Wang
On Wed, Jan 21, 2015 at 09:44:10PM -0800, Nicolin Chen wrote: > On Thu, Jan 22, 2015 at 12:55:35PM +0800, Zidan Wang wrote: > > On Wed, Jan 21, 2015 at 10:08:03AM -0800, Nicolin Chen wrote: > > > On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > > > > @@ -369,10 +380,25 @@ static int fs

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-21 Thread Preeti U Murthy
On 01/21/2015 05:16 PM, Thomas Gleixner wrote: > On Tue, 20 Jan 2015, Preeti U Murthy wrote: >> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c >> index 5544990..f3907c9 100644 >> --- a/kernel/time/clockevents.c >> +++ b/kernel/time/clockevents.c >> @@ -568,6 +568,7 @@ int clocke

Re: powerpc/powernv: Don't alloc IRQ map if necessary

2015-01-21 Thread Michael Ellerman
On Thu, 2015-08-01 at 05:42:32 UTC, Gavin Shan wrote: > On PowerNV platform, the OPAL interrupts are exported by firmware > through device-node property (/ibm,opal::opal-interrupts). Under > some extreme circumstances (e.g. simulator), we don't have this > property found from the device tree. For t

Re: [alsa-devel][PATCH 3/3] ASoC: fsl_sai: Add support for Right-J mode

2015-01-21 Thread Nicolin Chen
On Thu, Jan 22, 2015 at 01:13:46PM +0800, Zidan Wang wrote: > On Wed, Jan 21, 2015 at 10:53:20AM -0800, Nicolin Chen wrote: > > On Tue, Jan 20, 2015 at 08:21:20PM +0800, Zidan Wang wrote: > > > Add Right-J mode and set TCR5 FBT bit to let data right justify. > > > > > > Signed-off-by: Zidan Wang

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Nicolin Chen
On Thu, Jan 22, 2015 at 12:55:35PM +0800, Zidan Wang wrote: > On Wed, Jan 21, 2015 at 10:08:03AM -0800, Nicolin Chen wrote: > > On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > > > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct > > > snd_pcm_substream *substream, > > > u3

Re: [PATCH] powerpc/pseries: fix endian problems with LE migration

2015-01-21 Thread Cyril Bur
On Wed, 2015-01-21 at 14:33 +1100, Michael Ellerman wrote: > On Wed, 2015-01-21 at 13:32 +1100, Cyril Bur wrote: > > The need to handle ibm,suspend_me specially from within ppc_rtas has left an > > endian bug exposed as rtas_ibm_suspend_me actually performs HCALLs and > > should > > have its param

Re: offlining cpus breakage

2015-01-21 Thread Michael Ellerman
On Fri, 2015-01-16 at 14:40 +0530, Preeti U Murthy wrote: > On 01/16/2015 02:26 PM, Preeti U Murthy wrote: > > On 01/16/2015 08:34 AM, Michael Ellerman wrote: > >> On Fri, 2015-01-16 at 13:28 +1300, Alexey Kardashevskiy wrote: > >>> On 01/16/2015 02:22 AM, Preeti U Murthy wrote: > Hi Alexey, >

Re: [alsa-devel][PATCH 3/3] ASoC: fsl_sai: Add support for Right-J mode

2015-01-21 Thread Zidan Wang
On Wed, Jan 21, 2015 at 10:53:20AM -0800, Nicolin Chen wrote: > On Tue, Jan 20, 2015 at 08:21:20PM +0800, Zidan Wang wrote: > > Add Right-J mode and set TCR5 FBT bit to let data right justify. > > > > Signed-off-by: Zidan Wang > > > - if (sai->is_lsb_first) > > + if (sai->is_lsb_first && sai

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

2015-01-21 Thread Michael Ellerman
On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: > When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() > return 0. Check for these return values and skip registering the dump buffer. > > Signed-off-by: Pranith Kumar > CC: Michael Ellerman > --- > arch/powerpc/plat

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Zidan Wang
On Wed, Jan 21, 2015 at 10:08:03AM -0800, Nicolin Chen wrote: > On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct snd_pcm_substream > > *substream, > > u32 word_width = snd_pcm_format_width(params_format(params)); > >

Re: [PATCH] powerpc/fsl_pci: Fix pci stack build bug with FRAME_WARN

2015-01-21 Thread Scott Wood
On Wed, 2015-01-21 at 20:48 -0600, Kim Phillips wrote: > On Tue, 20 Jan 2015 18:31:32 -0600 > Scott Wood wrote: > > > On Tue, 2015-01-20 at 14:03 -0600, Kim Phillips wrote: > > > Fix this: > > > > > > CC arch/powerpc/sysdev/fsl_pci.o > > > arch/powerpc/sysdev/fsl_pci.c: In function 'fsl_p

Re: [PATCH] powerpc/fsl_pci: Fix pci stack build bug with FRAME_WARN

2015-01-21 Thread Kim Phillips
On Tue, 20 Jan 2015 18:31:32 -0600 Scott Wood wrote: > On Tue, 2015-01-20 at 14:03 -0600, Kim Phillips wrote: > > Fix this: > > > > CC arch/powerpc/sysdev/fsl_pci.o > > arch/powerpc/sysdev/fsl_pci.c: In function 'fsl_pcie_check_link': > > arch/powerpc/sysdev/fsl_pci.c:91:1: error: the fra

[PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

2015-01-21 Thread Pranith Kumar
When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() return 0. Check for these return values and skip registering the dump buffer. Signed-off-by: Pranith Kumar CC: Michael Ellerman --- arch/powerpc/platforms/powernv/opal.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH] powerpc: Replace cpumask_weight(cpu_possible_mask) with num_possible_cpus()

2015-01-21 Thread Emil Medve
Hello Michael, On 01/21/2015 07:12 PM, Michael Ellerman wrote: > On Wed, 2015-01-21 at 16:21 -0600, Emil Medve wrote: >> Signed-off-by: Emil Medve > > Why? > > Because: > >#define num_possible_cpus()cpumask_weight(cpu_possible_mask) > > > But please say so in future. I'll fix it

Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds

2015-01-21 Thread Joonsoo Kim
On Wed, Jan 21, 2015 at 09:57:59PM +0900, Akinobu Mita wrote: > 2015-01-21 9:07 GMT+09:00 Andrew Morton : > > On Tue, 20 Jan 2015 15:01:50 -0800 j...@joshtriplett.org wrote: > > > >> On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: > >> > It's possible to configure DEBUG_PAGEALLOC with

Re: [PATCH] powerpc: Replace cpumask_weight(cpu_possible_mask) with num_possible_cpus()

2015-01-21 Thread Michael Ellerman
On Wed, 2015-01-21 at 16:21 -0600, Emil Medve wrote: > Signed-off-by: Emil Medve Why? Because: #define num_possible_cpus() cpumask_weight(cpu_possible_mask) But please say so in future. I'll fix it up this time. cheers ___ Linuxppc-dev mailin

Re: [PATCH resend] powernv/iommu: disable IOMMU bypass with param iommu=nobypass

2015-01-21 Thread Michael Ellerman
On Wed, 2015-01-21 at 13:23 -0200, Thadeu Lima de Souza Cascardo wrote: > When IOMMU bypass is enabled, a PCI device can read and write memory > that was not mapped by the driver without causing an EEH. That might > cause memory corruption, for example. > > When we disable bypass, DMA reads and wr

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-01-21 Thread Michael Neuling
On Thu, 2015-01-01 at 13:38 +0530, Anshuman Khandual wrote: > On 12/20/2014 12:58 AM, Edjunior Barbosa Machado wrote: > > On 12/08/2014 08:08 AM, Anshuman Khandual wrote: > >> On 12/03/2014 12:18 PM, Anshuman Khandual wrote: > >>> On 12/03/2014 10:52 AM, Michael Ellerman wrote: > On Tue, 2014-

[PATCH] powerpc/dts: Remove T4240 emulator support

2015-01-21 Thread Emil Medve
Probably we should have not upstreamed this in the first place Signed-off-by: Emil Medve --- arch/powerpc/boot/dts/t4240emu.dts | 281 - 1 file changed, 281 deletions(-) delete mode 100644 arch/powerpc/boot/dts/t4240emu.dts diff --git a/arch/powerpc/boot/dts

[PATCH] powerpc: Remove duplicate tlbcam_index declarations

2015-01-21 Thread Emil Medve
They seem to be leftovers from '14cf11a powerpc: Merge enough to start building in arch/powerpc' Signed-off-by: Emil Medve --- arch/powerpc/mm/fsl_booke_mmu.c | 2 -- arch/powerpc/mm/pgtable_32.c| 1 - 2 files changed, 3 deletions(-) diff --git a/arch/powerpc/mm/fsl_booke_mmu.c b/arch/power

[PATCH] powerpc: Replace cpumask_weight(cpu_possible_mask) with num_possible_cpus()

2015-01-21 Thread Emil Medve
Signed-off-by: Emil Medve --- arch/powerpc/platforms/cell/smp.c| 2 +- arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +- arch/powerpc/sysdev/mpic.c | 2 +- arch/powerpc/sysdev/xics/xics-common.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [alsa-devel][PATCH 3/3] ASoC: fsl_sai: Add support for Right-J mode

2015-01-21 Thread Nicolin Chen
On Tue, Jan 20, 2015 at 08:21:20PM +0800, Zidan Wang wrote: > Add Right-J mode and set TCR5 FBT bit to let data right justify. > > Signed-off-by: Zidan Wang > - if (sai->is_lsb_first) > + if (sai->is_lsb_first && sai->is_right_j_mode) > val_cr5 |= FSL_SAI_CR5_FBT(0); Are y

Re: [PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER

2015-01-21 Thread Robert Richter
On 21.01.15 22:54:08, Anton Blanchard wrote: > HAVE_PERF_EVENTS_NMI is used for two things - the oprofile NMI timer > and the hard lockup detector. > > Create HAVE_OPROFILE_NMI_TIMER so an architecture can select them > separately. On ppc64 we want to add the hard lockup detector, but not > the op

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Nicolin Chen
On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct snd_pcm_substream > *substream, > u32 word_width = snd_pcm_format_width(params_format(params)); > u32 val_cr4 = 0, val_cr5 = 0; > int ret; > + u32 bclk; > +

Re: [alsa-devel][PATCH 1/3] SoC: fsl_sai: add sai master mode support

2015-01-21 Thread Nicolin Chen
On Wed, Jan 21, 2015 at 05:25:32PM +0800, Zidan Wang wrote: > On Tue, Jan 20, 2015 at 10:07:03PM -0800, Nicolin Chen wrote: > > On Tue, Jan 20, 2015 at 08:21:18PM +0800, Zidan Wang wrote: > > > + if ((tx && sai->synchronous[TX]) || (!tx && !sai->synchronous[RX])) { > > > + regmap_update_bi

Re: [RFC PATCH 0/8] Fix perf probe issues on powerpc

2015-01-21 Thread Naveen N. Rao
On 2015/01/21 09:51AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 09, 2014 at 11:03:58PM +0530, Naveen N. Rao escreveu: > > This patchset fixes various issues with perf probe on powerpc > > across ABIv1 and ABIv2: > > - in the presence of DWARF debug-info, > > - in the absence of DWARF, but with

[PATCH resend] powernv/iommu: disable IOMMU bypass with param iommu=nobypass

2015-01-21 Thread Thadeu Lima de Souza Cascardo
When IOMMU bypass is enabled, a PCI device can read and write memory that was not mapped by the driver without causing an EEH. That might cause memory corruption, for example. When we disable bypass, DMA reads and writes to addresses not mapped by the IOMMU will cause an EEH, allowing us to debug

Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds

2015-01-21 Thread Akinobu Mita
2015-01-21 9:07 GMT+09:00 Andrew Morton : > On Tue, 20 Jan 2015 15:01:50 -0800 j...@joshtriplett.org wrote: > >> On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: >> > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on >> > ppc. Fix building the generic kernel_map_pag

Re: [RFC PATCH 0/8] Fix perf probe issues on powerpc

2015-01-21 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 09, 2014 at 11:03:58PM +0530, Naveen N. Rao escreveu: > This patchset fixes various issues with perf probe on powerpc > across ABIv1 and ABIv2: > - in the presence of DWARF debug-info, > - in the absence of DWARF, but with the symbol table, and > - in the absence of debug-info, but with

Re: [PATCH 1/2] powerpc: Add 64bit optimised memcmp

2015-01-21 Thread Anton Blanchard
Hi Arnd, > Would it help to also add a way for an architecture to override > memcmp_pages() with its own implementation? That way you could > skip the unaligned part, hardcode the loop counter and avoid the > preempt_disable() in kmap_atomic(). Good idea. We could also have a generic implementati

[PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER

2015-01-21 Thread Anton Blanchard
HAVE_PERF_EVENTS_NMI is used for two things - the oprofile NMI timer and the hard lockup detector. Create HAVE_OPROFILE_NMI_TIMER so an architecture can select them separately. On ppc64 we want to add the hard lockup detector, but not the oprofile NMI timer fallback. Signed-off-by: Anton Blanchar

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-21 Thread Thomas Gleixner
On Tue, 20 Jan 2015, Preeti U Murthy wrote: > diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c > index 5544990..f3907c9 100644 > --- a/kernel/time/clockevents.c > +++ b/kernel/time/clockevents.c > @@ -568,6 +568,7 @@ int clockevents_notify(unsigned long reason, void *arg) > >

[PATCH V2] cpuidle: Add missing checks to the exit condition of cpu_idle_poll()

2015-01-21 Thread Preeti U Murthy
cpu_idle_poll() is entered into when either the cpu_idle_force_poll is set or tick_check_broadcast_expired() returns true. The exit condition from cpu_idle_poll() is tif_need_resched(). However this does not take into account scenarios where cpu_idle_force_poll changes or tick_check_broadcast_expi

Re: [PATCH] idle/tick-broadcast: Exit cpu idle poll loop when cleared from tick_broadcast_force_mask

2015-01-21 Thread Preeti U Murthy
On 01/21/2015 03:26 PM, Thomas Gleixner wrote: > On Tue, 20 Jan 2015, Preeti U Murthy wrote: >> On 01/20/2015 04:51 PM, Thomas Gleixner wrote: >>> On Mon, 19 Jan 2015, Preeti U Murthy wrote: An idle cpu enters cpu_idle_poll() if it is set in the tick_broadcast_force_mask. This is so

Re: [alsa-devel][PATCH 1/3] SoC: fsl_sai: add sai master mode support

2015-01-21 Thread Zidan Wang
On Tue, Jan 20, 2015 at 10:07:03PM -0800, Nicolin Chen wrote: > On Tue, Jan 20, 2015 at 08:21:18PM +0800, Zidan Wang wrote: > > +static int fsl_sai_set_bclk(struct snd_soc_dai *dai, bool tx, u32 freq) > > > + if ((tx && sai->synchronous[TX]) || (!tx && !sai->synchronous[RX])) { > > + r

[PATCH v2 03/10] clk: qoriq: Fix checkpatch type ALLOC_SIZEOF_STRUCT

2015-01-21 Thread Emil Medve
CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*cmux_clk)...) over kzalloc(sizeof(struct cmux_clk)...) + cmux_clk = kzalloc(sizeof(struct cmux_clk), GFP_KERNEL); CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*onecell_data)...) over kzalloc(sizeof(struct clk_onecell_data)...) + o

[PATCH v2 10/10] clk: qoriq: Add support for the FMan clock

2015-01-21 Thread Emil Medve
From: Igal Liberman Change-Id: Ide452600ece9fdd7028a27556d2f1ab3bddd3aa5 Signed-off-by: Igal Liberman --- drivers/clk/clk-qoriq.c | 253 1 file changed, 253 insertions(+) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index cda90

[PATCH v2 08/10] powerpc/corenet: Enable CLK_QORIQ

2015-01-21 Thread Emil Medve
Change-Id: I1a80ad7b9f6854791bd270b746f93a91439155a6 Signed-off-by: Emil Medve --- arch/powerpc/configs/corenet32_smp_defconfig | 1 + arch/powerpc/configs/corenet64_smp_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/co

[PATCH v2 04/10] clk: qoriq: Fix checkpatch type OOM_MESSAGE

2015-01-21 Thread Emil Medve
WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message + if (!parent_names) { + pr_err("%s: could not allocate parent_names\n", __func__); WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message + if (!cmux_clk) { + pr_err("%s: could not

[PATCH v2 07/10] clk: qoriq: Use pr_fmt()

2015-01-21 Thread Emil Medve
Currently a mix of clk-qoriq/qoriq-clk and no prefix is used Signed-off-by: Emil Medve --- drivers/clk/clk-qoriq.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 4b44825..07bdfc5 100644 --- a/drivers/clk/clk-qori

[PATCH v2 02/10] clk: qoriq: Fix checkpatch type ALLOC_WITH_MULTIPLY

2015-01-21 Thread Emil Medve
WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply + subclks = kzalloc(sizeof(struct clk *) * count, GFP_KERNEL); Signed-off-by: Emil Medve --- drivers/clk/clk-qoriq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-qoriq.c b/driv

[PATCH v2 00/10] clk: qoriq: Add support for the FMan clock

2015-01-21 Thread Emil Medve
Based on clk-next from git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git v2: Rebased as several prerequisite patches (including a file rename) got applied upstream Emil Medve (9): clk: qoriq: Fix checkpatch type PARENTHESIS_ALIGNMENT clk: qoriq: Fix checkpatch type ALLO

[PATCH v2 09/10] clk: qoriq: Add support for the platform PLL

2015-01-21 Thread Emil Medve
Change-Id: Iac11ed95f274485a86d2c11f32a3dc502bcd020f Signed-off-by: Emil Medve --- drivers/clk/clk-qoriq.c | 83 + 1 file changed, 83 insertions(+) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 07bdfc5..cda90a9 100644 --- a/d

[PATCH v2 06/10] clk: qoriq: Replace kzalloc() with kmalloc()

2015-01-21 Thread Emil Medve
Where the memset() is not necessary Signed-off-by: Emil Medve --- drivers/clk/clk-qoriq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 07936a3..4b44825 100644 --- a/drivers/clk/clk-qoriq.c +++ b/drivers/clk/clk-qoriq.

[PATCH v2 01/10] clk: qoriq: Fix checkpatch type PARENTHESIS_ALIGNMENT

2015-01-21 Thread Emil Medve
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis + rc = of_property_read_string_index(np, "clock-output-names", + 0, &clk_name); CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis + pr_err("Could not register clock pro

[PATCH v2 05/10] clk: qoriq: Make local symbol 'static'

2015-01-21 Thread Emil Medve
drivers/clk/clk-qoriq.c:59:22: warning: symbol 'cmux_ops' was not declared. Should it be static? Signed-off-by: Emil Medve --- drivers/clk/clk-qoriq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index e25dea9..07936a3 100

Re: [PATCH 8/8] clk: ppc-corenet: Add support for the platform PLL

2015-01-21 Thread Emil Medve
Hello Yuan-Tian, On 01/21/2015 03:37 AM, Tang Yuantian-B29983 wrote: > Hello Emil, > >>From the RM and your code, I didn't see any difference between the two type >>of PLL. > Could you provide some use cases or feature that prove this is necessary? I said the DT makes the core_pll_init() code

Re: [PATCH] idle/tick-broadcast: Exit cpu idle poll loop when cleared from tick_broadcast_force_mask

2015-01-21 Thread Thomas Gleixner
On Tue, 20 Jan 2015, Preeti U Murthy wrote: > On 01/20/2015 04:51 PM, Thomas Gleixner wrote: > > On Mon, 19 Jan 2015, Preeti U Murthy wrote: > >> An idle cpu enters cpu_idle_poll() if it is set in the > >> tick_broadcast_force_mask. > >> This is so that it does not incur the overhead of entering i

Re: [PATCH] powerpc/mpic: Add DT option to skip readback after EOI

2015-01-21 Thread Scott Wood
On Wed, 2015-01-21 at 11:35 +0200, Purcareata Bogdan wrote: > On 14.01.2015 19:58, Scott Wood wrote: > > On Wed, 2015-01-14 at 11:57 +, Bogdan Purcareata wrote: > >> The readback is necessary in order to handle PCI posted > >> writes, > > > > That is unclear. > > I'm going to try an venture a

Re: [PATCH] powerpc/mpic: Add DT option to skip readback after EOI

2015-01-21 Thread Purcareata Bogdan
On 14.01.2015 19:58, Scott Wood wrote: On Wed, 2015-01-14 at 11:57 +, Bogdan Purcareata wrote: The readback is necessary in order to handle PCI posted writes, That is unclear. I'm going to try an venture a different explanation here. I found a good explanation in Writing PCI Drivers [1]

RE: [PATCH 8/8] clk: ppc-corenet: Add support for the platform PLL

2015-01-21 Thread Yuantian Tang
Hello Emil, From the RM and your code, I didn't see any difference between the two type of PLL. Could you provide some use cases or feature that prove this is necessary? If there did have some features that current function didn't contain, can we expend the current one to include it? BTW: if y

Re: [PATCH 1/2] powerpc: Add 64bit optimised memcmp

2015-01-21 Thread Arnd Bergmann
On Wednesday 21 January 2015 12:27:38 Anton Blanchard wrote: > I noticed ksm spending quite a lot of time in memcmp on a large > KVM box. The current memcmp loop is very unoptimised - byte at a > time compares with no loop unrolling. We can do much much better. > > Optimise the loop in a few ways:

Re: [PATCH 8/8] clk: ppc-corenet: Add support for the platform PLL

2015-01-21 Thread Emil Medve
Hello Yuan-Tian, On 01/21/2015 02:35 AM, Tang Yuantian-B29983 wrote: > Hi Emil, > > I don't think it is the best to add a function that is very similar to > existing one. > If you think the function name is not appropriate, rename it. It's not a naming matter. As I said, core_pll_init() assum

Re: [PATCH] powerpc/mm: Add trace point for tracking hash pte fault

2015-01-21 Thread Aneesh Kumar K.V
Michael Ellerman writes: > On Tue, 2015-01-20 at 17:05 +0530, Aneesh Kumar K.V wrote: >> This enables us to understand how many hash fault we are taking >> when running benchmarks. >> >> For ex: >> -bash-4.2# ./perf stat -e powerpc:hash_fault -e page-faults >> /tmp/ebizzy.ppc64 -S 30 -P -n 10

RE: [PATCH 8/8] clk: ppc-corenet: Add support for the platform PLL

2015-01-21 Thread Yuantian Tang
Hi Emil, I don't think it is the best to add a function that is very similar to existing one. If you think the function name is not appropriate, rename it. Thanks, Yuantian > -Original Message- > From: Emil Medve [mailto:emilian.me...@freescale.com] > Sent: Wednesday, January 21, 2015

RE: PowerMac G5 Quad Issue reporting

2015-01-21 Thread luigi burdo
Hi Mike, thank you for your reply . yes im sorry i was fixed the issue yesterday night, forcing the module i2c_powermac loaded from etc/modules stange it was not loaded by default like it was before. in any way *fixed :-) About the RadeonHD , yes you are true, have the Mesa/Gallium working is pr

Re: [PATCH 8/8] clk: ppc-corenet: Add support for the platform PLL

2015-01-21 Thread Emil Medve
Hello Yuan-Tian, On 01/20/2015 11:42 PM, Tang Yuantian-B29983 wrote: > Which platform are you trying to use this on? CoreNet chassis v1 and v2 SoC(s) > Can this be initialized by core pll function core_pll_init()? > I just saw most of this function is silimar to the core_pll_init(). Yes, the f