Re: [PATCH] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Ian Munsie
Excerpts from andrew.donnellan's message of 2015-09-04 16:20:24 +1000: > +if (!cxl_adapter_link_ok(afu->adapter)) > +dev_warn(>dev, "%s: Device link is down, refusing to enable > AFU\n", __func__); > +return false; Based on the indentation it looks like you meant to add some

[PATCH] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Andrew Donnellan
cxl_pci_enable_device_hook() is called when attempting to enable an AFU sitting on a vPHB. At present, the state of the underlying CXL card's PCI channel is only checked when it calls cxl_afu_check_and_enable() at the very end, after it has already set DMA options and initialised a default

Re: memcpy regression

2015-09-06 Thread Michael Ellerman
Hi Michal, Thanks for finding the problem. On Sun, 2015-09-06 at 23:01 +0200, Michal Sojka wrote: > > I found the problem. The compiler replaces an assignment with a call to > memcpy. The following patch fixes the problem for me. However, I'm not > sure whether this is the real solution. I

Re: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case

2015-09-06 Thread Michael Ellerman
On Sun, 2015-09-06 at 17:44 +0300, Michael S. Tsirkin wrote: > On Fri, Sep 04, 2015 at 08:17:12PM -0300, Guilherme G. Piccoli wrote: > > Hello Bjorn, > > > > >of_create_pci_dev() already has a lot of code that duplicates > > >pci_setup_device(), and it's a shame to add more. There's also a sparc

Re: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case

2015-09-06 Thread Michael Ellerman
On Thu, 2015-09-03 at 12:56 -0500, Bjorn Helgaas wrote: > [+cc Fam, Yinghai, Yijing, Eric (reviewers of MST's original series), Dave] > > Hi Guilherme, > > On Wed, Aug 19, 2015 at 03:54:10PM -0300, Guilherme G. Piccoli wrote: > > diff --git a/arch/powerpc/kernel/pci_of_scan.c > >

Re: [PATCH v2] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Andrew Donnellan
On 07/09/15 12:53, Michael Ellerman wrote: Is this a fix targetting 4.3 (current release) and/or stable, or something for next? 4.3 - this fix is related to cxl's EEH support which has been merged for 4.3. For the record, since I neglected to add this earlier: --- Changes from v1: - Insert

Re: [PATCH] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Andrew Donnellan
On 07/09/15 09:58, Ian Munsie wrote: Excerpts from andrew.donnellan's message of 2015-09-04 16:20:24 +1000: +if (!cxl_adapter_link_ok(afu->adapter)) +dev_warn(>dev, "%s: Device link is down, refusing to enable AFU\n", __func__); +return false; Based on the indentation

Re: [PATCH v2] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Michael Ellerman
On Mon, 2015-09-07 at 10:52 +1000, Andrew Donnellan wrote: > cxl_pci_enable_device_hook() is called when attempting to enable an AFU > sitting on a vPHB. At present, the state of the underlying CXL card's PCI > channel is only checked when it calls cxl_afu_check_and_enable() at the > very end,

Re: [PATCH v2] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Ian Munsie
Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: memcpy regression

2015-09-06 Thread Michal Sojka
On Sun, Sep 06 2015, Michal Sojka wrote: > On Sun, Sep 06 2015, christophe leroy wrote: >> Le 05/09/2015 02:08, Michal Sojka a écrit : >>> On 4.9.2015 21:49, Michal Sojka wrote: On 4.9.2015 20:10, christophe leroy wrote: > > > Le 04/09/2015 16:35, Michal Sojka a écrit : >> On

Re: [PATCH] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Ian Munsie
That looks better :) Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc

2015-09-06 Thread Michael Ellerman
On Fri, 2015-09-04 at 17:51 -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 01, 2015 at 12:18:47PM +0530, Hemant Kumar escreveu: > > >Should I try to process the 5 together, applying thest two first? > > > Yes, this patchset needs to be applied before applying the other patchset, > > since

[PATCH] powerpc: Kconfig: remove BE-only platforms from LE kernel build

2015-09-06 Thread Boqun Feng
Currently, little endian is only supported on powernv and pseries, however, Kconfigs still allow us to include other platforms in a LE kernel, this may result in space wasting or even build error if some BE-only platforms always assume they are built for a BE kernel. So just modify the Kconfigs of

[PATCH v2] cxl: abort cxl_pci_enable_device_hook() if PCI channel is offline

2015-09-06 Thread Andrew Donnellan
cxl_pci_enable_device_hook() is called when attempting to enable an AFU sitting on a vPHB. At present, the state of the underlying CXL card's PCI channel is only checked when it calls cxl_afu_check_and_enable() at the very end, after it has already set DMA options and initialised a default

Re: memcpy regression

2015-09-06 Thread christophe leroy
Le 05/09/2015 02:08, Michal Sojka a écrit : On 4.9.2015 21:49, Michal Sojka wrote: On 4.9.2015 20:10, christophe leroy wrote: Le 04/09/2015 16:35, Michal Sojka a écrit : On Fri, Sep 04 2015, Christophe LEROY wrote: Le 04/09/2015 15:33, Michal Sojka a écrit : Dear Christophe, my

RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram

2015-09-06 Thread Zhao Qiang
On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, September 02, 2015 8:34 AM > To: Zhao Qiang-B45475 > Cc: linux-ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > lau...@codeaurora.org; Xie Xiaobo-R63061;

Re: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case

2015-09-06 Thread Michael S. Tsirkin
On Fri, Sep 04, 2015 at 08:17:12PM -0300, Guilherme G. Piccoli wrote: > Hello Bjorn, > > >of_create_pci_dev() already has a lot of code that duplicates > >pci_setup_device(), and it's a shame to add more. There's also a sparc > >version of of_create_pci_dev() that presumably has the same problem

Re: memcpy regression

2015-09-06 Thread Michal Sojka
On Sun, Sep 06 2015, christophe leroy wrote: > Le 05/09/2015 02:08, Michal Sojka a écrit : >> On 4.9.2015 21:49, Michal Sojka wrote: >>> On 4.9.2015 20:10, christophe leroy wrote: Le 04/09/2015 16:35, Michal Sojka a écrit : > On Fri, Sep 04 2015, Christophe LEROY wrote: >>