Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers

2016-09-11 Thread Michael Ellerman
Borislav Petkov writes: > On Sat, Sep 10, 2016 at 07:57:08PM +1000, Michael Ellerman wrote: >> We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it >> from powerpc-only drivers. >> >> Signed-off-by: Michael Ellerman >> --- >>

Re: [PATCH 2/3] powernv/eeh: Skip finding bus for VF resets

2016-09-11 Thread Andrew Donnellan
On 12/09/16 14:17, Russell Currey wrote: When the PE used in pnv_eeh_reset() is that of a VF, pnv_eeh_reset_vf_pe() is used. Unlike the other reset functions called in pnv_eeh_reset(), the VF reset doesn't require a bus, and if a bus was missing the function would error out before resetting the

Re: [PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting

2016-09-11 Thread Andrew Donnellan
On 12/09/16 14:17, Russell Currey wrote: In eeh_handle_special_event(), eeh_pe_bus_get() is called before calling eeh_report_failure() on every device under a PE. If a PE was missing a bus for some reason, the error would occur before reporting failure, even though eeh_report_failure() doesn't

Re: [PATCH 1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get

2016-09-11 Thread Andrew Donnellan
On 12/09/16 14:17, Russell Currey wrote: eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE. Some callers don't check this, and can cause a null pointer dereference under certain circumstances. Fix this by checking NULL everywhere eeh_pe_bus_get() is called. Cc: stable

[PATCH 2/3] powernv/eeh: Skip finding bus for VF resets

2016-09-11 Thread Russell Currey
When the PE used in pnv_eeh_reset() is that of a VF, pnv_eeh_reset_vf_pe() is used. Unlike the other reset functions called in pnv_eeh_reset(), the VF reset doesn't require a bus, and if a bus was missing the function would error out before resetting the VF PE. To avoid this, reorder the VF

[PATCH 3/3] powerpc/eeh: Skip finding bus until after failure reporting

2016-09-11 Thread Russell Currey
In eeh_handle_special_event(), eeh_pe_bus_get() is called before calling eeh_report_failure() on every device under a PE. If a PE was missing a bus for some reason, the error would occur before reporting failure, even though eeh_report_failure() doesn't require a bus. Fix this by moving the bus

[PATCH 1/3] powerpc/eeh: Null check uses of eeh_pe_bus_get

2016-09-11 Thread Russell Currey
eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE. Some callers don't check this, and can cause a null pointer dereference under certain circumstances. Fix this by checking NULL everywhere eeh_pe_bus_get() is called. Cc: stable #3.10+ Signed-off-by: Russell Currey

Re: [PATCH] powerpc: set used_vsr/used_vr/used_spe in sigreturn path when MSR bits are active

2016-09-11 Thread Simon Guo
On Tue, Jul 26, 2016 at 04:06:01PM +0800, wei.guo.si...@gmail.com wrote: > From: Simon Guo > > Normally, when MSR[VSX/VR/SPE] bits = 1, the used_vsr/used_vr/used_spe > bit have already been set. However signal frame locates at user space > and it is controlled by user

[PATCH v2] powerpc/ptrace: Fix cppcheck issue in gpr32_set_common/gpr32_get_common()

2016-09-11 Thread wei . guo . simon
From: Simon Guo The ckpt_regs usage in gpr32_set_common/gpr32_get_common() will lead to following cppcheck error at ifndef CONFIG_PPC_TRANSACTIONAL_MEM case: [arch/powerpc/kernel/ptrace.c:2062]: (error) Uninitialized variable: ckpt_regs

Re: [PATCH v2 3/3] powerpc/mm: Speed up computation of base and actual page size for a HPTE

2016-09-11 Thread Michael Ellerman
Paolo Bonzini writes: > On 08/09/2016 12:08, Paul Mackerras wrote: >>> > >>> > arch/powerpc/include/asm/book3s/64/mmu-hash.h | 37 >>> > arch/powerpc/include/asm/kvm_book3s_64.h | 87 >>> > +++ >>> > arch/powerpc/include/asm/mmu.h

[PATCH] powerpc/kernel: Fix size of NUM_CPU_FTR_KEYS on 32-bit

2016-09-11 Thread Michael Ellerman
The number of CPU feature keys is meant to map 1:1 to the number of CPU feature flags defined in cputable.h, and the latter must fit in an unsigned long. In commit 4db7327194db ("powerpc: Add option to use jump label for cpu_has_feature()"), I incorrectly defined NUM_CPU_FTR_KEYS to 64. There

Re: [PATCH] powerpc/ptrace: Fix cppcheck issue in gpr32_set_common/gpr32_get_common.

2016-09-11 Thread Michael Ellerman
Simon Guo writes: > Thanks for the feedback regarding too many ifdefs. Is following implemention > better for this issue? Yes that looks much better. Can you send a proper patch with a change log and so on, thanks. cheers

Re: [PATCH v2 3/3] powerpc/mm: Speed up computation of base and actual page size for a HPTE

2016-09-11 Thread Paul Mackerras
On Thu, Sep 08, 2016 at 12:16:00PM +0200, Paolo Bonzini wrote: > > > On 08/09/2016 12:08, Paul Mackerras wrote: > >> > > >> > arch/powerpc/include/asm/book3s/64/mmu-hash.h | 37 > >> > arch/powerpc/include/asm/kvm_book3s_64.h | 87 > >> > +++ > >> >

Re: [PATCH 0/6] KVM: PPC: e500: Fine-tuning for two function implementations

2016-09-11 Thread Paul Mackerras
On Sun, Aug 28, 2016 at 07:09:57PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 28 Aug 2016 19:01:02 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (6): > Use

Re: [PATCH v2] powerpc: move hmi.c to arch/powerpc/kvm/

2016-09-11 Thread Paul Mackerras
On Thu, Aug 11, 2016 at 03:07:43PM +0200, Paolo Bonzini wrote: > hmi.c functions are unused unless sibling_subcore_state is nonzero, and > that in turn happens only if KVM is in use. So move the code to > arch/powerpc/kvm/, putting it under CONFIG_KVM_BOOK3S_HV_POSSIBLE > rather than

Re: [PATCH 00/13] Real-mode acceleration of device interrupts in HV KVM

2016-09-11 Thread Paul Mackerras
On Fri, Aug 19, 2016 at 03:35:44PM +1000, Paul Mackerras wrote: > This patch set reduces the latency for presenting interrupts from PCI > pass-through devices to a Book3S HV guest. Currently, if an interrupt > arrives from a PCI pass-through device while a guest is running, it > causes an exit of

[PATCH v2 07/13] KVM: PPC: Book3S HV: Handle passthrough interrupts in guest

2016-09-11 Thread Paul Mackerras
Currently, KVM switches back to the host to handle any external interrupt (when the interrupt is received while running in the guest). This patch updates real-mode KVM to check if an interrupt is generated by a passthrough adapter that is owned by this guest. If so, the real mode KVM will directly

Re: [PATCH 6/6] KVM: PPC: e500: Rename jump labels in kvmppc_e500_tlb_init()

2016-09-11 Thread Paul Mackerras
On Sun, Aug 28, 2016 at 07:19:22PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 28 Aug 2016 18:45:26 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring

Linux 4.8: Reported regressions as of Sunday, 2016-09-11

2016-09-11 Thread Thorsten Leemhuis
Hi! Here is my third regression report for Linux 4.8. It lists 10 regressions I'm aware of. 6 of them are new; 3 mentioned in the last report sent two weeks ago got fixed; 3 got removed for other reasons (see below). As always: Are you aware of any other regressions? Then please let me know

Re: [PATCH] powerpc/ptrace: Fix cppcheck issue in gpr32_set_common/gpr32_get_common.

2016-09-11 Thread Simon Guo
On Fri, Sep 09, 2016 at 08:52:52PM +1000, Michael Ellerman wrote: > I do - Sorry Simon but your patch just adds too many #ifdefs. > > Any time you have to do something like: > > +#ifdef CONFIG_PPC_TRANSACTIONAL_MEM > } > +#endif > > It should be a sign that something

Re: UBSAN: Undefined behaviour in arch/powerpc/kernel/cputable.c

2016-09-11 Thread Meelis Roos
> Does this fix it? Yes, thank you! > diff --git a/arch/powerpc/include/asm/cpu_has_feature.h > b/arch/powerpc/include/asm/cpu_has_feature.h > index 2ef55f8968a2..b312b152461b 100644 > --- a/arch/powerpc/include/asm/cpu_has_feature.h > +++ b/arch/powerpc/include/asm/cpu_has_feature.h > @@ -15,7