[PATCH 0/3] PowerPC-OPAL: Adjustments for some function implementations

2017-10-17 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 17 Oct 2017 13:45:54 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete ten error messages for a failed memory allocation Improve 12 size determinations Fix a typo in a comment line of two file

Re: [PATCH v2 2/2] vgaarb: Factor out EFI and fallback default device selection

2017-10-17 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 01:03:46PM +1100, Daniel Axtens wrote: > Bjorn Helgaas writes: > > > The default VGA device is normally set in vga_arbiter_add_pci_device() when > > we call it for the first enabled device that can be accessed with the > > legacy VGA resources ([mem 0xa-0xb], etc.)

Re: [PATCH] powerpc/mm/radix: Drop unneeded NULL check

2017-10-17 Thread Nicholas Piggin
On Mon, 16 Oct 2017 12:41:00 +0530 "Aneesh Kumar K.V" wrote: > @@ -175,10 +175,9 @@ void radix__local_flush_tlb_page(struct vm_area_struct > *vma, unsigned long vmadd > #ifdef CONFIG_HUGETLB_PAGE > /* need the return fix for nohash.c */ > if (vma && is_vm_hugetlb_page(vma)) > -

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Mimi Zohar
Hi Julia, On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote: > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > > > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, J

Re: [PATCH v12 01/11] mm: deferred_init_memmap improvements

2017-10-17 Thread Michal Hocko
On Fri 13-10-17 13:32:04, Pavel Tatashin wrote: > deferred_init_memmap() is called when struct pages are initialized later > in boot by slave CPUs. This patch simplifies and optimizes this function, > and also fixes a couple issues (described below). > > The main change is that now we are iteratin

Re: [PATCH 3/4] char/tpm: Improve a size determination in nine functions

2017-10-17 Thread Andy Shevchenko
On Mon, 2017-10-16 at 19:33 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 16 Oct 2017 18:28:17 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator "sizeof" to make the corresponding > size > determination a bit s

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Dan Carpenter wrote: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > > > > > A minor complaint: all commits are missing "F

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Dan Carpenter
On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: > > > On Tue, 17 Oct 2017, Dan Carpenter wrote: > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > > > A minor complaint: all commits are missing "Fixes:" tag. > > > > > > > Fixes is only for bug fixes. Th

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread SF Markus Elfring
> Fixes is only for bug fixes. These don't fix any bugs. How do you distinguish these in questionable source code from other error categories or software weaknesses? Regards, Markus

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Julia Lawall
On Tue, 17 Oct 2017, Dan Carpenter wrote: > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > > > A minor complaint: all commits are missing "Fixes:" tag. > > > > Fixes is only for bug fixes. These don't fix any bugs. 0-day seems to put Fixes for everything. Should they be

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread Dan Carpenter
On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: > > A minor complaint: all commits are missing "Fixes:" tag. > Fixes is only for bug fixes. These don't fix any bugs. regards, dan carpenter

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

2017-10-17 Thread SF Markus Elfring
>> A minor complaint: all commits are missing "Fixes:" tag. > > None of these patches fix anything. It depends on the view which you prefer. > All are trivial changes without much of any impact. I find that they improve the affected software another bit. Other adjustments can be more noticeabl

<    1   2