From: Markus Elfring
Date: Tue, 17 Oct 2017 13:45:54 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete ten error messages for a failed memory allocation
Improve 12 size determinations
Fix a typo in a comment line of two file
On Tue, Oct 17, 2017 at 01:03:46PM +1100, Daniel Axtens wrote:
> Bjorn Helgaas writes:
>
> > The default VGA device is normally set in vga_arbiter_add_pci_device() when
> > we call it for the first enabled device that can be accessed with the
> > legacy VGA resources ([mem 0xa-0xb], etc.)
On Mon, 16 Oct 2017 12:41:00 +0530
"Aneesh Kumar K.V" wrote:
> @@ -175,10 +175,9 @@ void radix__local_flush_tlb_page(struct vm_area_struct
> *vma, unsigned long vmadd
> #ifdef CONFIG_HUGETLB_PAGE
> /* need the return fix for nohash.c */
> if (vma && is_vm_hugetlb_page(vma))
> -
Hi Julia,
On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote:
>
> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>
> > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 17 Oct 2017, Dan Carpenter wrote:
> > >
> > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, J
On Fri 13-10-17 13:32:04, Pavel Tatashin wrote:
> deferred_init_memmap() is called when struct pages are initialized later
> in boot by slave CPUs. This patch simplifies and optimizes this function,
> and also fixes a couple issues (described below).
>
> The main change is that now we are iteratin
On Mon, 2017-10-16 at 19:33 +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 16 Oct 2017 18:28:17 +0200
>
> Replace the specification of data structures by pointer dereferences
> as the parameter for the operator "sizeof" to make the corresponding
> size
> determination a bit s
On Tue, 17 Oct 2017, Dan Carpenter wrote:
> On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 17 Oct 2017, Dan Carpenter wrote:
> >
> > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> > > >
> > > > A minor complaint: all commits are missing "F
On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
>
>
> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>
> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> > >
> > > A minor complaint: all commits are missing "Fixes:" tag.
> > >
> >
> > Fixes is only for bug fixes. Th
> Fixes is only for bug fixes. These don't fix any bugs.
How do you distinguish these in questionable source code
from other error categories or software weaknesses?
Regards,
Markus
On Tue, 17 Oct 2017, Dan Carpenter wrote:
> On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> >
> > A minor complaint: all commits are missing "Fixes:" tag.
> >
>
> Fixes is only for bug fixes. These don't fix any bugs.
0-day seems to put Fixes for everything. Should they be
On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
>
> A minor complaint: all commits are missing "Fixes:" tag.
>
Fixes is only for bug fixes. These don't fix any bugs.
regards,
dan carpenter
>> A minor complaint: all commits are missing "Fixes:" tag.
>
> None of these patches fix anything.
It depends on the view which you prefer.
> All are trivial changes without much of any impact.
I find that they improve the affected software another bit.
Other adjustments can be more noticeabl
101 - 112 of 112 matches
Mail list logo