Re: [v3 PATCH 3/3] powernv-cpufreq: Treat pstates as opaque 8-bit values

On Wed, Dec 13, 2017 at 5:57 PM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > On POWER8 and POWER9, the PMSR and the PMCR registers define pstates > to be 8-bit wide values. The device-tree exports pstates as 32-bit > wide values of

Re: [v3 PATCH 2/3] powernv-cpufreq: Fix pstate_to_idx() to handle non-continguous pstates

On Wed, Dec 13, 2017 at 5:57 PM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > The code in powernv-cpufreq, makes the following two assumptions which > are not guaranteed by the device-tree bindings: > > 1) Pstate ids are

Re: [v3 PATCH 1/3] powernv-cpufreq: Add helper to extract pstate from PMSR

On Wed, Dec 13, 2017 at 5:57 PM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > On POWERNV platform, the fields for pstates in the Power Management > Status Register (PMSR) and the Power Management Control Register > (PMCR) are 8-bits

Re: [PATCH V2] cxl: Add support for ASB_Notify on POWER9

Hi Christophe, Thank you for the patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v4.15-rc3 next-20171215] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 00/11] ASoC: fsl_ssi: Clean up - coding style level

Hello Mark, Can you please take the first two patches since Timur acked? For the rest ones, we probably still need some discussion. Thanks Nicolin On Dec 15, 2017 20:53, "Timur Tabi" wrote: On 12/13/17 5:18 PM, Nicolin Chen wrote: > Additionally, in order to fix/work-around

Re: powerpc64 kernel panic if you disable CONFIG_PPC_TRANSACTIONAL_MEM?

On Sun, Dec 17, 2017 at 8:34 AM, Rob Landley wrote: > I just added a ppc64 target to https://github.com/landley/mkroot which > means I built 4.14 with the attached miniconfig and ran it with the > attached qemu command line, and it works fine as is but if you remove > the

powerpc64 kernel panic if you disable CONFIG_PPC_TRANSACTIONAL_MEM?

I just added a ppc64 target to https://github.com/landley/mkroot which means I built 4.14 with the attached miniconfig and ran it with the attached qemu command line, and it works fine as is but if you remove the transactional mem line from the config the kernel panics instead of launching a shell

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 12:31:34PM -0600, Timur Tabi wrote: > On 12/16/17 11:49 AM, Nicolin Chen wrote: > >I never said that I don't agree with Timur. Every change here is > >to simplify things. As long as Timur or any reviewer feels one of > >new comments is harder to understand, I am totally

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

First of all, thanks a lot for the review. And I will send a v4 after I refine these comments. But please please don't think in the way like "you can touch it unless it's untrue." I never said anything or anyone is wrong here. As the other patches that shortens variable names, this patch just

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 11:49 AM, Nicolin Chen wrote: I never said that I don't agree with Timur. Every change here is to simplify things. As long as Timur or any reviewer feels one of new comments is harder to understand, I am totally fine to rework. I respect everyone's opinion, but I hope everyone can

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 09:30:14AM -0800, Caleb Crome wrote: > Having come to work on this driver with very little knowledge about > kernel programming, and i.MX, I have to agree with Timur. It's an > amazingly complex driver (with support of so many variants). By > eliminating verbose

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 11:30 AM, Caleb Crome wrote: Having come to work on this driver with very little knowledge about kernel programming, and i.MX, I have to agree with Timur. It's an amazingly complex driver (with support of so many variants). By eliminating verbose commentary, it's also wiping away a

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

Hi, On Sat, Dec 16, 2017 at 10:27:06AM -0600, Timur Tabi wrote: > On 12/16/17 12:10 AM, Nicolin Chen wrote: > >Hi, > > > >I am outside so can't use mutt. Sorry for that. > > > >This comment is going to be replaced in the 2nd set anyway because the > >whole function will be replaced. > > So

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On Sat, Dec 16, 2017 at 9:15 AM, Timur Tabi wrote: > > On 12/13/17 5:18 PM, Nicolin Chen wrote: > >> - /* Used when using fsl-ssi as sound-card. This is only used by ppc >> and >> -* should be replaced with simple-sound-card. */ >> struct platform_device

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/13/17 5:18 PM, Nicolin Chen wrote: - /* Used when using fsl-ssi as sound-card. This is only used by ppc and -* should be replaced with simple-sound-card. */ struct platform_device *pdev; Is this comment no longer true? + * 1) SSI in earlier SoCS has crtical bits

Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments

On 12/16/17 12:10 AM, Nicolin Chen wrote: Hi, I am outside so can't use mutt. Sorry for that. This comment is going to be replaced in the 2nd set anyway because the whole function will be replaced. So you're asking me to review comment changes that will soon be deleted? Can you send out a

[PATCH 1/2] ps3: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Sat, 16 Dec 2017 12:32:42 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] PS3: Adjustments for six function implementations

From: Markus Elfring Date: Sat, 16 Dec 2017 14:42:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Improve a size determination

[PATCH 2/2] ps3: Improve a size determination in five functions

From: Markus Elfring Date: Sat, 16 Dec 2017 14:21:04 +0100 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 38/45] arch/powerpc: remove duplicate includes

These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge --- arch/powerpc/kernel/time.c | 2 -- arch/powerpc/lib/code-patching.c