Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-18 Thread Christophe LEROY
Le 18/02/2018 à 18:14, Horia Geantă a écrit : On 2/17/2018 6:32 PM, Christophe LEROY wrote: Le 07/02/2018 à 15:39, Horia Geantă a écrit : On 10/6/2017 4:06 PM, Christophe Leroy wrote: At every request, we map and unmap the same hash hw_context. This patch moves the dma mapping/unmapping

[PATCH] scsi: cxlflash: Select SCSI_SCAN_ASYNC

2018-02-18 Thread Vaibhav Jain
The cxlflash driver uses "Asynchronous SCSI scanning" enabled by CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash module gets hung with following backtrace: Call Trace: __switch_to+0x2cc/0x470 __schedule+0x288/0xab0 schedule+0x40/0xc0 schedule_timeout+0x254/0x4f0

Re: [PATCH V3] cxl: Fix timebase synchronization status on P9

2018-02-18 Thread Vaibhav Jain
Hi Christophe, Mostly ok with this patch. Some very minor review comments: Christophe Lombard writes: > --- a/drivers/misc/cxl/sysfs.c > +++ b/drivers/misc/cxl/sysfs.c > @@ -62,6 +62,16 @@ static ssize_t psl_timebase_synced_show(struct device > *device, >

Re: [PATCH] powerpc/npu-dma.c: Fix deadlock in mmio_invalidate

2018-02-18 Thread Alistair Popple
> > Shouldn't that be enforced with READ_ONCE() then? Yep, I can add that. > Good point, although I think the acquire_* function itself may be called > from a higher layer with the mmap_sem always held. I wonder if we need > barriers around get and put mmio_atsd_reg. test_and_set_bit() should

Re: [PATCH 1/3] tools include powerpc: Grab a copy of arch/powerpc/include/uapi/asm/unistd.h

2018-02-18 Thread Michael Ellerman
Arnaldo Carvalho de Melo writes: > Em Fri, Feb 16, 2018 at 02:29:01PM -0300, Arnaldo Carvalho de Melo escreveu: >> Humm, we need to create two tables, one for 32-bit and another for 64, >> even with ppc not having (AFAIK) clashes in syscall numbers for 32/64... >> >> Trying to

Re: [PATCH] powerpc/npu-dma.c: Fix deadlock in mmio_invalidate

2018-02-18 Thread Balbir Singh
On Thu, 15 Feb 2018 19:11:19 -0800 Mark Hairgrove wrote: > On Wed, 14 Feb 2018, Alistair Popple wrote: > > > > > +struct mmio_atsd_reg { > > > > + struct npu *npu; > > > > + int reg; > > > > +}; > > > > + > > > > > > Is it just easier to move reg to inside

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-18 Thread Sam Ravnborg
Hi Masahiro. On Sat, Feb 17, 2018 at 03:38:28AM +0900, Masahiro Yamada wrote: > I brushed up the implementation in this version. > > In the previous RFC, CC_HAS_ was described by using 'option shell=', > like this: > > config CC_HAS_STACKPROTECTOR > bool > option shell="$CC

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-18 Thread Horia Geantă
On 2/17/2018 6:32 PM, Christophe LEROY wrote: > > > Le 07/02/2018 à 15:39, Horia Geantă a écrit : >> On 10/6/2017 4:06 PM, Christophe Leroy wrote: >>> At every request, we map and unmap the same hash hw_context. >>> >>> This patch moves the dma mapping/unmapping in functions ahash_init() >>> and

Re: [PATCH] fix double ;;s in code

2018-02-18 Thread Christophe LEROY
Le 17/02/2018 à 22:19, Pavel Machek a écrit : Fix double ;;'s in code. Signed-off-by: Pavel Machek A summary of the files modified on top of the patch would help understand the impact. A maybe there should be one patch by area, eg one for each arch specific modif and one

Re: pseries/drmem: Check for zero filled ibm, dynamic-memory property.

2018-02-18 Thread Michael Ellerman
On Fri, 2018-02-16 at 03:27:41 UTC, Nathan Fontenot wrote: > Some versions of QEMU will produce an ibm,dynamic-reconfiguration-memory > node with a ibm,dynamic-memory property that is zero-filled. This causes > the drmem code to oops trying to parse this property. > > The fix for this is to

Re: powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA

2018-02-18 Thread Michael Ellerman
On Wed, 2018-02-14 at 12:17:47 UTC, Corentin Labbe wrote: > When CONFIG_NUMA is not set, build fail with: > arch/powerpc/platforms/pseries/hotplug-cpu.c:335:4: error: déclaration > implicite de la fonction « update_numa_cpu_lookup_table » > [-Werror=implicit-function-declaration] > > So we

Re: powerpc: Expose TSCR via sysfs only on powernv

2018-02-18 Thread Michael Ellerman
On Wed, 2018-02-14 at 03:27:06 UTC, Cyril Bur wrote: > The TSCR can only be accessed in hypervisor mode. > > Fixes: 88b5e12eeb11 ("powerpc: Expose TSCR via sysfs") > Signed-off-by: Cyril Bur Applied to powerpc fixes, thanks.

Re: powerpc/xive: use hw CPU ids when configuring the CPU queues

2018-02-18 Thread Michael Ellerman
On Tue, 2018-02-13 at 08:47:12 UTC, =?utf-8?q?C=C3=A9dric_Le_Goater?= wrote: > The CPU event notification queues on sPAPR should be configured using > a hardware CPU identifier. > > The problem did not show up on the Power Hypervisor because pHyp > supports 8 threads per core which keeps CPU

Re: powerpc/powernv: IMC fix out of bounds memory access at shutdown

2018-02-18 Thread Michael Ellerman
On Tue, 2018-02-13 at 07:45:11 UTC, Nicholas Piggin wrote: > The OPAL IMC driver's shutdown handler disables nest PMU counters by > walking nodes and taking the first CPU out of their cpumask, which is > used to index into the paca (get_hard_smp_processor_id()). This does > not always do the right