Re: [PATCH] cpuidle:powernv: Make the snooze timeout dynamic.

2018-05-31 Thread Gautham R Shenoy
Hi Balbir, Thanks for reviewing the patch! On Fri, Jun 01, 2018 at 12:51:05AM +1000, Balbir Singh wrote: > On Thu, May 31, 2018 at 10:15 PM, Gautham R. Shenoy [..snip..] > > > > +static u64 get_snooze_timeout(struct cpuidle_device *dev, > > + struct cpuidle_driver

Re: [PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-05-31 Thread Stewart Smith
Haren Myneni writes: > NX increments readOffset by FIFO size in receive FIFO control register > when CRB is read. But the index in RxFIFO has to match with the > corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX > may be processing incorrect CRBs and can cause CRB timeout. > >

Re: [PATCH] powerpc/64s: Fix compiler store ordering to SLB shadow area

2018-05-31 Thread Nicholas Piggin
On Fri, 01 Jun 2018 00:22:21 +1000 Michael Ellerman wrote: > Nicholas Piggin writes: > > > The stores to update the SLB shadow area must be made as they appear > > in the C code, so that the hypervisor does not see an entry with > > mismatched vsid and esid. Use WRITE_ONCE for this. > > > >

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-31 Thread Scott Wood
On Thu, 2018-05-31 at 14:35 +, Diana Madalina Craciun wrote: > On 5/31/2018 5:21 PM, Michael Ellerman wrote: > > > > We can add a nospectre_v1 command line option if necessary. > > What about nobarrier_nospec (or similar) instead of nospectre_v1 command > line? We are not disabling all the

Re: [PATCH 2/2] powerpc: Add support for function error injection

2018-05-31 Thread Naveen N. Rao
Michael Ellerman wrote: "Naveen N. Rao" writes: Michael Ellerman wrote: "Naveen N. Rao" writes: ... A change log is always nice even if it's short :) I tried, but really couldn't come up with anything more to write. I'll try harder for v2 :) Yeah true. You could just say "All

[PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-05-31 Thread Haren Myneni
NX increments readOffset by FIFO size in receive FIFO control register when CRB is read. But the index in RxFIFO has to match with the corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX may be processing incorrect CRBs and can cause CRB timeout. VAS FIFO offset is 0 when the

Re: [RFC V2] virtio: Add platform specific DMA API translation for virito devices

2018-05-31 Thread Michael S. Tsirkin
On Thu, May 31, 2018 at 09:09:24AM +0530, Anshuman Khandual wrote: > On 05/24/2018 12:51 PM, Ram Pai wrote: > > On Wed, May 23, 2018 at 09:50:02PM +0300, Michael S. Tsirkin wrote: > >> subj: s/virito/virtio/ > >> > > ..snip.. > >>> machine_subsys_initcall_sync(pseries,

Re: [PATCH] cpuidle:powernv: Make the snooze timeout dynamic.

2018-05-31 Thread Balbir Singh
On Thu, May 31, 2018 at 10:15 PM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > The commit 78eaa10f027c ("cpuidle: powernv/pseries: Auto-promotion of > snooze to deeper idle state") introduced a timeout for the snooze idle > state so that it could be eventually be promoted to a deeper

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-31 Thread Diana Madalina Craciun
On 5/31/2018 5:21 PM, Michael Ellerman wrote: > Scott Wood writes: >> On Tue, 2018-05-29 at 15:22 +, Diana Madalina Craciun wrote: >>> On 05/22/2018 11:31 PM, Scott Wood wrote: Should there be a way for the user to choose not to enable this (editing the device tree doesn't

Re: [PATCH] powerpc/64s: Fix compiler store ordering to SLB shadow area

2018-05-31 Thread Michael Ellerman
Nicholas Piggin writes: > The stores to update the SLB shadow area must be made as they appear > in the C code, so that the hypervisor does not see an entry with > mismatched vsid and esid. Use WRITE_ONCE for this. > > GCC has been observed to elide the first store to esid in the update, > which

Re: [RFC PATCH] powerpc/fsl: Add barrier_nospec implementation for NXP PowerPC Book E

2018-05-31 Thread Michael Ellerman
Scott Wood writes: > On Tue, 2018-05-29 at 15:22 +, Diana Madalina Craciun wrote: >> On 05/22/2018 11:31 PM, Scott Wood wrote: > >> > Should there be a way for the user to choose not to enable this (editing >> > the >> > device tree doesn't count), for a use case that is not sufficiently >> >

Re: [PATCH 2/2] powerpc: Add support for function error injection

2018-05-31 Thread Michael Ellerman
"Naveen N. Rao" writes: > Michael Ellerman wrote: >> "Naveen N. Rao" writes: >>> ... >> >> A change log is always nice even if it's short :) > > I tried, but really couldn't come up with anything more to write. I'll > try harder for v2 :) Yeah true. You could just say "All that's required

Re: Build Failure on linux-next on Power8 machine

2018-05-31 Thread Michael Ellerman
Venkat Rao B writes: > On Thursday 31 May 2018 04:44 PM, Christophe LEROY wrote: >> Le 31/05/2018 à 12:38, vrbagal1 a écrit : >>> Greetings!!! >>> >>> I am observing a build failure on linux-next kernel. >>> >>> Machine: Power8 >>> Platform: PowerNV(Baremetal) >>> Git Tree: >>>

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-31 Thread Masahiro Yamada
2018-05-31 20:51 GMT+09:00 Michael Ellerman : > Masahiro Yamada writes: >> 2018-05-31 13:31 GMT+09:00 Michael Ellerman : >>> Masahiro Yamada writes: 2018-05-30 23:39 GMT+09:00 Michael Ellerman : > Nicholas Piggin writes: > >> This series of patches improves th powerpc kbuild

[PATCH] cpuidle:powernv: Make the snooze timeout dynamic.

2018-05-31 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" The commit 78eaa10f027c ("cpuidle: powernv/pseries: Auto-promotion of snooze to deeper idle state") introduced a timeout for the snooze idle state so that it could be eventually be promoted to a deeper idle state. The snooze timeout value is static and set to the target

Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

2018-05-31 Thread Michael Ellerman
Masahiro Yamada writes: > 2018-05-31 13:31 GMT+09:00 Michael Ellerman : >> Masahiro Yamada writes: >>> 2018-05-30 23:39 GMT+09:00 Michael Ellerman : Nicholas Piggin writes: > This series of patches improves th powerpc kbuild system. The > motivation was to to be compatible

[PATCH v2 20/21] powerpc/xmon: use match_string() helper

2018-05-31 Thread Yisheng Xie
match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Yisheng Xie --- arch/powerpc/xmon/xmon.c | 23

Re: Build Failure on linux-next on Power8 machine

2018-05-31 Thread Venkat Rao B
On Thursday 31 May 2018 04:44 PM, Christophe LEROY wrote: Le 31/05/2018 à 12:38, vrbagal1 a écrit : Greetings!!! I am observing a build failure on linux-next kernel. Machine: Power8 Platform: PowerNV(Baremetal) Git Tree:

Re: [PATCH v2] powerpc/64: Fix build failure with GCC 8.1

2018-05-31 Thread Michael Ellerman
Christophe LEROY writes: > Le 31/05/2018 à 07:54, Michael Ellerman a écrit : >> Christophe LEROY writes: >>> Le 29/05/2018 à 11:05, Geert Uytterhoeven a écrit : Hi Christophe, On Tue, May 29, 2018 at 10:56 AM, Christophe LEROY wrote: > Le 29/05/2018 à 09:47, Geert

Re: Build Failure on linux-next on Power8 machine

2018-05-31 Thread Christophe LEROY
Le 31/05/2018 à 12:38, vrbagal1 a écrit : Greetings!!! I am observing a build failure on linux-next kernel. Machine: Power8 Platform: PowerNV(Baremetal) Git Tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Which defconfig do you use, or can you give your .config

Build Failure on linux-next on Power8 machine

2018-05-31 Thread vrbagal1
Greetings!!! I am observing a build failure on linux-next kernel. Machine: Power8 Platform: PowerNV(Baremetal) Git Tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Below is the build error. 14:20:48 make[1]: *** [kernel/umh.o] Error 1 14:20:48 make[1]: ***

Re: [PATCH 2/2] powerpc: Add support for function error injection

2018-05-31 Thread Naveen N. Rao
Michael Ellerman wrote: "Naveen N. Rao" writes: ... A change log is always nice even if it's short :) I tried, but really couldn't come up with anything more to write. I'll try harder for v2 :) Signed-off-by: Naveen N. Rao --- arch/powerpc/Kconfig | 1 +

Re: [PATCH 1/2] error-injection: Simplify arch specific helpers

2018-05-31 Thread Naveen N. Rao
Masami Hiramatsu wrote: On Tue, 29 May 2018 18:06:02 +0530 "Naveen N. Rao" wrote: We already have an arch-independent way to set the instruction pointer with instruction_pointer_set(). Using this allows us to get rid of the need for override_function_with_return() that each architecture has

Re: [RFC PATCH 0/8] Remove unneccessary included headers

2018-05-31 Thread Michael Ellerman
Christophe Leroy writes: > The purpose of this serie is to limit the number of includes to > only the necessary ones in order to reduce the number of files > recompiled everytime a header file is modified. > > This is the start of the work, please provide feedback if any so > that I don't go in

powerpc/powernv: copy/paste - Mask XERS0 bit in CR

2018-05-31 Thread Haren Myneni
NX can set 3rd bit in CR register for XER[SO] (Summation overflow) which is not related to paste request. The current paste function returns failure for the successful request when this bit is set. So mask this bit and check the proper return status. Fixes: 2392c8c8c045

[PATCH 4.14 4/4] powerpc/mm/slice: Fix hugepage allocation at hint address on 8xx

2018-05-31 Thread Christophe Leroy
[ Upstream commit aa0ab02ba992eb956934b21373e0138211486ddd ] On the 8xx, the page size is set in the PMD entry and applies to all pages of the page table pointed by the said PMD entry. When an app has some regular pages allocated (e.g. see below) and tries to mmap() a huge page at a hint address

[PATCH 4.14 3/4] powerpc/mm/slice: Enhance for supporting PPC32

2018-05-31 Thread Christophe Leroy
[ Upstream commit db3a528db41caaa6dfd4c64e9f5efb1c81a80467 ] In preparation for the following patch which will fix an issue on the 8xx by re-using the 'slices', this patch enhances the 'slices' implementation to support 32 bits CPUs. On PPC32, the address space is limited to 4Gbytes, hence only

[PATCH 4.14 2/4] powerpc/mm/slice: create header files dedicated to slices

2018-05-31 Thread Christophe Leroy
[ Upstream commit a3286f05bc5a5bc7fc73a9783ec89de78fcd07f8 ] In preparation for the following patch which will enhance 'slices' for supporting PPC32 in order to fix an issue on hugepages on 8xx, this patch takes out of page*.h all bits related to 'slices' and put them into newly created slice.h

[PATCH 4.14 1/4] powerpc/mm/slice: Remove intermediate bitmap copy

2018-05-31 Thread Christophe Leroy
[ Upstream commit 326691ad4f179e6edc7eb1271e618dd673e4736d ] bitmap_or() and bitmap_andnot() can work properly with dst identical to src1 or src2. There is no need of an intermediate result bitmap that is copied back to dst in a second step. Signed-off-by: Christophe Leroy Reviewed-by: Aneesh