[PATCH 6/6] selftests: powerpc/pmu: Link ebb tests with -no-pie

2018-10-22 Thread Joel Stanley
When running the ebb tests after building on a ppc64le Ubuntu machine: $ pmu/ebb/reg_access_test: error while loading shared libraries: R_PPC64_ADDR16_HI reloc at 0x00013a965130 for symbol `' out of range This is because the Ubuntu toolchain builds has PIE enabled by default. Change it to

[PATCH 5/6] selftests: powerpc/signal: Fix signal_tm CFLAGS

2018-10-22 Thread Joel Stanley
signal_tm tries to build with -mhtm but it currently does not. The targets is modified in lib.mk to add the $(OUTPUT) prefix. The makefile needs to specify that modifying the rules, or else it does not match and we miss out on the extra flag. Signed-off-by: Joel Stanley --- tools/testing/selfte

[PATCH 4/6] selftests: powerpc/signal: Make tests build

2018-10-22 Thread Joel Stanley
According to lib.mk, TEST_PROGS is for shell scripts. It appears we need to define the programs as TEST_GEN_PROGS to ensure they are built. The definition must also happen below the inclusion of lib.mk. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/signal/Makefile | 7 ++-

[PATCH 3/6] selftests: powerpc/ptrace: Fix linking against pthread

2018-10-22 Thread Joel Stanley
Some of the ptrace tests require -ptrace when linking: /usr/bin/ld: /tmp/ccH32S9w.o: in function `init_child_sync': core-pkey.c:(.text+0x1d64): undefined reference to `sem_init' The targets for these tests are modfied in lib.mk to add the $(OUTPUT) prefix. The makefile needs to specify that mod

[PATCH 2/6] selftests: powerpc/ptrace: Remove clean rule

2018-10-22 Thread Joel Stanley
When running 'make ptrace': make[1]: Entering directory 'tools/testing/selftests/powerpc/ptrace' Makefile:18: warning: overriding recipe for target 'clean' ../../lib.mk:137: warning: ignoring old recipe for target 'clean' The rule is unnecessary as TEST_GEN_FILES are cleaned up by the rule in

[PATCH 1/6] selftests: powerpc/ptrace: Make tests build

2018-10-22 Thread Joel Stanley
According to lib.mk, TEST_PROGS is for shell scripts. It appears we need to define the programs as TEST_GEN_PROGS to ensure they are built. Signed-off-by: Joel Stanley --- tools/testing/selftests/powerpc/ptrace/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/to

[PATCH 0/6] selftests: powerpc build fixes

2018-10-22 Thread Joel Stanley
This series fixes issues I encountered building and running the selftests on a Ubuntu Cosmic ppc64le system. Joel Stanley (6): selftests: powerpc/ptrace: Make tests build selftests: powerpc/ptrace: Remove clean rule selftests: powerpc/ptrace: Fix linking against pthread selftests: powerpc/

Re: [PATCH] net/wan/fsl_ucc_hdlc: error counters

2018-10-22 Thread David Miller
From: Mathias Thore Date: Mon, 22 Oct 2018 14:55:50 +0200 > Extract error information from rx and tx buffer descriptors, > and update error counters. > > Signed-off-by: Mathias Thore Applied.

[PATCH] powerpc/pseries: add missing cpumask.h include file

2018-10-22 Thread Tyrel Datwyler
Build error is encountered when inlcuding if no explicit or implicit include of cpumask.h exists in the including file. In file included from arch/powerpc/platforms/pseries/hotplug-pci.c:3:0: ./arch/powerpc/include/asm/rtas.h:360:34: error: unknown type name 'cpumask_var_t' extern int rtas_onli

Pull request: scottwood/linux.git next

2018-10-22 Thread Scott Wood
This contains a couple device tree updates, and a fix for a missing prototype warning. The following changes since commit a0e102914aa3f619a5bc68a0d33e17d1788cdf4c: powerpc/io: remove old GCC version implementation (2018-10-19 00:56:17 +1100) are available in the Git repository at: git://git

Re: [PATCH v5 00/18] of: overlay: validation checks, subsequent fixes

2018-10-22 Thread Alan Tull
On Thu, Oct 18, 2018 at 5:48 PM wrote: > > From: Frank Rowand > > Add checks to (1) overlay apply process and (2) memory freeing > triggered by overlay release. The checks are intended to detect > possible memory leaks and invalid overlays. I've tested v5, nothing new to report. Alan > > The

[PATCH] selftests/powerpc: Fix ptrace tm failure

2018-10-22 Thread Breno Leitao
Test ptrace-tm-spd-gpr fails on current kernel (4.19) due to a segmentation fault that happens on the child process prior to setting cptr[2] = 1. This causes the parent process to wait forever at 'while (!pptr[2])' and the test to be killed by the test harness framework by timeout, thus, failing.

Re: [v9 2/7] dmaengine: fsldma: Adding macro FSL_DMA_IN/OUT implement for ARM platform

2018-10-22 Thread kbuild test robot
Hi Peng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux-sof-driver/master] [also build test WARNING on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0d

[PATCH 4/9] powerpc/xive: Define xive_do_source_eoi as static

2018-10-22 Thread Breno Leitao
Sparse shows that xive_do_source_eoi() file is defined without any declaration, thus, it should be a static function. arch/powerpc/sysdev/xive/common.c:312:6: warning: symbol 'xive_do_source_eoi' was not declared. Should it be static? This patch simply turns this symbol into static. Sig

[PATCH 2/9] powerpc/eeh: Declare pci_ers_result_name() as static

2018-10-22 Thread Breno Leitao
Function pci_ers_result_name() is a static function, although not declared as such. This was detected by sparse in the following warning arch/powerpc/kernel/eeh_driver.c:63:12: warning: symbol 'pci_ers_result_name' was not declared. Should it be static? This patch simply declares the fun

[PATCH 9/9] powerpc/pkey: Define functions as static

2018-10-22 Thread Breno Leitao
Sparse tool is showing some warnings on pkeys.c file, mainly related to storage class identifiers. There are static variables and functions not declared as such. The same thing happens with an extern function, which misses the header inclusion. arch/powerpc/mm/pkeys.c:14:6: warning: symbol

[PATCH 8/9] powerpc/perf: Declare static identifier a such

2018-10-22 Thread Breno Leitao
There are three symbols (two variables and a function) that are being used solely in the same file (imc-pmu.c), thus, these symbols should be static, but they are not. This was detected by sparse: arch/powerpc/perf/imc-pmu.c:31:20: warning: symbol 'nest_imc_refc' was not declared. Should

[PATCH 6/9] powerpc/lib: Declare static methods

2018-10-22 Thread Breno Leitao
Functions do_stf_{entry,exit}_barrier_fixups are static but not declared as such. This was detected by `sparse` tool with the following warning: arch/powerpc/lib/feature-fixups.c:121:6: warning: symbol 'do_stf_entry_barrier_fixups' was not declared. Should it be static? arch/powe

[PATCH 7/9] powerpc/scom: Return NULL instead of 0

2018-10-22 Thread Breno Leitao
Function scom_map_device() returns data type 'scom_map_t', which is a typedef for 'void *'. This functions is currently returning NULL and zero, which causes the following warning by 'sparse': arch/powerpc/sysdev/scom.c:63:24: warning: Using plain integer as NULL pointer arch/powe

[PATCH 5/9] powerpc/xmon: Define static functions

2018-10-22 Thread Breno Leitao
Currently sparse is complaining about three issues on the xmon code. Two storage classes issues and a dereferencing a 'noderef' pointer. These are the warnings: arch/powerpc/xmon/xmon.c:2783:1: warning: symbol 'dump_log_buf' was not declared. Should it be static? arch/powerpc/xmo

[PATCH 1/9] powerpc/64s: Include cpu header

2018-10-22 Thread Breno Leitao
Current powerpc security.c file is defining functions, as cpu_show_meltdown(), cpu_show_spectre_v{1,2} and others, that are being declared at linux/cpu.h header without including the header file that contains these declarations. This is being reported by sparse, which thinks that these functions a

[PATCH 3/9] powerpc/mm: Remove extern from function definition

2018-10-22 Thread Breno Leitao
Function huge_ptep_set_access_flags() has the 'extern' keyword in the function definition and also in the function declaration. This causes a warning in 'sparse' since the 'extern' storage class should be used only on symbol declarations. arch/powerpc/mm/pgtable.c:232:12: warning: function

Re: [PATCH] powerpc: Fix stack protector crashes on CPU hotplug

2018-10-22 Thread Abdul Haleem
On Fri, 2018-10-19 at 16:59 +1100, Michael Ellerman wrote: > Recently in commit 7241d26e8175 ("powerpc/64: properly initialise > the stackprotector canary on SMP.") we fixed a crash with stack > protector on SMP by initialising the stack canary in > cpu_idle_thread_init(). > > But this can also ca

[PATCH] selftests: powerpc: Fix warning for security subdir

2018-10-22 Thread Joel Stanley
typing 'make' inside tools/testing/selftests/powerpc gave a build warning: BUILD_TARGET=tools/testing/selftests/powerpc/security; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C security all make[1]: Entering directory 'tools/testing/selftests/powerpc/security' ../../lib.mk:20: ../../../.

Re: [PATCH] powerpc/pseries: Export maximum memory value

2018-10-22 Thread Aravinda Prasad
On Wednesday 10 October 2018 09:50 PM, Nathan Fontenot wrote: > On 10/10/2018 05:22 AM, Aravinda Prasad wrote: >> This patch exports the maximum possible amount of memory >> configured on the system via /proc/powerpc/lparcfg. >> >> Signed-off-by: Aravinda Prasad >> --- >> arch/powerpc/platform

Re: powerpc/msi: Fix compile error on mpc83xx

2018-10-22 Thread Michael Ellerman
On Fri, 2018-10-19 at 06:12:50 UTC, Christophe Leroy wrote: > mpic_get_primary_version() is not defined when not using MPIC. > The compile error log like: > > arch/powerpc/sysdev/built-in.o: In function `fsl_of_msi_probe': > fsl_msi.c:(.text+0x150c): undefined reference to > `fsl_mpic_primary_get

Re: powerpc: Fix stack protector crashes on CPU hotplug

2018-10-22 Thread Michael Ellerman
On Fri, 2018-10-19 at 05:59:27 UTC, Michael Ellerman wrote: > Recently in commit 7241d26e8175 ("powerpc/64: properly initialise > the stackprotector canary on SMP.") we fixed a crash with stack > protector on SMP by initialising the stack canary in > cpu_idle_thread_init(). > > But this can also c

Re: powerpc/time: Fix clockevent_decrementer initalisation for PR KVM

2018-10-22 Thread Michael Ellerman
On Fri, 2018-10-19 at 04:23:19 UTC, Michael Ellerman wrote: > In the recent commit 8b78fdb045de ("powerpc/time: Use > clockevents_register_device(), fixing an issue with large > decrementer") we changed the way we initialise the decrementer > clockevent(s). > > We no longer initialise the mult & s

Re: [1/6] powerpc/mm/radix: Fix off-by-one in split mapping logic

2018-10-22 Thread Michael Ellerman
On Fri, 2018-10-19 at 04:13:29 UTC, Michael Ellerman wrote: > When we have CONFIG_STRICT_KERNEL_RWX enabled, we try to split the > kernel linear (1:1) mapping so that the kernel text is in a separate > page to kernel data, so we can mark the former read-only. > > We could achieve that just by alwa

Re: powerpc/mm: Fix page table dump to work on Radix

2018-10-22 Thread Michael Ellerman
On Fri, 2018-10-19 at 04:12:50 UTC, Michael Ellerman wrote: > When we're running on Book3S with the Radix MMU enabled the page table > dump currently prints the wrong addresses because it uses the wrong > start address. > > Fix it to use PAGE_OFFSET rather than KERN_VIRT_START. > > Signed-off-by:

Re: selftests/powerpc: Fix out-of-tree build errors

2018-10-22 Thread Michael Ellerman
On Fri, 2018-10-19 at 04:06:16 UTC, Michael Ellerman wrote: > Some of our Makefiles don't do the right thing when building the > selftests with O=, fix them up. > > Signed-off-by: Michael Ellerman Applied to powerpc next. https://git.kernel.org/powerpc/c/d8a2fe29d3c97038c8efcc328d5e79 cheers

Re: powerpc/ftrace: Handle large kernel configs

2018-10-22 Thread Michael Ellerman
On Tue, 2018-10-16 at 20:25:00 UTC, "Naveen N. Rao" wrote: > Currently, we expect to be able to reach ftrace_caller() from all > ftrace-enabled functions through a single relative branch. With large > kernel configs, we see functions outside of 32MB of ftrace_caller() > causing ftrace_init() to bai

Re: [v3] powerpc/pseries: Export raw per-CPU VPA data via debugfs

2018-10-22 Thread Michael Ellerman
On Tue, 2018-10-16 at 11:50:05 UTC, Aravinda Prasad wrote: > This patch exports the raw per-CPU VPA data via debugfs. > A per-CPU file is created which exports the VPA data of > that CPU to help debug some of the VPA related issues or > to analyze the per-CPU VPA related statistics. > > v3: Remove

Re: [1/2] powerpc/uapi: Fix sigcontext definition to use user_pt_regs

2018-10-22 Thread Michael Ellerman
On Mon, 2018-10-15 at 12:01:42 UTC, Michael Ellerman wrote: > My recent patch to split pt_regs between user and kernel missed > the usage in struct sigcontext. > > Because this is a user visible struct it should be using the user > visible definition, which when we're building for the kernel is ca

Re: powerpc/book3s64: fix dump_linuxpagetables "present" flag

2018-10-22 Thread Michael Ellerman
On Mon, 2018-10-15 at 06:37:41 UTC, Christophe Leroy wrote: > Since commit bd0dbb73e013 ("powerpc/mm/books3s: Add new pte bit to > mark pte temporarily invalid."), _PAGE_PRESENT doesn't mean exactly > that a page is present. A page is also considered preset when > _PAGE_INVALID is set. > > This pa

Re: powerpc/mm: Fix WARN_ON with THP NUMA migration

2018-10-22 Thread Michael Ellerman
On Sat, 2018-10-13 at 16:48:15 UTC, "Aneesh Kumar K.V" wrote: > WARNING: CPU: 12 PID: 4322 at /arch/powerpc/mm/pgtable-book3s64.c:76 > set_pmd_at+0x4c/0x2b0 > Modules linked in: > CPU: 12 PID: 4322 Comm: qemu-system-ppc Tainted: GW > 4.19.0-rc3-00758-g8f0c636b0542 #36 > NIP: c

Re: powerpc/traps: restore recoverability of machine_check interrupts

2018-10-22 Thread Michael Ellerman
On Sat, 2018-10-13 at 09:16:22 UTC, Christophe Leroy wrote: > commit b96672dd840f ("powerpc: Machine check interrupt is a non- > maskable interrupt") added a call to nmi_enter() at the beginning of > machine check restart exception handler. Due to that, in_interrupt() > always returns true regardle

Re: powerpc/kgdb: add kgdb_arch_set/remove_breakpoint()

2018-10-22 Thread Michael Ellerman
On Tue, 2018-09-18 at 09:26:03 UTC, Christophe Leroy wrote: > Generic implementation fails to remove breakpoints after init > when CONFIG_STRICT_KERNEL_RWX is selected: > > [ 13.251285] KGDB: BP remove failed: c001c338 > [ 13.259587] kgdbts: ERROR PUT: end of test buffer on 'do_fork_test' line

Re: [RFC] powerpc/64/module: REL32 relocation range check

2018-10-22 Thread Michael Ellerman
On Wed, 2018-08-29 at 11:56:56 UTC, Nicholas Piggin wrote: > The recent module relocation overflow crash demonstrated that we > have no range checking on REL32 relative relocations. This patch > implements a basic check, the same kernel that previously oopsed > and rebooted now continues with some

Re: powerpc/64s/radix: Fix radix__flush_tlb_collapsed_pmd double flushing pmd

2018-10-22 Thread Michael Ellerman
On Tue, 2018-08-28 at 08:11:27 UTC, Nicholas Piggin wrote: > Signed-off-by: Nicholas Piggin Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/dd76ff5af35350fd6d5bb5b069e73b cheers

Re: powerpc/sysdev/ipic: check primary_ipic NULL pointer before using it

2018-10-22 Thread Michael Ellerman
On Mon, 2018-08-27 at 08:27:27 UTC, Christophe Leroy wrote: > ipic_get_mcp_status() is used by targets implementing NMI > watchdog in target specific machine check handler in order > to known whether a machine check results from a watchdog > NMI reset. > > In case of very early machine check, prim

Re: [v2] powerpc/mm: fix always true/false warning in slice.c

2018-10-22 Thread Michael Ellerman
On Thu, 2018-08-02 at 09:25:55 UTC, Christophe Leroy wrote: > This patch fixes the following warnings (obtained with make W=1). > > arch/powerpc/mm/slice.c: In function 'slice_range_to_mask': > arch/powerpc/mm/slice.c:73:12: error: comparison is always true due to > limited range of data type [-W

Re: [v5, 1/3] powerpc/time: isolate scaled cputime accounting in dedicated functions.

2018-10-22 Thread Michael Ellerman
On Thu, 2018-08-02 at 07:53:57 UTC, Christophe Leroy wrote: > scaled cputime is only meaningfull when the processor has > SPURR and/or PURR, which means only on PPC64. > > In preparation of the following patch that will remove > CONFIG_ARCH_HAS_SCALED_CPUTIME on PPC32, this patch moves > all scale

Re: selftests/powerpc: Add a test of wild bctr

2018-10-22 Thread Michael Ellerman
On Tue, 2018-07-24 at 05:53:22 UTC, Michael Ellerman wrote: > This tests that a bctr (Branch to counter and link), ie. a function > call, to a wildly out-of-bounds address is handled correctly. > > Some old kernel versions didn't handle it correctly, see eg: > > "powerpc/slb: Force a full SLB f

Re: powerpc/mm: fix missing prototypes in slice.c

2018-10-22 Thread Michael Ellerman
On Fri, 2018-06-22 at 13:49:48 UTC, Christophe Leroy wrote: > This patch fixes the following warnings (obtained with make W=1). > > arch/powerpc/mm/slice.c: At top level: > arch/powerpc/mm/slice.c:682:15: error: no previous prototype for > 'arch_get_unmapped_area' [-Werror=missing-prototypes] >

Re: [v3] powerpc: Add support for function error injection

2018-10-22 Thread Michael Ellerman
On Thu, 2018-06-07 at 09:52:02 UTC, "Naveen N. Rao" wrote: > We implement regs_set_return_value() and override_function_with_return() > for this purpose. > > On powerpc, a return from a function (blr) just branches to the location > contained in the link register. So, we can just update pt_regs ra

Re: powerpc64/module elfv1: Set opd addresses after module relocation

2018-10-22 Thread Michael Ellerman
On Tue, 2018-05-29 at 06:51:00 UTC, "Naveen N. Rao" wrote: > module_frob_arch_sections() is called before the module is moved to its > final location. The function descriptor section addresses we are setting > here are thus invalid. Fix this by processing opd section during > module_finalize() >

Re: [v2,1/2] selftests/powerpc: Move UCONTEXT_NIA() into utils.h

2018-10-22 Thread Michael Ellerman
On Mon, 2018-05-21 at 15:13:56 UTC, "Naveen N. Rao" wrote: > ... so that it can be used by others. > > Signed-off-by: Naveen N. Rao Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/db3848515aff369404c31ef5a63699 cheers

Re: [v2,1/2] powerpc/mm: Add missing tracepoint for tlbie

2018-10-22 Thread Michael Ellerman
On Wed, 2018-03-21 at 14:16:58 UTC, Christophe Leroy wrote: > commit 0428491cba927 ("powerpc/mm: Trace tlbie(l) instructions") > added tracepoints for tlbie calls, but _tlbil_va() was forgotten > > Fixes: 0428491cba927 ("powerpc/mm: Trace tlbie(l) instructions") > Signed-off-by: Christophe Leroy