Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-03 Thread David Gibson
On Thu, Dec 06, 2018 at 08:45:09AM +0200, Leon Romanovsky wrote: > On Thu, Dec 06, 2018 at 03:19:51PM +1100, David Gibson wrote: > > Mellanox ConnectX-5 IB cards (MT27800) seem to cause a call trace when > > unbound from their regular driver and attached to vfio-pci in order to pass > > them

Re: [PATCH v8 22/25] powerpc: Remove CONFIG_GENERIC_NVRAM and adopt CONFIG_HAVE_ARCH_NVRAM_OPS

2019-01-03 Thread Finn Thain
On Thu, 3 Jan 2019, Christoph Hellwig wrote: > > # All PPC32s use generic nvram driver through ppc_md > > -config GENERIC_NVRAM > > +config HAVE_ARCH_NVRAM_OPS > > bool > > default y if PPC32 > > Symbols like this really should be defined in common code, and then > just selected by the

Re: [PATCH v8 05/25] char/nvram: Adopt arch_nvram_ops

2019-01-03 Thread Finn Thain
On Thu, 3 Jan 2019, Christoph Hellwig wrote: > > + > > +const struct nvram_ops arch_nvram_ops = { > > + .read_byte = nvram_read_byte, > > + .write_byte = nvram_write_byte, > > + .get_size = nvram_get_size, > > +}; > > +EXPORT_SYMBOL(arch_nvram_ops); > > I think something

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Nicolin Chen
Hi, On Thu, Jan 03, 2019 at 03:56:46PM +, Viorel Suman wrote: > > >  sound/soc/fsl/fsl_amix.c   | 554 > > > + > > >  sound/soc/fsl/fsl_amix.h   | 101 > > I aimn't against the naming here, but it seems to be AUDMIX in RM?

Re: use generic DMA mapping code in powerpc V4

2019-01-03 Thread Christian Zigotzky
Hi Christoph, Happy new year for you too. Unfortunately we have some problems with the latest DRM patches. They modified a lot and some graphics cards don’t work anymore. During the holidays we tried to figure out where the problems are but without any success. I will try to test your patches

RE: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Viorel Suman
> -Original Message- > From: Rob Herring [mailto:robh...@kernel.org] > Sent: Thursday, January 3, 2019 8:26 PM > To: Viorel Suman > Cc: nicoleots...@gmail.com; dl-linux-imx ; linux- > ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; ti...@kernel.org; > devicet...@vger.kernel.org;

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Rob Herring
On Thu, Jan 3, 2019 at 9:59 AM Viorel Suman wrote: > > Hi Nicolin, > > Thank you for your feedback, same here - just back from vacation. > > On Jo, 2018-12-27 at 01:24 +0800, Nicolin Chen wrote: > > Hi Viorel, > > > > Sorry for the late response, having been on a long vacation. > > > > The code

Re: [PATCH v3 1/2] selftests/powerpc: Add MSR bits

2019-01-03 Thread LEROY Christophe
Breno Leitao a écrit : This patch simply adds definitions for the MSR bits and some macros to test for MSR TM bits. This was copied from arch/powerpc/include/asm/reg.h generic MSR part. Can't we find a way to avoid duplicating such defines ? Christophe Signed-off-by: Breno Leitao ---

[PATCH v3 2/2] selftests/powerpc: New TM signal self test

2019-01-03 Thread Breno Leitao
A new self test that forces MSR[TS] to be set without calling any TM instruction. This test also tries to cause a page fault at a signal handler, exactly between MSR[TS] set and tm_recheckpoint(), forcing thread->texasr to be rewritten with TEXASR[FS] = 0, which will cause a BUG when

[PATCH v3 1/2] selftests/powerpc: Add MSR bits

2019-01-03 Thread Breno Leitao
This patch simply adds definitions for the MSR bits and some macros to test for MSR TM bits. This was copied from arch/powerpc/include/asm/reg.h generic MSR part. Signed-off-by: Breno Leitao --- tools/testing/selftests/powerpc/include/reg.h | 45 +++ 1 file changed, 45

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Viorel Suman
Hi Nicolin, Thank you for your feedback, same here - just back from vacation. On Jo, 2018-12-27 at 01:24 +0800, Nicolin Chen wrote: > Hi Viorel, > > Sorry for the late response, having been on a long vacation. > > The code looks pretty clean. Just some small concerns/questions > below. > > On

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Viorel Suman
Hi Rob, On Vi, 2018-12-28 at 17:32 -0600, Rob Herring wrote: > On Tue, Dec 18, 2018 at 04:30:01PM +, Viorel Suman wrote: > > > > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs. > > The Audio Mixer is a on-chip functional module that allows mixing > > of > > two audio

Re: [PATCH] selftests/powerpc: New TM signal self test

2019-01-03 Thread Breno Leitao
Hi Michael, On 12/20/18 10:51 AM, Michael Ellerman wrote: > Breno Leitao writes: > >> A new self test that forces MSR[TS] to be set without calling any TM >> instruction. This test also tries to cause a page fault at a signal >> handler, exactly between MSR[TS] set and tm_recheckpoint(),

Re: [PATCH v8 22/25] powerpc: Remove CONFIG_GENERIC_NVRAM and adopt CONFIG_HAVE_ARCH_NVRAM_OPS

2019-01-03 Thread Christoph Hellwig
> # All PPC32s use generic nvram driver through ppc_md > -config GENERIC_NVRAM > +config HAVE_ARCH_NVRAM_OPS > bool > default y if PPC32 Symbols like this really should be defined in common code, and then just selected by the users.

Re: [PATCH v8 05/25] char/nvram: Adopt arch_nvram_ops

2019-01-03 Thread Christoph Hellwig
> + > +const struct nvram_ops arch_nvram_ops = { > + .read_byte = nvram_read_byte, > + .write_byte = nvram_write_byte, > + .get_size = nvram_get_size, > +}; > +EXPORT_SYMBOL(arch_nvram_ops); I think something this internal should always be EXPORT_SYMBOL_GPL.